Repository navigation
docs(design-system): record the SemVer policy and the #14790 brand-layer verdict - #16796
Conversation
…yer precedent The review on #14790 asked whether the brand-layer move should have been a major bump. Nothing was ever published at 1.1.0 (npm has 1.0.0/1.0.1), the PR body itself declares the change breaking, so the next release carrying it must be 2.0.0. Document both the policy and the verdict where the package documents versioning.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe design-system README adds SemVer guidance for exported CSS and icon assets. It also states that the brand-layer move must first ship in version 2.0.0. ChangesDesign system release policy
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The README records that 1.1.0 shipped without the brand-layer move and specifies 2.0.0 for the release carrying it. No actionable merge risk remains in this documentation-only change. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-16796.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-eq7afajkn-comfyui.vercel.app Last updated: 2026-10-01T02:54:40Z for 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2595efcd93b007997d4adafbbdbf288108a86680
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16796 +/- ##
==========================================
- Coverage 84.51% 82.33% -2.19%
==========================================
Files 3367 3041 -326
Lines 162316 145218 -17098
Branches 42308 39358 -2950
==========================================
- Hits 137188 119562 -17626
- Misses 23208 23920 +712
+ Partials 1920 1736 -184
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| loading Inter. That PR was merged into a feature-branch stack with an | ||
| in-tree version of `1.1.0`, and the review raised whether it should have been | ||
| `2.0.0`. The verdict: the change **is breaking** — the PR's own body says so, | ||
| and nothing was ever published to npm at `1.1.0` (the published versions are |
There was a problem hiding this comment.
Severity: Major
What: lines 65-68 record that nothing was published at 1.1.0 (published versions 1.0.0 and 1.0.1) and instruct "do not let the in-tree 1.1.0 from that stack reach npm", but the registry lists 1.1.0 as latest, published 2026-09-05T08:05Z from main's own bump ca54f4bd2e (#17063), while #14790's merge ac4dd382b9 is still not on main and that tarball carries no brand-layer file.
Why this is an issue: the recorded evidence is false on merge day and the instruction can no longer be followed, so a reader who checks the registry finds the precedent wrong in one command and gets no guidance for the real situation, where the stack's in-tree 1.1.0 now collides with a published minor and the release carrying the move must be 2.0.0 because it is breaking against the shipped 1.1.0.
Proposed Fix: rewrite lines 65-68 to today's facts (1.1.0 shipped 2026-09-05 without the brand-layer move; the stack rebases over it and the release carrying the move is 2.0.0), deleting the "never published" sentence and the "do not let 1.1.0 reach npm" instruction.
Docs-only follow-up answering the SemVer question raised on #14790.
Verdict: the brand-layer move is breaking, and the first release carrying it must be
2.0.0. Key facts:_palette.cssand stopsbase.cssfrom loading Inter, changing the package's public styling surface.@comfyorg/design-system@1.1.0was published frommainon 2026-09-05 without the brand-layer move.main, so its old in-tree1.1.0version does not establish a published precedent for the move.This PR records the policy (exports are part of the public SemVer surface; removing tokens,
@font-facerules, or exported files is breaking) and the current release precedent in the README'sReleasingsection. It does not change package code or the package version.Verification
npm view @comfyorg/design-system versionreports1.1.0.maincurrently declares1.1.0inpackages/design-system/package.json.packages/design-system/README.md.