Repository navigation
[backport core/1.49] fix(first-run-tour): replace a fallback template no backend serves (#14683) - #14783
Conversation
…14683) ## Summary `templates-qwen_multiangle.app` is pinned as a Getting Started fallback card, and **no supported backend serves it.** It 404s on the templates package bundled with ComfyUI v0.19.3 (`0.9.57`) and on the one bundled with v0.30.0 (`0.11.27`) alike, so this is a live product bug rather than version drift: whenever the grid falls back to it, the card silently drops out and its tour role pins go unchecked. I verified this against real backends rather than the repo, by querying both CI container images directly: | backend | templates pkg | `/templates/templates-qwen_multiangle.app.json` | | --- | --- | --- | | `comfyui-ci-container:0.0.21` (ComfyUI v0.19.3) | `0.9.57` | ❌ 404 | | `comfyui-ci-container:0.0.22` (ComfyUI v0.30.0) | `0.11.27` | ❌ 404, and absent from `/templates/index.json` | ### Why it was easy to miss The id **is** present in `Comfy-Org/workflow_templates` under `templates/`. But the published package ships a **509-template subset** of that directory, so "exists on `workflow_templates@main`" never implied that a backend serves it. That inference is what hid this. ## The replacement `flux_fill_inpaint_example`, picked on verified properties rather than on looking like a plausible successor: | | `0.9.57` | `0.11.27` | | --- | --- | --- | | source `17` | `LoadImage` ×1 | `LoadImage` ×1 | | prompt `23` | `CLIPTextEncode` ×1 | `CLIPTextEncode` ×1 | | sink `9` | `SaveImage` ×1 | `SaveImage` ×1 | | node count | 14 | 14 | - **Pins are identical on both template versions**, so this does not re-create the drift it replaces. I scanned all 493 indexed templates for "exactly one `LoadImage`, exactly one image sink, ids unique across root + subgraphs" and then filtered to the ones stable across both versions. - **Local models only.** Every other pinned template is local; the two smallest candidates (`templates_doc_workbox_poster_recreator`, `templates_graphic_design_recomposer`) are Gemini API templates, which would have made this the one first-run card that needs API credits to run. That seemed like the wrong default for a first-run experience, so I passed on them despite being simpler. - It is an inpaint workflow, which lines up with the existing `inpaint` tutorial card. `@MaanilVerma` — assigning you as the owner of `firstRunTour`; the template choice is the part worth a second opinion, the "it 404s everywhere" part is measured. ## Scope note This deliberately does **not** touch `image_qwen_image_edit_2509`, which has a related but *version-dependent* problem: it was restructured upstream into a subgraph, and its sink is node `60` (`SaveImage`) on `0.9.57` but node `469` (`SaveImageAdvanced`) on `0.11.27`. **No single pin is correct for both**, so it cannot be fixed independently of the container bump — that fix rides in #14682. This PR is version-independent by construction, which is why it can land on `main` on its own. ## Verification - `firstRunTourRolePins.spec.ts` run against **both** containers locally: passes on `0.0.21` (which is what `main`'s CI uses, so this should be green here) and, on `0.0.22`, the only remaining failure is the `image_qwen_image_edit_2509` pin that #14682 fixes. - `pnpm typecheck`, `pnpm lint`, `pnpm format` clean; full unit suite passes. Co-authored-by: t <t@t.t> (cherry picked from commit 6af1cea)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1781 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T11:26:45.043Z",
"gitSha": "0d59612e56fb0a40e94b7a89e9beb5c17c0cfb30",
"branch": "backport/14683-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.2130000000216,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.607999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.373,
"heapDeltaBytes": 4694780,
"heapUsedBytes": 72794392,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 17.9,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.3029999999749,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.8580000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.273,
"heapDeltaBytes": 5351600,
"heapUsedBytes": 73532852,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 18.624000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.7029999999768,
"styleRecalcs": 72,
"styleRecalcDurationMs": 32.423,
"layouts": 12,
"layoutDurationMs": 3.6039999999999996,
"taskDurationMs": 804.932,
"heapDeltaBytes": -18430848,
"heapUsedBytes": 49624504,
"domNodes": -283,
"jsHeapTotalBytes": 20692992,
"scriptDurationMs": 102.76,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.105999999967,
"styleRecalcs": 71,
"styleRecalcDurationMs": 28.788999999999994,
"layouts": 12,
"layoutDurationMs": 3.232,
"taskDurationMs": 699.93,
"heapDeltaBytes": -561348,
"heapUsedBytes": 67883776,
"domNodes": 53,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 99.103,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.902999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.136000000000001,
"layouts": 6,
"layoutDurationMs": 0.56,
"taskDurationMs": 317.244,
"heapDeltaBytes": 7996836,
"heapUsedBytes": 76274732,
"domNodes": 76,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 18.570000000000004,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.322999999974,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.872,
"layouts": 6,
"layoutDurationMs": 0.562,
"taskDurationMs": 310.84000000000003,
"heapDeltaBytes": 8077676,
"heapUsedBytes": 76280732,
"domNodes": 75,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 17.24,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 555.5889999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.909000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.564,
"heapDeltaBytes": -12355412,
"heapUsedBytes": 56028460,
"domNodes": 18,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 49.699,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 517.9630000000088,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.614999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 305.52599999999995,
"heapDeltaBytes": -12206204,
"heapUsedBytes": 55854916,
"domNodes": 20,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 45.885,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.6160000000236,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.950000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584,
"heapDeltaBytes": 8125180,
"heapUsedBytes": 67316416,
"domNodes": -281,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 86.463,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2008.1539999999904,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.698,
"heapDeltaBytes": 8576272,
"heapUsedBytes": 67638380,
"domNodes": -282,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 96.865,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2106.4830000000256,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1048.584,
"heapDeltaBytes": 4289372,
"heapUsedBytes": 64515840,
"domNodes": -282,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 356.039,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2130.7930000000397,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1068.6599999999999,
"heapDeltaBytes": 22428364,
"heapUsedBytes": 82318332,
"domNodes": -284,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 338.87,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3061.2160000000017,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.963,
"layouts": 60,
"layoutDurationMs": 7.228999999999999,
"taskDurationMs": 1267.407,
"heapDeltaBytes": 22864040,
"heapUsedBytes": 84646388,
"domNodes": 16,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 432.51700000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3136.6350000000693,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.948000000000004,
"layouts": 60,
"layoutDurationMs": 7.403,
"taskDurationMs": 1291.253,
"heapDeltaBytes": -5563276,
"heapUsedBytes": 56232060,
"domNodes": -284,
"jsHeapTotalBytes": 7397376,
"scriptDurationMs": 440.45300000000003,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.5579999999845,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.017999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.426,
"heapDeltaBytes": 8751024,
"heapUsedBytes": 70599176,
"domNodes": -279,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 87.26400000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.0799999999836,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.198999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.103,
"heapDeltaBytes": 3169292,
"heapUsedBytes": 65127964,
"domNodes": -280,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 87.236,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 480.7749999999942,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.578999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.28900000000004,
"heapDeltaBytes": -11102744,
"heapUsedBytes": 57169880,
"domNodes": 20,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 93.997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 516.7989999999918,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.126000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.101,
"heapDeltaBytes": -12297472,
"heapUsedBytes": 55933604,
"domNodes": 18,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 94.966,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.6219999999785,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.40099999999995,
"heapDeltaBytes": 4833536,
"heapUsedBytes": 73050472,
"domNodes": 22,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 19.016,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.0900000000101,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.698999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.58000000000004,
"heapDeltaBytes": 4926488,
"heapUsedBytes": 73090700,
"domNodes": 22,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 14.207,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.4239999999859,
"styleRecalcs": 81,
"styleRecalcDurationMs": 32.931999999999995,
"layouts": 16,
"layoutDurationMs": 4.2589999999999995,
"taskDurationMs": 688.785,
"heapDeltaBytes": -21368596,
"heapUsedBytes": 46854640,
"domNodes": -280,
"jsHeapTotalBytes": 21217280,
"scriptDurationMs": 78.41300000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.7110000000225,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.054000000000002,
"layouts": 16,
"layoutDurationMs": 3.4760000000000004,
"taskDurationMs": 637.384,
"heapDeltaBytes": -4404648,
"heapUsedBytes": 63947624,
"domNodes": 64,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 81.30999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.9790000000107,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.052999999999997,
"layouts": 15,
"layoutDurationMs": 9.165000000000001,
"taskDurationMs": 707.894,
"heapDeltaBytes": 30564276,
"heapUsedBytes": 99838328,
"domNodes": 13673,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 21.665000000000003,
"eventListeners": 2373,
"totalBlockingTimeMs": 79,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8133.830000000045,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.367999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3706.088,
"heapDeltaBytes": 29493948,
"heapUsedBytes": 88794296,
"domNodes": -279,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 1088.0400000000002,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8157.98099999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.298,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3619.9909999999995,
"heapDeltaBytes": 4116044,
"heapUsedBytes": 65254928,
"domNodes": -280,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 1082.935,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14540.68000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14499.109999999999,
"heapDeltaBytes": -44808200,
"heapUsedBytes": 167869124,
"domNodes": -8312,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 428.689,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14958.677999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14937.163999999999,
"heapDeltaBytes": -42200644,
"heapUsedBytes": 167619512,
"domNodes": -8312,
"jsHeapTotalBytes": -9900032,
"scriptDurationMs": 477.704,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17394.627999999953,
"styleRecalcs": 121,
"styleRecalcDurationMs": 15.099999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17368.565,
"heapDeltaBytes": -40851720,
"heapUsedBytes": 166690316,
"domNodes": -8312,
"jsHeapTotalBytes": -11210752,
"scriptDurationMs": 765.3,
"eventListeners": -16385,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17437.55699999997,
"styleRecalcs": 122,
"styleRecalcDurationMs": 15.368999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17401.737,
"heapDeltaBytes": -29596748,
"heapUsedBytes": 176146864,
"domNodes": -8312,
"jsHeapTotalBytes": -2560000,
"scriptDurationMs": 739.2729999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 424.3329999999901,
"styleRecalcs": 15,
"styleRecalcDurationMs": 16.479,
"layouts": 3,
"layoutDurationMs": 0.528,
"taskDurationMs": 96.65099999999998,
"heapDeltaBytes": -15584980,
"heapUsedBytes": 51627100,
"domNodes": 134,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 8.191999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 439.0939999999546,
"styleRecalcs": 15,
"styleRecalcDurationMs": 16.025,
"layouts": 3,
"layoutDurationMs": 0.537,
"taskDurationMs": 98.824,
"heapDeltaBytes": -15593140,
"heapUsedBytes": 51778668,
"domNodes": 125,
"jsHeapTotalBytes": 7458816,
"scriptDurationMs": 8.419,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.49 #14783 +/- ##
==========================================
Coverage 78.74% 78.74%
==========================================
Files 1790 1790
Lines 104458 104458
Branches 32032 32032
==========================================
Hits 82251 82251
Misses 21777 21777
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FYI I checked the workflow and it's also on labeled, it was skipped here because it needs the |
|
Reviewing now |
Backport of #14683 to
core/1.49.templates-qwen_multiangle.appis pinned as a Getting Started fallback card and no supported backend serves it — it 404s on the templates package bundled with ComfyUI v0.19.3 (0.9.57) and on v0.30.0 (0.11.27) alike. Whenever the grid falls back to it the card silently drops out and its tour role pins go unchecked.Why this needs a manual backport: #14683 was merged before the
core/1.49label was applied, and the backport workflow triggers on the merge event — so adding the label afterwards fired nothing. Verified the bug is live on this branch:qwen_multiangleis still present intutorialCards.tshere and gone frommain.Clean cherry-pick, no conflicts (2 files, +5/-4).