Repository navigation
[backport cloud/1.49] fix(first-run-tour): read Anti-prompt as the negative prompt - #15096
Conversation
## Summary A workflow whose only multiline text box is titled `Anti-prompt` had the first-run tour's _"Describe what you want — your image gets built from this description"_ callout spotlit on its **negative** box. The user types "a cat" and gets everything except a cat. Closes #14623 ## Changes - **What**: `heuristicRoles.ts` now disqualifies a prompt candidate whose label reads as an anti-prompt, alongside the existing `negative`/`neg`/`system`/`undesired`/`avoid` stems. ### Why not just add `anti` to the stem list The issue suggests one more stem. That does not work as written: `DISQUALIFYING` is matched against **normalised label words**, and `labelWords('anti_aliasing')` is `['anti', 'aliasing']` — so a bare `anti` stem disqualifies `anti_aliasing`, which the existing carve-out test at `heuristicRoles.test.ts` explicitly requires to remain a valid prompt (its message already anticipates this: _"a prefix match on 'neg'/'anti' drops the prompt step for ordinary words"_). `startsWith('anti')` is worse — it also eats `antique`. `anti` only names the negative box next to the noun, so the check matches the pair off the normalised label rather than its individual words: ```ts const ANTI_PROMPT = /\banti ?prompts?\b/ ``` Because it runs on the label after camelCase-splitting and separator normalisation, one expression covers `Anti-prompt`, `anti prompt`, `AntiPrompt`, `anti_prompts` and `ANTIPROMPT`, while `antique`, `anti_aliasing` and `antialiasing strength` still qualify. It is applied to the same label set as the existing check — node title, widget name, subgraph port name, and the input name the node feeds — so a widget named `anti_prompt` is caught too. ## Review Focus - The regex is deliberately noun-adjacent rather than a stem. If you would rather lose `anti_aliasing` as a prompt than carry a regex, say so and I will swap it for the stem plus a deleted test case — but that trade seems clearly worse. - Bare `anti` as an entire label (no noun) is _not_ disqualified. It is ambiguous and unattested; the existing `anti_aliasing` carve-out points the same way. ## Verification - `pnpm test:unit src/renderer/extensions/firstRunTour/roles/heuristicRoles.test.ts` — 47 passed. - Red-green checked: with the new guard line deleted and the new cases kept, exactly the 6 new assertions fail (`Anti-prompt`, `anti prompt`, `AntiPrompt`, `ANTIPROMPT`, `anti_prompts`, and the `anti_prompt` widget); restoring it turns them green with no other test moving. - `pnpm format:check`, `pnpm lint`, `pnpm typecheck` — all clean. Not verified: no browser run. This is pure label-matching logic with unit coverage on both the disqualifying and the must-not-disqualify side, so a live tour run would not add signal beyond what the tests assert. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit b2540ac)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1786 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-12T01:06:53.706Z",
"gitSha": "10c5792a46e3eb05887584778a5721c2115acd40",
"branch": "backport/14669-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2108.7149999999892,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.7280000000001,
"heapDeltaBytes": 5230380,
"heapUsedBytes": 73778096,
"domNodes": 16,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 26.721999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2000.4059999999981,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.354,
"heapDeltaBytes": 5261996,
"heapUsedBytes": 73677436,
"domNodes": 16,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 22.866,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.1160000000002,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.757000000000005,
"layouts": 12,
"layoutDurationMs": 3.6890000000000005,
"taskDurationMs": 912.7180000000001,
"heapDeltaBytes": -261292,
"heapUsedBytes": 68020252,
"domNodes": 62,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 130.545,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.79700000004,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.517,
"layouts": 12,
"layoutDurationMs": 3.6110000000000007,
"taskDurationMs": 940.7079999999999,
"heapDeltaBytes": -18040812,
"heapUsedBytes": 50649084,
"domNodes": -281,
"jsHeapTotalBytes": 20164608,
"scriptDurationMs": 136.088,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.5859999999843,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.079000000000004,
"layouts": 6,
"layoutDurationMs": 0.6460000000000001,
"taskDurationMs": 435.98,
"heapDeltaBytes": 8405568,
"heapUsedBytes": 77078308,
"domNodes": 75,
"jsHeapTotalBytes": 19775488,
"scriptDurationMs": 27.122999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.06199999999,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.853,
"layouts": 6,
"layoutDurationMs": 0.5900000000000001,
"taskDurationMs": 428.49799999999993,
"heapDeltaBytes": 8227852,
"heapUsedBytes": 76753360,
"domNodes": 77,
"jsHeapTotalBytes": 19775488,
"scriptDurationMs": 25.938000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 605.8009999999854,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.842,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.3179999999999,
"heapDeltaBytes": -11255928,
"heapUsedBytes": 57235132,
"domNodes": 18,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 58.806999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 588.3890000000065,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.942999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.08500000000004,
"heapDeltaBytes": -12759468,
"heapUsedBytes": 55655288,
"domNodes": 14,
"jsHeapTotalBytes": 22921216,
"scriptDurationMs": 63.129000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.6059999999447,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.153000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 749.3580000000001,
"heapDeltaBytes": 8612268,
"heapUsedBytes": 70300580,
"domNodes": -281,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 119.36099999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.9070000000702,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.290000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.062,
"heapDeltaBytes": 4362196,
"heapUsedBytes": 64032016,
"domNodes": -283,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 112.726,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2268.1289999999876,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.732000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1379.496,
"heapDeltaBytes": 8194468,
"heapUsedBytes": 68962872,
"domNodes": -284,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 463.80000000000007,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2294.824999999946,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.642000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1373.319,
"heapDeltaBytes": 5397492,
"heapUsedBytes": 66458148,
"domNodes": -286,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 455.711,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3370.0900000000047,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.767999999999999,
"layouts": 60,
"layoutDurationMs": 7.6579999999999995,
"taskDurationMs": 1623.497,
"heapDeltaBytes": 7489872,
"heapUsedBytes": 70354916,
"domNodes": -292,
"jsHeapTotalBytes": 6873088,
"scriptDurationMs": 565.5949999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3366.045999999983,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.186999999999998,
"layouts": 60,
"layoutDurationMs": 7.74,
"taskDurationMs": 1649.3220000000001,
"heapDeltaBytes": 8246900,
"heapUsedBytes": 70430548,
"domNodes": -289,
"jsHeapTotalBytes": 7659520,
"scriptDurationMs": 566.736,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.3500000000126,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.8279999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 776.8589999999999,
"heapDeltaBytes": 8189456,
"heapUsedBytes": 69751740,
"domNodes": -284,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 126.963,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.5499999999156,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.546999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.987,
"heapDeltaBytes": 8998668,
"heapUsedBytes": 70729656,
"domNodes": -283,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 127.134,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.3249999999889,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.347,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.99399999999997,
"heapDeltaBytes": -11268824,
"heapUsedBytes": 57354776,
"domNodes": 16,
"jsHeapTotalBytes": 21086208,
"scriptDurationMs": 121.749,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.6119999999319,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.735999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.42400000000004,
"heapDeltaBytes": -10795916,
"heapUsedBytes": 57694048,
"domNodes": 20,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 120.02099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.832999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.860999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.9369999999999,
"heapDeltaBytes": -21943276,
"heapUsedBytes": 46710836,
"domNodes": -282,
"jsHeapTotalBytes": 19902464,
"scriptDurationMs": 21.208000000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.443999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.767999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.1539999999999,
"heapDeltaBytes": 5184880,
"heapUsedBytes": 73837076,
"domNodes": 18,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 20.664,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.7700000000345,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.964999999999996,
"layouts": 16,
"layoutDurationMs": 4.083,
"taskDurationMs": 854.128,
"heapDeltaBytes": -22147172,
"heapUsedBytes": 46532176,
"domNodes": 6,
"jsHeapTotalBytes": 19640320,
"scriptDurationMs": 95.098,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1681.8640000000187,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.983000000000004,
"layouts": 16,
"layoutDurationMs": 3.781,
"taskDurationMs": 797.1170000000001,
"heapDeltaBytes": -3913096,
"heapUsedBytes": 64680144,
"domNodes": 64,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 95.968,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.1780000000117,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.216000000000008,
"layouts": 14,
"layoutDurationMs": 12.575999999999997,
"taskDurationMs": 1027.861,
"heapDeltaBytes": 4785144,
"heapUsedBytes": 96835520,
"domNodes": 13673,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 39.27399999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8886.672999999973,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.39,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4873.284,
"heapDeltaBytes": 18617516,
"heapUsedBytes": 78602500,
"domNodes": -285,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 1486.848,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8750.236000000086,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.781,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4863.870999999999,
"heapDeltaBytes": 18854468,
"heapUsedBytes": 78594452,
"domNodes": -284,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 1483.784,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17532.263,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17502.786,
"heapDeltaBytes": -45510560,
"heapUsedBytes": 167863884,
"domNodes": -8312,
"jsHeapTotalBytes": -11739136,
"scriptDurationMs": 590.631,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17368.966999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17344.99,
"heapDeltaBytes": -56674112,
"heapUsedBytes": 156093392,
"domNodes": -8312,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 640.709,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21056.968999999983,
"styleRecalcs": 145,
"styleRecalcDurationMs": 18.44100000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20969.351000000002,
"heapDeltaBytes": -34841744,
"heapUsedBytes": 174223760,
"domNodes": -8312,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 900.1649999999998,
"eventListeners": -16385,
"totalBlockingTimeMs": 237,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20685.333999999897,
"styleRecalcs": 140,
"styleRecalcDurationMs": 16.72399999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20647.994000000002,
"heapDeltaBytes": -38647032,
"heapUsedBytes": 171453004,
"domNodes": -8312,
"jsHeapTotalBytes": -9904128,
"scriptDurationMs": 888.777,
"eventListeners": -16385,
"totalBlockingTimeMs": 193,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 453.86199999995824,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.53,
"layouts": 2,
"layoutDurationMs": 0.392,
"taskDurationMs": 129.078,
"heapDeltaBytes": -16011352,
"heapUsedBytes": 51744276,
"domNodes": 134,
"jsHeapTotalBytes": 7979008,
"scriptDurationMs": 10.672,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 464.74700000010216,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.191,
"layouts": 3,
"layoutDurationMs": 0.513,
"taskDurationMs": 125.20900000000002,
"heapDeltaBytes": -15929304,
"heapUsedBytes": 51864040,
"domNodes": 125,
"jsHeapTotalBytes": 6930432,
"scriptDurationMs": 9.742,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
Self-correction on this PR's own hygiene, since it is the exact failure this I opened it from const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/so this PR opened with That matters because Label applied by hand. Flagging rather than quietly fixing, because my earlier |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.49 #15096 +/- ##
=============================================
Coverage ? 71.91%
=============================================
Files ? 1767
Lines ? 92434
Branches ? 26794
=============================================
Hits ? 66471
Misses ? 25844
Partials ? 119
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## The workflow does not catch the branches it exists for `pr-label-backport.yaml`'s header states its purpose plainly — *"Guarantees that every backport PR carries the `backport` label, **whoever opened it**"* — and explains that manual backports are the case that matters, because `pr-backport.yaml` only labels the PRs it creates itself, and hands off to a human when the cherry-pick conflicts. But `isBackportBranchForBase` matched only the exact branch the workflow generates: ```ts const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ ``` A human finishing a conflicted cherry-pick does not produce that. They produce `<user>/backport-<pr>-to-<target>` — what `gh` and most local branch conventions give you. ## This week's worked example **Comfy-Org#15102** and **Comfy-Org#15103** (`jaeone94/backport-14984-to-core-1.49` and `…-cloud-1.49`) were opened by hand after `pr-backport.yaml` failed on Comfy-Org#14984's cherry-pick, and carry the `backport` label **only because someone applied it manually**. That matters because an unlabelled backport is invisible to `backport-auto-merge.yaml` and `pr-assign-release-sheriff.yaml` — both sweep `gh pr list --label backport` — so it sits open until somebody notices. Which is exactly what Comfy-Org#14018–Comfy-Org#14021 are cited for in the workflow's own header. Surveying every backport-titled PR in the repo: the bot's `backport-<n>-to-<target>` branches are all labelled, and the only user-prefixed pair is the one that needed a human. ## Only the prefix widens ```diff -const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ +const BACKPORT_BRANCH_PATTERN = /^(?:.*\/)?backport-\d+-to-(.+)$/ ``` The `\d+-to-` core and the existing base check still decide what counts as a backport, so this does **not** loosen the definition: | branch | base | before | after | | --- | --- | --- | --- | | `backport-14979-to-core-1.49` | `core/1.49` | ✅ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `core/1.49` | ❌ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `cloud/1.49` | ❌ | ❌ *(target ≠ base)* | | `glary/backport-resilient-partial-failure` | `core/1.49` | ❌ | ❌ | | `deepme987/infra/backport-assign-author` | `main` | ❌ | ❌ | The last two are real branches in this repo — *about* backporting rather than backports. A prefix must not turn them into one, and it doesn't: they have no `<digits>-to-` segment. ## Verification `backport-label.test.ts` **16/16**, with three new cases covering the prefixed form, the prefixed-but-wrong-base rejection, and the two real non-backport branches above. Mutation-checked rather than asserted green — reverting the regex to `^backport-` fails exactly one test (the new prefixed case) and leaves the other 15 passing. ## Disclosure I hit this myself from the other direction. My manual backports Comfy-Org#15095/Comfy-Org#15096 used `backport/<pr>-to-<target>` — a **slash** where the convention uses a hyphen. That one is genuinely off-convention rather than a gap in the rule, so this PR deliberately does **not** widen the pattern to bless it; I fixed those branches' labels by hand instead. Co-authored-by: t <t@t.t>
Manual backport of #14669 (
b2540ac0767) — the label-driven bot did not fire.#14669 merged carrying
core/1.49andcloud/1.49, applied before the merge(so this is not the after-the-fact labelling that silently skipped #14683). No
backport PR was created. Verified by content rather than by the bot's silence:
So the fix is on the dev line only and the 1.49 RC still reads
Anti-promptasthe positive prompt — the tour spotlights the wrong node.
Cherry-picked with
-x, clean, no conflicts, identical to main's commit(2 files, +65/-2).
heuristicRoles.test.tspasses 49/49 on this branch.