Skip to content

[backport cloud/1.49] fix(first-run-tour): read Anti-prompt as the negative prompt - #15096

Merged
comfy-pr-bot merged 1 commit into
cloud/1.49from
backport/14669-to-cloud-1.49
Aug 12, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.49from
backport/14669-to-cloud-1.49

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Manual backport of #14669 (b2540ac0767) — the label-driven bot did not fire.

#14669 merged carrying core/1.49 and cloud/1.49, applied before the merge
(so this is not the after-the-fact labelling that silently skipped #14683). No
backport PR was created. Verified by content rather than by the bot's silence:

$ git grep -c "Anti-prompt" origin/<branch> -- src/renderer/extensions/firstRunTour/
  main       2 files
  core/1.49  0 files
  cloud/1.49 0 files

So the fix is on the dev line only and the 1.49 RC still reads Anti-prompt as
the positive prompt — the tour spotlights the wrong node.

Cherry-picked with -x, clean, no conflicts, identical to main's commit
(2 files, +65/-2). heuristicRoles.test.ts passes 49/49 on this branch.

Second silent skip of this bot in this effort. Raising it separately — a
backport bot that no-ops without complaining is indistinguishable from one
that succeeded, which is how #14683 shipped the dead template to both release
branches.

## Summary

A workflow whose only multiline text box is titled `Anti-prompt` had the
first-run tour's _"Describe what you want — your image gets built from
this description"_ callout spotlit on its **negative** box. The user
types "a cat" and gets everything except a cat.

Closes #14623

## Changes

- **What**: `heuristicRoles.ts` now disqualifies a prompt candidate
whose label reads as an anti-prompt, alongside the existing
`negative`/`neg`/`system`/`undesired`/`avoid` stems.

### Why not just add `anti` to the stem list

The issue suggests one more stem. That does not work as written:
`DISQUALIFYING` is matched against **normalised label words**, and
`labelWords('anti_aliasing')` is `['anti', 'aliasing']` — so a bare
`anti` stem disqualifies `anti_aliasing`, which the existing carve-out
test at `heuristicRoles.test.ts` explicitly requires to remain a valid
prompt (its message already anticipates this: _"a prefix match on
'neg'/'anti' drops the prompt step for ordinary words"_).
`startsWith('anti')` is worse — it also eats `antique`.

`anti` only names the negative box next to the noun, so the check
matches the pair off the normalised label rather than its individual
words:

```ts
const ANTI_PROMPT = /\banti ?prompts?\b/
```

Because it runs on the label after camelCase-splitting and separator
normalisation, one expression covers `Anti-prompt`, `anti prompt`,
`AntiPrompt`, `anti_prompts` and `ANTIPROMPT`, while `antique`,
`anti_aliasing` and `antialiasing strength` still qualify. It is applied
to the same label set as the existing check — node title, widget name,
subgraph port name, and the input name the node feeds — so a widget
named `anti_prompt` is caught too.

## Review Focus

- The regex is deliberately noun-adjacent rather than a stem. If you
would rather lose `anti_aliasing` as a prompt than carry a regex, say so
and I will swap it for the stem plus a deleted test case — but that
trade seems clearly worse.
- Bare `anti` as an entire label (no noun) is _not_ disqualified. It is
ambiguous and unattested; the existing `anti_aliasing` carve-out points
the same way.

## Verification

- `pnpm test:unit
src/renderer/extensions/firstRunTour/roles/heuristicRoles.test.ts` — 47
passed.
- Red-green checked: with the new guard line deleted and the new cases
kept, exactly the 6 new assertions fail (`Anti-prompt`, `anti prompt`,
`AntiPrompt`, `ANTIPROMPT`, `anti_prompts`, and the `anti_prompt`
widget); restoring it turns them green with no other test moving.
- `pnpm format:check`, `pnpm lint`, `pnpm typecheck` — all clean.

Not verified: no browser run. This is pure label-matching logic with
unit coverage on both the disqualifying and the must-not-disqualify
side, so a live tour run would not add signal beyond what the tests
assert.

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit b2540ac)
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c095aa41-2ec5-426b-b23d-04ee5e9b3907

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/12/2026, 12:56:17 AM UTC

Links

🎭 Playwright: ✅ 1786 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1767 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 133ms TBT · 92.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 154.5 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 215ms TBT · 164.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 576ms
canvas-idle: script duration 25ms
canvas-idle: TBT 0ms
canvas-idle: heap used 70.3 MB
canvas-idle: DOM nodes 16
canvas-idle: event listeners 5
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 927ms
canvas-mouse-sweep: script duration 133ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 56.6 MB
canvas-mouse-sweep: DOM nodes -110
canvas-mouse-sweep: event listeners -75
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 432ms
canvas-zoom-sweep: script duration 27ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 396ms
dom-widget-clipping: script duration 61ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.8 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 739ms
large-graph-idle: script duration 116ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 64.1 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -165
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1376ms
large-graph-pan: script duration 460ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.6 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -149
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1636ms
large-graph-zoom: script duration 566ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 67.1 MB
large-graph-zoom: DOM nodes -291
large-graph-zoom: event listeners -153
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 783ms
minimap-idle: script duration 127ms
minimap-idle: TBT 0ms
minimap-idle: heap used 67.0 MB
minimap-idle: DOM nodes -284
minimap-idle: event listeners -149
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 415ms
subgraph-dom-widget-clipping: script duration 121ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 54.9 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 560ms
subgraph-idle: script duration 21ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.5 MB
subgraph-idle: DOM nodes -132
subgraph-idle: event listeners -75
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 826ms
subgraph-mouse-sweep: script duration 96ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 53.0 MB
subgraph-mouse-sweep: DOM nodes 35
subgraph-mouse-sweep: event listeners -75
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1028ms
subgraph-transition-enter: script duration 39ms
subgraph-transition-enter: TBT 133ms
subgraph-transition-enter: heap used 92.3 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4869ms
viewport-pan-sweep: script duration 1485ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.0 MB
viewport-pan-sweep: DOM nodes -285
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17424ms
vue-large-graph-idle: script duration 616ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 154.5 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16388
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 143
vue-large-graph-pan: task duration 20809ms
vue-large-graph-pan: script duration 894ms
vue-large-graph-pan: TBT 215ms
vue-large-graph-pan: heap used 164.8 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16385
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 0ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 15
workflow-execution: task duration 127ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 49.4 MB
workflow-execution: DOM nodes 130
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-12T01:06:53.706Z",
  "gitSha": "10c5792a46e3eb05887584778a5721c2115acd40",
  "branch": "backport/14669-to-cloud-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2108.7149999999892,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.7280000000001,
      "heapDeltaBytes": 5230380,
      "heapUsedBytes": 73778096,
      "domNodes": 16,
      "jsHeapTotalBytes": 20037632,
      "scriptDurationMs": 26.721999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2000.4059999999981,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.989,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.354,
      "heapDeltaBytes": 5261996,
      "heapUsedBytes": 73677436,
      "domNodes": 16,
      "jsHeapTotalBytes": 20037632,
      "scriptDurationMs": 22.866,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1859.1160000000002,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 43.757000000000005,
      "layouts": 12,
      "layoutDurationMs": 3.6890000000000005,
      "taskDurationMs": 912.7180000000001,
      "heapDeltaBytes": -261292,
      "heapUsedBytes": 68020252,
      "domNodes": 62,
      "jsHeapTotalBytes": 20561920,
      "scriptDurationMs": 130.545,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1906.79700000004,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 39.517,
      "layouts": 12,
      "layoutDurationMs": 3.6110000000000007,
      "taskDurationMs": 940.7079999999999,
      "heapDeltaBytes": -18040812,
      "heapUsedBytes": 50649084,
      "domNodes": -281,
      "jsHeapTotalBytes": 20164608,
      "scriptDurationMs": 136.088,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1753.5859999999843,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.079000000000004,
      "layouts": 6,
      "layoutDurationMs": 0.6460000000000001,
      "taskDurationMs": 435.98,
      "heapDeltaBytes": 8405568,
      "heapUsedBytes": 77078308,
      "domNodes": 75,
      "jsHeapTotalBytes": 19775488,
      "scriptDurationMs": 27.122999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.06199999999,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.853,
      "layouts": 6,
      "layoutDurationMs": 0.5900000000000001,
      "taskDurationMs": 428.49799999999993,
      "heapDeltaBytes": 8227852,
      "heapUsedBytes": 76753360,
      "domNodes": 77,
      "jsHeapTotalBytes": 19775488,
      "scriptDurationMs": 25.938000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 605.8009999999854,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.842,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.3179999999999,
      "heapDeltaBytes": -11255928,
      "heapUsedBytes": 57235132,
      "domNodes": 18,
      "jsHeapTotalBytes": 20561920,
      "scriptDurationMs": 58.806999999999995,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 588.3890000000065,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.942999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.08500000000004,
      "heapDeltaBytes": -12759468,
      "heapUsedBytes": 55655288,
      "domNodes": 14,
      "jsHeapTotalBytes": 22921216,
      "scriptDurationMs": 63.129000000000005,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.6059999999447,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.153000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 749.3580000000001,
      "heapDeltaBytes": 8612268,
      "heapUsedBytes": 70300580,
      "domNodes": -281,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 119.36099999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.9070000000702,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.290000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 728.062,
      "heapDeltaBytes": 4362196,
      "heapUsedBytes": 64032016,
      "domNodes": -283,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 112.726,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2268.1289999999876,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.732000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1379.496,
      "heapDeltaBytes": 8194468,
      "heapUsedBytes": 68962872,
      "domNodes": -284,
      "jsHeapTotalBytes": 5263360,
      "scriptDurationMs": 463.80000000000007,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2294.824999999946,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.642000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1373.319,
      "heapDeltaBytes": 5397492,
      "heapUsedBytes": 66458148,
      "domNodes": -286,
      "jsHeapTotalBytes": 5001216,
      "scriptDurationMs": 455.711,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3370.0900000000047,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.767999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.6579999999999995,
      "taskDurationMs": 1623.497,
      "heapDeltaBytes": 7489872,
      "heapUsedBytes": 70354916,
      "domNodes": -292,
      "jsHeapTotalBytes": 6873088,
      "scriptDurationMs": 565.5949999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3366.045999999983,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.186999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.74,
      "taskDurationMs": 1649.3220000000001,
      "heapDeltaBytes": 8246900,
      "heapUsedBytes": 70430548,
      "domNodes": -289,
      "jsHeapTotalBytes": 7659520,
      "scriptDurationMs": 566.736,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2027.3500000000126,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.8279999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 776.8589999999999,
      "heapDeltaBytes": 8189456,
      "heapUsedBytes": 69751740,
      "domNodes": -284,
      "jsHeapTotalBytes": 4513792,
      "scriptDurationMs": 126.963,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.5499999999156,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.546999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 789.987,
      "heapDeltaBytes": 8998668,
      "heapUsedBytes": 70729656,
      "domNodes": -283,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 127.134,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 610.3249999999889,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.347,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.99399999999997,
      "heapDeltaBytes": -11268824,
      "heapUsedBytes": 57354776,
      "domNodes": 16,
      "jsHeapTotalBytes": 21086208,
      "scriptDurationMs": 121.749,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 601.6119999999319,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.735999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.42400000000004,
      "heapDeltaBytes": -10795916,
      "heapUsedBytes": 57694048,
      "domNodes": 20,
      "jsHeapTotalBytes": 20561920,
      "scriptDurationMs": 120.02099999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.832999999996,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.860999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.9369999999999,
      "heapDeltaBytes": -21943276,
      "heapUsedBytes": 46710836,
      "domNodes": -282,
      "jsHeapTotalBytes": 19902464,
      "scriptDurationMs": 21.208000000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.443999999964,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.767999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.1539999999999,
      "heapDeltaBytes": 5184880,
      "heapUsedBytes": 73837076,
      "domNodes": 18,
      "jsHeapTotalBytes": 20037632,
      "scriptDurationMs": 20.664,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1712.7700000000345,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.964999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.083,
      "taskDurationMs": 854.128,
      "heapDeltaBytes": -22147172,
      "heapUsedBytes": 46532176,
      "domNodes": 6,
      "jsHeapTotalBytes": 19640320,
      "scriptDurationMs": 95.098,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1681.8640000000187,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.983000000000004,
      "layouts": 16,
      "layoutDurationMs": 3.781,
      "taskDurationMs": 797.1170000000001,
      "heapDeltaBytes": -3913096,
      "heapUsedBytes": 64680144,
      "domNodes": 64,
      "jsHeapTotalBytes": 20561920,
      "scriptDurationMs": 95.968,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.1780000000117,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.216000000000008,
      "layouts": 14,
      "layoutDurationMs": 12.575999999999997,
      "taskDurationMs": 1027.861,
      "heapDeltaBytes": 4785144,
      "heapUsedBytes": 96835520,
      "domNodes": 13673,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 39.27399999999999,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 133,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8886.672999999973,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.39,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4873.284,
      "heapDeltaBytes": 18617516,
      "heapUsedBytes": 78602500,
      "domNodes": -285,
      "jsHeapTotalBytes": 7852032,
      "scriptDurationMs": 1486.848,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8750.236000000086,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.781,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4863.870999999999,
      "heapDeltaBytes": 18854468,
      "heapUsedBytes": 78594452,
      "domNodes": -284,
      "jsHeapTotalBytes": 5754880,
      "scriptDurationMs": 1483.784,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17532.263,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17502.786,
      "heapDeltaBytes": -45510560,
      "heapUsedBytes": 167863884,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11739136,
      "scriptDurationMs": 590.631,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17368.966999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17344.99,
      "heapDeltaBytes": -56674112,
      "heapUsedBytes": 156093392,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11214848,
      "scriptDurationMs": 640.709,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21056.968999999983,
      "styleRecalcs": 145,
      "styleRecalcDurationMs": 18.44100000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20969.351000000002,
      "heapDeltaBytes": -34841744,
      "heapUsedBytes": 174223760,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11022336,
      "scriptDurationMs": 900.1649999999998,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 237,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20685.333999999897,
      "styleRecalcs": 140,
      "styleRecalcDurationMs": 16.72399999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20647.994000000002,
      "heapDeltaBytes": -38647032,
      "heapUsedBytes": 171453004,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9904128,
      "scriptDurationMs": 888.777,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 193,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.86199999995824,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 20.53,
      "layouts": 2,
      "layoutDurationMs": 0.392,
      "taskDurationMs": 129.078,
      "heapDeltaBytes": -16011352,
      "heapUsedBytes": 51744276,
      "domNodes": 134,
      "jsHeapTotalBytes": 7979008,
      "scriptDurationMs": 10.672,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.74700000010216,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 20.191,
      "layouts": 3,
      "layoutDurationMs": 0.513,
      "taskDurationMs": 125.20900000000002,
      "heapDeltaBytes": -15929304,
      "heapUsedBytes": 51864040,
      "domNodes": 125,
      "jsHeapTotalBytes": 6930432,
      "scriptDurationMs": 9.742,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions
github-actions Bot requested a review from thedatalife August 12, 2026 00:55
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Aug 12, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Self-correction on this PR's own hygiene, since it is the exact failure this
repo already documented.

I opened it from backport/14669-to-core-1.49. The convention is
backport-<pr>-to-<target> — a hyphen, not a slash. backport-label.ts
derives the backport label from exactly that shape:

const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/

so this PR opened with size:S and nothing else, while the bot's equivalent
(#15085, backport-14979-to-core-1.49) carries backport, size:M.

That matters because backport-auto-merge.yaml sweeps
gh pr list --label backport and pr-assign-release-sheriff.yaml keys off the
same label — so an unlabelled backport is invisible to both and just sits open.
pr-label-backport.yaml's header names PRs #14018–#14021 as the worked example
of precisely this.

Label applied by hand. Flagging rather than quietly fixing, because my earlier
manual backports #14783 and #14784 had the same malformed branch name and the
same missing label — they merged anyway, so nothing was lost, but they were
invisible to the sweep for as long as they were open.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.49   #15096   +/-   ##
=============================================
  Coverage              ?   71.91%           
=============================================
  Files                 ?     1767           
  Lines                 ?    92434           
  Branches              ?    26794           
=============================================
  Hits                  ?    66471           
  Misses                ?    25844           
  Partials              ?      119           
Flag Coverage Δ
unit 71.91% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/extensions/firstRunTour/roles/heuristicRoles.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 7c403c7 into cloud/1.49 Aug 12, 2026
78 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport/14669-to-cloud-1.49 branch August 12, 2026 05:37
balpreetgrowthnatives pushed a commit to balpreetgrowthnatives/ComfyUI_frontend that referenced this pull request Aug 14, 2026
## The workflow does not catch the branches it exists for

`pr-label-backport.yaml`'s header states its purpose plainly —
*"Guarantees that
every backport PR carries the `backport` label, **whoever opened it**"*
— and
explains that manual backports are the case that matters, because
`pr-backport.yaml` only labels the PRs it creates itself, and hands off
to a
human when the cherry-pick conflicts.

But `isBackportBranchForBase` matched only the exact branch the workflow
generates:

```ts
const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/
```

A human finishing a conflicted cherry-pick does not produce that. They
produce
`<user>/backport-<pr>-to-<target>` — what `gh` and most local branch
conventions give you.

## This week's worked example

**Comfy-Org#15102** and **Comfy-Org#15103** (`jaeone94/backport-14984-to-core-1.49` and
`…-cloud-1.49`) were opened by hand after `pr-backport.yaml` failed on
Comfy-Org#14984's cherry-pick, and carry the `backport` label **only because
someone
applied it manually**.

That matters because an unlabelled backport is invisible to
`backport-auto-merge.yaml` and `pr-assign-release-sheriff.yaml` — both
sweep
`gh pr list --label backport` — so it sits open until somebody notices.
Which
is exactly what Comfy-Org#14018–Comfy-Org#14021 are cited for in the workflow's own
header.

Surveying every backport-titled PR in the repo: the bot's
`backport-<n>-to-<target>` branches are all labelled, and the only
user-prefixed pair is the one that needed a human.

## Only the prefix widens

```diff
-const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/
+const BACKPORT_BRANCH_PATTERN = /^(?:.*\/)?backport-\d+-to-(.+)$/
```

The `\d+-to-` core and the existing base check still decide what counts
as a
backport, so this does **not** loosen the definition:

| branch | base | before | after |
| --- | --- | --- | --- |
| `backport-14979-to-core-1.49` | `core/1.49` | ✅ | ✅ |
| `jaeone94/backport-14984-to-core-1.49` | `core/1.49` | ❌ | ✅ |
| `jaeone94/backport-14984-to-core-1.49` | `cloud/1.49` | ❌ | ❌ *(target
≠ base)* |
| `glary/backport-resilient-partial-failure` | `core/1.49` | ❌ | ❌ |
| `deepme987/infra/backport-assign-author` | `main` | ❌ | ❌ |

The last two are real branches in this repo — *about* backporting rather
than
backports. A prefix must not turn them into one, and it doesn't: they
have no
`<digits>-to-` segment.

## Verification

`backport-label.test.ts` **16/16**, with three new cases covering the
prefixed
form, the prefixed-but-wrong-base rejection, and the two real
non-backport
branches above.

Mutation-checked rather than asserted green — reverting the regex to
`^backport-`
fails exactly one test (the new prefixed case) and leaves the other 15
passing.

## Disclosure

I hit this myself from the other direction. My manual backports
Comfy-Org#15095/Comfy-Org#15096
used `backport/<pr>-to-<target>` — a **slash** where the convention uses
a
hyphen. That one is genuinely off-convention rather than a gap in the
rule, so
this PR deliberately does **not** widen the pattern to bless it; I fixed
those
branches' labels by hand instead.

Co-authored-by: t <t@t.t>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants