Repository navigation
[backport core/1.49] fix(first-run-tour): read Anti-prompt as the negative prompt - #15095
Conversation
## Summary A workflow whose only multiline text box is titled `Anti-prompt` had the first-run tour's _"Describe what you want — your image gets built from this description"_ callout spotlit on its **negative** box. The user types "a cat" and gets everything except a cat. Closes #14623 ## Changes - **What**: `heuristicRoles.ts` now disqualifies a prompt candidate whose label reads as an anti-prompt, alongside the existing `negative`/`neg`/`system`/`undesired`/`avoid` stems. ### Why not just add `anti` to the stem list The issue suggests one more stem. That does not work as written: `DISQUALIFYING` is matched against **normalised label words**, and `labelWords('anti_aliasing')` is `['anti', 'aliasing']` — so a bare `anti` stem disqualifies `anti_aliasing`, which the existing carve-out test at `heuristicRoles.test.ts` explicitly requires to remain a valid prompt (its message already anticipates this: _"a prefix match on 'neg'/'anti' drops the prompt step for ordinary words"_). `startsWith('anti')` is worse — it also eats `antique`. `anti` only names the negative box next to the noun, so the check matches the pair off the normalised label rather than its individual words: ```ts const ANTI_PROMPT = /\banti ?prompts?\b/ ``` Because it runs on the label after camelCase-splitting and separator normalisation, one expression covers `Anti-prompt`, `anti prompt`, `AntiPrompt`, `anti_prompts` and `ANTIPROMPT`, while `antique`, `anti_aliasing` and `antialiasing strength` still qualify. It is applied to the same label set as the existing check — node title, widget name, subgraph port name, and the input name the node feeds — so a widget named `anti_prompt` is caught too. ## Review Focus - The regex is deliberately noun-adjacent rather than a stem. If you would rather lose `anti_aliasing` as a prompt than carry a regex, say so and I will swap it for the stem plus a deleted test case — but that trade seems clearly worse. - Bare `anti` as an entire label (no noun) is _not_ disqualified. It is ambiguous and unattested; the existing `anti_aliasing` carve-out points the same way. ## Verification - `pnpm test:unit src/renderer/extensions/firstRunTour/roles/heuristicRoles.test.ts` — 47 passed. - Red-green checked: with the new guard line deleted and the new cases kept, exactly the 6 new assertions fail (`Anti-prompt`, `anti prompt`, `AntiPrompt`, `ANTIPROMPT`, `anti_prompts`, and the `anti_prompt` widget); restoring it turns them green with no other test moving. - `pnpm format:check`, `pnpm lint`, `pnpm typecheck` — all clean. Not verified: no browser run. This is pure label-matching logic with unit coverage on both the disqualifying and the must-not-disqualify side, so a live tour run would not add signal beyond what the tests assert. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit b2540ac)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1785 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-12T01:06:53.459Z",
"gitSha": "57ce8dd057bc27c74b09cf5fc17f9d4fbd5eae3d",
"branch": "backport/14669-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2183.138999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.824,
"heapDeltaBytes": 5355840,
"heapUsedBytes": 74175352,
"domNodes": 18,
"jsHeapTotalBytes": 19517440,
"scriptDurationMs": 20.450000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2034.3129999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.338000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.534,
"heapDeltaBytes": 5415532,
"heapUsedBytes": 73766184,
"domNodes": 16,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 23.722,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2057.2659999999987,
"styleRecalcs": 81,
"styleRecalcDurationMs": 49.859,
"layouts": 12,
"layoutDurationMs": 4.504,
"taskDurationMs": 1059.4470000000001,
"heapDeltaBytes": -16696548,
"heapUsedBytes": 51868932,
"domNodes": -278,
"jsHeapTotalBytes": 21479424,
"scriptDurationMs": 136.22699999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1950.0259999999798,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.972,
"layouts": 12,
"layoutDurationMs": 3.939999999999999,
"taskDurationMs": 1014.629,
"heapDeltaBytes": -16703700,
"heapUsedBytes": 51954604,
"domNodes": -284,
"jsHeapTotalBytes": 20692992,
"scriptDurationMs": 130.81300000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.7559999999903,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.464999999999998,
"layouts": 6,
"layoutDurationMs": 0.6169999999999999,
"taskDurationMs": 387.40599999999995,
"heapDeltaBytes": 8223248,
"heapUsedBytes": 76884640,
"domNodes": 77,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 18.773999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1772.0769999999675,
"styleRecalcs": 32,
"styleRecalcDurationMs": 24.863999999999997,
"layouts": 6,
"layoutDurationMs": 0.8299999999999997,
"taskDurationMs": 480.53200000000004,
"heapDeltaBytes": 8024512,
"heapUsedBytes": 76420660,
"domNodes": 79,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 30.496999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 593.1400000000053,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.656,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.326,
"heapDeltaBytes": -12671760,
"heapUsedBytes": 56078448,
"domNodes": 18,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 58.583,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 593.1779999999662,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.166,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.769,
"heapDeltaBytes": -11379472,
"heapUsedBytes": 57168688,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 60.16100000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2062.8040000000283,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.505000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 691.867,
"heapDeltaBytes": 8810088,
"heapUsedBytes": 68598556,
"domNodes": -284,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 97.48599999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.7419999999656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.274000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.141,
"heapDeltaBytes": 8304144,
"heapUsedBytes": 68048172,
"domNodes": -280,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 113.73799999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2141.3239999999973,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.655999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1262.184,
"heapDeltaBytes": 4435300,
"heapUsedBytes": 65734024,
"domNodes": -291,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 403.782,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2384.4030000000203,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1530.975,
"heapDeltaBytes": 9224736,
"heapUsedBytes": 70202080,
"domNodes": -285,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 530.9639999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3197.952999999984,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.677,
"layouts": 60,
"layoutDurationMs": 8.456999999999999,
"taskDurationMs": 1514.935,
"heapDeltaBytes": 24238424,
"heapUsedBytes": 87017632,
"domNodes": 12,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 557.121,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3259.013999999979,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.411,
"layouts": 60,
"layoutDurationMs": 9.228,
"taskDurationMs": 1621.7839999999999,
"heapDeltaBytes": 25686700,
"heapUsedBytes": 88221292,
"domNodes": 12,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 567.673,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2034.337999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.1740000000001,
"heapDeltaBytes": 9104404,
"heapUsedBytes": 71049152,
"domNodes": -285,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 96.76099999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2038.0840000000262,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.185999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 853.996,
"heapDeltaBytes": 8132064,
"heapUsedBytes": 70012728,
"domNodes": -280,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 133.34099999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.6049999999841,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.9700000000001,
"heapDeltaBytes": -10906164,
"heapUsedBytes": 57580940,
"domNodes": 18,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 132.517,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.7450000000281,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.203999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.65500000000003,
"heapDeltaBytes": -11352108,
"heapUsedBytes": 57426356,
"domNodes": 20,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 129.18699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.777999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.73199999999997,
"heapDeltaBytes": -21987600,
"heapUsedBytes": 46561032,
"domNodes": -281,
"jsHeapTotalBytes": 19382272,
"scriptDurationMs": 13.927,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.0139999999838,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.965,
"heapDeltaBytes": 5261228,
"heapUsedBytes": 74023912,
"domNodes": 20,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 20.889000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1760.4639999999563,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.991,
"layouts": 16,
"layoutDurationMs": 4.678,
"taskDurationMs": 831.3770000000001,
"heapDeltaBytes": -20350916,
"heapUsedBytes": 48346964,
"domNodes": -283,
"jsHeapTotalBytes": 19644416,
"scriptDurationMs": 88.425,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.5029999999697,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.646,
"layouts": 16,
"layoutDurationMs": 4.281,
"taskDurationMs": 806.914,
"heapDeltaBytes": -21366464,
"heapUsedBytes": 47161700,
"domNodes": -279,
"jsHeapTotalBytes": 19644416,
"scriptDurationMs": 90.594,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.929999999989,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.667,
"layouts": 14,
"layoutDurationMs": 11.952,
"taskDurationMs": 1032.791,
"heapDeltaBytes": 5296128,
"heapUsedBytes": 76655456,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 39.93800000000002,
"eventListeners": 2375,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8283.634000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.323,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4430.531999999999,
"heapDeltaBytes": 611516,
"heapUsedBytes": 60191572,
"domNodes": -280,
"jsHeapTotalBytes": 6610944,
"scriptDurationMs": 1343.324,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8321.931000000062,
"styleRecalcs": 249,
"styleRecalcDurationMs": 44.553000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4923.735000000001,
"heapDeltaBytes": 13012924,
"heapUsedBytes": 72797884,
"domNodes": -283,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 1420.171,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18605.01099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18549.775999999998,
"heapDeltaBytes": -48986336,
"heapUsedBytes": 161856244,
"domNodes": -8312,
"jsHeapTotalBytes": -8327168,
"scriptDurationMs": 587.4110000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18557.30100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18535.955,
"heapDeltaBytes": -45189932,
"heapUsedBytes": 167386868,
"domNodes": -8312,
"jsHeapTotalBytes": -10686464,
"scriptDurationMs": 604.041,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23261.584000000028,
"styleRecalcs": 174,
"styleRecalcDurationMs": 26.019000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23220.056,
"heapDeltaBytes": -54359904,
"heapUsedBytes": 167003440,
"domNodes": -8312,
"jsHeapTotalBytes": -10424320,
"scriptDurationMs": 961.8319999999999,
"eventListeners": -16379,
"totalBlockingTimeMs": 786,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23098.265999999967,
"styleRecalcs": 172,
"styleRecalcDurationMs": 26.816000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23063.748,
"heapDeltaBytes": -57079796,
"heapUsedBytes": 165000792,
"domNodes": -8312,
"jsHeapTotalBytes": -9900032,
"scriptDurationMs": 947.5020000000001,
"eventListeners": -16383,
"totalBlockingTimeMs": 683,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.48999999998387,
"styleRecalcs": 11,
"styleRecalcDurationMs": 20.604999999999997,
"layouts": 3,
"layoutDurationMs": 0.753,
"taskDurationMs": 134.29399999999998,
"heapDeltaBytes": -15768932,
"heapUsedBytes": 51833188,
"domNodes": 128,
"jsHeapTotalBytes": 7458816,
"scriptDurationMs": 11.293,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 479.53000000006796,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.712999999999997,
"layouts": 3,
"layoutDurationMs": 1.2289999999999999,
"taskDurationMs": 141.111,
"heapDeltaBytes": -15508220,
"heapUsedBytes": 52259740,
"domNodes": 149,
"jsHeapTotalBytes": 6934528,
"scriptDurationMs": 11.834000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
|
Self-correction on this PR's own hygiene, since it is the exact failure this I opened it from const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/so this PR opened with That matters because Label applied by hand. Flagging rather than quietly fixing, because my earlier |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.49 #15095 +/- ##
===========================================
Coverage 79.20% 79.20%
===========================================
Files 1854 1854
Lines 108629 108633 +4
Branches 33159 34082 +923
===========================================
+ Hits 86035 86039 +4
Misses 22159 22159
Partials 435 435
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## The workflow does not catch the branches it exists for `pr-label-backport.yaml`'s header states its purpose plainly — *"Guarantees that every backport PR carries the `backport` label, **whoever opened it**"* — and explains that manual backports are the case that matters, because `pr-backport.yaml` only labels the PRs it creates itself, and hands off to a human when the cherry-pick conflicts. But `isBackportBranchForBase` matched only the exact branch the workflow generates: ```ts const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ ``` A human finishing a conflicted cherry-pick does not produce that. They produce `<user>/backport-<pr>-to-<target>` — what `gh` and most local branch conventions give you. ## This week's worked example **Comfy-Org#15102** and **Comfy-Org#15103** (`jaeone94/backport-14984-to-core-1.49` and `…-cloud-1.49`) were opened by hand after `pr-backport.yaml` failed on Comfy-Org#14984's cherry-pick, and carry the `backport` label **only because someone applied it manually**. That matters because an unlabelled backport is invisible to `backport-auto-merge.yaml` and `pr-assign-release-sheriff.yaml` — both sweep `gh pr list --label backport` — so it sits open until somebody notices. Which is exactly what Comfy-Org#14018–Comfy-Org#14021 are cited for in the workflow's own header. Surveying every backport-titled PR in the repo: the bot's `backport-<n>-to-<target>` branches are all labelled, and the only user-prefixed pair is the one that needed a human. ## Only the prefix widens ```diff -const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ +const BACKPORT_BRANCH_PATTERN = /^(?:.*\/)?backport-\d+-to-(.+)$/ ``` The `\d+-to-` core and the existing base check still decide what counts as a backport, so this does **not** loosen the definition: | branch | base | before | after | | --- | --- | --- | --- | | `backport-14979-to-core-1.49` | `core/1.49` | ✅ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `core/1.49` | ❌ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `cloud/1.49` | ❌ | ❌ *(target ≠ base)* | | `glary/backport-resilient-partial-failure` | `core/1.49` | ❌ | ❌ | | `deepme987/infra/backport-assign-author` | `main` | ❌ | ❌ | The last two are real branches in this repo — *about* backporting rather than backports. A prefix must not turn them into one, and it doesn't: they have no `<digits>-to-` segment. ## Verification `backport-label.test.ts` **16/16**, with three new cases covering the prefixed form, the prefixed-but-wrong-base rejection, and the two real non-backport branches above. Mutation-checked rather than asserted green — reverting the regex to `^backport-` fails exactly one test (the new prefixed case) and leaves the other 15 passing. ## Disclosure I hit this myself from the other direction. My manual backports Comfy-Org#15095/Comfy-Org#15096 used `backport/<pr>-to-<target>` — a **slash** where the convention uses a hyphen. That one is genuinely off-convention rather than a gap in the rule, so this PR deliberately does **not** widen the pattern to bless it; I fixed those branches' labels by hand instead. Co-authored-by: t <t@t.t>
Manual backport of #14669 (
b2540ac0767) — the label-driven bot did not fire.#14669 merged carrying
core/1.49andcloud/1.49, applied before the merge(so this is not the after-the-fact labelling that silently skipped #14683). No
backport PR was created. Verified by content rather than by the bot's silence:
So the fix is on the dev line only and the 1.49 RC still reads
Anti-promptasthe positive prompt — the tour spotlights the wrong node.
Cherry-picked with
-x, clean, no conflicts, identical to main's commit(2 files, +65/-2).
heuristicRoles.test.tspasses 49/49 on this branch.