Repository navigation
test: pin the remaining container-coupled node titles - #14774
Conversation
Extends the #14744 stub to the two sites it left out: the `api-pricing-*` goldens (`FluxProUltraImageNode` -> `Flux 1.1 [pro] Ultra Image`) and the `node-badge-{mode}` goldens (`PreviewImage` -> `Preview Image`). The other node in `nodes/execution_error`, `DevToolsErrorRaiseNode`, is left unpinned: it ships from `tools/devtools/` in this repo, so its title is not a function of the container image. No baselines regenerated — both strings are the ones the committed PNGs already render.
🎭 Playwright: ✅ 1782 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle: 8.26 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 114 kB (baseline 114 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 281 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T08:52:48.701Z",
"gitSha": "8801d6ed44e796d83ef413973ec9a1f3cec91e52",
"branch": "test/stub-remaining-container-coupled-goldens",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2077.175000000011,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.382,
"heapDeltaBytes": -17725456,
"heapUsedBytes": 46243608,
"domNodes": -281,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 19.420999999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2050.7740000000467,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.226000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.125,
"heapDeltaBytes": 5316120,
"heapUsedBytes": 69523784,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 21.623000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.7049999999767,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.172999999999995,
"layouts": 12,
"layoutDurationMs": 3.4979999999999998,
"taskDurationMs": 898.162,
"heapDeltaBytes": -13391780,
"heapUsedBytes": 50578496,
"domNodes": -280,
"jsHeapTotalBytes": 24358912,
"scriptDurationMs": 125.15300000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.82100000005,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.501999999999995,
"layouts": 12,
"layoutDurationMs": 3.6359999999999997,
"taskDurationMs": 899.1499999999999,
"heapDeltaBytes": -15122816,
"heapUsedBytes": 48938548,
"domNodes": -280,
"jsHeapTotalBytes": 24096768,
"scriptDurationMs": 127.73200000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.4460000000063,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.627999999999997,
"layouts": 6,
"layoutDurationMs": 0.5289999999999999,
"taskDurationMs": 396.173,
"heapDeltaBytes": 8688736,
"heapUsedBytes": 72720972,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 22.427000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2619999999397,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.770000000000003,
"layouts": 6,
"layoutDurationMs": 0.6050000000000001,
"taskDurationMs": 397.017,
"heapDeltaBytes": 8691508,
"heapUsedBytes": 72677340,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 21.064,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 592.9689999999823,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.05,
"heapDeltaBytes": -11031716,
"heapUsedBytes": 52977716,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 60.291,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 624.0849999999227,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.274999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.524,
"heapDeltaBytes": -11157832,
"heapUsedBytes": 52964280,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 62.273999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2014.9210000000153,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 735.498,
"heapDeltaBytes": 6483644,
"heapUsedBytes": 65784516,
"domNodes": -281,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 112.289,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.461999999934,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.777999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.2090000000001,
"heapDeltaBytes": 7124636,
"heapUsedBytes": 66458908,
"domNodes": -281,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 105.767,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2308.285000000012,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.896999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1368.042,
"heapDeltaBytes": 908420,
"heapUsedBytes": 62108688,
"domNodes": -284,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 452.376,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2311.368000000016,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1328.33,
"heapDeltaBytes": 4912520,
"heapUsedBytes": 65525180,
"domNodes": -284,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 449.21999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3347.1759999999904,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.736999999999997,
"layouts": 60,
"layoutDurationMs": 7.451000000000001,
"taskDurationMs": 1642.2920000000001,
"heapDeltaBytes": 5084424,
"heapUsedBytes": 67981288,
"domNodes": -289,
"jsHeapTotalBytes": 7708672,
"scriptDurationMs": 575.1919999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3298.49200000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.840000000000002,
"layouts": 60,
"layoutDurationMs": 7.327,
"taskDurationMs": 1544.049,
"heapDeltaBytes": 4273416,
"heapUsedBytes": 66930564,
"domNodes": -287,
"jsHeapTotalBytes": 7184384,
"scriptDurationMs": 537.5269999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2066.118000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.640999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.5519999999999,
"heapDeltaBytes": 7446812,
"heapUsedBytes": 68007292,
"domNodes": -283,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 117.88200000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.8759999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.615999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.6739999999999,
"heapDeltaBytes": 6395216,
"heapUsedBytes": 66698276,
"domNodes": -284,
"jsHeapTotalBytes": 4300800,
"scriptDurationMs": 106.324,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.053999999971,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.846,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.3420000000001,
"heapDeltaBytes": -10287564,
"heapUsedBytes": 53819736,
"domNodes": 16,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 120.85200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.9989999999943,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.30199999999996,
"heapDeltaBytes": -10454092,
"heapUsedBytes": 53804868,
"domNodes": 16,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 128.469,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5630000000142,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.527,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.715,
"heapDeltaBytes": -17725568,
"heapUsedBytes": 46324192,
"domNodes": -281,
"jsHeapTotalBytes": 23572480,
"scriptDurationMs": 17.285,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.9909999999472,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.678999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.447,
"heapDeltaBytes": -17845280,
"heapUsedBytes": 46255184,
"domNodes": -278,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 13.935999999999998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.1789999999764,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.754999999999995,
"layouts": 16,
"layoutDurationMs": 4.316999999999999,
"taskDurationMs": 786.2640000000001,
"heapDeltaBytes": -4252936,
"heapUsedBytes": 59911812,
"domNodes": 65,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 93.516,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.6940000000086,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.867,
"layouts": 16,
"layoutDurationMs": 4.03,
"taskDurationMs": 874.069,
"heapDeltaBytes": -17406240,
"heapUsedBytes": 46870112,
"domNodes": -280,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 96.025,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.576000000001,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.879,
"layouts": 13,
"layoutDurationMs": 12.488,
"taskDurationMs": 991.3960000000002,
"heapDeltaBytes": 31093208,
"heapUsedBytes": 99420096,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 37.05800000000001,
"eventListeners": 2375,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8372.229000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.964999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4598.284,
"heapDeltaBytes": 11990020,
"heapUsedBytes": 70858380,
"domNodes": -279,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 1400.4500000000003,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8358.973000000105,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.004999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4458.356,
"heapDeltaBytes": 12490364,
"heapUsedBytes": 71921008,
"domNodes": -282,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 1383.875,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17477.49300000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17445.093,
"heapDeltaBytes": -23102016,
"heapUsedBytes": 179963180,
"domNodes": -8312,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 606.4559999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17153.693999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17128.172000000002,
"heapDeltaBytes": -59815820,
"heapUsedBytes": 167211440,
"domNodes": -8312,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 573.481,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20689.752999999997,
"styleRecalcs": 142,
"styleRecalcDurationMs": 17.808000000000046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20656.399999999998,
"heapDeltaBytes": -40158264,
"heapUsedBytes": 164246528,
"domNodes": -8312,
"jsHeapTotalBytes": -9375744,
"scriptDurationMs": 903.0709999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 248,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21039.389999999912,
"styleRecalcs": 148,
"styleRecalcDurationMs": 18.961000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21018.266,
"heapDeltaBytes": -45503120,
"heapUsedBytes": 176546996,
"domNodes": -8312,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 941.812,
"eventListeners": -16383,
"totalBlockingTimeMs": 372,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 451.95000000001073,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.189000000000004,
"layouts": 3,
"layoutDurationMs": 1.0939999999999999,
"taskDurationMs": 117.39000000000001,
"heapDeltaBytes": 5373888,
"heapUsedBytes": 68423548,
"domNodes": 136,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.986,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 449.4329999999991,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.558,
"layouts": 2,
"layoutDurationMs": 0.44300000000000006,
"taskDurationMs": 105.89599999999999,
"heapDeltaBytes": 5077612,
"heapUsedBytes": 68210804,
"domNodes": 123,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.414000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe node badge browser test replaces one deprecated-node override with a reusable display-name map. The setup applies pinned names for deprecated, API, and preview nodes. ChangesNode display name stabilization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14774 +/- ##
=======================================
Coverage 78.62% 78.62%
=======================================
Files 1796 1796
Lines 109402 109402
Branches 31385 31341 -44
=======================================
Hits 86014 86014
+ Misses 22887 22883 -4
- Partials 501 505 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Reverts five PRs that were merged to `main` without independent review, which is not our process. Backing them out so they can go through review properly. Reverted, newest first: - #14775 — resolve display name and description at read time - #14774 — pin remaining container-coupled node titles - #14773 — warn on dropped malformed node defs - #14747 — widget labels, output names and tooltips from the backend - #14744 — decouple node-title goldens from the CI container **Not reverted:** #14541. It was authored by @bigcat88 and carried a genuine approval before merge, so it followed process. The five above were authored and merged under the same account, and GitHub blocks self-approval, so none of them could receive one. Three had no approval of any kind at merge time. `main` is not branch-protected here, so nothing blocked the merges. That is the gap that let this happen. ## State after this revert All five reverts applied without conflict. The tree returns to the post-14541 state: `resolveNodeDefText` and `setBackendNodeText` remain, `translateNodeDef` resolves `display_name`/`description` inline again, and the slot resolvers, getters, dropped-def warning and golden stubbing are all removed. Verified locally: `pnpm typecheck` clean, `pnpm knip` clean, 156 unit tests pass across the four affected suites. ## Follow-up Each reverted change will be re-opened as its own PR from its original branch, which still exists, for normal review. Nothing is lost. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org>
Summary
Finishes what #14744 started: the last two node-title goldens that still track the CI container image are now pinned. No baselines regenerated.
Changes
browser_tests/tests/nodeBadge.spec.tsalready extended thepagefixture to stub/object_infoforImageBatch. That map now also carries:api-pricing-{on,off}-{classic,vue}FluxProUltraImageNodeFlux 1.1 [pro] Ultra Imagenode-badge-{Show-all,Hide-built-in,None}PreviewImagePreview ImageThe route shape, the
try/finallyunroute and the pre-boot install are unchanged — only the mutator body generalises to a loop.nodes/execution_erroralso rendersDevToolsErrorRaiseNode(Raise Error), which is deliberately not pinned. That name is defined in this repo attools/devtools/nodes/errors.py:76and copied intocustom_nodesduring CI, so it is not a function of the container image. Pinning it would mask a deliberate in-repo rename.Review Focus
Motivation. Since #14541 English node display names resolve from the backend
/object_info, so every golden containing a node header is a function ofghcr.io/comfy-org/comfyui-ci-container. #14682 moves that pin from0.0.21(ComfyUI v0.19.3) to0.0.22(v0.30.0) — eleven minors. The goal is that after this lands, a node-title golden that moves on that bump means a real structural change, not an upstream rename.How the strings were established. Both are read off the committed PNGs, not guessed:
Flux 1.1 [pro] Ultra Imageis legible in the title band ofapi-pricing-on-classicandapi-pricing-on-vue, and matchessrc/locales/en/nodeDefs.json.Preview Imageis legible in the title band of all threenode-badge-*goldens, likewise matching the bundled snapshot.Two independent corroborations that these strings hold on both sides of the bump:
image-compare-*andnode-lifecycle-*. It leftapi-pricing-*andnode-badge-*byte-identical, so at0.0.21the container name already equalled the bundled name.node-badge-*sit at x 454–509 / y 69–81 — animagesoutput slot appearing onPreviewImage. The title band is byte-identical, andapi-pricing-*is not regenerated at all. So neither title moves at0.0.22either.Sweep. All 26 goldens #14682 regenerates were diffed old-vs-new and classified. None move because of a node display name:
SaveImage/PreviewImagegained animagesoutputcolorPalette×9,node-badge-*×3,loadWorkflowInMedia×4,save-image-and-webm-preview,lod-comparison-high-qualitycontrol after generatedefaultrandomize->fixedstatic-primitive-connectedload3d-*×3interaction×3,lod-comparison-low-qualitySo there is no evidence-backed third site. The remaining exposure is the default-workflow titles (
KSampler,CLIP Text Encode (Prompt),Load Checkpoint,Save Image, …), which appear across roughly 37 spec files and 257 goldens. Pinning those would touch most of the screenshot suite for a rename that has not happened, so it is left out; the fixture pattern applies unchanged if one ever does.Testing
typecheck,lint,format,knippass locally. The stub itself needs a running ComfyUI backend, so CI is the verifier — the proof is that thenodeBadgeandimageComparescreenshot tests stay green with the goldens unmodified, which also exercises the route-install ordering.Related: #14630 (closed by #14744; this is the follow-through)