Repository navigation
ci: bump comfyui-ci-container to 0.0.22 - #14682
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (33)
📒 Files selected for processing (11)
Included review availability: 2 reviews are currently available. Based on recent review activity, included reviews refill at 4 per hour. 📝 WalkthroughWalkthroughThe pull request updates CI container references to ChangesBrowser test navigation
First-run tour mappings
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates the CI container used by end-to-end and performance workflows so pinned templates are available; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1820 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 8.85 MB gzip 🔴 +109 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • 🔴 +41 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-17T22:40:33.996Z",
"gitSha": "49d1a9d0950ba88411a94e3c3ed82e33e8bd5ad8",
"branch": "christian/bump-ci-container-0.0.22",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2047.1510000000137,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.370999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.46899999999994,
"heapDeltaBytes": -1444820,
"heapUsedBytes": 59066436,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.468000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2048.733000000084,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.052000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.14400000000006,
"heapDeltaBytes": -2459024,
"heapUsedBytes": 59035356,
"domNodes": -283,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.109000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2062.8849999999943,
"styleRecalcs": 76,
"styleRecalcDurationMs": 58.711999999999996,
"layouts": 12,
"layoutDurationMs": 3.5189999999999997,
"taskDurationMs": 1032.4560000000001,
"heapDeltaBytes": 14489820,
"heapUsedBytes": 75610960,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 120.679,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1828.1849999999622,
"styleRecalcs": 73,
"styleRecalcDurationMs": 39.402,
"layouts": 12,
"layoutDurationMs": 3.533,
"taskDurationMs": 879.121,
"heapDeltaBytes": 1178684,
"heapUsedBytes": 61625116,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 114.80499999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.2139999999558,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.947999999999997,
"layouts": 6,
"layoutDurationMs": 0.67,
"taskDurationMs": 377.346,
"heapDeltaBytes": 2808712,
"heapUsedBytes": 62957508,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.528,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2869999999903,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.893999999999995,
"layouts": 6,
"layoutDurationMs": 0.7079999999999999,
"taskDurationMs": 375.525,
"heapDeltaBytes": 3035568,
"heapUsedBytes": 63741908,
"domNodes": 79,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.459,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 573.5760000000028,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.963000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.859,
"heapDeltaBytes": 10050492,
"heapUsedBytes": 70910760,
"domNodes": 10,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 57.211000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 568.1049999999459,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.157000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.538,
"heapDeltaBytes": 10737704,
"heapUsedBytes": 71170828,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 54.272,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2087.2979999999757,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.052,
"heapDeltaBytes": -358384,
"heapUsedBytes": 73696572,
"domNodes": -270,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 17.564000000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2033.8809999999512,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.905000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.057,
"heapDeltaBytes": -9017420,
"heapUsedBytes": 65198068,
"domNodes": -283,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 14.164000000000003,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2250.5030000000374,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.686000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1206.763,
"heapDeltaBytes": 2025808,
"heapUsedBytes": 76717768,
"domNodes": -269,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 348.493,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2197.7490000000444,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1237.105,
"heapDeltaBytes": -329900,
"heapUsedBytes": 74690712,
"domNodes": -238,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 359.82800000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3134.527999999989,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.933999999999996,
"layouts": 60,
"layoutDurationMs": 7.002000000000001,
"taskDurationMs": 1320.3749999999998,
"heapDeltaBytes": 15584556,
"heapUsedBytes": 78475384,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 382.802,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3084.8799999999983,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.614,
"layouts": 60,
"layoutDurationMs": 6.928,
"taskDurationMs": 1322.3590000000002,
"heapDeltaBytes": 15000440,
"heapUsedBytes": 76227784,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 381.07,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.49999999998,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.694000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.8670000000001,
"heapDeltaBytes": 950424,
"heapUsedBytes": 77043128,
"domNodes": -269,
"jsHeapTotalBytes": -2101248,
"scriptDurationMs": 14.328999999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2012.2780000000375,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.091000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.7389999999998,
"heapDeltaBytes": -12023776,
"heapUsedBytes": 63808332,
"domNodes": -283,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 14.860999999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.9680000000035,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.059000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.855,
"heapDeltaBytes": 11798672,
"heapUsedBytes": 73087996,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 120.88199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.2779999999502,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.630999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.69100000000003,
"heapDeltaBytes": 11308472,
"heapUsedBytes": 71872044,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.622,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.6910000000134,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.476,
"heapDeltaBytes": 5535012,
"heapUsedBytes": 66563408,
"domNodes": -280,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 7.453000000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.5680000000584,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.284999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.20199999999994,
"heapDeltaBytes": 3916596,
"heapUsedBytes": 64356696,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.2120000000000015,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.0429999999565,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.903,
"layouts": 16,
"layoutDurationMs": 5.237,
"taskDurationMs": 828.812,
"heapDeltaBytes": 5411572,
"heapUsedBytes": 65945824,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 89.832,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.1470000000782,
"styleRecalcs": 73,
"styleRecalcDurationMs": 34.806000000000004,
"layouts": 16,
"layoutDurationMs": 4.441,
"taskDurationMs": 804.8910000000001,
"heapDeltaBytes": -2807204,
"heapUsedBytes": 57912064,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 86.174,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6570000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.262999999999998,
"layouts": 13,
"layoutDurationMs": 14.339000000000004,
"taskDurationMs": 972.3029999999999,
"heapDeltaBytes": -509244,
"heapUsedBytes": 96795676,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 16.578999999999997,
"eventListeners": 2375,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8286.199000000011,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.782,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4340.835999999999,
"heapDeltaBytes": 9246944,
"heapUsedBytes": 83179032,
"domNodes": -233,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 1081.088,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8380.070000000047,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.858000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4204.153,
"heapDeltaBytes": 8022460,
"heapUsedBytes": 82014708,
"domNodes": -261,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 1051.622,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17715.85699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16836.463000000003,
"heapDeltaBytes": -40942104,
"heapUsedBytes": 178460876,
"domNodes": -8312,
"jsHeapTotalBytes": -14585856,
"scriptDurationMs": 119.43799999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17468.983000000095,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16695.929,
"heapDeltaBytes": -42497024,
"heapUsedBytes": 178135296,
"domNodes": -8312,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 117.514,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21106.50499999997,
"styleRecalcs": 172,
"styleRecalcDurationMs": 18.782999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20472.142,
"heapDeltaBytes": -26258812,
"heapUsedBytes": 179834264,
"domNodes": -8312,
"jsHeapTotalBytes": -13594624,
"scriptDurationMs": 459.20900000000006,
"eventListeners": -16383,
"totalBlockingTimeMs": 145,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20964.507000000027,
"styleRecalcs": 172,
"styleRecalcDurationMs": 18.177,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20384.400999999998,
"heapDeltaBytes": -15142316,
"heapUsedBytes": 190811512,
"domNodes": -8312,
"jsHeapTotalBytes": -12283904,
"scriptDurationMs": 451.405,
"eventListeners": -16383,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 500.9939999999915,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.063,
"layouts": 4,
"layoutDurationMs": 1.3490000000000002,
"taskDurationMs": 138.554,
"heapDeltaBytes": 5238096,
"heapUsedBytes": 65708860,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.244,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 477.9439999999795,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.168,
"layouts": 3,
"layoutDurationMs": 1.5130000000000001,
"taskDurationMs": 110.01100000000001,
"heapDeltaBytes": 5050616,
"heapUsedBytes": 66007964,
"domNodes": 145,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.077000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎨 Storybook: ✅ Built — View Storybook |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14682 +/- ##
==========================================
+ Coverage 79.11% 80.78% +1.67%
==========================================
Files 2209 1882 -327
Lines 122386 109240 -13146
Branches 38327 33759 -4568
==========================================
- Hits 96821 88248 -8573
+ Misses 24989 20600 -4389
+ Partials 576 392 -184
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 460 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Correction: my "#14670 should then pass" claim was wrongI wrote in the PR body:
Step 2 is wrong, and I'm the one who wrote it. I asserted it from the template-availability check alone without checking the pins themselves against the new template payloads. Bumping the image is necessary but not sufficient. Here is what the run actually shows, and what I verified offline against the real artifacts. What the bump does fixAll eight ids in What it does not fix —
|
| pin | pinned | templates 0.9.57 |
templates 0.11.27 |
|---|---|---|---|
| source | 78 LoadImage |
✅ 1 match | ✅ 1 match |
| prompt | 435 PrimitiveStringMultiline |
✅ 1 match | ❌ 0 matches |
| sink | 60 SaveImage |
✅ 1 match | ❌ 0 matches |
The template now has no PrimitiveStringMultiline and no SaveImage node at all. The prompt is TextEncodeQwenImageEditPlus inside the subgraph Image Edit (Qwen 2509) (node 111 is positive — link 211 → KSampler slot 1; node 110 is negative), and the sink is SaveImageAdvanced at id 469.
CI only reports the prompt failure because the assertions short-circuit; the sink is a second, hidden failure. MEDIA_KIND_BY_SINK_TYPE also has no SaveImageAdvanced entry, so the mediaKind assertion is a third.
I re-ran the guard's exact logic offline against all eight templates at 0.11.27: seven pass, only image_qwen_image_edit_2509 fails. So this is one stale pin set, not systemic pin rot.
The larger thing the bump surfaces: v0.30.0 reorganised node categories
This is the part I had not accounted for at all, and it is most of the red.
ComfyUI moved its node category taxonomy between v0.22.0 and v0.24.0:
| v0.19.3 | v0.30.0 |
|---|---|
sampling |
model/sampling |
loaders |
model/loaders |
conditioning/* |
model/conditioning/* |
latent/* |
model/latent/* |
_for_testing |
experimental |
sampling/custom_sampling |
model/sampling/guiders |
sampling and loaders are no longer top-level categories. Every e2e test that reaches for them by name fails. That is ~22 tests across nodeSearchBoxV2, nodeSearchBoxV2Extended, sidebar/nodeLibrary, sidebar/nodeLibraryV2, rightClickMenu and workflowTabThumbnail — including the ones that look like generic click timeouts (getByText('loaders') waiting 15 s) and the mobile-chrome category-sampling failure.
Worth noting: nodeSearchBoxV2.spec.ts:192 asserts categoryButton('sampling') .toBeHidden(), which passes vacuously now that the element does not exist. That test is currently green for the wrong reason.
Falling back to v0.29.0 does not avoid any of this
I checked this rather than assuming, since I offered it in the PR body as the conservative option:
- v0.29.0, v0.28.0 and v0.24.0 already carry the new taxonomy — the reorg predates all of them.
- templates
0.11.19(what v0.29.0 pins) already has the restructured qwen template, so the pin failure is identical there. image_krea2_turbo_t2i— the curated id that motivated this whole PR — first appears in templates0.11.1, i.e. ComfyUI v0.27.0, which is already past the taxonomy change.
There is no ComfyUI version that both serves the curated first-run templates and preserves the old category taxonomy. The category churn is the unavoidable cost of serving the curated set, at v0.29.0 exactly as much as at v0.30.0. My "v0.29.0 is the conservative fallback" line in the PR body is therefore also misleading — it is not more conservative in any way that matters, it just lands the same breakage one minor earlier.
Revised expected outcome
- This PR merges → e2e runs against templates
0.11.27and the v0.30.0 category taxonomy. - test(first-run-tour): assert every pinned template is served, not just three #14670's
unservedassertion passes, but the per-pin assertions onimage_qwen_image_edit_2509fail until its pins are corrected — so test(first-run-tour): assert every pinned template is served, not just three #14670 does not go green on this bump alone. - The category-taxonomy test updates have to ride along, because they cannot be validated against
0.0.21.
I am carrying the pin fix and the taxonomy test updates on this branch, since neither can be verified without the new image.
cc @maanil-verma — the TOUR_ROLE_PINS change touches firstRunTour.
|
/update-playwright Regenerating expectations against |
|
Updating Playwright Expectations |
|
/update-playwright |
Correction #2: the v0.29.0 fallback I offered does not existMy earlier correction dealt with "#14670 should then pass". This one retracts the other claim in the PR body, which I had left standing:
There is no conservative fallback. I offered v0.29.0 as a safety valve without checking whether it avoided anything, and it avoids nothing. The version evidence:
The taxonomy reorganisation landed between v0.22.0 and v0.24.0. The curated template first ships in v0.27.0. Those windows do not overlap, so no ComfyUI version both serves the curated first-run templates and preserves the old category taxonomy. v0.29.0 carries the identical taxonomy change and the identical restructured qwen template (0.11.19 already has it). Picking it would land exactly the same breakage one minor earlier while giving up eleven months of backend fixes. The category test churn in this PR is not a cost of choosing v0.30.0. It is the cost of serving the curated templates at all, and it was always going to be paid on whichever bump got there first. What is now on this branch
The screenshot drift is a real node-def change, not noiseWorth a reviewer's attention rather than a rubber stamp: I diffed the images against the same container rather than assuming. I also re-ran every affected screenshot spec with One thing a reviewer should know about the regeneration mechanism
Separately, that workflow's Split outThe dead fallback template is a live product bug independent of this bump —
|
Finding: the expectations regeneration rewrites snapshots that have not drifted
What happened
Cause: nondeterministic glyph rasterization, captured onceI ran the regeneration command against Two distinct images, the minority appearing roughly 1 run in 6. They differ by 795 pixels (70 past Playwright's 0.2 threshold), and amplifying the difference shows the changed pixels form legible text glyphs — node widget labels and model filenames. Layout, pan offset and node positions are byte-identical. It is font antialiasing, not a rendering change. Why a normal run tolerates this but regeneration does not
This test also sets no Why this matters beyond one flaky imageThe regeneration path has no notion of whether a snapshot actually drifted. It rewrites any snapshot whose bytes differ from the committed one, then commits the result. That cuts both ways:
That is the same fail-open shape as the other two: the mechanism reports success while having verified nothing. Not fixing it here
The third one alone would have made this obvious immediately: of the 34 files regenerated, 33 corresponded to genuinely failing tests and one did not. |
The expectations regeneration rewrote `vue-nodes-paned-with-touch-mobile-chrome-linux.png`, but that test was already green against 0.0.22 before the regeneration ran — mobile-chrome passed in full on the preceding commit. The regenerated sample differs from what the e2e job renders by ~40px, so it turned a passing test red. Every other file the regeneration touched belongs to a test that was genuinely failing; several of those tests assert more than one screenshot, which is why the changed-file count exceeds the failing-test count. This is the only one that was not. Reverted to the previously committed image rather than re-running the regeneration, since that image is the one CI has already demonstrated it matches.
… pins Addresses review feedback: #14682 (comment)
#14744 stubs `/object_info` display names for `ImageCompare` and `ImageBatch`, so `imageCompare-*` and `node-lifecycle-*` no longer track the container's ComfyUI build. Their regenerated copies here are unnecessary — restore main's. The `node-badge-*` trio is not covered: it renders the `nodes/execution_error` workflow, whose titles are unstubbed, so those baselines stay regenerated. Addresses review feedback: #14682 (comment)
`tourRolePins.ts` had no test. The table is maintained by hand against templates that move underneath it, so its failure mode is drifting out of agreement with itself - which is exactly the bug this PR fixes: the qwen sink became `SaveImageAdvanced`, a type `MEDIA_KIND_BY_SINK_TYPE` did not list. Asserts the invariants rather than the ids, since restating `id: 469` would only copy the table into a second place: - every id the Getting Started grid can offer is pinned - every pin's `mediaKind` agrees with what its sink type actually emits - no two roles in one template land on the same node Both halves verified by mutation: dropping this PR's `SaveImageAdvanced: 'image'` entry fails 1/17, and flipping the qwen `mediaKind` to `'video'` fails 1/17.
211b675 to
a09000e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
08c09d7 restored main's copies for all seven `imageCompare-*` / `node-lifecycle-*` baselines, on the argument that #14744 stubs `/object_info` display names so they no longer follow the container's ComfyUI build. CI says that holds for five of them and not for two: image-compare-default-50 15 pixels differ node-lifecycle-Show-all-classic 654 pixels differ Both reproduce identically on all three attempts, so this is real drift under 0.0.22, not the nondeterministic glyph rasterisation that makes these files flap. Note the split is within each pair - `Show-all-vue` and `slider-25`/`slider-75` genuinely are decoupled and stay on main's copies - which is why the blanket restore looked right. Puts back the regenerated copies for just those two.
|
Rebased onto current The baseline restore in
|
| baseline | pixels differing | attempt 1 | 2 | 3 |
|---|---|---|---|---|
image-compare-default-50 |
15 | 15 | 15 | 15 |
node-lifecycle-Show-all-classic |
654 | 654 | 654 | 654 |
Identical on every attempt, so this is real drift under 0.0.22, not the
nondeterministic glyph rasterisation that makes these particular files flap
(that one varies run to run — I measured 2 distinct images across 12 runs
earlier in this PR's life).
What made the blanket restore look right is that the split runs within each
pair — Show-all-vue passes while Show-all-classic fails, slider-25 and
slider-75 pass while default-50 fails. So "these files are decoupled" was
true of most of the group and got generalised.
Restored the regenerated copies for just those two; the other five stay on
main's.
Still outstanding
Shard 12 fails on modelLibrary waiting for sd_xl_base_1.0 to become
visible (locator.click timeout, not a screenshot). That looks like the
container image's bundled model set changing in 0.0.22 rather than anything
this PR's diff does, but I have not confirmed it — the new run will say whether
it persists.
08c09d7 restored main's copies for the whole `imageCompare-*` / `node-lifecycle-*` group, arguing that #14744's `/object_info` display-name stubs decouple them from the container's ComfyUI build. dac4bcc then put two of them back after CI failed on those two. Both steps were wrong about the split. The two that were put back now pass and the failures moved to the five that were left: image-compare-slider-25 image-compare-slider-75 node-lifecycle-None-classic node-lifecycle-None-vue node-lifecycle-Show-all-vue That is exactly the complement, which is not a coincidence - the whole group drifts under 0.0.22. The earlier "only two of seven" reading came from a truncated log that showed only the first failure per shard. Restores the regenerated copies for all seven.
|
Correcting my last comment — I got the split wrong, and the way I got it wrong I claimed the
The new failures are exactly the complement of the two I fixed. That is not Why I saw a split that wasn't there: I read the first run's log with a
The other good news from that run: shard 12 now passes. The |
|
@coderabbitai review Both points are addressed and the thread is resolved: |
|
✅ Action performedReview finished.
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
`check-comfyui-container-version.sh` requires every reference to agree, and merging main brought in two that this branch had not seen: - `ci-tests-e2e.yaml:226`, a job block added after this PR was opened - `scripts/start-comfyui-e2e.sh`, a new file from #14995 Both were still on 0.0.21, so the check reported `Found: 0.0.21 0.0.22`. Verified with the repo's own script, which now prints `ComfyUI CI container references use 0.0.22`.
…ther PRs (#14684) Two independent defects in `pr-update-playwright-expectations.yaml`, both found while regenerating baselines for #14682 (the container-image bump). Both are specific to the `/update-playwright` comment trigger. ## Bug 1: the comment trigger fails open (silent false green) GitHub runs `issue_comment`-triggered workflows from the **default branch's** copy of the workflow file, not the PR's. The container image was a literal in that file, so `/update-playwright` on a PR that bumps the image tag regenerated snapshots under **main's** image (0.0.21), not the PR's (0.0.22). No pixels changed, nothing was committed, and the run reported **success**. A maintainer sees a green "baselines updated" result for work that never happened. The label trigger (`New Browser Test Expectations`) does not have this bug: `pull_request` events run the PR's own copy of the workflow. **Fix chosen: derive the tag from the PR's checked-out files at runtime**, rather than merely detecting the mismatch and failing. This makes the comment path *correct* instead of merely *loud* — a maintainer who comments `/update-playwright` on an image bump now gets working baselines instead of a red run telling them to go use the label. `jobs.<id>.container.image` accepts the `needs` context, so the `setup` job (which already checks out the PR branch) resolves the tag and the sharded job consumes it. The tag is read from the PR's `ci-tests-e2e.yaml` because that is the workflow which will *verify* these snapshots, so it defines the environment they must match. Matching is anchored to `image:` value lines, and all containerized jobs in that file must agree on one tag - `ci-tests-e2e.yaml` has two (`playwright-tests` and `playwright-tests-chromium-sharded`), and requiring agreement catches them drifting apart. Resolution is fail-closed: a missing file, zero matches, or conflicting tags all `::error::` and fail the job. As a side effect this workflow no longer carries an image literal, so future bumps touch two files instead of three. The two rejected options: detecting the mismatch and failing loudly leaves the comment path unusable for exactly the PRs that most need it; removing the comment trigger discards a workflow maintainers actively use. **Residual risk, now surfaced rather than silent:** only the image is taken from the PR. Everything else in this file (job graph, shard matrix, `run` commands) still comes from the default branch on the comment path. A new non-fatal step emits a `::warning::` when the PR modifies this workflow, pointing the maintainer at the label trigger. It cannot fail the job — a failed `git fetch` degrades to a `::notice::` and exits 0. ## Bug 2: concurrency group collides across PRs `concurrency.group` keyed on `github.ref`, which for `issue_comment` is always the default branch. Every comment-triggered run therefore shared one group with `cancel-in-progress: true`, so a comment on **any** PR cancelled an in-flight regeneration on **any other** PR. This actually happened. Note the blast radius is wider than it looks: workflow-level concurrency is evaluated when the run is created, before the job-level `if:` guard filters non-matching comments, so an ordinary comment on an unrelated issue also entered the group. Now keyed on the PR number, with a fallback that is valid for every declared trigger: ``` ${{ github.workflow }}-${{ github.event.issue.number || github.event.number || github.ref }} ``` `github.event.issue.number` for `issue_comment`, `github.event.number` for `pull_request` (`github.event.issue` is absent there and dereferences to null), `github.ref` as a last resort. The label path was already correctly isolated (`refs/pull/N/merge`) and keeps per-PR isolation under the new key. ## Verification Cannot be exercised end-to-end without merging — `issue_comment` workflows only ever run from the default branch, so the fixed comment path is unreachable until this lands. Same structural constraint as #13699 (a different workflow, `pr-backport.yaml`, unrelated defect). Validated as far as statically possible: - `yamllint --config-file .yamllint` (the repo's `CI: YAML Validation` gate) passes. - `actionlint` v1.7.11 reports **no** expression or context errors. It emits the same 6 pre-existing `SC2086:info` findings as the file on `main` — zero new findings. This is what checks expression validity per trigger. - `bash -n` passes on every inline script. - The image-resolution script was **executed** against 7 real inputs: `main`'s `ci-tests-e2e.yaml` -> `0.0.21`; **#14682's branch -> `0.0.22`** (the bug, directly demonstrated); a decoy tag inside a YAML comment -> still `0.0.21`; a quoted `image:` value -> `0.0.21`; missing file -> error, exit 1; two conflicting tags -> error, exit 1; no tag -> error, exit 1. - The drift-warning script was executed in a throwaway repo: no drift -> silent; modified workflow -> `::warning::`; unreachable remote -> `::notice::`, exit 0. **Unverifiable until merge:** that GitHub actually accepts `needs.*` in `container.image` at runtime (documented and widely used, but not exercised here); that the resolved image pulls under `credentials`; and the real end-to-end comment-triggered regeneration. ## Other fail-open path, not fixed here `Update snapshots (Shard N)` carries `continue-on-error: true`. That is necessary — `--update-snapshots` exits non-zero when it rewrites a baseline — but it also swallows hard failures. If a shard dies for an unrelated reason (ComfyUI server never boots, container broken, Playwright crashes), zero snapshots change, `merge-and-commit` logs "No changes to commit", and the workflow goes green having done nothing. That is the same silent-false-green shape as Bug 1 and survives this PR; distinguishing "no diffs" from "the run never happened" needs the Playwright result JSON and is a larger change. Flagging for a follow-up rather than bundling it. --------- Co-authored-by: t <t@t.t> Co-authored-by: Amp <amp@ampcode.com>
Bumps the e2e/perf container from
0.0.21to0.0.22across the four workflow references.0.0.21built from ComfyUI v0.19.3, which installscomfyui-workflow-templates==0.9.57. That predates several templates this repo pins by id, so the e2e backend does not serve them. Verified directly against the templates package:image_krea2_turbo_t2iimage_krea2_turbo_t2iis the first entry inCURATED_TEMPLATE_IDSand the inpaint tutorial card's thumbnail. It landed upstream 2026-07-21; the image was eleven ComfyUI minors behind.Why it went unnoticed
browser_tests/tests/firstRunTourRolePins.spec.tsasserted a count — six served passed a> 2check — so a curated template being unserved was invisible. Tightening that to an identity check (#14670) is what surfaced it, and #14670 is blocked until this lands.Risk
Caution
This is a large backend jump under the whole frontend e2e suite. It is the point of the change — a minimal bump to v0.29.0 would fix the immediate symptom and leave the image to fall behind again within weeks — but if it destabilises the suite, v0.29.0 is the conservative fallback and still resolves the curated-template gap.Struck — this was wrong and it was mine. There is no conservative fallback. The node-category taxonomy reorg landed between v0.22.0 and v0.24.0, and
image_krea2_turbo_t2ifirst ships with ComfyUI v0.27.0, so no version both serves the curated templates and keeps the old taxonomy. v0.29.0 carries the identical taxonomy change and the identical restructured qwen template. See the correction comments below.Container side: Comfy-Org/comfyui-ci-container#29, merged, image published as
v0.0.22.Sequence
test(first-run-tour): assert every pinned template is served, not just three #14670 should then pass— struck, also mine and also wrong. The bump makes all pinned templates served, butimage_qwen_image_edit_2509was restructured upstream and its prompt/sink pins had to be corrected here first;templates-qwen_multiangle.appis gone from the package entirely and is replaced in fix(first-run-tour): replace a fallback template no backend serves #14683.🤖 Generated with Claude Code