Repository navigation
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1784 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle: 8.63 MB gzip 🔴 +851 BDetailsSummary
Category Glance App Entry Points — 3.68 kB (baseline 3.67 kB) • 🔴 +3 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • 🔴 +12 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • 🔴 +3 BTop-level views, pages, and routed surfaces
Status: 15 added / 15 removed / 2 unchanged Panels & Settings — 570 kB (baseline 570 kB) • 🔴 +5 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 27 kB (baseline 27 kB) • 🟢 -4 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 140 kB (baseline 125 kB) • 🔴 +14.2 kBModals, dialogs, drawers, and in-app editors
Status: 9 added / 8 removed UI Components — 67.1 kB (baseline 67.1 kB) • 🔴 +1 BReusable component library chunks
Status: 14 added / 14 removed Data & Services — 3.5 MB (baseline 3.49 MB) • 🔴 +3.62 kBStores, services, APIs, and repositories
Status: 14 added / 15 removed / 2 unchanged Utilities & Hooks — 552 kB (baseline 547 kB) • 🔴 +4.93 kBHelpers, composables, and utility bundles
Status: 29 added / 28 removed / 10 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • 🔴 +3 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed / 14 unchanged Other — 13.8 MB (baseline 13.8 MB) • 🟢 -21.7 kBBundles that do not match a named category
Status: 110 added / 111 removed / 175 unchanged ⚡ Performance
|
🌐 Website E2ETip All tests passed.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesDisabled node support
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/nodeDisabled/disabledNodeStore.ts`:
- Around line 54-93: Extend the hook management around ensureGraphHooks and
restoreGraphHooks to track the canvas’s active graph, not only app.rootGraph, so
node additions and removals inside an open Subgraph trigger scheduleScan
immediately. Install the same onNodeAdded and onNodeRemoved wrappers whenever
canvas.setGraph() activates a subgraph, while preserving restoration of each
graph’s original callbacks when switching or closing graphs.
In `@src/stores/executionErrorStore.ts`:
- Around line 406-416: Update totalErrorCount in the execution error store to
include disabledNodeStore.offenders.length, matching hasAnyError’s disabled-node
behavior. Add a behavioral test covering a workflow with only disabled offenders
and assert the public totalErrorCount is nonzero and equals the disabled
offender count.
In `@src/stores/nodeDefStore.ts`:
- Around line 339-354: Update the watchEffect handling registered node types so
a missing nodeDef preserves the nodeType’s existing skip_list instead of
clearing it; only clear skip_list when a present definition explicitly permits
the node. Add a regression test covering removal and restoration of a disabled
definition, using the existing node definition update and scan/queue behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a863e861-3ae0-49f4-9de5-dfbdba4a2757
📒 Files selected for processing (33)
packages/object-info-parser/src/__tests__/nodeDefSchema.test.tspackages/object-info-parser/src/schemas/nodeDefSchema.tssrc/components/actionbar/ComfyRunButton/ComfyQueueButton.test.tssrc/components/actionbar/ComfyRunButton/ComfyQueueButton.vuesrc/components/error/useErrorOverlayState.test.tssrc/components/rightSidePanel/RightSidePanel.vuesrc/components/rightSidePanel/errors/ErrorGroupList.vuesrc/components/rightSidePanel/errors/types.tssrc/components/rightSidePanel/errors/useErrorGroups.tssrc/components/searchbox/v2/NodeSearchContent.test.tssrc/components/searchbox/v2/NodeSearchContent.vuesrc/components/sidebar/tabs/NodeLibrarySidebarTabV2.test.tssrc/components/sidebar/tabs/NodeLibrarySidebarTabV2.vuesrc/components/toast/GlobalToast.vuesrc/composables/graph/useNodeErrorFlagSync.tssrc/locales/en/main.jsonsrc/platform/nodeDisabled/DisabledNodesCard.vuesrc/platform/nodeDisabled/disabledNodeStore.test.tssrc/platform/nodeDisabled/disabledNodeStore.tssrc/platform/nodeDisabled/openDisabledNodeDetails.tssrc/platform/nodeReplacement/missingNodeScan.test.tssrc/renderer/extensions/linearMode/LinearControls.test.tssrc/renderer/extensions/linearMode/LinearControls.vuesrc/schemas/nodeDef/migration.tssrc/schemas/nodeDef/nodeDefSchemaV2.tssrc/scripts/app.test.tssrc/scripts/app.tssrc/services/litegraphService.tssrc/stores/executionErrorStore.test.tssrc/stores/executionErrorStore.tssrc/stores/missingMediaPreviewRegression.test.tssrc/stores/nodeDefStore.test.tssrc/stores/nodeDefStore.ts
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14531 +/- ##
==========================================
+ Coverage 78.81% 78.83% +0.02%
==========================================
Files 1866 1867 +1
Lines 113111 113140 +29
Branches 34057 32898 -1159
==========================================
+ Hits 89147 89193 +46
+ Misses 23468 23447 -21
- Partials 496 500 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
50b3964 to
8a852f0
Compare
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/scripts/app.ts (1)
1662-1674: 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy liftScope the disabled-node gate to partial executions.
queuePromptscans the activerootGraphand blocks when any disabled node exists, before parsingqueueNodeIds; this covers both full-workflow andqueuePrompt(..., queueNodeIds)calls. For partial execution, return the workflow-wide toast only when the requested targets depend on or are inside an ancestor execution path that contains a disabled node.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/scripts/app.ts` around lines 1662 - 1674, The disabled-node check in queuePrompt should not block every invocation based on the active rootGraph. Parse queueNodeIds first, and for partial executions only surface the workflow-wide disabled-node toast when the requested targets depend on or lie within an ancestor execution path containing a disabled node; preserve the existing full-workflow gate for calls without queueNodeIds.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/object-info-parser/src/schemas/nodeDefSchema.ts`:
- Around line 286-287: Remove the public export from the NodeDisableReason type
alias in the schema module, keeping it available internally for zod inference
and leaving the NodeDisabled export unchanged.
- Around line 282-284: Update zNodeDisabled.reasons to require at least one
element while preserving validation of each reason with zNodeDisableReason. Add
a malformed-metadata case for { reasons: [] } to the existing it.for cases in
nodeDefSchema tests and assert that validation fails.
In `@src/components/searchbox/v2/NodeSearchContent.vue`:
- Around line 356-386: Move the shared disabled-node definitions and search
service computation from NodeSearchContent.vue into nodeDefStore.ts beside
visibleNodeDefs, exposing reusable store-level computed values. Update
NodeSearchContent.vue and NodeLibrarySidebarTabV2.vue to consume those store
values and remove their local disabledNodeDefs/disabledSearchService
definitions, preserving the existing disabledMatchCount behavior.
In `@src/components/sidebar/tabs/NodeLibrarySidebarTabV2.vue`:
- Around line 286-303: Move the shared disabled-node filtering and
search-service computeds from the sidebar component into nodeDefStore.ts,
exposing reusable store symbols for disabled node definitions and their
NodeSearchService. Update NodeLibrarySidebarTabV2.vue and NodeSearchContent.vue
to consume those store computeds, removing their local duplicate definitions
while preserving disabledMatchCount behavior.
In `@src/components/toast/GlobalToast.vue`:
- Around line 3-23: Remove the additional PrimeVue Toast instance added for the
disabled-nodes group in GlobalToast.vue and extend the existing Toast host to
render this group-specific message through its current slot logic, preserving
the disabled-node details action without introducing another PrimeVue component.
In `@src/platform/nodeDisabled/openDisabledNodeDetails.ts`:
- Around line 5-10: Add a colocated Vitest test for openDisabledNodeDetails
covering both Comfy.UseNewMenu values: assert Disabled invokes
useExecutionErrorStore().showErrorOverlay, and the non-Disabled path invokes
useRightSidePanelStore().openPanel('errors'). Mock the relevant stores and
verify the corresponding user-visible navigation behavior without changing the
implementation.
In `@src/stores/executionErrorStore.test.ts`:
- Around line 843-846: Update the beforeEach setup in the “disabled node errors”
test suite to use createTestingPinia({ stubActions: false }) instead of
createPinia(), preserving real actions while following the required
disabled-node store test harness.
---
Outside diff comments:
In `@src/scripts/app.ts`:
- Around line 1662-1674: The disabled-node check in queuePrompt should not block
every invocation based on the active rootGraph. Parse queueNodeIds first, and
for partial executions only surface the workflow-wide disabled-node toast when
the requested targets depend on or lie within an ancestor execution path
containing a disabled node; preserve the existing full-workflow gate for calls
without queueNodeIds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ba0b0e56-a4b6-415a-b5aa-4f27b3c56deb
📒 Files selected for processing (33)
packages/object-info-parser/src/__tests__/nodeDefSchema.test.tspackages/object-info-parser/src/schemas/nodeDefSchema.tssrc/components/actionbar/ComfyRunButton/ComfyQueueButton.test.tssrc/components/actionbar/ComfyRunButton/ComfyQueueButton.vuesrc/components/error/useErrorOverlayState.test.tssrc/components/rightSidePanel/RightSidePanel.vuesrc/components/rightSidePanel/errors/ErrorGroupList.vuesrc/components/rightSidePanel/errors/types.tssrc/components/rightSidePanel/errors/useErrorGroups.tssrc/components/searchbox/v2/NodeSearchContent.test.tssrc/components/searchbox/v2/NodeSearchContent.vuesrc/components/sidebar/tabs/NodeLibrarySidebarTabV2.test.tssrc/components/sidebar/tabs/NodeLibrarySidebarTabV2.vuesrc/components/toast/GlobalToast.vuesrc/composables/graph/useNodeErrorFlagSync.tssrc/locales/en/main.jsonsrc/platform/nodeDisabled/DisabledNodesCard.vuesrc/platform/nodeDisabled/disabledNodeStore.test.tssrc/platform/nodeDisabled/disabledNodeStore.tssrc/platform/nodeDisabled/openDisabledNodeDetails.tssrc/platform/nodeReplacement/missingNodeScan.test.tssrc/renderer/extensions/linearMode/LinearControls.test.tssrc/renderer/extensions/linearMode/LinearControls.vuesrc/schemas/nodeDef/migration.tssrc/schemas/nodeDef/nodeDefSchemaV2.tssrc/scripts/app.test.tssrc/scripts/app.tssrc/services/litegraphService.tssrc/stores/executionErrorStore.test.tssrc/stores/executionErrorStore.tssrc/stores/missingMediaPreviewRegression.test.tssrc/stores/nodeDefStore.test.tssrc/stores/nodeDefStore.ts
befb89d to
9d61214
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/services/litegraphService.test.ts`:
- Around line 67-70: Wrap the assertion for
LiteGraph.registered_node_types[nodeDef.name].skip_list in a try/finally block
and move LiteGraph.unregisterNodeType(nodeDef.name) into finally, ensuring
cleanup runs even when the assertion fails.
In `@src/services/litegraphService.ts`:
- Around line 604-609: The node-definition watcher in nodeDefStore must check
disabled status before dev_only when recalculating skip_list, so enabling
developer mode never clears a disabled node’s skip_list. Add a regression test
covering a node that is both disabled and dev-only while toggling developer
mode.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 30ce216c-763d-47e1-8405-4144bad12dc6
📒 Files selected for processing (6)
packages/object-info-parser/src/__tests__/nodeDefSchema.test.tspackages/object-info-parser/src/schemas/nodeDefSchema.tssrc/services/litegraphService.test.tssrc/services/litegraphService.tssrc/stores/nodeDefStore.test.tssrc/stores/nodeDefStore.ts
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/services/litegraphService.test.ts (1)
49-83: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAssert the node-discovery outcome.
Line 78 checks LiteGraph’s internal
skip_listflag instead of the public discovery result. This test can pass whileDisabledTestNodestill appears in categories or searches if a regression changes category filtering. AssertLiteGraph.getNodeTypesCategories()/LiteGraph.getNodeTypesInCategory()behavior after enablingComfy.DevMode.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/services/litegraphService.test.ts` around lines 49 - 83, Update the test around useLitegraphService().registerNodeDef to assert the public node-discovery outcome after enabling Comfy.DevMode, rather than inspecting registered_node_types[nodeDef.name].skip_list. Verify the disabled node is absent from LiteGraph.getNodeTypesCategories() or the relevant getNodeTypesInCategory() result, while preserving the existing setup and cleanup.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/stores/nodeDefStore.ts`:
- Around line 346-353: Update updateNodeDefs() so each refreshed definition also
synchronizes its corresponding LiteGraph.registered_node_types entry, including
current nodeData and skip_list derived from disabled/dev_only. Ensure the
watcher uses the refreshed nodeDefsByName[nodeData.name] rather than stale
registration data, while preserving existing visibility behavior when either
flag is added or removed.
---
Outside diff comments:
In `@src/services/litegraphService.test.ts`:
- Around line 49-83: Update the test around
useLitegraphService().registerNodeDef to assert the public node-discovery
outcome after enabling Comfy.DevMode, rather than inspecting
registered_node_types[nodeDef.name].skip_list. Verify the disabled node is
absent from LiteGraph.getNodeTypesCategories() or the relevant
getNodeTypesInCategory() result, while preserving the existing setup and
cleanup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 98e0ef94-6a77-4039-88ae-30148671629a
📒 Files selected for processing (2)
src/services/litegraphService.test.tssrc/stores/nodeDefStore.ts
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the current minimal diff at 6a5270d7efdd1cf0a3d096023e2bc9869b3a4281. The parser preserves the backend metadata, both Vue discovery paths and LiteGraph registration exclude disabled nodes, frequency suggestions follow the visible definitions, and the disabled/dev-only precedence regression is covered. I also checked the refresh path: reloadNodeDefs() re-registers each refreshed definition before updateVueAppNodeDefs(defs), so the unresolved stale-nodeData bot finding does not reproduce in the application flow.
suggestion: Please align the PR description and test plan with the final minimal scope before merge. It still claims workflow errors, canvas highlighting, queue gating, and reactivity work that was removed by the rewrite. Per the frontend PR standard, labeling the existing image as the TO BE state and adding an AS IS comparison would also make the behavior change easier to validate.
|
fyi @dante01yoon |
dante01yoon
left a comment
There was a problem hiding this comment.
The prior scope/documentation feedback is resolved, but the current head introduces an eager shared-store dependency that leaves the required aggregate unit check failing.
|
|
||
| export const useNodeDefStore = defineStore('nodeDef', () => { | ||
| const settingStore = useSettingStore() | ||
| const { isNodeDisabled } = useNodeDisabledState() |
There was a problem hiding this comment.
issue: Eagerly creating useNodeDisabledState() here makes every useNodeDefStore() consumer instantiate the governance store, whose immediate flag resolution calls api.getServerFeature. The required aggregate test check is currently failing with 34 errors in existing suites that validly use partial api mocks (subgraphStore.test.ts and MissingModelRow.test.ts), all through this new dependency path. Could we avoid the eager global dependency or update the shared test setup/mocks so the full unit suite remains green?
94d241b to
04c32fe
Compare
|
when @dante01yoon you get a chance please take a look, thank you |
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed the current head at 04c32feaa3cc70fc759f54d185463de3c51134f6. The prior blocking dependency issue is resolved: governance state is now initialized only when disabled state is actually evaluated, so ordinary useNodeDefStore() consumers no longer eagerly traverse the feature-flag/API path. The previously affected subgraphStore and MissingModelRow suites pass, and the required unit, lint/format, and E2E checks are green.
I also rechecked the policy/category derivation, reactive Vue discovery filtering, LiteGraph menu filtering, disabled/dev-only precedence, and frequency suggestions. No remaining blocking findings on this revision.
|
@comfydesigner has a new design for it, will convert it back to draft |
|
Closing because backend disabled-state support was dropped and the replacement design was still pending. The interim provider-policy implementation is no longer the source-of-truth direction. |
Summary
Important
Repurpose the implementation by remove disabled state and ensure it is easily replaceable when the backend supports disabled states via object_info.
Workspace provider policy now controls partner API-node discovery. Nodes from a disabled provider are removed from Vue search, frequency suggestions, and LiteGraph menus; enforcement-off policies remain permissive.
The policy/category join is isolated behind
isNodeDisabled, so a futureobject_info.disabledsource can replace it without changing discovery consumers.Linear FE-1473
Verification
Captured from the current PR head with the same mocked
object_infoand provider catalog; onlyprovider-policy.providers[openai].enabledchanged.