Skip to content

feat: show workspace-disabled partner nodes as disabled in search - #14917

Closed
comfydesigner wants to merge 11 commits into
codex/object-info-disabled-statefrom
comfydesigner/show-disabled-partner-nodes
Closed

comfydesigner wants to merge 11 commits into
codex/object-info-disabled-statefrom
comfydesigner/show-disabled-partner-nodes

Conversation

@comfydesigner

@comfydesigner comfydesigner commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Design-comparison spike stacked on #14531: instead of hiding workspace-disabled partner nodes from discovery, show them in a disabled state — reduced opacity plus an amber Disabled badge — so members learn a node exists-but-is-gated rather than experiencing silent disappearance. Companion artifact for the DES-660 show-vs-hide decision; #14531's isNodeDisabled seam is reused unchanged, only the consumers flip from filter-out to annotate.

Changes

  • What:
    • visibleNodeDefs no longer filters policy-disabled nodes — they stay in the search corpus and node library
    • Both search result items (NodeSearchItem, v2 NodeSearchListItem) render disabled nodes at 60% opacity with an amber Disabled badge. In the v2 dialog the badge sits in the right-hand badge cluster using the shared pill style (amber label); the compact layout keeps the status-tag style alongside deprecated/experimental
    • Disabled nodes cannot be placed: addNodeOnGraph rejects them with a warn toast (reuses the PARTNER_NODE_DISABLED catalog copy), covering search click/Enter, drag-to-canvas, and canvas drop in one gate
    • Frequency suggestions stay curated: topNodeDefs excludes disabled nodes explicitly (limited slots shouldn't carry dead entries)
    • LiteGraph legacy add-node menu shows disabled nodes as native disabled entries (dimmed, unclickable) via a live LGraphCanvas.isNodeTypeDisabled hook — evaluated at menu open, so policy changes apply without reload. The reactive skip_list hiding from the base branch is removed.
    • Node library (v2 panel): disabled rows dim to 60%; the hover preview card carries the policy note; click/drag pickup is blocked with the policy toast
  • Breaking: none

Open (design review inputs)

  • Grouping: whether disabled matches sink below enabled matches / group under a divider
  • Node library tree renders returned nodes without annotation yet
  • If this direction wins, feat: hide workspace-disabled partner nodes #14531's search/library filtering reverts while its isNodeDisabled module and menu handling stay

Linear: DES-660 · FE-1473

Screenshots

Screenshot 2026-08-12 at 2 26 16 PM Screenshot 2026-08-12 at 2 26 47 PM Screenshot 2026-08-12 at 2 26 57 PM

@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cd29af20-434f-421f-8af1-e5d7855be64f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/17/2026, 09:24:59 PM UTC

Links

🎭 Playwright: ✅ 1780 passed, 0 failed · 6 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1761 / ❌ 0 / ⚠️ 5 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 144ms TBT · 94.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.2 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 196ms TBT · 154.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 538ms
canvas-idle: script duration 21ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.8 MB
canvas-idle: DOM nodes 19
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 1009ms
canvas-mouse-sweep: script duration 125ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 48.7 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -153
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 414ms
canvas-zoom-sweep: script duration 23ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 395ms
dom-widget-clipping: script duration 60ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 51.0 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 743ms
large-graph-idle: script duration 114ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.3 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1303ms
large-graph-pan: script duration 417ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 57.8 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 16ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1514ms
large-graph-zoom: script duration 527ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.6 MB
large-graph-zoom: DOM nodes -138
large-graph-zoom: event listeners -88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 703ms
minimap-idle: script duration 105ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.0 MB
minimap-idle: DOM nodes -284
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 412ms
subgraph-dom-widget-clipping: script duration 122ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 52.7 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 498ms
subgraph-idle: script duration 20ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 55.8 MB
subgraph-idle: DOM nodes 21
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 864ms
subgraph-mouse-sweep: script duration 99ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 52.2 MB
subgraph-mouse-sweep: DOM nodes -109
subgraph-mouse-sweep: event listeners -75
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1054ms
subgraph-transition-enter: script duration 43ms
subgraph-transition-enter: TBT 144ms
subgraph-transition-enter: heap used 94.7 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4517ms
viewport-pan-sweep: script duration 1347ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 68.6 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -132
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17888ms
vue-large-graph-idle: script duration 571ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.2 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16387
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 124
vue-large-graph-pan: task duration 19013ms
vue-large-graph-pan: script duration 899ms
vue-large-graph-pan: TBT 196ms
vue-large-graph-pan: heap used 154.5 MB
vue-large-graph-pan: DOM nodes -8314
vue-large-graph-pan: event listeners -16385
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 13
workflow-execution: task duration 122ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.1 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-17T21:35:18.611Z",
  "gitSha": "21105782358a4ddfd0e8a1a2f78783b28862e41e",
  "branch": "comfydesigner/show-disabled-partner-nodes",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2060.473000000002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.421000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 558.1469999999999,
      "heapDeltaBytes": 6090480,
      "heapUsedBytes": 71036332,
      "domNodes": 18,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 21.075000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2021.4369999999917,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.43,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.849,
      "heapDeltaBytes": 6156540,
      "heapUsedBytes": 71165148,
      "domNodes": 20,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 21.415999999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2087.56200000002,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 50.592,
      "layouts": 12,
      "layoutDurationMs": 4.268,
      "taskDurationMs": 1100.33,
      "heapDeltaBytes": -13164460,
      "heapUsedBytes": 52054156,
      "domNodes": -281,
      "jsHeapTotalBytes": 23568384,
      "scriptDurationMs": 130.613,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1856.9549999999708,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 38.223,
      "layouts": 12,
      "layoutDurationMs": 3.6099999999999994,
      "taskDurationMs": 916.7450000000001,
      "heapDeltaBytes": -14865300,
      "heapUsedBytes": 50120300,
      "domNodes": -281,
      "jsHeapTotalBytes": 23568384,
      "scriptDurationMs": 119.97600000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.0739999999792,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.341,
      "layouts": 6,
      "layoutDurationMs": 0.696,
      "taskDurationMs": 440.94500000000005,
      "heapDeltaBytes": 8369808,
      "heapUsedBytes": 73570776,
      "domNodes": 78,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 25.296,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.407000000033,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.521,
      "layouts": 6,
      "layoutDurationMs": 0.6199999999999999,
      "taskDurationMs": 386.277,
      "heapDeltaBytes": 9128940,
      "heapUsedBytes": 74465500,
      "domNodes": 76,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 20.439000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 590.6999999999698,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.978000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.194,
      "heapDeltaBytes": -11655200,
      "heapUsedBytes": 53343768,
      "domNodes": 18,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 59.034,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 590.787999999975,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.814,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.42099999999994,
      "heapDeltaBytes": -11251896,
      "heapUsedBytes": 53652504,
      "domNodes": 14,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 60.38699999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2010.356999999999,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.223,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 750.9879999999999,
      "heapDeltaBytes": 6004940,
      "heapUsedBytes": 66132684,
      "domNodes": -282,
      "jsHeapTotalBytes": 3248128,
      "scriptDurationMs": 114.21699999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.9799999999568,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.828999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 734.7919999999999,
      "heapDeltaBytes": 6786440,
      "heapUsedBytes": 66568680,
      "domNodes": -282,
      "jsHeapTotalBytes": 2985984,
      "scriptDurationMs": 113.686,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2227.113999999972,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.852000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1302.3709999999999,
      "heapDeltaBytes": 5176240,
      "heapUsedBytes": 65908468,
      "domNodes": -286,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 420.43800000000005,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2180.041000000074,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.284999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1303.2440000000001,
      "heapDeltaBytes": -5424456,
      "heapUsedBytes": 55396044,
      "domNodes": -283,
      "jsHeapTotalBytes": 4034560,
      "scriptDurationMs": 413.551,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3196.632999999963,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.63,
      "layouts": 60,
      "layoutDurationMs": 8.063,
      "taskDurationMs": 1500.921,
      "heapDeltaBytes": 23688148,
      "heapUsedBytes": 86202844,
      "domNodes": 12,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 532.41,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3197.2150000000283,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.593999999999998,
      "layouts": 60,
      "layoutDurationMs": 8.008000000000001,
      "taskDurationMs": 1527.077,
      "heapDeltaBytes": -2791188,
      "heapUsedBytes": 59661032,
      "domNodes": -288,
      "jsHeapTotalBytes": 5607424,
      "scriptDurationMs": 521.8340000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2027.6929999999993,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.787000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 729.7940000000001,
      "heapDeltaBytes": 6939792,
      "heapUsedBytes": 67764884,
      "domNodes": -285,
      "jsHeapTotalBytes": 4558848,
      "scriptDurationMs": 113.556,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.6179999999322,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.089999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 675.3339999999998,
      "heapDeltaBytes": 5555512,
      "heapUsedBytes": 66370528,
      "domNodes": -283,
      "jsHeapTotalBytes": 4296704,
      "scriptDurationMs": 95.626,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 612.6480000000356,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.466,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.0930000000001,
      "heapDeltaBytes": -9783712,
      "heapUsedBytes": 55266248,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 121.981,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.8240000000169,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.317,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.14400000000006,
      "heapDeltaBytes": -9720288,
      "heapUsedBytes": 55290212,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 122.571,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.438000000026,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.09499999999997,
      "heapDeltaBytes": 6008588,
      "heapUsedBytes": 71084248,
      "domNodes": 22,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 20.503,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.328000000045,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.238,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.4540000000001,
      "heapDeltaBytes": -19324428,
      "heapUsedBytes": 46007432,
      "domNodes": 20,
      "jsHeapTotalBytes": 21995520,
      "scriptDurationMs": 19.534000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.8029999999794,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.132,
      "layouts": 16,
      "layoutDurationMs": 4.966,
      "taskDurationMs": 825.9159999999999,
      "heapDeltaBytes": -3289900,
      "heapUsedBytes": 61879156,
      "domNodes": 62,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 99.023,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1790.0620000000345,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.184999999999995,
      "layouts": 16,
      "layoutDurationMs": 5.054,
      "taskDurationMs": 901.636,
      "heapDeltaBytes": -17750616,
      "heapUsedBytes": 47507564,
      "domNodes": -280,
      "jsHeapTotalBytes": 23568384,
      "scriptDurationMs": 98.68,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.5560000000237,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.793000000000003,
      "layouts": 15,
      "layoutDurationMs": 12.465,
      "taskDurationMs": 1054.395,
      "heapDeltaBytes": 30729084,
      "heapUsedBytes": 99350332,
      "domNodes": 13673,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 42.762999999999984,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8346.104999999967,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.416999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4600.768999999999,
      "heapDeltaBytes": 9866660,
      "heapUsedBytes": 72256036,
      "domNodes": -282,
      "jsHeapTotalBytes": 6586368,
      "scriptDurationMs": 1366.397,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8236.654000000044,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.385000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4432.714,
      "heapDeltaBytes": 11409792,
      "heapUsedBytes": 71667720,
      "domNodes": -283,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 1328.147,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17899.654999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17876.426,
      "heapDeltaBytes": -43375368,
      "heapUsedBytes": 167346680,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10129408,
      "scriptDurationMs": 562.422,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17944.58899999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17900.324999999997,
      "heapDeltaBytes": -20254376,
      "heapUsedBytes": 189601416,
      "domNodes": -8312,
      "jsHeapTotalBytes": -5443584,
      "scriptDurationMs": 580.384,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16611.793999999976,
      "styleRecalcs": 102,
      "styleRecalcDurationMs": 15.124000000000027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16554.042,
      "heapDeltaBytes": -51976796,
      "heapUsedBytes": 155002780,
      "domNodes": -8316,
      "jsHeapTotalBytes": -10162176,
      "scriptDurationMs": 827.6980000000001,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 71,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21516.57499999999,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 20.66599999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21471.905,
      "heapDeltaBytes": -53468088,
      "heapUsedBytes": 168961664,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9113600,
      "scriptDurationMs": 969.767,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 320,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.50599999999076,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 25.121,
      "layouts": 4,
      "layoutDurationMs": 1.452,
      "taskDurationMs": 130.486,
      "heapDeltaBytes": 5325584,
      "heapUsedBytes": 69410700,
      "domNodes": 130,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.32,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 465.4319999999643,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 18.91,
      "layouts": 3,
      "layoutDurationMs": 0.7050000000000001,
      "taskDurationMs": 113.65100000000001,
      "heapDeltaBytes": 5092136,
      "heapUsedBytes": 69274540,
      "domNodes": 123,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.496,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@codecov

codecov Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.00000% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/node/NodePreviewCard.vue 0.00% 5 Missing ⚠️
src/components/searchbox/NodeSearchItem.vue 0.00% 5 Missing ⚠️
...mponents/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue 0.00% 5 Missing ⚠️
src/components/searchbox/v2/NodeSearchListItem.vue 60.00% 2 Missing and 2 partials ⚠️
@@                         Coverage Diff                          @@
##           codex/object-info-disabled-state   #14917      +/-   ##
====================================================================
- Coverage                             78.83%   78.82%   -0.01%     
====================================================================
  Files                                  1867     1867              
  Lines                                113140   113177      +37     
  Branches                              32898    32921      +23     
====================================================================
+ Hits                                  89193    89213      +20     
- Misses                                23447    23463      +16     
- Partials                                500      501       +1     
Flag Coverage Δ
unit 72.24% <62.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/common/TreeExplorerV2Node.vue 96.00% <100.00%> (+1.55%) ⬆️
src/composables/node/useNodeDragToCanvas.ts 100.00% <100.00%> (ø)
src/lib/litegraph/src/LGraphCanvas.ts 63.50% <ø> (ø)
src/lib/litegraph/src/LGraphNode.ts 63.88% <ø> (ø)
src/services/litegraphService.ts 56.94% <100.00%> (+0.62%) ⬆️
src/stores/nodeDefStore.ts 91.12% <100.00%> (-0.04%) ⬇️
src/components/searchbox/v2/NodeSearchListItem.vue 91.02% <60.00%> (-4.63%) ⬇️
src/components/node/NodePreviewCard.vue 59.61% <0.00%> (-6.35%) ⬇️
src/components/searchbox/NodeSearchItem.vue 34.14% <0.00%> (-3.70%) ⬇️
...mponents/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue 59.52% <0.00%> (-4.58%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfydesigner
comfydesigner marked this pull request as ready for review August 12, 2026 21:58
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 12, 2026

huang47 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Current-head UI evidence for b3feba7: route-mocked real-app capture. The red toast is a mock-fixture setup error, not a PR finding.

Disabled OpenAI node search result

@huang47 huang47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head screenshot: #14917 (comment)

source = 'sidebar_drag'
}: StartDragOptions = {}
) {
if (useNodeDisabledState().isNodeDisabled(nodeDef)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could policy change after this check but before drop? If it does, addNodeOnGraph shows PARTNER_NODE_DISABLED, then stopDrag also emits assetBrowser.failedToCreateNode because it receives null. Please distinguish policy rejection from creation failure and cover the mid-drag transition.

Current-head UI evidence: #14917 (comment)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — fixed in 0d0b3d3e8f. When addNodeOnGraph returns null, the drop path now checks isNodeDisabled first and returns silently (the placement gate already showed the policy toast), so the failedToCreateNode toast only fires for genuine creation failures. Added a test covering the mid-drag policy flip.

@huang47 huang47 assigned comfydesigner and unassigned huang47 Aug 17, 2026
@comfydesigner
comfydesigner requested a review from huang47 August 17, 2026 19:37
@huang47

huang47 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Current-head UI evidence for 0d0b3d3: route-mocked real-app capture showing an enabled partner node and a workspace-disabled partner node in search.
11267afb626e-disabled-partner-node-search

@huang47 huang47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would it be worth squashing or reordering b7dc49f and 874ca586 so disabled-node discovery and placement rejection stay atomic, with a direct addNodeOnGraph rejection test?

Current-head UI evidence

Comment thread src/lib/litegraph/src/LGraphCanvas.ts Outdated
static gradients: Record<string, CanvasGradient> = {}

static search_limit = -1
static isNodeTypeDisabled?: (nodeType: typeof LGraphNode) => boolean

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to keep this workspace-policy predicate outside LGraphCanvas—for example, in a focused menu-policy adapter or passed into menu construction—so the canvas does not gain application-specific mutable state?

Current-head UI evidence

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — moved in 29702a5913. The predicate now lives in src/lib/litegraph/src/nodeTypeAvailability.ts (setNodeTypeDisabledPredicate / isNodeTypeDisabled); the menu builder imports the read side and LGraphCanvas carries no app-specific state.

@comfydesigner

Copy link
Copy Markdown
Contributor Author

On squashing b7dc49f + 874ca586 for atomicity: the repo squash-merges PRs, so discovery and placement rejection land as a single commit either way. Added the direct addNodeOnGraph rejection test in 29702a5913 (disabled def → null + policy toast).

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a design-comparison artifact for the DES-660 show-vs-hide decision this does its job — the screenshots make the tradeoff legible, and reusing #14531's seam rather than forking it was the right call.

What I can't sign off on is this direction merging on the current foundation, and the reason is specific to what changes when you flip from filter-out to annotate.

isNodeDisabled is not a server verdict. It's composed in the frontend:

function isNodeDisabled(nodeDef) {
  return nodeDef.api_node === true &&
    getDisabledNodeCategories().value.has(getProviderName(nodeDef.category))
}

…where getProviderName is category.split('/').at(-1) — a string parse of a category path — cross-referenced against a set assembled from the governance catalog and policy documents. The code says as much itself:

// TODO: Remove isNodeFromPartnerProvider once object_info.disabled is available.

Under #14531 a mistake in that composition meant a node quietly went missing. Under this PR the same mistake tells the customer their workspace disabled it — amber Disabled badge — and refuses to place it with a policy toast. That's the frontend asserting a governance verdict it derived rather than received. Silently filtering on a heuristic is survivable; announcing it as policy is not.

So my ask is ordering, not direction: if show-with-badge wins DES-660, land object_info.disabled first and read the flag, rather than shipping the badge on the string-parsed stand-in the TODO is already waiting to delete.

Four items inline. If this is staying a spike and isn't headed for main, say so and I'll drop this to a comment — I don't want to block a comparison artifact on merge criteria it was never meant to meet.

Unanchored

The policy contract already exists — we're hand-declaring it. src/platform/workspace/api/partnerNodePolicyApi.ts (from the base branch) declares local zod schemas:

const partnerProviderSchema = z.object({ provider_id, display_name, node_categories })
const partnerNodePolicyResponseSchema = z.object({ enforcement_enabled, providers })

But packages/ingest-types/src/types.gen.ts L1171-1213 already carries the generated catalog and policy types, and its doc comments carry the semantics the frontend is re-deriving — including the exact effective rule:

Effective rule: enabled(P) = !enforcement_enabled || (the entry for P has enabled=true); absent from the array = unset (deny when enforcing).

The local implementation happens to match that today (I checked isProviderEnabled — absent yields false, which is correct). But it matches by coincidence of two independent authors, not by construction, and per the repo convention these types should be imported rather than restated. This is #14531's code, so it belongs on that PR — flagging here because this PR is what makes the divergence customer-visible.

Node library tree. The description notes it "renders returned nodes without annotation yet". With visibleNodeDefs no longer filtering, that surface now lists disabled nodes with no badge and no dimming — a strictly worse state than either endpoint of the show-vs-hide comparison. Worth closing before this is evaluated as a candidate.

'flex h-[18px] max-w-28 shrink-0 items-center justify-center gap-1 rounded-full bg-secondary-background-hover/80 px-2'

const { isNodeDisabled } = useNodeDisabledState()
const isDisabled = computed(() => isNodeDisabled(nodeDef))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This computes a governance claim per search result on the client, and the surrounding markup then states it to the customer as fact (workspacePanel.partnerNodes.disabledBadge, L39/L104).

isNodeDisabled resolves through getProviderName(nodeDef.category), i.e. category.split('/').at(-1). The generated contract documents partner categories as partner/<modality>/<Segment> with a provider owning several segments (openai -> ["OpenAI", "Sora"]), so this works only while the provider segment is exactly the last one. A node categorized one level deeper resolves to the wrong name, misses the disabled set, and renders as enabled.

That failure direction is the safer one here, but the badge makes the opposite direction expensive too: any node whose last category segment happens to collide with a disabled provider's segment gets labelled Disabled and blocked, for a provider the workspace never disabled.

Once object_info.disabled exists this is a flag read and both directions go away. Could the badge wait for it?

options: CreateNodeOptions = {},
addOptions?: GraphAddOptions
): LGraphNode | null {
if (isNodeDisabled(nodeDef)) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This is the part that worries me most, because it's the client refusing a user action on a locally-derived verdict.

addNodeOnGraph now rejects placement when isNodeDisabled(nodeDef) — covering search click/Enter, drag-to-canvas and canvas drop, per the description. The predicate behind it is the category-string composition, and it's guarded by governanceStore.policy?.enforcementEnabled !== true returning an empty set, which means the answer also depends on whether the policy document has finished loading.

So there's a load-order question I'd like to understand: if addNodeOnGraph runs before loadPolicy() resolves, isNodeDisabled returns false and the node is placed. Is that the intended behavior — placement allowed until policy arrives — and if so, what happens to a graph that was already saved with a node the policy would have blocked? Conversely if the policy is loaded but a category parse misses, we block a node the customer is entitled to and the toast blames a policy that doesn't apply to it.

A server-owned disabled flag on the node def makes this a non-question: it arrives with the node or it doesn't.

separately, nodeDef here is built inline at L187 via isNodeDisabled({ ... }) — worth confirming the category passed at that call site is the full path and not an already-truncated segment, since the predicate's correctness depends entirely on it.

nodeDef !== undefined && visibleNodeNames.has(nodeDef.name)
nodeDef !== undefined &&
visibleNodeNames.has(nodeDef.name) &&
!isNodeDisabled(nodeDef)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: visibleNodeDefs drops the isNodeDisabled filter (correct for this direction), but topNodeDefs gains it here, and the store also stops setting skip_list for disabled nodes.

That leaves three different policies for the same fact in one file: search shows disabled nodes annotated, frequency suggestions exclude them entirely, and skip_list no longer reflects them at all. The reasoning given — "limited slots shouldn't carry dead entries" — is sensible on its own, but it means "disabled" means hidden in one list and labelled in another.

Is that intentional for the comparison, or would you expect the frequency row to annotate too if this direction wins? Asking mainly because it's the kind of divergence that tends to outlive the spike.

categoriesWithEnabledNodes.add(nodeType.category)
}
}
function isCategoryFullyDisabled(categoryPath: string): boolean {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: isCategoryFullyDisabled adds a third client-side derivation on top of the composed per-node verdict — a category-level rollup, computed by string prefix:

if (!`${category}/`.startsWith(categoryPath)) continue

Two concerns:

  1. Correctness of the prefix test. This asks whether the category is a prefix of the categoryPath, which reads inverted for a "is this category under this path" check — categoryPath is the menu node being rendered, so I'd expect category.startsWith(categoryPath). With the current direction, a menu entry for a deep path gets compared against shorter category strings and sawAny stays false, so isCategoryFullyDisabled returns false and the dimming silently never applies for nested categories. Could you confirm which way round this is meant to go, and is there a test covering a nested partner category?

  2. Layering. This puts workspace billing/governance policy inference inside LGraphCanvas, via a module-level mutable predicate (setNodeTypeDisabledPredicate). Even granting the hook is the pragmatic seam for the legacy menu, rolling categories up from it is new business logic in the renderer. If object_info.disabled lands, the per-node flag makes this loop a plain every() over server-given values instead of a policy computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants