Repository navigation
feat: show workspace-disabled partner nodes as disabled in search - #14917
comfydesigner wants to merge 11 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1780 passed, 0 failed · 6 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-17T21:35:18.611Z",
"gitSha": "21105782358a4ddfd0e8a1a2f78783b28862e41e",
"branch": "comfydesigner/show-disabled-partner-nodes",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2060.473000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.421000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.1469999999999,
"heapDeltaBytes": 6090480,
"heapUsedBytes": 71036332,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 21.075000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.4369999999917,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.43,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.849,
"heapDeltaBytes": 6156540,
"heapUsedBytes": 71165148,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 21.415999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2087.56200000002,
"styleRecalcs": 79,
"styleRecalcDurationMs": 50.592,
"layouts": 12,
"layoutDurationMs": 4.268,
"taskDurationMs": 1100.33,
"heapDeltaBytes": -13164460,
"heapUsedBytes": 52054156,
"domNodes": -281,
"jsHeapTotalBytes": 23568384,
"scriptDurationMs": 130.613,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.9549999999708,
"styleRecalcs": 73,
"styleRecalcDurationMs": 38.223,
"layouts": 12,
"layoutDurationMs": 3.6099999999999994,
"taskDurationMs": 916.7450000000001,
"heapDeltaBytes": -14865300,
"heapUsedBytes": 50120300,
"domNodes": -281,
"jsHeapTotalBytes": 23568384,
"scriptDurationMs": 119.97600000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.0739999999792,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.341,
"layouts": 6,
"layoutDurationMs": 0.696,
"taskDurationMs": 440.94500000000005,
"heapDeltaBytes": 8369808,
"heapUsedBytes": 73570776,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 25.296,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.407000000033,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.521,
"layouts": 6,
"layoutDurationMs": 0.6199999999999999,
"taskDurationMs": 386.277,
"heapDeltaBytes": 9128940,
"heapUsedBytes": 74465500,
"domNodes": 76,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 20.439000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 590.6999999999698,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.978000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.194,
"heapDeltaBytes": -11655200,
"heapUsedBytes": 53343768,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 59.034,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 590.787999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.814,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.42099999999994,
"heapDeltaBytes": -11251896,
"heapUsedBytes": 53652504,
"domNodes": 14,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 60.38699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.356999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.9879999999999,
"heapDeltaBytes": 6004940,
"heapUsedBytes": 66132684,
"domNodes": -282,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 114.21699999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.9799999999568,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.828999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.7919999999999,
"heapDeltaBytes": 6786440,
"heapUsedBytes": 66568680,
"domNodes": -282,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 113.686,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2227.113999999972,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.852000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1302.3709999999999,
"heapDeltaBytes": 5176240,
"heapUsedBytes": 65908468,
"domNodes": -286,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 420.43800000000005,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2180.041000000074,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.284999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1303.2440000000001,
"heapDeltaBytes": -5424456,
"heapUsedBytes": 55396044,
"domNodes": -283,
"jsHeapTotalBytes": 4034560,
"scriptDurationMs": 413.551,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3196.632999999963,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.63,
"layouts": 60,
"layoutDurationMs": 8.063,
"taskDurationMs": 1500.921,
"heapDeltaBytes": 23688148,
"heapUsedBytes": 86202844,
"domNodes": 12,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 532.41,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3197.2150000000283,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.593999999999998,
"layouts": 60,
"layoutDurationMs": 8.008000000000001,
"taskDurationMs": 1527.077,
"heapDeltaBytes": -2791188,
"heapUsedBytes": 59661032,
"domNodes": -288,
"jsHeapTotalBytes": 5607424,
"scriptDurationMs": 521.8340000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.6929999999993,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.787000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.7940000000001,
"heapDeltaBytes": 6939792,
"heapUsedBytes": 67764884,
"domNodes": -285,
"jsHeapTotalBytes": 4558848,
"scriptDurationMs": 113.556,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.6179999999322,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.089999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.3339999999998,
"heapDeltaBytes": 5555512,
"heapUsedBytes": 66370528,
"domNodes": -283,
"jsHeapTotalBytes": 4296704,
"scriptDurationMs": 95.626,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.6480000000356,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.0930000000001,
"heapDeltaBytes": -9783712,
"heapUsedBytes": 55266248,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 121.981,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.8240000000169,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.317,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.14400000000006,
"heapDeltaBytes": -9720288,
"heapUsedBytes": 55290212,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 122.571,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.438000000026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.09499999999997,
"heapDeltaBytes": 6008588,
"heapUsedBytes": 71084248,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 20.503,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.328000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.238,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.4540000000001,
"heapDeltaBytes": -19324428,
"heapUsedBytes": 46007432,
"domNodes": 20,
"jsHeapTotalBytes": 21995520,
"scriptDurationMs": 19.534000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.8029999999794,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.132,
"layouts": 16,
"layoutDurationMs": 4.966,
"taskDurationMs": 825.9159999999999,
"heapDeltaBytes": -3289900,
"heapUsedBytes": 61879156,
"domNodes": 62,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 99.023,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1790.0620000000345,
"styleRecalcs": 78,
"styleRecalcDurationMs": 40.184999999999995,
"layouts": 16,
"layoutDurationMs": 5.054,
"taskDurationMs": 901.636,
"heapDeltaBytes": -17750616,
"heapUsedBytes": 47507564,
"domNodes": -280,
"jsHeapTotalBytes": 23568384,
"scriptDurationMs": 98.68,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.5560000000237,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.793000000000003,
"layouts": 15,
"layoutDurationMs": 12.465,
"taskDurationMs": 1054.395,
"heapDeltaBytes": 30729084,
"heapUsedBytes": 99350332,
"domNodes": 13673,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 42.762999999999984,
"eventListeners": 2375,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8346.104999999967,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.416999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4600.768999999999,
"heapDeltaBytes": 9866660,
"heapUsedBytes": 72256036,
"domNodes": -282,
"jsHeapTotalBytes": 6586368,
"scriptDurationMs": 1366.397,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8236.654000000044,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.385000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4432.714,
"heapDeltaBytes": 11409792,
"heapUsedBytes": 71667720,
"domNodes": -283,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1328.147,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17899.654999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17876.426,
"heapDeltaBytes": -43375368,
"heapUsedBytes": 167346680,
"domNodes": -8312,
"jsHeapTotalBytes": -10129408,
"scriptDurationMs": 562.422,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17944.58899999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17900.324999999997,
"heapDeltaBytes": -20254376,
"heapUsedBytes": 189601416,
"domNodes": -8312,
"jsHeapTotalBytes": -5443584,
"scriptDurationMs": 580.384,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16611.793999999976,
"styleRecalcs": 102,
"styleRecalcDurationMs": 15.124000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16554.042,
"heapDeltaBytes": -51976796,
"heapUsedBytes": 155002780,
"domNodes": -8316,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 827.6980000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 71,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21516.57499999999,
"styleRecalcs": 146,
"styleRecalcDurationMs": 20.66599999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21471.905,
"heapDeltaBytes": -53468088,
"heapUsedBytes": 168961664,
"domNodes": -8312,
"jsHeapTotalBytes": -9113600,
"scriptDurationMs": 969.767,
"eventListeners": -16385,
"totalBlockingTimeMs": 320,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 468.50599999999076,
"styleRecalcs": 12,
"styleRecalcDurationMs": 25.121,
"layouts": 4,
"layoutDurationMs": 1.452,
"taskDurationMs": 130.486,
"heapDeltaBytes": 5325584,
"heapUsedBytes": 69410700,
"domNodes": 130,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.32,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.4319999999643,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.91,
"layouts": 3,
"layoutDurationMs": 0.7050000000000001,
"taskDurationMs": 113.65100000000001,
"heapDeltaBytes": 5092136,
"heapUsedBytes": 69274540,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.496,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## codex/object-info-disabled-state #14917 +/- ##
====================================================================
- Coverage 78.83% 78.82% -0.01%
====================================================================
Files 1867 1867
Lines 113140 113177 +37
Branches 32898 32921 +23
====================================================================
+ Hits 89193 89213 +20
- Misses 23447 23463 +16
- Partials 500 501 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
huang47
left a comment
There was a problem hiding this comment.
Current-head screenshot: #14917 (comment)
| source = 'sidebar_drag' | ||
| }: StartDragOptions = {} | ||
| ) { | ||
| if (useNodeDisabledState().isNodeDisabled(nodeDef)) { |
There was a problem hiding this comment.
Could policy change after this check but before drop? If it does, addNodeOnGraph shows PARTNER_NODE_DISABLED, then stopDrag also emits assetBrowser.failedToCreateNode because it receives null. Please distinguish policy rejection from creation failure and cover the mid-drag transition.
Current-head UI evidence: #14917 (comment)
There was a problem hiding this comment.
Good catch — fixed in 0d0b3d3e8f. When addNodeOnGraph returns null, the drop path now checks isNodeDisabled first and returns silently (the placement gate already showed the policy toast), so the failedToCreateNode toast only fires for genuine creation failures. Added a test covering the mid-drag policy flip.
huang47
left a comment
There was a problem hiding this comment.
LGTM. Would it be worth squashing or reordering b7dc49f and 874ca586 so disabled-node discovery and placement rejection stay atomic, with a direct addNodeOnGraph rejection test?
| static gradients: Record<string, CanvasGradient> = {} | ||
|
|
||
| static search_limit = -1 | ||
| static isNodeTypeDisabled?: (nodeType: typeof LGraphNode) => boolean |
There was a problem hiding this comment.
Would it be simpler to keep this workspace-policy predicate outside LGraphCanvas—for example, in a focused menu-policy adapter or passed into menu construction—so the canvas does not gain application-specific mutable state?
There was a problem hiding this comment.
Agreed — moved in 29702a5913. The predicate now lives in src/lib/litegraph/src/nodeTypeAvailability.ts (setNodeTypeDisabledPredicate / isNodeTypeDisabled); the menu builder imports the read side and LGraphCanvas carries no app-specific state.
|
On squashing |
dante01yoon
left a comment
There was a problem hiding this comment.
As a design-comparison artifact for the DES-660 show-vs-hide decision this does its job — the screenshots make the tradeoff legible, and reusing #14531's seam rather than forking it was the right call.
What I can't sign off on is this direction merging on the current foundation, and the reason is specific to what changes when you flip from filter-out to annotate.
isNodeDisabled is not a server verdict. It's composed in the frontend:
function isNodeDisabled(nodeDef) {
return nodeDef.api_node === true &&
getDisabledNodeCategories().value.has(getProviderName(nodeDef.category))
}…where getProviderName is category.split('/').at(-1) — a string parse of a category path — cross-referenced against a set assembled from the governance catalog and policy documents. The code says as much itself:
// TODO: Remove isNodeFromPartnerProvider once object_info.disabled is available.Under #14531 a mistake in that composition meant a node quietly went missing. Under this PR the same mistake tells the customer their workspace disabled it — amber Disabled badge — and refuses to place it with a policy toast. That's the frontend asserting a governance verdict it derived rather than received. Silently filtering on a heuristic is survivable; announcing it as policy is not.
So my ask is ordering, not direction: if show-with-badge wins DES-660, land object_info.disabled first and read the flag, rather than shipping the badge on the string-parsed stand-in the TODO is already waiting to delete.
Four items inline. If this is staying a spike and isn't headed for main, say so and I'll drop this to a comment — I don't want to block a comparison artifact on merge criteria it was never meant to meet.
Unanchored
The policy contract already exists — we're hand-declaring it. src/platform/workspace/api/partnerNodePolicyApi.ts (from the base branch) declares local zod schemas:
const partnerProviderSchema = z.object({ provider_id, display_name, node_categories })
const partnerNodePolicyResponseSchema = z.object({ enforcement_enabled, providers })But packages/ingest-types/src/types.gen.ts L1171-1213 already carries the generated catalog and policy types, and its doc comments carry the semantics the frontend is re-deriving — including the exact effective rule:
Effective rule:
enabled(P) = !enforcement_enabled || (the entry for P has enabled=true); absent from the array = unset (deny when enforcing).
The local implementation happens to match that today (I checked isProviderEnabled — absent yields false, which is correct). But it matches by coincidence of two independent authors, not by construction, and per the repo convention these types should be imported rather than restated. This is #14531's code, so it belongs on that PR — flagging here because this PR is what makes the divergence customer-visible.
Node library tree. The description notes it "renders returned nodes without annotation yet". With visibleNodeDefs no longer filtering, that surface now lists disabled nodes with no badge and no dimming — a strictly worse state than either endpoint of the show-vs-hide comparison. Worth closing before this is evaluated as a candidate.
| 'flex h-[18px] max-w-28 shrink-0 items-center justify-center gap-1 rounded-full bg-secondary-background-hover/80 px-2' | ||
|
|
||
| const { isNodeDisabled } = useNodeDisabledState() | ||
| const isDisabled = computed(() => isNodeDisabled(nodeDef)) |
There was a problem hiding this comment.
issue: This computes a governance claim per search result on the client, and the surrounding markup then states it to the customer as fact (workspacePanel.partnerNodes.disabledBadge, L39/L104).
isNodeDisabled resolves through getProviderName(nodeDef.category), i.e. category.split('/').at(-1). The generated contract documents partner categories as partner/<modality>/<Segment> with a provider owning several segments (openai -> ["OpenAI", "Sora"]), so this works only while the provider segment is exactly the last one. A node categorized one level deeper resolves to the wrong name, misses the disabled set, and renders as enabled.
That failure direction is the safer one here, but the badge makes the opposite direction expensive too: any node whose last category segment happens to collide with a disabled provider's segment gets labelled Disabled and blocked, for a provider the workspace never disabled.
Once object_info.disabled exists this is a flag read and both directions go away. Could the badge wait for it?
| options: CreateNodeOptions = {}, | ||
| addOptions?: GraphAddOptions | ||
| ): LGraphNode | null { | ||
| if (isNodeDisabled(nodeDef)) { |
There was a problem hiding this comment.
issue: This is the part that worries me most, because it's the client refusing a user action on a locally-derived verdict.
addNodeOnGraph now rejects placement when isNodeDisabled(nodeDef) — covering search click/Enter, drag-to-canvas and canvas drop, per the description. The predicate behind it is the category-string composition, and it's guarded by governanceStore.policy?.enforcementEnabled !== true returning an empty set, which means the answer also depends on whether the policy document has finished loading.
So there's a load-order question I'd like to understand: if addNodeOnGraph runs before loadPolicy() resolves, isNodeDisabled returns false and the node is placed. Is that the intended behavior — placement allowed until policy arrives — and if so, what happens to a graph that was already saved with a node the policy would have blocked? Conversely if the policy is loaded but a category parse misses, we block a node the customer is entitled to and the toast blames a policy that doesn't apply to it.
A server-owned disabled flag on the node def makes this a non-question: it arrives with the node or it doesn't.
separately, nodeDef here is built inline at L187 via isNodeDisabled({ ... }) — worth confirming the category passed at that call site is the full path and not an already-truncated segment, since the predicate's correctness depends entirely on it.
| nodeDef !== undefined && visibleNodeNames.has(nodeDef.name) | ||
| nodeDef !== undefined && | ||
| visibleNodeNames.has(nodeDef.name) && | ||
| !isNodeDisabled(nodeDef) |
There was a problem hiding this comment.
question: visibleNodeDefs drops the isNodeDisabled filter (correct for this direction), but topNodeDefs gains it here, and the store also stops setting skip_list for disabled nodes.
That leaves three different policies for the same fact in one file: search shows disabled nodes annotated, frequency suggestions exclude them entirely, and skip_list no longer reflects them at all. The reasoning given — "limited slots shouldn't carry dead entries" — is sensible on its own, but it means "disabled" means hidden in one list and labelled in another.
Is that intentional for the comparison, or would you expect the frequency row to annotate too if this direction wins? Asking mainly because it's the kind of divergence that tends to outlive the spike.
| categoriesWithEnabledNodes.add(nodeType.category) | ||
| } | ||
| } | ||
| function isCategoryFullyDisabled(categoryPath: string): boolean { |
There was a problem hiding this comment.
issue: isCategoryFullyDisabled adds a third client-side derivation on top of the composed per-node verdict — a category-level rollup, computed by string prefix:
if (!`${category}/`.startsWith(categoryPath)) continueTwo concerns:
-
Correctness of the prefix test. This asks whether the category is a prefix of the categoryPath, which reads inverted for a "is this category under this path" check —
categoryPathis the menu node being rendered, so I'd expectcategory.startsWith(categoryPath). With the current direction, a menu entry for a deep path gets compared against shorter category strings andsawAnystaysfalse, soisCategoryFullyDisabledreturnsfalseand the dimming silently never applies for nested categories. Could you confirm which way round this is meant to go, and is there a test covering a nested partner category? -
Layering. This puts workspace billing/governance policy inference inside
LGraphCanvas, via a module-level mutable predicate (setNodeTypeDisabledPredicate). Even granting the hook is the pragmatic seam for the legacy menu, rolling categories up from it is new business logic in the renderer. Ifobject_info.disabledlands, the per-node flag makes this loop a plainevery()over server-given values instead of a policy computation.


Summary
Design-comparison spike stacked on #14531: instead of hiding workspace-disabled partner nodes from discovery, show them in a disabled state — reduced opacity plus an amber
Disabledbadge — so members learn a node exists-but-is-gated rather than experiencing silent disappearance. Companion artifact for the DES-660 show-vs-hide decision; #14531'sisNodeDisabledseam is reused unchanged, only the consumers flip from filter-out to annotate.Changes
visibleNodeDefsno longer filters policy-disabled nodes — they stay in the search corpus and node libraryNodeSearchItem, v2NodeSearchListItem) render disabled nodes at 60% opacity with an amberDisabledbadge. In the v2 dialog the badge sits in the right-hand badge cluster using the shared pill style (amber label); the compact layout keeps the status-tag style alongside deprecated/experimentaladdNodeOnGraphrejects them with a warn toast (reuses thePARTNER_NODE_DISABLEDcatalog copy), covering search click/Enter, drag-to-canvas, and canvas drop in one gatetopNodeDefsexcludes disabled nodes explicitly (limited slots shouldn't carry dead entries)LGraphCanvas.isNodeTypeDisabledhook — evaluated at menu open, so policy changes apply without reload. The reactiveskip_listhiding from the base branch is removed.Open (design review inputs)
isNodeDisabledmodule and menu handling stayLinear: DES-660 · FE-1473
Screenshots