Skip to content

test: document QwenVL asset picker writing filenames where the node expects folder names - #14314

Open
claude[bot] wants to merge 4 commits into
mainfrom
test/qwenvl-widget-value-folder-vs-filename
Open

claude[bot] wants to merge 4 commits into
mainfrom
test/qwenvl-widget-value-folder-vs-filename

Conversation

@claude

@claude claude Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

This originally added a failing test documenting that the asset browser writes a per-file filename, such as model-00001-of-00004.safetensors, into AILab_QwenVL.model_name, when the node actually requires a folder-style repo identifier such as Qwen3-VL-8B-Instruct.

Update (2026-08-25): #14489 deliberately removed LLM/Qwen-VL/* from MODEL_NODE_MAPPINGS — those widgets accept repository IDs and now fall back to /api/object_info, so AILab_QwenVL.model_name no longer receives a value from assetService at all. The scenario this test pinned is no longer reachable through any real consumer. Checked the rest of MODEL_NODE_MAPPINGS for a still-mapped node with the same folder-vs-filename shape to retarget onto instead: nothing qualifies, since no entry has a decided contract for representing a multi-file, folder-addressed model as a single widget value (the "mint a folder-level value" vs. "exclude the mapping" choice this test called out is still undecided repo-wide, not specific to QwenVL). Per Christian Byrne's review, the it.fails case has been removed rather than pinned to an invalidated or speculative scenario. This supersedes the "Status note" below where the two describe this PR's own case — that note's "not fixed" verdict is about a different bug (see the clarification inline).

How to verify: pnpm test:unit src/platform/assets/services/assetService.test.ts


Generated by Claude Code


Status note — 2026-08-03

This note is shared boilerplate posted across the sibling test series (#14311, #14312, #14313, #14314). The table below tracks a different bug — a node type resolving to only its first registered MODEL_NODE_MAPPINGS directory — not the folder-vs-filename widget-value mismatch this PR (#14314) originally documented. That case was removed per the 2026-08-25 update above; it does not appear in the table below because it was never about directory reachability. This note is retained only for continuity with the sibling PRs' shared status tracking.

Re-verified against main on this date.

AILab_QwenVL and eight other model-id-based node families were de-registered from MODEL_NODE_MAPPINGS by #14489 (merged 2026-08-01, backported to cloud/1.48 via #14527). That fixed the reported symptom in BE-5071 — those widgets now fall back to the node's own /api/object_info combo.

The bug class documented here is not fixed. The asset browser still resolves a node type to exactly one category. As of 2026-08-03 it remains live on main for five node/input pairs:

Node Input Directories (only the first is reachable)
LS_LoadSegformerModel model_name segformer_b2_clothes, segformer_b3_clothes, segformer_b3_fashion
UpscaleModelLoader model_name upscale_models, onnx
CLIPVisionLoader clip_name clip_vision, clip
FlashVSRNode (auto) FlashVSR, FlashVSR-v1.1
UltralyticsDetectorProvider model_name ultralytics/bbox, ultralytics/segm

Tracked by FE-1177 (query model_type: rather than a single directory), FE-1181 (generate the mapping from object_info), FE-1080 (child-directory tags) and BE-5255 (backend subtype-carrying tag).

Why this is a merged test rather than a Slack thread: it.fails inverts the report — the assertion genuinely fails (proving the bug is real) but CI stays green. It turns red only when someone fixes the bug without updating the test, which is exactly the alarm we want. As an unmerged draft it provides none of that, which is why these are being taken out of draft.

@github-actions

github-actions Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/17/2026, 09:27:13 PM UTC

Links

📦 Bundle: 8.85 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 37.4 MB baseline 37.4 MB — ⚪ 0 B
  • Gzip: 8.85 MB baseline 8.85 MB — ⚪ 0 B
  • Brotli: 6.19 MB baseline 6.19 MB — ⚪ 0 B
  • Bundles: 438 current • 438 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (16.8 MB) · Other ⚪ 0 B (14.2 MB) · Data & Services ⚪ 0 B (3.52 MB) · Graph Workspace ⚪ 0 B (1.37 MB) · Panels & Settings ⚪ 0 B (566 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 285 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 118ms TBT · 76.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.8 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 135ms TBT · 172.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap

⚠️ 8 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 384ms 462ms +20% ⚠️ z=2.2
canvas-zoom-sweep: task duration 309ms 386ms +25% ⚠️ z=2.6
dom-widget-clipping: task duration 291ms 401ms +38% ⚠️ z=2.2
large-graph-idle: task duration 494ms 661ms +34% ⚠️ z=2.2
large-graph-pan: task duration 954ms 1253ms +31% ⚠️ z=4.0
subgraph-dom-widget-clipping: task duration 319ms 418ms +31% ⚠️ z=2.2
subgraph-idle: task duration 373ms 469ms +26% ⚠️ z=3.2
subgraph-mouse-sweep: layout duration 4ms 8ms +115% ⚠️ z=10.7
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.9
canvas-idle: p95 frame time 17ms 17ms -1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 6ms 7ms +20% z=-3.7
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 9 -10% z=-3.8
canvas-idle: task duration 384ms 462ms +20% ⚠️ z=2.2
canvas-idle: script duration 6ms 7ms +14% z=-8.0
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 66.2 MB 67.2 MB +2% —
canvas-idle: DOM nodes 20 18 -10% z=-3.6
canvas-idle: event listeners 6 4 -33% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms +1% —
canvas-mouse-sweep: layout duration 3ms 4ms +11% z=-0.3
canvas-mouse-sweep: style recalc duration 27ms 36ms +34% z=-2.0
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 73 74 +1% z=-2.2
canvas-mouse-sweep: task duration 715ms 923ms +29% z=1.0
canvas-mouse-sweep: script duration 81ms 107ms +33% z=-4.4
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 45.8 MB 54.3 MB +19% —
canvas-mouse-sweep: DOM nodes -280 -114 -59% z=-68.2
canvas-mouse-sweep: event listeners -151 -75 -51% z=-19.9
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms -0% —
canvas-zoom-sweep: layout duration 1ms 1ms +4% z=0.8
canvas-zoom-sweep: style recalc duration 13ms 18ms +35% z=-0.9
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 32 -2% z=0.5
canvas-zoom-sweep: task duration 309ms 386ms +25% ⚠️ z=2.6
canvas-zoom-sweep: script duration 9ms 11ms +29% z=-5.3
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.2 MB 69.8 MB +1% —
canvas-zoom-sweep: DOM nodes 79 77 -3% z=-3.5
canvas-zoom-sweep: event listeners 21 19 -10% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 6ms 9ms +62% z=-0.6
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 12 -12% z=-3.2
dom-widget-clipping: task duration 291ms 401ms +38% ⚠️ z=2.2
dom-widget-clipping: script duration 40ms 57ms +42% z=-3.4
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.1 MB 51.1 MB +2% —
dom-widget-clipping: DOM nodes 22 19 -14% z=-2.2
dom-widget-clipping: event listeners 2 1 -50% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms -0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 5ms 7ms +34% z=-4.7
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 8 -11% z=-11.5
large-graph-idle: task duration 494ms 661ms +34% ⚠️ z=2.2
large-graph-idle: script duration 12ms 17ms +50% z=-8.1
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 69.3 MB 69.5 MB +0% —
large-graph-idle: DOM nodes -281 -282 +0% z=-339.3
large-graph-idle: event listeners -149 -164 +10% z=-31.2
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 12ms 16ms +30% z=-1.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-1.7
large-graph-pan: task duration 954ms 1253ms +31% ⚠️ z=4.0
large-graph-pan: script duration 252ms 326ms +30% z=-4.2
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 64.9 MB 66.9 MB +3% —
large-graph-pan: DOM nodes -284 -283 -1% z=-182.7
large-graph-pan: event listeners -147 -148 +1% z=-184.7
large-graph-zoom: avg frame time 17ms 17ms -0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 8ms 8ms +6% —
large-graph-zoom: style recalc duration 14ms 15ms +10% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 65 64 -2% —
large-graph-zoom: task duration 1104ms 1370ms +24% —
large-graph-zoom: script duration 290ms 392ms +35% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 75.7 MB 75.6 MB -0% —
large-graph-zoom: DOM nodes 12 10 -17% —
large-graph-zoom: event listeners 6 8 +33% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.7
minimap-idle: p95 frame time 17ms 17ms -1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 6ms 6ms -5% z=-4.6
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 10 7 -35% z=-4.5
minimap-idle: task duration 503ms 622ms +24% z=2.0
minimap-idle: script duration 14ms 16ms +14% z=-8.3
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 70.4 MB 68.8 MB -2% —
minimap-idle: DOM nodes -282 -286 +1% z=-222.7
minimap-idle: event listeners -149 -164 +10% z=-255.3
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 7ms 12ms +58% z=-1.1
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +1% z=-0.8
subgraph-dom-widget-clipping: task duration 319ms 418ms +31% ⚠️ z=2.2
subgraph-dom-widget-clipping: script duration 89ms 123ms +38% z=-0.8
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.9 MB 51.7 MB -0% —
subgraph-dom-widget-clipping: DOM nodes 20 21 +5% z=-1.1
subgraph-dom-widget-clipping: event listeners 8 6 -25% z=-1.7
subgraph-idle: avg frame time 17ms 17ms +0% z=0.9
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 6ms 9ms +43% z=-1.8
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 10 +0% z=-1.4
subgraph-idle: task duration 373ms 469ms +26% ⚠️ z=3.2
subgraph-idle: script duration 6ms 7ms +26% z=-4.9
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 66.6 MB 67.3 MB +1% —
subgraph-idle: DOM nodes 20 20 +0% z=-1.2
subgraph-idle: event listeners 6 4 -33% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.5
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 4ms 8ms +115% ⚠️ z=10.7
subgraph-mouse-sweep: style recalc duration 28ms 38ms +35% z=-1.4
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 77 -1% z=-1.9
subgraph-mouse-sweep: task duration 609ms 774ms +27% z=0.1
subgraph-mouse-sweep: script duration 62ms 87ms +41% z=-2.1
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 57.4 MB 58.8 MB +2% —
subgraph-mouse-sweep: DOM nodes 62 63 +1% z=-2.0
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -1% —
subgraph-transition-enter: layout duration 9ms 11ms +34% —
subgraph-transition-enter: style recalc duration 24ms 29ms +22% —
subgraph-transition-enter: layout count 14 15 +7% —
subgraph-transition-enter: style recalc count 19 20 +5% —
subgraph-transition-enter: task duration 710ms 983ms +39% —
subgraph-transition-enter: script duration 13ms 17ms +34% —
subgraph-transition-enter: TBT 110ms 118ms +7% —
subgraph-transition-enter: heap used 75.8 MB 76.1 MB +0% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2373 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 37ms 41ms +13% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 249 -0% —
viewport-pan-sweep: task duration 3392ms 4201ms +24% —
viewport-pan-sweep: script duration 821ms 994ms +21% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 69.9 MB 72.2 MB +3% —
viewport-pan-sweep: DOM nodes -283 -282 -0% —
viewport-pan-sweep: event listeners -133 -149 +12% —
vue-large-graph-idle: avg frame time 17ms 18ms +3% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 12437ms 17417ms +40% —
vue-large-graph-idle: script duration 101ms 134ms +32% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 158.8 MB 162.8 MB +2% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16391 -16389 -0% —
vue-large-graph-pan: avg frame time 18ms 18ms -0% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 15ms 21ms +47% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 90 169 +88% —
vue-large-graph-pan: task duration 15190ms 21301ms +40% —
vue-large-graph-pan: script duration 408ms 421ms +3% —
vue-large-graph-pan: TBT 39ms 135ms +246% —
vue-large-graph-pan: heap used 174.1 MB 172.6 MB -1% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16385 -16381 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=1.6
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 1ms +13% z=-5.4
workflow-execution: style recalc duration 16ms 20ms +23% z=-2.1
workflow-execution: layout count 3 3 -17% z=-4.5
workflow-execution: style recalc count 14 15 +4% z=-1.6
workflow-execution: task duration 95ms 115ms +21% z=-0.7
workflow-execution: script duration 6ms 9ms +48% z=-6.9
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.5 MB 66.3 MB +1% —
workflow-execution: DOM nodes 126 136 +8% z=-3.6
workflow-execution: event listeners 99 98 -1% z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-17T21:37:33.651Z",
  "gitSha": "88ac6af08f27cb04680ed9f1a4542f3a08addaa6",
  "branch": "test/qwenvl-widget-value-folder-vs-filename",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2015.7439999999838,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.6240000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.877,
      "heapDeltaBytes": 5058108,
      "heapUsedBytes": 70446660,
      "domNodes": 18,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 7.1469999999999985,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2043.3170000000018,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.357000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.162,
      "heapDeltaBytes": 5210956,
      "heapUsedBytes": 70490756,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 7.547999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1935.543000000024,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.707,
      "layouts": 12,
      "layoutDurationMs": 3.5620000000000003,
      "taskDurationMs": 999.8530000000001,
      "heapDeltaBytes": -16868908,
      "heapUsedBytes": 48403108,
      "domNodes": -284,
      "jsHeapTotalBytes": 23171072,
      "scriptDurationMs": 110.199,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1850.0889999999686,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 34.79,
      "layouts": 12,
      "layoutDurationMs": 3.535,
      "taskDurationMs": 845.1469999999999,
      "heapDeltaBytes": 53296,
      "heapUsedBytes": 65464660,
      "domNodes": 56,
      "jsHeapTotalBytes": 25169920,
      "scriptDurationMs": 103.479,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.608000000023,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.523,
      "layouts": 6,
      "layoutDurationMs": 0.659,
      "taskDurationMs": 383.25399999999996,
      "heapDeltaBytes": 7646636,
      "heapUsedBytes": 73073656,
      "domNodes": 77,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 11.006000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.0349999999717,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.061,
      "layouts": 6,
      "layoutDurationMs": 0.696,
      "taskDurationMs": 389.511,
      "heapDeltaBytes": 7975368,
      "heapUsedBytes": 73374596,
      "domNodes": 76,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 11.565000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 637.1890000000064,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 11.324999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.629,
      "heapDeltaBytes": -11815560,
      "heapUsedBytes": 53613056,
      "domNodes": 20,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 60.115,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 572.339999999997,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.451000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.989,
      "heapDeltaBytes": -11726612,
      "heapUsedBytes": 53654436,
      "domNodes": 18,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 53.407,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2035.8150000000137,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.273999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 674.293,
      "heapDeltaBytes": 12553772,
      "heapUsedBytes": 72580812,
      "domNodes": -284,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 18.422,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.761000000046,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.367999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 646.9150000000001,
      "heapDeltaBytes": 12981216,
      "heapUsedBytes": 73115888,
      "domNodes": -280,
      "jsHeapTotalBytes": 3506176,
      "scriptDurationMs": 16.34,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2144.7860000000105,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.412000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1196.983,
      "heapDeltaBytes": 10375560,
      "heapUsedBytes": 71303376,
      "domNodes": -283,
      "jsHeapTotalBytes": 3698688,
      "scriptDurationMs": 308.35200000000003,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2307.4719999999616,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 16.666999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1309.7880000000002,
      "heapDeltaBytes": 8037628,
      "heapUsedBytes": 68963880,
      "domNodes": -282,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 343.54699999999997,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3166.0479999999893,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.862999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.998,
      "taskDurationMs": 1366.3529999999998,
      "heapDeltaBytes": 16756932,
      "heapUsedBytes": 79309144,
      "domNodes": 10,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 392.581,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3130.543999999986,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.46,
      "layouts": 60,
      "layoutDurationMs": 8.579,
      "taskDurationMs": 1373.317,
      "heapDeltaBytes": 17281636,
      "heapUsedBytes": 79219452,
      "domNodes": 10,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 391.298,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.5209999999838,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.535999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.4639999999999,
      "heapDeltaBytes": 13152952,
      "heapUsedBytes": 74165144,
      "domNodes": -287,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 14.269,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.6950000000752,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.079999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 644.749,
      "heapDeltaBytes": 9024176,
      "heapUsedBytes": 70047696,
      "domNodes": -284,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 17.033,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.6080000000038,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.510999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.478,
      "heapDeltaBytes": -11306572,
      "heapUsedBytes": 54133496,
      "domNodes": 22,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 125.26399999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 601.0350000000244,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.85,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.34499999999997,
      "heapDeltaBytes": -11069672,
      "heapUsedBytes": 54347744,
      "domNodes": 20,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 120.98500000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.7270000000033,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.038,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.423,
      "heapDeltaBytes": 5029764,
      "heapUsedBytes": 70504748,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 6.765000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.7229999999558,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.008000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.795,
      "heapDeltaBytes": 5187428,
      "heapUsedBytes": 70738092,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 7.824000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1712.82599999995,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.93299999999999,
      "layouts": 16,
      "layoutDurationMs": 11.769,
      "taskDurationMs": 802.6260000000001,
      "heapDeltaBytes": -3875528,
      "heapUsedBytes": 61524868,
      "domNodes": 63,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 89.05,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.311999999978,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.769,
      "layouts": 16,
      "layoutDurationMs": 4.508000000000001,
      "taskDurationMs": 746.258,
      "heapDeltaBytes": -3564000,
      "heapUsedBytes": 61810828,
      "domNodes": 62,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 85.58500000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1368.584999999996,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 29.29100000000001,
      "layouts": 15,
      "layoutDurationMs": 11.435,
      "taskDurationMs": 983.368,
      "heapDeltaBytes": -6146932,
      "heapUsedBytes": 79784608,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 16.938000000000002,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 118,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8191.601999999989,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.459999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4119.367,
      "heapDeltaBytes": 17295100,
      "heapUsedBytes": 77751232,
      "domNodes": -281,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 990.946,
      "eventListeners": -165,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8279.415999999968,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 43.418,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4282.49,
      "heapDeltaBytes": 13105080,
      "heapUsedBytes": 73584184,
      "domNodes": -283,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 997.4660000000001,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18177.37899999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17308.275,
      "heapDeltaBytes": -27622536,
      "heapUsedBytes": 170344548,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14880768,
      "scriptDurationMs": 134.199,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18411.666999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17524.827,
      "heapDeltaBytes": -40077716,
      "heapUsedBytes": 170970656,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8589312,
      "scriptDurationMs": 133.12800000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21926.878999999986,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 21.21200000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21236.191000000003,
      "heapDeltaBytes": -12244252,
      "heapUsedBytes": 185415444,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13115392,
      "scriptDurationMs": 424.989,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 82,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22027.067999999985,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 21.479000000000028,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21364.985999999997,
      "heapDeltaBytes": -21037716,
      "heapUsedBytes": 176476456,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11018240,
      "scriptDurationMs": 416.635,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 188,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.32100000004084,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 20.781000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.879,
      "taskDurationMs": 116.88300000000001,
      "heapDeltaBytes": 5215300,
      "heapUsedBytes": 69582928,
      "domNodes": 152,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.110999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 514.9209999999584,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 18.49,
      "layouts": 3,
      "layoutDurationMs": 0.637,
      "taskDurationMs": 113.084,
      "heapDeltaBytes": 4926520,
      "heapUsedBytes": 69419760,
      "domNodes": 119,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 7.353999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🎭 Playwright: ✅ 1822 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1801 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

@github-actions

Copy link
Copy Markdown
Contributor

🎭 Playwright: ⏳ Running...

@codecov

codecov Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #14314      +/-   ##
==========================================
+ Coverage   78.95%   81.47%   +2.52%     
==========================================
  Files        2209     1882     -327     
  Lines      112281   109561    -2720     
  Branches    32992    31454    -1538     
==========================================
+ Hits        88647    89270     +623     
+ Misses      23178    19907    -3271     
+ Partials      456      384      -72     
Flag Coverage Δ
unit 72.89% <ø> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 399 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne marked this pull request as ready for review August 4, 2026 02:45
@christian-byrne
christian-byrne requested a review from a team August 4, 2026 02:45
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 4, 2026
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@christian-byrne

Copy link
Copy Markdown
Contributor

What this pins: the picker writes an asset filename into a widget where the node expects a folder-style model identifier, so execution fails validation. Real fix: BE-975 — note FE#14489 (de-registering QwenVL from MODEL_NODE_MAPPINGS) may already fix the reported instance as a side effect, so re-verification comes before implementation there.

Why it.fails and not a fix. This PR changes no production code. It pins a known bug as an executable test so it stops living in a ticket description, and so CI goes red if someone fixes it by accident. The real fix is tracked separately (below).

Merge order. #14311, #14313 and #14314 all insert into assetService.test.ts, and #14311 and #14313 conflict when stacked — whichever lands second needs a trivial rebase. #14312 is independent. Suggested order: 14312 → 14311 → 14313 → 14314. (#14315 merged 2026-08-12.)

On the green checks. Worth knowing before you trust them: on 2026-08-11 all five of these were 262 commits behind main, so their passing CI proved nothing about current main. They were rebased onto ae2783911d and re-verified then — each contributes exactly one expected fail, with pnpm typecheck, eslint and oxfmt --check clean. They have since drifted ~40 commits behind again.

Note for anyone running these locally: use pnpm test:unit, not npx vitest — running vitest directly bypasses vite.config.mts and therefore the happy-dom environment, which produces ~65 spurious failures.

@claude
claude Bot force-pushed the test/qwenvl-widget-value-folder-vs-filename branch from b4e5e44 to 80c398a Compare August 14, 2026 00:04
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 14, 2026
AustinMroz
AustinMroz previously approved these changes Aug 17, 2026

@AustinMroz AustinMroz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the model has been sharded into several files, then I would expect the 'asset' to be the folder containing the file shards. Otherwise we'll deal with awful edge cases like each shard of a model being a different independently selectable asset. Correspondingly, I suspect the asset response including the individual shards in the asset list is part of the bug.

I would want to see the test changed when an actual fix is implemented, and I have slight concern that the existence of this test will result in the eventual fix to instead address this mistated problem.

But any amount of documentation for the problem is better than it being silently forgotten about, so it gets my approval.

Documents that the it.fails test only covers renaming a single mocked
shard's name to a folder-style identifier. It does not assert that
multiple shards sharing a model_type: tag collapse into one ModelFile
entry, so a per-shard rename fix could pass this test while leaving
the real bug (undeduplicated shard list) intact.
@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@AustinMroz Your read is correct — confirmed it by checking what the current test actually asserts. It mocks a single shard and only checks that its name gets renamed to a folder-style identifier. It never asserts that multiple shards sharing one model_type: tag collapse into a single asset-list entry. So a fix that just renames each shard independently (leaving each shard as its own separately-selectable asset) would make this test pass while leaving the real bug — the shard list not being deduplicated into one folder-level asset — intact.

Added a short comment above the it.fails test (846f3ed) scoping this out, so a future implementer knows shard-list deduplication into one folder-level asset is part of "done" here, not just cosmetic renaming, and that the test should be extended to cover multi-shard dedup when the real fix lands.


Generated by Claude Code

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: this test pins a QwenVL path removed by #14489.

Full context for agent readers

Current main deliberately leaves LLM/Qwen-VL/* out of MODEL_NODE_MAPPINGS because those widgets take repository IDs and now use /api/object_info. assetService still returns loader paths or filenames for mapped consumers. The inline finding identifies the required change.

Exact-head R2 review: 846f3ed4de6267d23ffe4d6588fb3ca8032a341c.

// this test while leaving the real bug (shard list not deduped into one
// folder-level asset) intact. Extend this test to cover multi-shard
// dedup before treating a fix as complete.
it.fails("produces a folder-style model identifier for multi-file QwenVL repos, not a raw asset filename (so the node's own combo validation accepts it)", async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This expected-failure test now encodes a superseded contract. #14489 deliberately removed LLM/Qwen-VL/* from MODEL_NODE_MAPPINGS because these widgets accept repository IDs and now fall back to /api/object_info; assetService still returns loader paths or filenames for mapped consumers. Please remove this case or retarget it to a still-reachable picker path with a decided desired behavior. As written, a valid service refactor could make it.fails pass and turn CI red for behavior the product no longer uses.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and confirmed on main: LLM/Qwen-VL/* is intentionally excluded from MODEL_NODE_MAPPINGS (see the comment block at the top of modelNodeMappings.ts), so AILab_QwenVL.model_name no longer receives a value from assetService — it falls back to /api/object_info per #14489.

I checked the rest of MODEL_NODE_MAPPINGS for a still-mapped node/widget with the same folder-vs-filename shape to retarget onto instead (the wrapper-style "DownloadAndLoad*" entries — SAM2, DepthAnythingV3, MimicMotion, SeedVR2, CogVideo, LivePortrait, etc. — were the plausible candidates, since those custom nodes often address HF-repo-style multi-file models). None of them have a decided contract to assert against: the underlying question this test was pinning — mint a folder-level value for a multi-file asset group vs. exclude the mapping entirely — is still undecided repo-wide, not something #14489 or anything since has settled for any specific node. Retargeting onto one of those would just be swapping in an unproven, speculative scenario for the invalidated one.

So I removed the it.fails case rather than retargeting it, per the fallback you offered. Commit: 80312b3. Kept the multi-shard-dedup scope comment's underlying concern in mind, but since the case it was scoping no longer exists, it went with it. PR description updated to reflect this.


Generated by Claude Code

@christian-byrne christian-byrne removed their assignment Aug 25, 2026
LLM/Qwen-VL/* was deliberately removed from MODEL_NODE_MAPPINGS by
#14489, so AILab_QwenVL no longer receives a value from the asset
picker and falls back to /api/object_info. The it.fails case pinned a
contract for a path that is no longer reachable, so a valid refactor
of assetService could flip it green for behavior nothing exercises
anymore. No other MODEL_NODE_MAPPINGS entry has a decided contract for
representing a multi-file, folder-addressed model as one widget value,
so there is no reachable node to retarget onto; removing the case is
the reviewer-authorized fallback.
@claude
claude Bot requested a review from christian-byrne August 25, 2026 11:34
@github-actions github-actions Bot added risk:R1 PR risk grade (advisory shadow check; grader-owned) and removed risk:R2 PR risk grade (advisory shadow check; grader-owned) labels Aug 25, 2026
claude Bot pushed a commit that referenced this pull request Aug 25, 2026
#14529 (already an ancestor of this branch) removed all three
segformer_* rows from MODEL_NODE_MAPPINGS, along with onnx and clip,
because those widgets accept ids rather than asset filenames and fall
back to /api/object_info. The only remaining LS_LoadSegformerModel
category registration lived in this test's own mock, so the it.fails
case exercised a picker path that no longer exists in production.

Checked the rest of MODEL_NODE_MAPPINGS for a still-reachable node
registered against multiple directories under one non-empty input
key: none exists. UltralyticsDetectorProvider's rows remain disabled,
and FlashVSRNode's two directories sit behind an empty key, so it
never exposes a widget picker. Removing rather than retargeting,
matching how #14312 and #14314 resolved the same staleness elsewhere
in this test series.
@huang47 huang47 added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 20, 2026
…nd bucket key (Comfy-Org#14313)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785357549411849?thread_ts=1785296212.634389&cid=C0A4XMHANP3)_

This adds a failing test documenting that the node-widget dropdown's
category identifier, a full directory path like
LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct, and the model-library sidebar's
bucket key, the top-level folder only such as LLM, are incompatible, so
querying the bucket-based model list with the widget's own category
string returns nothing.

This mismatch is a known blocker to migrating the node-dropdown query
onto the newer bucket-based asset listing, since the two systems need to
agree on category identifier shape first. This test exists so the
mismatch has permanent, executable documentation rather than living only
in investigation notes.

Root cause: getCategoryForNodeType, the forward/widget path, returns
full hierarchical paths, while modelFolderFromTag, the bucket path,
collapses bare tags to only their first path segment, two different
identifier spaces for what's conceptually the same category.

Path to a real fix: normalizing all tag-as-identifier usages onto one
consistent scheme, follow-up work that hasn't been scheduled yet, would
resolve this. Once that lands, convert this test from it.fails to a real
assertion.

How to verify: pnpm test:unit
src/platform/assets/services/assetService.test.ts


---
_Generated by [Claude
Code](https://claude.ai/code/session_01P6mHd4AJXxneJFqt8y3ozA)_

---

### Status note — 2026-08-03

Re-verified against `main` on this date.

`AILab_QwenVL` and eight other model-id-based node families were
**de-registered from `MODEL_NODE_MAPPINGS` by Comfy-Org#14489** (merged
2026-08-01, backported to `cloud/1.48` via Comfy-Org#14527). That fixed the
*reported symptom* in BE-5071 — those widgets now fall back to the
node's own `/api/object_info` combo.

**The bug class documented here is not fixed.** The asset browser still
resolves a node type to exactly one category. As of 2026-08-03 it
remains live on `main` for five node/input pairs:

| Node | Input | Directories (only the first is reachable) |
|---|---|---|
| `LS_LoadSegformerModel` | `model_name` | `segformer_b2_clothes`,
`segformer_b3_clothes`, `segformer_b3_fashion` |
| `UpscaleModelLoader` | `model_name` | `upscale_models`, `onnx` |
| `CLIPVisionLoader` | `clip_name` | `clip_vision`, `clip` |
| `FlashVSRNode` | *(auto)* | `FlashVSR`, `FlashVSR-v1.1` |
| `UltralyticsDetectorProvider` | `model_name` | `ultralytics/bbox`,
`ultralytics/segm` |

Tracked by FE-1177 (query `model_type:` rather than a single directory),
FE-1181 (generate the mapping from `object_info`), FE-1080
(child-directory tags) and BE-5255 (backend subtype-carrying tag).

**Why this is a merged test rather than a Slack thread:** `it.fails`
inverts the report — the assertion genuinely fails (proving the bug is
real) but CI stays green. It turns **red only when someone fixes the bug
without updating the test**, which is exactly the alarm we want. As an
unmerged draft it provides none of that, which is why these are being
taken out of draft.

### Status note — 2026-08-25

Per
[review](Comfy-Org#14313 (review)),
`AILab_QwenVL` / `LLM/Qwen-VL/*` was an invalid target: Comfy-Org#14489 (merged
2026-08-01, confirmed an ancestor of this PR's exact head via `git
merge-base --is-ancestor`) intentionally de-registered it from
`MODEL_NODE_MAPPINGS` because that widget accepts a model or repository
ID and now falls back to `/api/object_info`, so the mock's
`LLM/Qwen-VL/*` category never reaches a live product path.

Unlike the sibling PRs in this series, this PR's bug shape (a full
hierarchical category path vs. a bucket key truncated to its first path
segment) has a still-reachable production analog, so the case was
**retargeted, not removed**. Checked current `MODEL_NODE_MAPPINGS` for a
live entry that is (a) a multi-segment directory path and (b) registered
with a non-empty input key, since an empty key means the node auto-loads
without a widget and can't expose the bug. The `chatterbox/*` and
`CogVideo/ControlNet` entries are also multi-segment but all use an
empty key, so they're not eligible either. `['LLM/checkpoints',
'LoadChatGLM3', 'chatglm3_checkpoint']` is: it's live on `main`, uses
the real `chatglm3_checkpoint` widget key, and `getAssetCategories`'s
bare-tag mode (`asset.tags.map(tag => tag.split('/')[0])`) collapses an
`LLM/checkpoints`-tagged asset to bucket key `LLM`, while
`getCategoryForNodeType('LoadChatGLM3')` still returns the full
`LLM/checkpoints` string — the exact same key-space mismatch the test
documents, on a mapping nothing has removed.

Also independently re-checked the 2026-08-03 five-pair table per the
review's flag: `Comfy-Org#14529` (also confirmed an ancestor of this head)
removed the `segformer_*`, `onnx`, and `clip` mappings entirely;
`UltralyticsDetectorProvider`'s two rows remain commented out/disabled;
and `FlashVSRNode` registers two directories under an empty input key,
so it never exposes a widget picker. None of the five pairs still
exhibit a live, widget-reachable symptom — consistent with the same
conclusion reached independently on Comfy-Org#14311, Comfy-Org#14312, and Comfy-Org#14314 today,
though that table was never this test's own case and doesn't otherwise
affect this PR's fix.

Mock and assertion in
`src/platform/assets/services/assetService.test.ts` now use
`LoadChatGLM3` / `chatglm3_checkpoint` / `LLM/checkpoints` in place of
`AILab_QwenVL` / `model_name` / `LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct`.
`pnpm test:unit src/platform/assets/services/assetService.test.ts`
passes (65 passed, 1 expected fail).

How to verify: `pnpm test:unit
src/platform/assets/services/assetService.test.ts`

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
christian-byrne pushed a commit that referenced this pull request Oct 10, 2026
#14529 (already an ancestor of this branch) removed all three
segformer_* rows from MODEL_NODE_MAPPINGS, along with onnx and clip,
because those widgets accept ids rather than asset filenames and fall
back to /api/object_info. The only remaining LS_LoadSegformerModel
category registration lived in this test's own mock, so the it.fails
case exercised a picker path that no longer exists in production.

Checked the rest of MODEL_NODE_MAPPINGS for a still-reachable node
registered against multiple directories under one non-empty input
key: none exists. UltralyticsDetectorProvider's rows remain disabled,
and FlashVSRNode's two directories sit behind an empty key, so it
never exposes a widget picker. Removing rather than retargeting,
matching how #14312 and #14314 resolved the same staleness elsewhere
in this test series.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants