Repository navigation
test: document QwenVL asset picker writing filenames where the node expects folder names - #14314
claude[bot] wants to merge 4 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.85 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category Status: 285 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-17T21:37:33.651Z",
"gitSha": "88ac6af08f27cb04680ed9f1a4542f3a08addaa6",
"branch": "test/qwenvl-widget-value-folder-vs-filename",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.7439999999838,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.6240000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.877,
"heapDeltaBytes": 5058108,
"heapUsedBytes": 70446660,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 7.1469999999999985,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2043.3170000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.357000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.162,
"heapDeltaBytes": 5210956,
"heapUsedBytes": 70490756,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.547999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1935.543000000024,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.707,
"layouts": 12,
"layoutDurationMs": 3.5620000000000003,
"taskDurationMs": 999.8530000000001,
"heapDeltaBytes": -16868908,
"heapUsedBytes": 48403108,
"domNodes": -284,
"jsHeapTotalBytes": 23171072,
"scriptDurationMs": 110.199,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.0889999999686,
"styleRecalcs": 73,
"styleRecalcDurationMs": 34.79,
"layouts": 12,
"layoutDurationMs": 3.535,
"taskDurationMs": 845.1469999999999,
"heapDeltaBytes": 53296,
"heapUsedBytes": 65464660,
"domNodes": 56,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 103.479,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.608000000023,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.523,
"layouts": 6,
"layoutDurationMs": 0.659,
"taskDurationMs": 383.25399999999996,
"heapDeltaBytes": 7646636,
"heapUsedBytes": 73073656,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 11.006000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.0349999999717,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.061,
"layouts": 6,
"layoutDurationMs": 0.696,
"taskDurationMs": 389.511,
"heapDeltaBytes": 7975368,
"heapUsedBytes": 73374596,
"domNodes": 76,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 11.565000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 637.1890000000064,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.324999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.629,
"heapDeltaBytes": -11815560,
"heapUsedBytes": 53613056,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 60.115,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 572.339999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.451000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.989,
"heapDeltaBytes": -11726612,
"heapUsedBytes": 53654436,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 53.407,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2035.8150000000137,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.273999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.293,
"heapDeltaBytes": 12553772,
"heapUsedBytes": 72580812,
"domNodes": -284,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 18.422,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.761000000046,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.367999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.9150000000001,
"heapDeltaBytes": 12981216,
"heapUsedBytes": 73115888,
"domNodes": -280,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 16.34,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2144.7860000000105,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.412000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1196.983,
"heapDeltaBytes": 10375560,
"heapUsedBytes": 71303376,
"domNodes": -283,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 308.35200000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2307.4719999999616,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.666999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.7880000000002,
"heapDeltaBytes": 8037628,
"heapUsedBytes": 68963880,
"domNodes": -282,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 343.54699999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3166.0479999999893,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.862999999999998,
"layouts": 60,
"layoutDurationMs": 7.998,
"taskDurationMs": 1366.3529999999998,
"heapDeltaBytes": 16756932,
"heapUsedBytes": 79309144,
"domNodes": 10,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 392.581,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3130.543999999986,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.46,
"layouts": 60,
"layoutDurationMs": 8.579,
"taskDurationMs": 1373.317,
"heapDeltaBytes": 17281636,
"heapUsedBytes": 79219452,
"domNodes": 10,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 391.298,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.5209999999838,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.535999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.4639999999999,
"heapDeltaBytes": 13152952,
"heapUsedBytes": 74165144,
"domNodes": -287,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 14.269,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.6950000000752,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.079999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.749,
"heapDeltaBytes": 9024176,
"heapUsedBytes": 70047696,
"domNodes": -284,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 17.033,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.6080000000038,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.510999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.478,
"heapDeltaBytes": -11306572,
"heapUsedBytes": 54133496,
"domNodes": 22,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 125.26399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.0350000000244,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.34499999999997,
"heapDeltaBytes": -11069672,
"heapUsedBytes": 54347744,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 120.98500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.7270000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.423,
"heapDeltaBytes": 5029764,
"heapUsedBytes": 70504748,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.765000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.7229999999558,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.008000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.795,
"heapDeltaBytes": 5187428,
"heapUsedBytes": 70738092,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 7.824000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.82599999995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.93299999999999,
"layouts": 16,
"layoutDurationMs": 11.769,
"taskDurationMs": 802.6260000000001,
"heapDeltaBytes": -3875528,
"heapUsedBytes": 61524868,
"domNodes": 63,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 89.05,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.311999999978,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.769,
"layouts": 16,
"layoutDurationMs": 4.508000000000001,
"taskDurationMs": 746.258,
"heapDeltaBytes": -3564000,
"heapUsedBytes": 61810828,
"domNodes": 62,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 85.58500000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.584999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 29.29100000000001,
"layouts": 15,
"layoutDurationMs": 11.435,
"taskDurationMs": 983.368,
"heapDeltaBytes": -6146932,
"heapUsedBytes": 79784608,
"domNodes": 13673,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 16.938000000000002,
"eventListeners": 2375,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8191.601999999989,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.459999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4119.367,
"heapDeltaBytes": 17295100,
"heapUsedBytes": 77751232,
"domNodes": -281,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 990.946,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8279.415999999968,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.418,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4282.49,
"heapDeltaBytes": 13105080,
"heapUsedBytes": 73584184,
"domNodes": -283,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 997.4660000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18177.37899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17308.275,
"heapDeltaBytes": -27622536,
"heapUsedBytes": 170344548,
"domNodes": -8312,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 134.199,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18411.666999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17524.827,
"heapDeltaBytes": -40077716,
"heapUsedBytes": 170970656,
"domNodes": -8312,
"jsHeapTotalBytes": -8589312,
"scriptDurationMs": 133.12800000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21926.878999999986,
"styleRecalcs": 171,
"styleRecalcDurationMs": 21.21200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21236.191000000003,
"heapDeltaBytes": -12244252,
"heapUsedBytes": 185415444,
"domNodes": -8312,
"jsHeapTotalBytes": -13115392,
"scriptDurationMs": 424.989,
"eventListeners": -16379,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22027.067999999985,
"styleRecalcs": 167,
"styleRecalcDurationMs": 21.479000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21364.985999999997,
"heapDeltaBytes": -21037716,
"heapUsedBytes": 176476456,
"domNodes": -8312,
"jsHeapTotalBytes": -11018240,
"scriptDurationMs": 416.635,
"eventListeners": -16383,
"totalBlockingTimeMs": 188,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 464.32100000004084,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.781000000000002,
"layouts": 2,
"layoutDurationMs": 0.879,
"taskDurationMs": 116.88300000000001,
"heapDeltaBytes": 5215300,
"heapUsedBytes": 69582928,
"domNodes": 152,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.110999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 514.9209999999584,
"styleRecalcs": 11,
"styleRecalcDurationMs": 18.49,
"layouts": 3,
"layoutDurationMs": 0.637,
"taskDurationMs": 113.084,
"heapDeltaBytes": 4926520,
"heapUsedBytes": 69419760,
"domNodes": 119,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7.353999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 1822 passed, 0 failed · 2 flaky📊 Browser Reports
|
🎭 Playwright: ⏳ Running... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14314 +/- ##
==========================================
+ Coverage 78.95% 81.47% +2.52%
==========================================
Files 2209 1882 -327
Lines 112281 109561 -2720
Branches 32992 31454 -1538
==========================================
+ Hits 88647 89270 +623
+ Misses 23178 19907 -3271
+ Partials 456 384 -72
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
54e0c96 to
b4e5e44
Compare
|
What this pins: the picker writes an asset filename into a widget where the node expects a folder-style model identifier, so execution fails validation. Real fix: BE-975 — note FE#14489 (de-registering QwenVL from Why Merge order. #14311, #14313 and #14314 all insert into On the green checks. Worth knowing before you trust them: on 2026-08-11 all five of these were 262 commits behind main, so their passing CI proved nothing about current main. They were rebased onto Note for anyone running these locally: use |
…xpects folder names
b4e5e44 to
80c398a
Compare
AustinMroz
left a comment
There was a problem hiding this comment.
If the model has been sharded into several files, then I would expect the 'asset' to be the folder containing the file shards. Otherwise we'll deal with awful edge cases like each shard of a model being a different independently selectable asset. Correspondingly, I suspect the asset response including the individual shards in the asset list is part of the bug.
I would want to see the test changed when an actual fix is implemented, and I have slight concern that the existence of this test will result in the eventual fix to instead address this mistated problem.
But any amount of documentation for the problem is better than it being silently forgotten about, so it gets my approval.
Documents that the it.fails test only covers renaming a single mocked shard's name to a folder-style identifier. It does not assert that multiple shards sharing a model_type: tag collapse into one ModelFile entry, so a per-shard rename fix could pass this test while leaving the real bug (undeduplicated shard list) intact.
|
@AustinMroz Your read is correct — confirmed it by checking what the current test actually asserts. It mocks a single shard and only checks that its Added a short comment above the Generated by Claude Code |
christian-byrne
left a comment
There was a problem hiding this comment.
Request changes: this test pins a QwenVL path removed by #14489.
Full context for agent readers
Current main deliberately leaves LLM/Qwen-VL/* out of MODEL_NODE_MAPPINGS because those widgets take repository IDs and now use /api/object_info. assetService still returns loader paths or filenames for mapped consumers. The inline finding identifies the required change.
Exact-head R2 review: 846f3ed4de6267d23ffe4d6588fb3ca8032a341c.
| // this test while leaving the real bug (shard list not deduped into one | ||
| // folder-level asset) intact. Extend this test to cover multi-shard | ||
| // dedup before treating a fix as complete. | ||
| it.fails("produces a folder-style model identifier for multi-file QwenVL repos, not a raw asset filename (so the node's own combo validation accepts it)", async () => { |
There was a problem hiding this comment.
issue: This expected-failure test now encodes a superseded contract. #14489 deliberately removed LLM/Qwen-VL/* from MODEL_NODE_MAPPINGS because these widgets accept repository IDs and now fall back to /api/object_info; assetService still returns loader paths or filenames for mapped consumers. Please remove this case or retarget it to a still-reachable picker path with a decided desired behavior. As written, a valid service refactor could make it.fails pass and turn CI red for behavior the product no longer uses.
There was a problem hiding this comment.
Agreed, and confirmed on main: LLM/Qwen-VL/* is intentionally excluded from MODEL_NODE_MAPPINGS (see the comment block at the top of modelNodeMappings.ts), so AILab_QwenVL.model_name no longer receives a value from assetService — it falls back to /api/object_info per #14489.
I checked the rest of MODEL_NODE_MAPPINGS for a still-mapped node/widget with the same folder-vs-filename shape to retarget onto instead (the wrapper-style "DownloadAndLoad*" entries — SAM2, DepthAnythingV3, MimicMotion, SeedVR2, CogVideo, LivePortrait, etc. — were the plausible candidates, since those custom nodes often address HF-repo-style multi-file models). None of them have a decided contract to assert against: the underlying question this test was pinning — mint a folder-level value for a multi-file asset group vs. exclude the mapping entirely — is still undecided repo-wide, not something #14489 or anything since has settled for any specific node. Retargeting onto one of those would just be swapping in an unproven, speculative scenario for the invalidated one.
So I removed the it.fails case rather than retargeting it, per the fallback you offered. Commit: 80312b3. Kept the multi-shard-dedup scope comment's underlying concern in mind, but since the case it was scoping no longer exists, it went with it. PR description updated to reflect this.
Generated by Claude Code
LLM/Qwen-VL/* was deliberately removed from MODEL_NODE_MAPPINGS by #14489, so AILab_QwenVL no longer receives a value from the asset picker and falls back to /api/object_info. The it.fails case pinned a contract for a path that is no longer reachable, so a valid refactor of assetService could flip it green for behavior nothing exercises anymore. No other MODEL_NODE_MAPPINGS entry has a decided contract for representing a multi-file, folder-addressed model as one widget value, so there is no reachable node to retarget onto; removing the case is the reviewer-authorized fallback.
#14529 (already an ancestor of this branch) removed all three segformer_* rows from MODEL_NODE_MAPPINGS, along with onnx and clip, because those widgets accept ids rather than asset filenames and fall back to /api/object_info. The only remaining LS_LoadSegformerModel category registration lived in this test's own mock, so the it.fails case exercised a picker path that no longer exists in production. Checked the rest of MODEL_NODE_MAPPINGS for a still-reachable node registered against multiple directories under one non-empty input key: none exists. UltralyticsDetectorProvider's rows remain disabled, and FlashVSRNode's two directories sit behind an empty key, so it never exposes a widget picker. Removing rather than retargeting, matching how #14312 and #14314 resolved the same staleness elsewhere in this test series.
…nd bucket key (Comfy-Org#14313) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785357549411849?thread_ts=1785296212.634389&cid=C0A4XMHANP3)_ This adds a failing test documenting that the node-widget dropdown's category identifier, a full directory path like LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct, and the model-library sidebar's bucket key, the top-level folder only such as LLM, are incompatible, so querying the bucket-based model list with the widget's own category string returns nothing. This mismatch is a known blocker to migrating the node-dropdown query onto the newer bucket-based asset listing, since the two systems need to agree on category identifier shape first. This test exists so the mismatch has permanent, executable documentation rather than living only in investigation notes. Root cause: getCategoryForNodeType, the forward/widget path, returns full hierarchical paths, while modelFolderFromTag, the bucket path, collapses bare tags to only their first path segment, two different identifier spaces for what's conceptually the same category. Path to a real fix: normalizing all tag-as-identifier usages onto one consistent scheme, follow-up work that hasn't been scheduled yet, would resolve this. Once that lands, convert this test from it.fails to a real assertion. How to verify: pnpm test:unit src/platform/assets/services/assetService.test.ts --- _Generated by [Claude Code](https://claude.ai/code/session_01P6mHd4AJXxneJFqt8y3ozA)_ --- ### Status note — 2026-08-03 Re-verified against `main` on this date. `AILab_QwenVL` and eight other model-id-based node families were **de-registered from `MODEL_NODE_MAPPINGS` by Comfy-Org#14489** (merged 2026-08-01, backported to `cloud/1.48` via Comfy-Org#14527). That fixed the *reported symptom* in BE-5071 — those widgets now fall back to the node's own `/api/object_info` combo. **The bug class documented here is not fixed.** The asset browser still resolves a node type to exactly one category. As of 2026-08-03 it remains live on `main` for five node/input pairs: | Node | Input | Directories (only the first is reachable) | |---|---|---| | `LS_LoadSegformerModel` | `model_name` | `segformer_b2_clothes`, `segformer_b3_clothes`, `segformer_b3_fashion` | | `UpscaleModelLoader` | `model_name` | `upscale_models`, `onnx` | | `CLIPVisionLoader` | `clip_name` | `clip_vision`, `clip` | | `FlashVSRNode` | *(auto)* | `FlashVSR`, `FlashVSR-v1.1` | | `UltralyticsDetectorProvider` | `model_name` | `ultralytics/bbox`, `ultralytics/segm` | Tracked by FE-1177 (query `model_type:` rather than a single directory), FE-1181 (generate the mapping from `object_info`), FE-1080 (child-directory tags) and BE-5255 (backend subtype-carrying tag). **Why this is a merged test rather than a Slack thread:** `it.fails` inverts the report — the assertion genuinely fails (proving the bug is real) but CI stays green. It turns **red only when someone fixes the bug without updating the test**, which is exactly the alarm we want. As an unmerged draft it provides none of that, which is why these are being taken out of draft. ### Status note — 2026-08-25 Per [review](Comfy-Org#14313 (review)), `AILab_QwenVL` / `LLM/Qwen-VL/*` was an invalid target: Comfy-Org#14489 (merged 2026-08-01, confirmed an ancestor of this PR's exact head via `git merge-base --is-ancestor`) intentionally de-registered it from `MODEL_NODE_MAPPINGS` because that widget accepts a model or repository ID and now falls back to `/api/object_info`, so the mock's `LLM/Qwen-VL/*` category never reaches a live product path. Unlike the sibling PRs in this series, this PR's bug shape (a full hierarchical category path vs. a bucket key truncated to its first path segment) has a still-reachable production analog, so the case was **retargeted, not removed**. Checked current `MODEL_NODE_MAPPINGS` for a live entry that is (a) a multi-segment directory path and (b) registered with a non-empty input key, since an empty key means the node auto-loads without a widget and can't expose the bug. The `chatterbox/*` and `CogVideo/ControlNet` entries are also multi-segment but all use an empty key, so they're not eligible either. `['LLM/checkpoints', 'LoadChatGLM3', 'chatglm3_checkpoint']` is: it's live on `main`, uses the real `chatglm3_checkpoint` widget key, and `getAssetCategories`'s bare-tag mode (`asset.tags.map(tag => tag.split('/')[0])`) collapses an `LLM/checkpoints`-tagged asset to bucket key `LLM`, while `getCategoryForNodeType('LoadChatGLM3')` still returns the full `LLM/checkpoints` string — the exact same key-space mismatch the test documents, on a mapping nothing has removed. Also independently re-checked the 2026-08-03 five-pair table per the review's flag: `Comfy-Org#14529` (also confirmed an ancestor of this head) removed the `segformer_*`, `onnx`, and `clip` mappings entirely; `UltralyticsDetectorProvider`'s two rows remain commented out/disabled; and `FlashVSRNode` registers two directories under an empty input key, so it never exposes a widget picker. None of the five pairs still exhibit a live, widget-reachable symptom — consistent with the same conclusion reached independently on Comfy-Org#14311, Comfy-Org#14312, and Comfy-Org#14314 today, though that table was never this test's own case and doesn't otherwise affect this PR's fix. Mock and assertion in `src/platform/assets/services/assetService.test.ts` now use `LoadChatGLM3` / `chatglm3_checkpoint` / `LLM/checkpoints` in place of `AILab_QwenVL` / `model_name` / `LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct`. `pnpm test:unit src/platform/assets/services/assetService.test.ts` passes (65 passed, 1 expected fail). How to verify: `pnpm test:unit src/platform/assets/services/assetService.test.ts` --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
#14529 (already an ancestor of this branch) removed all three segformer_* rows from MODEL_NODE_MAPPINGS, along with onnx and clip, because those widgets accept ids rather than asset filenames and fall back to /api/object_info. The only remaining LS_LoadSegformerModel category registration lived in this test's own mock, so the it.fails case exercised a picker path that no longer exists in production. Checked the rest of MODEL_NODE_MAPPINGS for a still-reachable node registered against multiple directories under one non-empty input key: none exists. UltralyticsDetectorProvider's rows remain disabled, and FlashVSRNode's two directories sit behind an empty key, so it never exposes a widget picker. Removing rather than retargeting, matching how #14312 and #14314 resolved the same staleness elsewhere in this test series.
Requested by Christian Byrne · Slack thread
This originally added a failing test documenting that the asset browser writes a per-file filename, such as model-00001-of-00004.safetensors, into AILab_QwenVL.model_name, when the node actually requires a folder-style repo identifier such as Qwen3-VL-8B-Instruct.
Update (2026-08-25): #14489 deliberately removed
LLM/Qwen-VL/*fromMODEL_NODE_MAPPINGS— those widgets accept repository IDs and now fall back to/api/object_info, soAILab_QwenVL.model_nameno longer receives a value fromassetServiceat all. The scenario this test pinned is no longer reachable through any real consumer. Checked the rest ofMODEL_NODE_MAPPINGSfor a still-mapped node with the same folder-vs-filename shape to retarget onto instead: nothing qualifies, since no entry has a decided contract for representing a multi-file, folder-addressed model as a single widget value (the "mint a folder-level value" vs. "exclude the mapping" choice this test called out is still undecided repo-wide, not specific to QwenVL). Per Christian Byrne's review, theit.failscase has been removed rather than pinned to an invalidated or speculative scenario. This supersedes the "Status note" below where the two describe this PR's own case — that note's "not fixed" verdict is about a different bug (see the clarification inline).How to verify: pnpm test:unit src/platform/assets/services/assetService.test.ts
Generated by Claude Code
Status note — 2026-08-03
This note is shared boilerplate posted across the sibling test series (#14311, #14312, #14313, #14314). The table below tracks a different bug — a node type resolving to only its first registered
MODEL_NODE_MAPPINGSdirectory — not the folder-vs-filename widget-value mismatch this PR (#14314) originally documented. That case was removed per the 2026-08-25 update above; it does not appear in the table below because it was never about directory reachability. This note is retained only for continuity with the sibling PRs' shared status tracking.Re-verified against
mainon this date.AILab_QwenVLand eight other model-id-based node families were de-registered fromMODEL_NODE_MAPPINGSby #14489 (merged 2026-08-01, backported tocloud/1.48via #14527). That fixed the reported symptom in BE-5071 — those widgets now fall back to the node's own/api/object_infocombo.The bug class documented here is not fixed. The asset browser still resolves a node type to exactly one category. As of 2026-08-03 it remains live on
mainfor five node/input pairs:LS_LoadSegformerModelmodel_namesegformer_b2_clothes,segformer_b3_clothes,segformer_b3_fashionUpscaleModelLoadermodel_nameupscale_models,onnxCLIPVisionLoaderclip_nameclip_vision,clipFlashVSRNodeFlashVSR,FlashVSR-v1.1UltralyticsDetectorProvidermodel_nameultralytics/bbox,ultralytics/segmTracked by FE-1177 (query
model_type:rather than a single directory), FE-1181 (generate the mapping fromobject_info), FE-1080 (child-directory tags) and BE-5255 (backend subtype-carrying tag).Why this is a merged test rather than a Slack thread:
it.failsinverts the report — the assertion genuinely fails (proving the bug is real) but CI stays green. It turns red only when someone fixes the bug without updating the test, which is exactly the alarm we want. As an unmerged draft it provides none of that, which is why these are being taken out of draft.