Repository navigation
test: document coarse model_type:LLM tags failing to resolve to a specific loader - #14312
claude[bot] wants to merge 3 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1820 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 8.85 MB gzip 🔴 +141 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-17T03:48:08.661Z",
"gitSha": "af0dfd84a3409622314cac0f1caf961ad94cd880",
"branch": "test/model-type-llm-subtype-granularity-gap",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.132999999987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.207,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.22,
"heapDeltaBytes": 5121168,
"heapUsedBytes": 69699852,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 7.637,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.0240000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.900999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.72200000000004,
"heapDeltaBytes": 5100976,
"heapUsedBytes": 69609024,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 6.665000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2017.9050000000132,
"styleRecalcs": 77,
"styleRecalcDurationMs": 46.977000000000004,
"layouts": 12,
"layoutDurationMs": 7.158999999999999,
"taskDurationMs": 971.446,
"heapDeltaBytes": -420532,
"heapUsedBytes": 63991108,
"domNodes": 60,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 125.691,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1928.196000000014,
"styleRecalcs": 79,
"styleRecalcDurationMs": 38.987,
"layouts": 12,
"layoutDurationMs": 3.377,
"taskDurationMs": 882.986,
"heapDeltaBytes": -17608044,
"heapUsedBytes": 46991004,
"domNodes": -280,
"jsHeapTotalBytes": 24088576,
"scriptDurationMs": 109.21799999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.76300000001,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.822,
"layouts": 6,
"layoutDurationMs": 0.503,
"taskDurationMs": 371.04900000000004,
"heapDeltaBytes": 8061628,
"heapUsedBytes": 72635220,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 9.574,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.4310000000287,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.174000000000003,
"layouts": 6,
"layoutDurationMs": 0.6719999999999998,
"taskDurationMs": 367.21700000000004,
"heapDeltaBytes": 8064944,
"heapUsedBytes": 72604940,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 9.181,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 585.9080000000176,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.098,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.336,
"heapDeltaBytes": -11183864,
"heapUsedBytes": 53358752,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 56.293,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.918000000017,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.769000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.08299999999997,
"heapDeltaBytes": -12139300,
"heapUsedBytes": 52191160,
"domNodes": 18,
"jsHeapTotalBytes": 27000832,
"scriptDurationMs": 57.318999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2039.7330000000125,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.898999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.6179999999999,
"heapDeltaBytes": 12630480,
"heapUsedBytes": 72858248,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 14.309000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.4919999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.188000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.982,
"heapDeltaBytes": 12577196,
"heapUsedBytes": 73177952,
"domNodes": -287,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 13.584,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2160.4679999999803,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.917000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1174.4669999999999,
"heapDeltaBytes": 7048504,
"heapUsedBytes": 68645528,
"domNodes": -283,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 338.945,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2124.6300000000247,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.087999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1162.727,
"heapDeltaBytes": 9466792,
"heapUsedBytes": 70515796,
"domNodes": -286,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 328.07599999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3182.604000000026,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.306999999999997,
"layouts": 60,
"layoutDurationMs": 7.097999999999999,
"taskDurationMs": 1353.158,
"heapDeltaBytes": -3410984,
"heapUsedBytes": 58517692,
"domNodes": -286,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 386.898,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3197.3310000000765,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.122000000000003,
"layouts": 60,
"layoutDurationMs": 7.122000000000001,
"taskDurationMs": 1362.057,
"heapDeltaBytes": -3496312,
"heapUsedBytes": 58527572,
"domNodes": -288,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 383.437,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.8470000000125,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.586000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.773,
"heapDeltaBytes": 12763516,
"heapUsedBytes": 73836588,
"domNodes": -285,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 14.064,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2037.6000000001113,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.049000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.6899999999999,
"heapDeltaBytes": 12383332,
"heapUsedBytes": 73168764,
"domNodes": -282,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 13.726000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.6109999999617,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.12800000000004,
"heapDeltaBytes": -10291292,
"heapUsedBytes": 54492908,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 116.81,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.1859999999269,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.025999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.66200000000003,
"heapDeltaBytes": -10615220,
"heapUsedBytes": 54078600,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 116.44,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1997.82799999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.249000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.80699999999996,
"heapDeltaBytes": 5089524,
"heapUsedBytes": 69617972,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 5.996999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2034.1210000000274,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.596000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.774,
"heapDeltaBytes": 5040320,
"heapUsedBytes": 69495236,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 6.247000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.1119999999892,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.37899999999999,
"layouts": 16,
"layoutDurationMs": 4.119,
"taskDurationMs": 743.5260000000001,
"heapDeltaBytes": -4155760,
"heapUsedBytes": 60462472,
"domNodes": 62,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 83.823,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.1580000000058,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.82399999999999,
"layouts": 16,
"layoutDurationMs": 3.999000000000001,
"taskDurationMs": 738.98,
"heapDeltaBytes": -4017012,
"heapUsedBytes": 60465032,
"domNodes": 62,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 81.572,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.0220000000118,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.532000000000004,
"layouts": 14,
"layoutDurationMs": 12.523000000000003,
"taskDurationMs": 946.645,
"heapDeltaBytes": -9786456,
"heapUsedBytes": 77467540,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 17.176000000000005,
"eventListeners": 2375,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.469999999952,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.672000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4145.518,
"heapDeltaBytes": 4210140,
"heapUsedBytes": 63930468,
"domNodes": -283,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 1023.108,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8261.11400000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.864999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4097.152,
"heapDeltaBytes": 13273260,
"heapUsedBytes": 73892272,
"domNodes": -281,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 1012.9220000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16879.10099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16284.233,
"heapDeltaBytes": -32158968,
"heapUsedBytes": 165950200,
"domNodes": -8312,
"jsHeapTotalBytes": -12263424,
"scriptDurationMs": 111.535,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17049.124000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16434.341,
"heapDeltaBytes": -43333244,
"heapUsedBytes": 166467556,
"domNodes": -8312,
"jsHeapTotalBytes": -13275136,
"scriptDurationMs": 120.034,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20461.130999999965,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.90900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19839.365999999998,
"heapDeltaBytes": -50340492,
"heapUsedBytes": 159948652,
"domNodes": -8312,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 412.40500000000003,
"eventListeners": -16383,
"totalBlockingTimeMs": 157,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20533.928000000058,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.418000000000045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20058.554,
"heapDeltaBytes": -27711736,
"heapUsedBytes": 169398684,
"domNodes": -8312,
"jsHeapTotalBytes": -13643776,
"scriptDurationMs": 404.427,
"eventListeners": -16385,
"totalBlockingTimeMs": 70,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 460.44900000003963,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.149,
"layouts": 3,
"layoutDurationMs": 0.57,
"taskDurationMs": 106.025,
"heapDeltaBytes": 4960736,
"heapUsedBytes": 68435232,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.24,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 518.1690000000572,
"styleRecalcs": 16,
"styleRecalcDurationMs": 20.262999999999998,
"layouts": 3,
"layoutDurationMs": 1.2219999999999998,
"taskDurationMs": 120.185,
"heapDeltaBytes": 5048344,
"heapUsedBytes": 68659508,
"domNodes": 143,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.310000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14312 +/- ##
==========================================
+ Coverage 78.95% 81.57% +2.62%
==========================================
Files 2209 1882 -327
Lines 112281 109185 -3096
Branches 32992 31287 -1705
==========================================
+ Hits 88647 89066 +419
+ Misses 23178 19747 -3431
+ Partials 456 372 -84
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
312354c to
d0f5516
Compare
|
What this pins: a coarse Why Merge order. #14311, #14313 and #14314 all insert into On the green checks. Worth knowing before you trust them: on 2026-08-11 all five of these were 262 commits behind main, so their passing CI proved nothing about current main. They were rebased onto Note for anyone running these locally: use |
d0f5516 to
84b2f7f
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Request changes: this detector cannot observe the claimed future fix.
Full context for agent readers
mockProvider(null) permanently makes every candidate unresolved, while the static fixture still contains only model_type:LLM; a future subtype tag therefore cannot make this test pass. AILab_QwenVL is also not a valid coarse-LLM default: #14489 intentionally removed its picker mappings because those widgets use repository IDs from /api/object_info. The inline finding identifies the required change.
Exact-head R2 review: cee4605b238671be8a492a0325a603dd49859875.
| expect(mockGetNodeProvider).toHaveBeenCalledWith('LLM/Qwen-VL/Qwen3-0.6B') | ||
| }) | ||
|
|
||
| it.fails('resolves a coarse model_type:LLM asset to a specific loader instead of NO_PROVIDER, once the tag vocabulary can express a subtype', () => { |
There was a problem hiding this comment.
issue: This expected-failure detector cannot turn green from the fix described in the PR. mockProvider(null) hard-wires every provider lookup to fail, while the fixture permanently supplies only model_type:LLM; a future backend subtype tag can never reach this static case. It also guesses AILab_QwenVL, which #14489 intentionally removed from the picker because its widget uses repository IDs via /api/object_info. Please remove this case or retarget it to a reachable contract with a subtype-bearing fixture and a matching provider mock.
#14489 mockProvider(null) hard-wired every provider lookup to fail while the fixture only carried the coarse model_type:LLM tag, so no future subtype tag could ever flip this test green. It also asserted AILab_QwenVL as the resolved loader, but #14489 removed that node family from MODEL_NODE_MAPPINGS because its widget takes repository IDs via /api/object_info, not asset filenames. Checked MODEL_NODE_MAPPINGS on main for a still-reachable pair of loaders sharing one coarse category (e.g. chatterbox/*, CogVideo vs CogVideo/ControlNet): in every such case the existing depth-preferring candidate logic already resolves correctly once a subtype-bearing tag is present (proved by the adjacent passing tests in this file). The remaining gap is purely that some assets never get a subtype tag from the backend at all, which a static frontend fixture cannot simulate turning into a fix. No reachable contract to retarget onto, so the case is removed rather than restated with different names.
|
Thanks for the review — agreed on both points, and I removed the case rather than retargeting it ( Why remove instead of retarget: the case's premise was that a future backend subtype tag would flip it green, but nothing in the test could ever observe that — Before removing, I checked I appended a dated status note to the PR description explaining this (kept the attribution line and the existing 2026-08-03 note as-is). Also checked sibling PR #14314, which got an almost-identical review from you around the same time — as of when I looked, no fix had landed there yet, so this decision was made independently on this PR's own bug shape rather than copying a pattern from it. Ran Generated by Claude Code |
#14529 (already an ancestor of this branch) removed all three segformer_* rows from MODEL_NODE_MAPPINGS, along with onnx and clip, because those widgets accept ids rather than asset filenames and fall back to /api/object_info. The only remaining LS_LoadSegformerModel category registration lived in this test's own mock, so the it.fails case exercised a picker path that no longer exists in production. Checked the rest of MODEL_NODE_MAPPINGS for a still-reachable node registered against multiple directories under one non-empty input key: none exists. UltralyticsDetectorProvider's rows remain disabled, and FlashVSRNode's two directories sit behind an empty key, so it never exposes a widget picker. Removing rather than retargeting, matching how #14312 and #14314 resolved the same staleness elsewhere in this test series.
…nd bucket key (Comfy-Org#14313) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785357549411849?thread_ts=1785296212.634389&cid=C0A4XMHANP3)_ This adds a failing test documenting that the node-widget dropdown's category identifier, a full directory path like LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct, and the model-library sidebar's bucket key, the top-level folder only such as LLM, are incompatible, so querying the bucket-based model list with the widget's own category string returns nothing. This mismatch is a known blocker to migrating the node-dropdown query onto the newer bucket-based asset listing, since the two systems need to agree on category identifier shape first. This test exists so the mismatch has permanent, executable documentation rather than living only in investigation notes. Root cause: getCategoryForNodeType, the forward/widget path, returns full hierarchical paths, while modelFolderFromTag, the bucket path, collapses bare tags to only their first path segment, two different identifier spaces for what's conceptually the same category. Path to a real fix: normalizing all tag-as-identifier usages onto one consistent scheme, follow-up work that hasn't been scheduled yet, would resolve this. Once that lands, convert this test from it.fails to a real assertion. How to verify: pnpm test:unit src/platform/assets/services/assetService.test.ts --- _Generated by [Claude Code](https://claude.ai/code/session_01P6mHd4AJXxneJFqt8y3ozA)_ --- ### Status note — 2026-08-03 Re-verified against `main` on this date. `AILab_QwenVL` and eight other model-id-based node families were **de-registered from `MODEL_NODE_MAPPINGS` by Comfy-Org#14489** (merged 2026-08-01, backported to `cloud/1.48` via Comfy-Org#14527). That fixed the *reported symptom* in BE-5071 — those widgets now fall back to the node's own `/api/object_info` combo. **The bug class documented here is not fixed.** The asset browser still resolves a node type to exactly one category. As of 2026-08-03 it remains live on `main` for five node/input pairs: | Node | Input | Directories (only the first is reachable) | |---|---|---| | `LS_LoadSegformerModel` | `model_name` | `segformer_b2_clothes`, `segformer_b3_clothes`, `segformer_b3_fashion` | | `UpscaleModelLoader` | `model_name` | `upscale_models`, `onnx` | | `CLIPVisionLoader` | `clip_name` | `clip_vision`, `clip` | | `FlashVSRNode` | *(auto)* | `FlashVSR`, `FlashVSR-v1.1` | | `UltralyticsDetectorProvider` | `model_name` | `ultralytics/bbox`, `ultralytics/segm` | Tracked by FE-1177 (query `model_type:` rather than a single directory), FE-1181 (generate the mapping from `object_info`), FE-1080 (child-directory tags) and BE-5255 (backend subtype-carrying tag). **Why this is a merged test rather than a Slack thread:** `it.fails` inverts the report — the assertion genuinely fails (proving the bug is real) but CI stays green. It turns **red only when someone fixes the bug without updating the test**, which is exactly the alarm we want. As an unmerged draft it provides none of that, which is why these are being taken out of draft. ### Status note — 2026-08-25 Per [review](Comfy-Org#14313 (review)), `AILab_QwenVL` / `LLM/Qwen-VL/*` was an invalid target: Comfy-Org#14489 (merged 2026-08-01, confirmed an ancestor of this PR's exact head via `git merge-base --is-ancestor`) intentionally de-registered it from `MODEL_NODE_MAPPINGS` because that widget accepts a model or repository ID and now falls back to `/api/object_info`, so the mock's `LLM/Qwen-VL/*` category never reaches a live product path. Unlike the sibling PRs in this series, this PR's bug shape (a full hierarchical category path vs. a bucket key truncated to its first path segment) has a still-reachable production analog, so the case was **retargeted, not removed**. Checked current `MODEL_NODE_MAPPINGS` for a live entry that is (a) a multi-segment directory path and (b) registered with a non-empty input key, since an empty key means the node auto-loads without a widget and can't expose the bug. The `chatterbox/*` and `CogVideo/ControlNet` entries are also multi-segment but all use an empty key, so they're not eligible either. `['LLM/checkpoints', 'LoadChatGLM3', 'chatglm3_checkpoint']` is: it's live on `main`, uses the real `chatglm3_checkpoint` widget key, and `getAssetCategories`'s bare-tag mode (`asset.tags.map(tag => tag.split('/')[0])`) collapses an `LLM/checkpoints`-tagged asset to bucket key `LLM`, while `getCategoryForNodeType('LoadChatGLM3')` still returns the full `LLM/checkpoints` string — the exact same key-space mismatch the test documents, on a mapping nothing has removed. Also independently re-checked the 2026-08-03 five-pair table per the review's flag: `Comfy-Org#14529` (also confirmed an ancestor of this head) removed the `segformer_*`, `onnx`, and `clip` mappings entirely; `UltralyticsDetectorProvider`'s two rows remain commented out/disabled; and `FlashVSRNode` registers two directories under an empty input key, so it never exposes a widget picker. None of the five pairs still exhibit a live, widget-reachable symptom — consistent with the same conclusion reached independently on Comfy-Org#14311, Comfy-Org#14312, and Comfy-Org#14314 today, though that table was never this test's own case and doesn't otherwise affect this PR's fix. Mock and assertion in `src/platform/assets/services/assetService.test.ts` now use `LoadChatGLM3` / `chatglm3_checkpoint` / `LLM/checkpoints` in place of `AILab_QwenVL` / `model_name` / `LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct`. `pnpm test:unit src/platform/assets/services/assetService.test.ts` passes (65 passed, 1 expected fail). How to verify: `pnpm test:unit src/platform/assets/services/assetService.test.ts` --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
#14529 (already an ancestor of this branch) removed all three segformer_* rows from MODEL_NODE_MAPPINGS, along with onnx and clip, because those widgets accept ids rather than asset filenames and fall back to /api/object_info. The only remaining LS_LoadSegformerModel category registration lived in this test's own mock, so the it.fails case exercised a picker path that no longer exists in production. Checked the rest of MODEL_NODE_MAPPINGS for a still-reachable node registered against multiple directories under one non-empty input key: none exists. UltralyticsDetectorProvider's rows remain disabled, and FlashVSRNode's two directories sit behind an empty key, so it never exposes a widget picker. Removing rather than retargeting, matching how #14312 and #14314 resolved the same staleness elsewhere in this test series.
Requested by Christian Byrne · Slack thread
This adds a failing test documenting that assets tagged with only a coarse category (e.g. model_type:LLM) cannot be resolved to a specific loader node when multiple node types like AILab_QwenVL and AILab_QwenVL_PromptEnhancer share that same broad category, so resolution fails with a no-provider error instead of picking a reasonable specific loader.
This is an explicitly acknowledged, code-commented gap. src/platform/assets/utils/resolveModelNodeFromAsset.ts (around lines 116-119) says: "Known gap (out of scope for FE-1076): flat model_type:LLM-style tags whose loaders are only registered hierarchically land here until the backend emits a subtype-carrying tag." It can't be fixed on the frontend alone; it needs the backend to start emitting finer-grained subtype tags first. This test exists so the gap has permanent, executable documentation and doesn't get lost.
Root cause: the category-resolution primitive collapses hierarchical categories to a single flat value under the new tag scheme, while today's node-to-category mappings are registered at a much deeper granularity, a structural mismatch once a tag is coarse.
Path to a real fix: needs backend work to emit subtype-carrying tags, plus frontend work to consume them in the resolution path, both currently tracked as follow-up work that hasn't been scheduled yet. Once available, convert this test from it.fails to a real assertion.
How to verify: pnpm test:unit src/platform/assets/utils/resolveModelNodeFromAsset.test.ts
Generated by Claude Code
Status note — 2026-08-03
Re-verified against
mainon this date.AILab_QwenVLand eight other model-id-based node families were de-registered fromMODEL_NODE_MAPPINGSby #14489 (merged 2026-08-01, backported tocloud/1.48via #14527). That fixed the reported symptom in BE-5071 — those widgets now fall back to the node's own/api/object_infocombo.The bug class documented here is not fixed. The asset browser still resolves a node type to exactly one category. As of 2026-08-03 it remains live on
mainfor five node/input pairs:LS_LoadSegformerModelmodel_namesegformer_b2_clothes,segformer_b3_clothes,segformer_b3_fashionUpscaleModelLoadermodel_nameupscale_models,onnxCLIPVisionLoaderclip_nameclip_vision,clipFlashVSRNodeFlashVSR,FlashVSR-v1.1UltralyticsDetectorProvidermodel_nameultralytics/bbox,ultralytics/segmTracked by FE-1177 (query
model_type:rather than a single directory), FE-1181 (generate the mapping fromobject_info), FE-1080 (child-directory tags) and BE-5255 (backend subtype-carrying tag).Why this is a merged test rather than a Slack thread:
it.failsinverts the report — the assertion genuinely fails (proving the bug is real) but CI stays green. It turns red only when someone fixes the bug without updating the test, which is exactly the alarm we want. As an unmerged draft it provides none of that, which is why these are being taken out of draft.Status note — 2026-08-25
Per review, the
it.failscase above has been removed, not retargeted.The case asserted that a
model_type:LLM-only asset would resolve toAILab_QwenVLonce "the tag vocabulary can express a subtype," but it could never observe that:mockProvider(null)hard-wired every category lookup to fail, and the fixture never gained the subtype tag the premise depended on, so no code change could turn it green.AILab_QwenVLis also gone fromMODEL_NODE_MAPPINGSas of #14489 (see the 2026-08-03 note above), for the same repository-ID-widget reason as the other de-registered node families — it was never a valid target to assert against.Looked for a still-reachable analog — two loaders genuinely sharing one coarse category today (checked the
chatterbox/*family andCogVideovsCogVideo/ControlNet, both still inMODEL_NODE_MAPPINGS). In every such case,resolveModelNodeFromAsset's existing deepest-path-preferred candidate logic already resolves correctly as soon as a subtype-bearing tag is present on the asset — that's exactly what the three passing tests directly above the removed case already cover (model_type:vae, the unresolvable-incidental-tag case, and theLLM/Qwen-VL/Qwen3-0.6Bdeepest-path case). The only remaining gap is assets for which the backend never emits any subtype-bearing tag at all, which is a backend-data gap, not a frontend resolution bug — a static frontend fixture can't simulate a backend starting to emit a tag it doesn't emit, so there's no honestly-falsifiable frontend contract left to pin here. The five node/input pairs in the 2026-08-03 table above (a related but distinct bug: one node registered under several sibling directories) remain live and undocumented-by-test elsewhere; they are out of scope for this specific case.