Repository navigation
test: document category key-space mismatch between node-widget path and bucket key - #14313
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2039 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T06:15:32.897Z",
"gitSha": "9bd577ef676b9db8e714d326193dc4f09ff28fbb",
"branch": "test/model-category-keyspace-mismatch",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.5800000001382,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.923,
"heapDeltaBytes": 8247752,
"heapUsedBytes": 69595572,
"domNodes": -265,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.956999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.8700000002154,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.414,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.73799999999994,
"heapDeltaBytes": 13371356,
"heapUsedBytes": 75120988,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.105,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.5709999999763,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.916,
"layouts": 14,
"layoutDurationMs": 4.332000000000001,
"taskDurationMs": 825.177,
"heapDeltaBytes": 18681608,
"heapUsedBytes": 80905256,
"domNodes": -261,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 160.697,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.7650000000685,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.105999999999998,
"layouts": 14,
"layoutDurationMs": 4.1339999999999995,
"taskDurationMs": 802.992,
"heapDeltaBytes": 9119256,
"heapUsedBytes": 71253480,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 159.184,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.651999999949,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.711999999999998,
"layouts": 6,
"layoutDurationMs": 1.0690000000000002,
"taskDurationMs": 320.666,
"heapDeltaBytes": 1891180,
"heapUsedBytes": 64025444,
"domNodes": 75,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.197000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7699999999822,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.255,
"layouts": 6,
"layoutDurationMs": 1.189,
"taskDurationMs": 321.275,
"heapDeltaBytes": 2196544,
"heapUsedBytes": 64038608,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.239999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.4000000000142,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.969,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.339,
"heapDeltaBytes": 17879440,
"heapUsedBytes": 79907552,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 168.484,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 613.1239999999707,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.73,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.371,
"heapDeltaBytes": 18151432,
"heapUsedBytes": 79043636,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 164.458,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.62900000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.610999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.3140000000001,
"heapDeltaBytes": 2494236,
"heapUsedBytes": 82418160,
"domNodes": -246,
"jsHeapTotalBytes": -1843200,
"scriptDurationMs": 31.028,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2022.653999999875,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.159999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.3379999999999,
"heapDeltaBytes": 3714148,
"heapUsedBytes": 82957444,
"domNodes": -245,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 34.10399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2255.278999999973,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.567000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1599.809,
"heapDeltaBytes": 18992120,
"heapUsedBytes": 83367976,
"domNodes": 4,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 847.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2182.6119999998355,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.171999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1424.7610000000002,
"heapDeltaBytes": 15220360,
"heapUsedBytes": 79167396,
"domNodes": -249,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 831.086,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3463.950999999952,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.389000000000001,
"layouts": 60,
"layoutDurationMs": 12.123999999999999,
"taskDurationMs": 1644.8649999999998,
"heapDeltaBytes": 9566980,
"heapUsedBytes": 74714884,
"domNodes": -258,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 778.466,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3521.8170000000555,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.477000000000002,
"layouts": 60,
"layoutDurationMs": 12.548,
"taskDurationMs": 1651.978,
"heapDeltaBytes": 8067240,
"heapUsedBytes": 73878364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.9490000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3102.9309999998986,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.856999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1942.4320000000002,
"heapDeltaBytes": -10865968,
"heapUsedBytes": 71880784,
"domNodes": -262,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 982.7750000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3020.608999999922,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.788999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1899.26,
"heapDeltaBytes": 18795180,
"heapUsedBytes": 84513772,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 979.545,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.8250000000735,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.823999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.9920000000001,
"heapDeltaBytes": -4685468,
"heapUsedBytes": 83096492,
"domNodes": -249,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.544,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2046.875,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.411,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.655,
"heapDeltaBytes": -7213148,
"heapUsedBytes": 80112324,
"domNodes": -254,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 34.297999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.0609999999251,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.83699999999993,
"heapDeltaBytes": 13845168,
"heapUsedBytes": 77270476,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.121,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.7519999999477,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.137000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.619,
"heapDeltaBytes": 13829308,
"heapUsedBytes": 76549960,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.387,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.0049999999355,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.245999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.384,
"heapDeltaBytes": 11159076,
"heapUsedBytes": 74206060,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.908000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.6909999999934,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.326,
"heapDeltaBytes": -1569252,
"heapUsedBytes": 61433120,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.881000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.4010000001417,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.894000000000002,
"layouts": 18,
"layoutDurationMs": 5.006,
"taskDurationMs": 750.9220000000001,
"heapDeltaBytes": 816388,
"heapUsedBytes": 64066564,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 105.606,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.8500000001732,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.311,
"layouts": 18,
"layoutDurationMs": 4.795,
"taskDurationMs": 762.1439999999999,
"heapDeltaBytes": 5097564,
"heapUsedBytes": 68372092,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 105.88600000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4779999999446,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.117000000000004,
"layouts": 5,
"layoutDurationMs": 13.274999999999999,
"taskDurationMs": 869.7229999999998,
"heapDeltaBytes": 20070252,
"heapUsedBytes": 102922416,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.120999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8309.36799999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.464999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5663.4929999999995,
"heapDeltaBytes": -4488320,
"heapUsedBytes": 75651448,
"domNodes": -248,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 2766.29,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8243.55700000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.748000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5126.348,
"heapDeltaBytes": -4006668,
"heapUsedBytes": 75216592,
"domNodes": -248,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 2790.644,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16655.884000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16045.377999999999,
"heapDeltaBytes": -33728224,
"heapUsedBytes": 185140196,
"domNodes": -8061,
"jsHeapTotalBytes": -9371648,
"scriptDurationMs": 252.957,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16601.038000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16001.564000000002,
"heapDeltaBytes": -32245972,
"heapUsedBytes": 183485392,
"domNodes": -8061,
"jsHeapTotalBytes": -7118848,
"scriptDurationMs": 261.067,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20489.21300000006,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.276000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20134.686,
"heapDeltaBytes": -53449244,
"heapUsedBytes": 176836836,
"domNodes": -8061,
"jsHeapTotalBytes": -14225408,
"scriptDurationMs": 921.0120000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 156,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20517.364999999925,
"styleRecalcs": 145,
"styleRecalcDurationMs": 17.013000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20322.839,
"heapDeltaBytes": -56938528,
"heapUsedBytes": 166597628,
"domNodes": -8061,
"jsHeapTotalBytes": -16650240,
"scriptDurationMs": 868.152,
"eventListeners": -14928,
"totalBlockingTimeMs": 20,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5964.570000000094,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.658,
"layouts": 20,
"layoutDurationMs": 23.195999999999994,
"taskDurationMs": 5874.265,
"heapDeltaBytes": -41354980,
"heapUsedBytes": 176425452,
"domNodes": -8061,
"jsHeapTotalBytes": 10899456,
"scriptDurationMs": 109.29300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 374,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6143.777,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.08299999999998,
"layouts": 20,
"layoutDurationMs": 25.459999999999997,
"taskDurationMs": 6073.5470000000005,
"heapDeltaBytes": -60510792,
"heapUsedBytes": 181685224,
"domNodes": -8061,
"jsHeapTotalBytes": 12185600,
"scriptDurationMs": 108.254,
"eventListeners": -14928,
"totalBlockingTimeMs": 491,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8293.16800000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8075.525000000001,
"heapDeltaBytes": 1401836,
"heapUsedBytes": 183581336,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 150.38899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8364.555999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8089.965000000001,
"heapDeltaBytes": 26129944,
"heapUsedBytes": 192829524,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 127.19000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 477.18299999996816,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.193,
"layouts": 4,
"layoutDurationMs": 2.0239999999999996,
"taskDurationMs": 129.00400000000002,
"heapDeltaBytes": 5131496,
"heapUsedBytes": 66779492,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.615000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 471.7470000000503,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.846999999999998,
"layouts": 4,
"layoutDurationMs": 2.118,
"taskDurationMs": 122.25900000000003,
"heapDeltaBytes": 4959992,
"heapUsedBytes": 66624252,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.554,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14313 +/- ##
==========================================
+ Coverage 82.78% 83.79% +1.01%
==========================================
Files 2936 2242 -694
Lines 144482 127635 -16847
Branches 37152 34338 -2814
==========================================
- Hits 119610 106958 -12652
+ Misses 23615 20387 -3228
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
d954702 to
70b99a2
Compare
|
Merge-order note: this and #14311 and #14314 all add cases to Re-verified against |
|
What this pins: the widget category is a full path while the sidebar bucket key is only the top folder, so the two do not match. Real fix: FE-1181. Why Merge order. #14311, #14313 and #14314 all insert into On the green checks. Worth knowing before you trust them: on 2026-08-11 all five of these were 262 commits behind main, so their passing CI proved nothing about current main. They were rebased onto Note for anyone running these locally: use |
70b99a2 to
8e40f17
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Request changes: this detector recreates a picker path removed by #14489.
Full context for agent readers
That merged fix is already an ancestor of this exact head. Production deliberately leaves LLM/Qwen-VL/* unmapped because those widgets accept model or repository IDs from /api/object_info, while this test alone inserts an AILab_QwenVL category. The it.fails case therefore exercises only mocked reachability, not a live product path. The inline finding identifies the required change.
Exact-head R2 review: 533cafb40a595cf032eee20a06b6c281f3605fe5.
| CheckpointLoaderSimple: 'checkpoints', | ||
| LoraLoader: 'loras' | ||
| LoraLoader: 'loras', | ||
| AILab_QwenVL: 'LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct' |
There was a problem hiding this comment.
Blocker: this picker category exists only in the test mock.
Full context for agent readers
#14489 intentionally removed all AILab_QwenVL mappings because these widgets accept model or repository IDs and fall back to /api/object_info; that merge is an ancestor of this exact head, and production records LLM/Qwen-VL/* as intentionally unmapped. This mock bypasses that product gate, so the expected-failure case cannot detect a reachable dropdown regression. The PR body's five-pair inventory is stale too: #14529 removed the Segformer, onnx, and clip mappings; Ultralytics remains disabled; and FlashVSR's empty input key exposes no eligible widget picker. Please remove this case or retarget it only if a current production mapping exposes the behavior.
There was a problem hiding this comment.
Agreed on AILab_QwenVL — confirmed #14489 (merge commit ac070934) is an ancestor of this PR's exact head (533cafb4) via git merge-base --is-ancestor, and current MODEL_NODE_MAPPINGS on main still carries the "Intentionally unmapped ... LLM/Qwen-VL/*" comment, so the mock's category never reaches a live product path.
Unlike the other three PRs in this series, though, this PR's specific bug shape (a full hierarchical category path vs. a bucket key truncated to its first path segment) does have a still-reachable production analog, so I retargeted the case rather than removing it. ['LLM/checkpoints', 'LoadChatGLM3', 'chatglm3_checkpoint'] is live on main, uses a real non-empty widget key, and hits the identical mismatch: getCategoryForNodeType('LoadChatGLM3') returns the full LLM/checkpoints string, while getAssetCategories's bare-tag mode collapses an LLM/checkpoints-tagged asset down to bucket key LLM. I also checked the other multi-segment entries (chatterbox/*, CogVideo/ControlNet) — all use an empty input key, so they can't expose the bug.
Also independently re-verified the five-pair table you flagged as stale: confirmed #14529 (also an ancestor of this head) removed the segformer_*, onnx, and clip mappings; UltralyticsDetectorProvider's two rows are still commented out; and FlashVSRNode has an empty input key. None of the five still exhibit a live symptom — same conclusion reached independently on #14311/#14312/#14314 today.
Pushed the retarget in 33c10b2 and updated the PR description with a dated status note. pnpm test:unit src/platform/assets/services/assetService.test.ts passes (65 passed, 1 expected fail). Left this thread open for you to resolve.
Generated by Claude Code
…atGLM3 mapping AILab_QwenVL was de-registered from MODEL_NODE_MAPPINGS by #14489, so the mocked category it exercised (LLM/Qwen-VL/*) no longer exists in production. Retargeted the mock and the it.fails assertion onto LoadChatGLM3 / chatglm3_checkpoint / LLM/checkpoints, a still-live, widget-reachable mapping with the same full-path-category vs top-folder-bucket-key mismatch.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
…: orphaned renames)
Requested by Christian Byrne · Slack thread
This adds a failing test documenting that the node-widget dropdown's category identifier, a full directory path like LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct, and the model-library sidebar's bucket key, the top-level folder only such as LLM, are incompatible, so querying the bucket-based model list with the widget's own category string returns nothing.
This mismatch is a known blocker to migrating the node-dropdown query onto the newer bucket-based asset listing, since the two systems need to agree on category identifier shape first. This test exists so the mismatch has permanent, executable documentation rather than living only in investigation notes.
Root cause: getCategoryForNodeType, the forward/widget path, returns full hierarchical paths, while modelFolderFromTag, the bucket path, collapses bare tags to only their first path segment, two different identifier spaces for what's conceptually the same category.
Path to a real fix: normalizing all tag-as-identifier usages onto one consistent scheme, follow-up work that hasn't been scheduled yet, would resolve this. Once that lands, convert this test from it.fails to a real assertion.
How to verify: pnpm test:unit src/platform/assets/services/assetService.test.ts
Generated by Claude Code
Status note — 2026-08-03
Re-verified against
mainon this date.AILab_QwenVLand eight other model-id-based node families were de-registered fromMODEL_NODE_MAPPINGSby #14489 (merged 2026-08-01, backported tocloud/1.48via #14527). That fixed the reported symptom in BE-5071 — those widgets now fall back to the node's own/api/object_infocombo.The bug class documented here is not fixed. The asset browser still resolves a node type to exactly one category. As of 2026-08-03 it remains live on
mainfor five node/input pairs:LS_LoadSegformerModelmodel_namesegformer_b2_clothes,segformer_b3_clothes,segformer_b3_fashionUpscaleModelLoadermodel_nameupscale_models,onnxCLIPVisionLoaderclip_nameclip_vision,clipFlashVSRNodeFlashVSR,FlashVSR-v1.1UltralyticsDetectorProvidermodel_nameultralytics/bbox,ultralytics/segmTracked by FE-1177 (query
model_type:rather than a single directory), FE-1181 (generate the mapping fromobject_info), FE-1080 (child-directory tags) and BE-5255 (backend subtype-carrying tag).Why this is a merged test rather than a Slack thread:
it.failsinverts the report — the assertion genuinely fails (proving the bug is real) but CI stays green. It turns red only when someone fixes the bug without updating the test, which is exactly the alarm we want. As an unmerged draft it provides none of that, which is why these are being taken out of draft.Status note — 2026-08-25
Per review,
AILab_QwenVL/LLM/Qwen-VL/*was an invalid target: #14489 (merged 2026-08-01, confirmed an ancestor of this PR's exact head viagit merge-base --is-ancestor) intentionally de-registered it fromMODEL_NODE_MAPPINGSbecause that widget accepts a model or repository ID and now falls back to/api/object_info, so the mock'sLLM/Qwen-VL/*category never reaches a live product path.Unlike the sibling PRs in this series, this PR's bug shape (a full hierarchical category path vs. a bucket key truncated to its first path segment) has a still-reachable production analog, so the case was retargeted, not removed. Checked current
MODEL_NODE_MAPPINGSfor a live entry that is (a) a multi-segment directory path and (b) registered with a non-empty input key, since an empty key means the node auto-loads without a widget and can't expose the bug. Thechatterbox/*andCogVideo/ControlNetentries are also multi-segment but all use an empty key, so they're not eligible either.['LLM/checkpoints', 'LoadChatGLM3', 'chatglm3_checkpoint']is: it's live onmain, uses the realchatglm3_checkpointwidget key, andgetAssetCategories's bare-tag mode (asset.tags.map(tag => tag.split('/')[0])) collapses anLLM/checkpoints-tagged asset to bucket keyLLM, whilegetCategoryForNodeType('LoadChatGLM3')still returns the fullLLM/checkpointsstring — the exact same key-space mismatch the test documents, on a mapping nothing has removed.Also independently re-checked the 2026-08-03 five-pair table per the review's flag:
#14529(also confirmed an ancestor of this head) removed thesegformer_*,onnx, andclipmappings entirely;UltralyticsDetectorProvider's two rows remain commented out/disabled; andFlashVSRNoderegisters two directories under an empty input key, so it never exposes a widget picker. None of the five pairs still exhibit a live, widget-reachable symptom — consistent with the same conclusion reached independently on #14311, #14312, and #14314 today, though that table was never this test's own case and doesn't otherwise affect this PR's fix.Mock and assertion in
src/platform/assets/services/assetService.test.tsnow useLoadChatGLM3/chatglm3_checkpoint/LLM/checkpointsin place ofAILab_QwenVL/model_name/LLM/Qwen-VL/Qwen2.5-VL-3B-Instruct.pnpm test:unit src/platform/assets/services/assetService.test.tspasses (65 passed, 1 expected fail).How to verify:
pnpm test:unit src/platform/assets/services/assetService.test.ts