Repository navigation
Conversation
- add blank canvas (demo) and app mode (wip) tours - overlay with target highlight, landing card, step state handling, step card - v-coachmark directive updating registry for mount/unmount - frame settling watcher for animated targets (dialogs) - focus trap for the target plus the coachmark element - add telemetry for each step
- move tour trigger to linear controls section
- onboardingTours: use 'auto' placement for assets panel so the card follows the sidebar side - TourOverlay: clamp no-target card left to the viewport margin so it never goes off-screen - useCoachmarkTour: catch onPrimary action failures, surface a toast, and only advance on success - useCoachmarkTour: claim the single-instance guard synchronously so a duplicate mount stays inert - useFocusTrap: send Shift+Tab from outside the trap to the last item instead of skipping it - telemetry: drop dead run-button imports left over from the rebase (superseded by getRunButtonTelemetryProperties)
- Open the tour only via the help button or ?coach= param (no auto-open when entering app mode) - Drop the loadTemplate step tech and the demo card image — the tour runs on the user's existing app - Skip the assets-button step at tour start when the assets panel is already open; step indicator counts 4 instead of 5
- Open the app-mode tour when entering an app with linear controls visible (mode === 'app' && hasOutputs), including when the overlay mounts into one already (immediate watch) - Respect the seen-flag, so it won't reopen once completed or skipped; skip the empty/welcome state and arrange (builder) mode - Move test target DOM cleanup into afterEach so appended nodes are removed even if a test fails early
- Track the spotlight target with VueUse useElementBounding instead of a hand-rolled measure/RAF/ResizeObserver loop; keep a capture-phase scroll listener so it still follows targets inside scrollable panels - Fold the spotlight ring into the dim element (CSS outline + box-shadow), dropping the separate SVG; the idle pulse now animates outline-color - Remove the unused CoachStep `elevated` field and its plumbing
Reka's built-in Escape dismissal proved unreliable for this dialog in e2e (Skip, which sets open=false directly, works); close via the same model path on Escape so the welcome landing reliably dismisses.
Trimming the graph-mode anchors earlier removed the templates-button click that loadTemplate relied on to open the browser; open it via the Comfy.BrowseTemplates command instead.
Extract TourSpotlight, rendered only while a spotlight step is shown, so the geometry/scroll, focus-trap and click-to-advance listeners (plus z-index and the stall pulse) register for the active step rather than the whole graph-view session. useCoachmarkTour slims to the state machine; the registry-query helpers (targetMounted/waitForTarget) move to coachmarkRegistry and useCoachmarkTarget becomes geometry-only and self-measuring. Also from review feedback: - read the ?coach= force in setup, before the immediate auto-open watcher, so an already-populated app no longer drops a ?coach=any replay - harden isEntryPath against prototype keys (Object.hasOwn) - decouple each tour's auto-open condition into useTourTriggers, keeping the engine tour-agnostic
Conflict in LinearControls.vue: main refactored the run-button test id into a named constant (linearRunButtonTestId, same 'linear-run-button' value), while this branch added the v-coachmark anchor and a static test id to the same sections. Kept the coachmark directive and adopted main's :data-testid binding, dropping the now-redundant static id.
Raise useCoachmarkTour.ts to full line coverage and TourSpotlight.vue escape handling with behavioral tests.
- Replace the hand-rolled card-placement math (resolvePlacement /
cardCorner / clampCardPosition) and the manual target tracking (scroll
listener + useElementBounding + rAF settle loop) with @floating-ui/vue
(offset/flip/shift + autoUpdate); promote it from a transitive to a
direct dependency.
- Keep vertically-centred (leftCenter) cards on-screen with
shift({ crossAxis: true }), and centre the card when its target hasn't
laid out, so a step never renders off-screen or invisible.
- Make targetMounted/waitForTarget layout-aware (poll per frame) so a
deferred target that registers before it sizes resolves only once
measurable, matching what the spotlight actually displays.
- Shrink the spotlight glow (pad 8->4) so it no longer spills onto an
adjacent control the user might click.
- Label the spotlight dialog with aria-labelledby pointing at its heading
instead of a duplicated aria-label.
- Drop the unused isActive option from useFocusTrap.
- Add an e2e guard that walks every app-mode spotlight step and asserts
each card sits fully within the viewport; add unit coverage for
last-step Skip hiding, modal z-index reclaim, and all four onboarding
telemetry stages.
- Drive Floating UI autoUpdate manually so animationFrame polling runs only while a deferred target is still moving, then fall back to scroll/resize listeners instead of polling every frame for the whole step - Set aria-modal to false on interaction steps where the user must click outside the card - Ignore unrecognized ?coach= values; keep `any` as the replay keyword - Align the spotlight scrim with the landing backdrop (0.62 -> 0.6) to avoid a dim shift on landing -> spotlight - Export COACH_IDS and import it in the drift guard instead of a hardcoded in-sync list - Clarify why the landing needs an explicit Escape listener (Reka's DismissableLayer doesn't fire update:open here) - Test that the started telemetry event omits step_index/coach_id while per-step events include them Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Report the timed-out deferred step in skip telemetry by advancing the step index before ending the tour, instead of logging the prior step - Make the ?coach= override one-shot: named paths force-start only via the delayed timer (respecting START_DELAY_MS) and re-entry honors the seen-flag again, rather than bypassing it all session - Resolve waitForTarget to false immediately when the signal is already aborted, so it can't hang until timeout - Reuse the cached dialog locator in Tour.cardForStep
- Drop the ?coach= query param: remove the forced-entry/replay-any override and delayed force-start; tours now start only via auto-open or an explicit request. E2E replays via the in-app help button after entering app mode - Flatten coachmarkController to plain requestTour/onTourRequested exports instead of a useCoachmarkController composable - Derive the top-bar safe inset from the --comfy-topbar-height token plus CARD_GAP instead of hardcoding 56 - Remove the landing Start button's fixed width - Document the real cause of the landing Escape workaround (global keybinding preventDefaults Escape before Reka's DismissableLayer dismisses) - Trim verbose comments in coachmarkRegistry and TourOverlay tests
- Show public/assets/images/app-mode-landing.png on the welcome landing's left panel
…otes - clear the spotlight's previous ZIndex entry before re-raising, so step changes stop leaking entries into the shared modal stacking sequence - report tour telemetry as the user-visible numbering: 1-based step_number within counted spotlight steps, omitted for the landing - seed the e2e seen-tours setting from TOURS so future tours can't auto-open under unrelated suites
- derive step translation keys from a step `name` (onboardingCoachmarks.<tour>.<name>.*), with te()-checked primary/skip label overrides falling back to Next/Done/Skip - move all tour i18n into the engine; TourOverlay and TourSpotlight now receive translated title/body strings - replace the landing's required open model with a skip emit and drop the landingOpen writable computed - simplify TourOverlay.test.ts mocks with fromPartial - replace SCRIM_COLOR with Tailwind classes (bg-black/60, spotlight spread shadow) - narrow the app-run-button anchor so the spotlight excludes the run error warning - key the e2e tour fixture's replay button by tour name - drop the tour spec's template loading; the test server's default workflow already populates the graph (locally: pnpm dev:test) - prune comments that restated code
- tour step keys are built as onboardingCoachmarks.<tour>.<name>.*, so the literal-key scan can't see them
- a single sync() replaces the per-hook register/unregister logic; mounted/updated/unmounted all reconcile desired vs current id - drops the oldValue bookkeeping and its explanatory comment
…k holes Nothing set maskRects, leaving a v-for over an empty list and a RAF that could only pause. Pin the DOM-target transition, which no test covered.
The offset maths was copied from DragAndScale.convertOffsetToCanvas, so a change to litegraph's camera convention would misplace every spotlight with nothing failing. Call it instead.
TransformPane already mirrors the camera every frame, so the spotlight's own RAF was a second loop doing the same work. Moving targets now expose onMove and the engine subscribes to it.
The sampled rect was written and then read straight back by update(): the card and the spotlight already share one middleware pass, so there was no drift for it to prevent.
Nodes 2.0 renders every node, so a coachmark target names one by selector and the engine anchors to the element itself. Drops the litegraph rect arithmetic that placed a synthesised rect from the camera: canvasCoachTarget went 49 lines to 15 and imports neither LGraphCanvas nor app. One candidate now answers both "where is it" and "does it move". Before, the element came from the first laid-out candidate and the motion flag from the first moving one, so a still target lost its 300ms glide whenever an unrelated moving target shared its coach id, and a step with nothing on screen still claimed to be moving. Resolving that candidate is a computed, so the camera no longer forces a querySelector and a layout read per frame from inside its own callback. A node that a re-render swaps for a fresh element is picked up from the DOM, which the old hand-written refresh managed only if the camera happened to move at the same time. The node still moves by a transform on an ancestor, which fires neither scroll nor resize, so a target keeps announcing its own motion — but only the anchored candidate is subscribed, since a second one would reposition a card pointing somewhere else.
📝 WalkthroughWalkthroughChangesOnboarding coachmark enhancements
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1758 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.18 MB gzip 🔴 +100 BDetailsSummary
Category Glance App Entry Points — 3.66 kB (baseline 3.66 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.28 MB (baseline 1.28 MB) • 🔴 +326 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70.7 kB (baseline 70.7 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.43 MB (baseline 3.43 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.6 MB (baseline 12.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 277 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-29T23:54:25.059Z",
"gitSha": "b9cc3b88e4abd481a58c21c4bcf5aafc3d2cbeff",
"branch": "deepme987/onboarding/selector-targets-lite",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.522999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.160000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.918,
"heapDeltaBytes": 3521852,
"heapUsedBytes": 71355188,
"domNodes": 18,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 29.211,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2040.3890000000047,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.655,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.95500000000004,
"heapDeltaBytes": 3822656,
"heapUsedBytes": 71914468,
"domNodes": 18,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 17.058999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.515999999991,
"styleRecalcs": 74,
"styleRecalcDurationMs": 42.81699999999999,
"layouts": 12,
"layoutDurationMs": 3.541,
"taskDurationMs": 1003.557,
"heapDeltaBytes": -14692964,
"heapUsedBytes": 53195976,
"domNodes": -275,
"jsHeapTotalBytes": 21749760,
"scriptDurationMs": 138.52100000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.273000000011,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.374,
"layouts": 12,
"layoutDurationMs": 3.535,
"taskDurationMs": 873.1759999999999,
"heapDeltaBytes": -15727896,
"heapUsedBytes": 52349900,
"domNodes": -274,
"jsHeapTotalBytes": 20439040,
"scriptDurationMs": 119.86099999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1839999999565,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.721000000000004,
"layouts": 6,
"layoutDurationMs": 0.8349999999999999,
"taskDurationMs": 438.544,
"heapDeltaBytes": 7080872,
"heapUsedBytes": 75006876,
"domNodes": 77,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 24.851000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.3689999999579,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.846,
"layouts": 6,
"layoutDurationMs": 0.626,
"taskDurationMs": 383.45,
"heapDeltaBytes": 6966316,
"heapUsedBytes": 74848552,
"domNodes": 77,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 19.933,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 687.1929999999793,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.035000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.5519999999999,
"heapDeltaBytes": -11699404,
"heapUsedBytes": 56217516,
"domNodes": 18,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 63.65,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.8240000000169,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.050999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.88500000000005,
"heapDeltaBytes": -12433236,
"heapUsedBytes": 55767380,
"domNodes": 20,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 59.603,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.492999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.874999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.239,
"heapDeltaBytes": 7524996,
"heapUsedBytes": 66752332,
"domNodes": -275,
"jsHeapTotalBytes": 5304320,
"scriptDurationMs": 121.759,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.908000000035,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.302,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 841.176,
"heapDeltaBytes": 6740372,
"heapUsedBytes": 66580644,
"domNodes": -276,
"jsHeapTotalBytes": 5304320,
"scriptDurationMs": 138.214,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2285.1229999999987,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.126,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.528,
"heapDeltaBytes": -4376872,
"heapUsedBytes": 55520996,
"domNodes": -277,
"jsHeapTotalBytes": 5304320,
"scriptDurationMs": 459.885,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2153.0819999999267,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1299.5960000000002,
"heapDeltaBytes": -5371392,
"heapUsedBytes": 55057404,
"domNodes": -279,
"jsHeapTotalBytes": 5566464,
"scriptDurationMs": 429.29,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3297.5910000000113,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.072999999999997,
"layouts": 60,
"layoutDurationMs": 7.3180000000000005,
"taskDurationMs": 1562.0369999999998,
"heapDeltaBytes": 5287868,
"heapUsedBytes": 66710844,
"domNodes": -280,
"jsHeapTotalBytes": 6877184,
"scriptDurationMs": 549.505,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3215.610999999967,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.313999999999997,
"layouts": 60,
"layoutDurationMs": 7.28,
"taskDurationMs": 1503.7600000000002,
"heapDeltaBytes": -830856,
"heapUsedBytes": 60637660,
"domNodes": -280,
"jsHeapTotalBytes": 8450048,
"scriptDurationMs": 535.813,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2034.2180000000099,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.837000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.4370000000001,
"heapDeltaBytes": 6291616,
"heapUsedBytes": 66970600,
"domNodes": -278,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 114.221,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.9209999999775,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.699999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.664,
"heapDeltaBytes": 6168544,
"heapUsedBytes": 66771000,
"domNodes": -278,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 133.021,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 670.9389999999757,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.791,
"heapDeltaBytes": -11526256,
"heapUsedBytes": 56551992,
"domNodes": 18,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 126.53699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.5340000000906,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.216,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.24000000000007,
"heapDeltaBytes": -11548788,
"heapUsedBytes": 56476220,
"domNodes": 18,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 120.32900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.9669999999655,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.894,
"heapDeltaBytes": 3780184,
"heapUsedBytes": 71756620,
"domNodes": 18,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 20.484,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.9160000000093,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.55300000000005,
"heapDeltaBytes": 3665444,
"heapUsedBytes": 71874944,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 12.524000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.8229999999776,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.87199999999999,
"layouts": 16,
"layoutDurationMs": 4.627,
"taskDurationMs": 874.0000000000001,
"heapDeltaBytes": -18898888,
"heapUsedBytes": 49270328,
"domNodes": -275,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 97.94999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1685.752999999977,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.79599999999999,
"layouts": 16,
"layoutDurationMs": 4.224,
"taskDurationMs": 824.299,
"heapDeltaBytes": -5437592,
"heapUsedBytes": 62407992,
"domNodes": 63,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 103.009,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7729999999347,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.90799999999999,
"layouts": 14,
"layoutDurationMs": 12.768999999999998,
"taskDurationMs": 959.4529999999999,
"heapDeltaBytes": 29139276,
"heapUsedBytes": 98910904,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 34.91599999999999,
"eventListeners": 2371,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8918.109000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5286.965,
"heapDeltaBytes": 14338588,
"heapUsedBytes": 75978932,
"domNodes": -274,
"jsHeapTotalBytes": 9936896,
"scriptDurationMs": 1736.3719999999998,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.723000000042,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.64099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4545.476000000001,
"heapDeltaBytes": 26153952,
"heapUsedBytes": 85927296,
"domNodes": -276,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 1423.06,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17053.870000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17037.536,
"heapDeltaBytes": -42640832,
"heapUsedBytes": 167130848,
"domNodes": -8312,
"jsHeapTotalBytes": -11472896,
"scriptDurationMs": 554.47,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17256.161000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17237.965000000004,
"heapDeltaBytes": -36447976,
"heapUsedBytes": 167094972,
"domNodes": -8312,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 565.868,
"eventListeners": -16386,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21136.02099999997,
"styleRecalcs": 148,
"styleRecalcDurationMs": 20.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21109.670000000002,
"heapDeltaBytes": -43456416,
"heapUsedBytes": 164364028,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 920.8290000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 373,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20843.71599999997,
"styleRecalcs": 143,
"styleRecalcDurationMs": 17.19799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20795.601000000002,
"heapDeltaBytes": -58912832,
"heapUsedBytes": 168364724,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 872.25,
"eventListeners": -16383,
"totalBlockingTimeMs": 258,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.42600000000766,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.96,
"layouts": 2,
"layoutDurationMs": 0.43399999999999994,
"taskDurationMs": 118.03500000000001,
"heapDeltaBytes": -15900144,
"heapUsedBytes": 51091192,
"domNodes": 132,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 10.915000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 478.3899999999903,
"styleRecalcs": 13,
"styleRecalcDurationMs": 22.586000000000002,
"layouts": 4,
"layoutDurationMs": 1.284,
"taskDurationMs": 128.76999999999998,
"heapDeltaBytes": -16121904,
"heapUsedBytes": 51069052,
"domNodes": 117,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 11.826,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
…w flag rides the existing frame loop
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/onboarding/onboardingTourStore.ts`:
- Around line 130-137: The next-step entry flow must not continue to tracking
after a non-abort onEnter failure. Update the onEnter catch handling in the
onboarding tour progression logic to surface a user-friendly actionable error
and stop or skip the tour, or propagate the rejection to the caller; ensure
trackTour('step_shown') is reached only after successful entry setup.
- Around line 207-217: Update begin() to track a unique pending run/token before
awaiting the tour definition, then verify it remains current before resolving or
assigning steps; stale completions must return false without resurrecting a
tour. In finish(), invalidate the pending token so dismissed tours cannot be
restored. Catch factory failures in begin(), invoke the existing user-visible
error handling with an actionable message, and return false instead of allowing
rejected auto-open promises to become unhandled.
In `@src/platform/onboarding/TourSpotlight.vue`:
- Around line 14-20: Update the dialog positioning transition near the card
element in TourSpotlight so its left/top easing is disabled when targetMoves is
true, matching the spotlight behavior. Preserve the existing 300ms transition
for stationary targets and leave unrelated transitions unchanged.
In `@src/platform/onboarding/useCoachmarkTarget.test.ts`:
- Around line 62-80: Extend the motion behavior test around useCoachmarkTarget
to cover a CoachStep without the follow property. Assert that targetMoves.value
is false for this step, while preserving the existing true assertion for follow:
true, so the disabled-motion branch is covered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1bdc38b0-4f88-4d2e-a6c5-ba9371c7ab42
📒 Files selected for processing (8)
src/platform/onboarding/TourSpotlight.vuesrc/platform/onboarding/coachmarkRegistry.test.tssrc/platform/onboarding/coachmarkRegistry.tssrc/platform/onboarding/onboardingTourStore.tssrc/platform/onboarding/onboardingTours.tssrc/platform/onboarding/useCoachmarkTarget.test.tssrc/platform/onboarding/useCoachmarkTarget.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
| if (nextStep.onEnter) { | ||
| try { | ||
| await nextStep.onEnter(signal) | ||
| } catch (error) { | ||
| if (!signal.aborted) console.error('coachmark onEnter failed', error) | ||
| } | ||
| if (signal.aborted) return | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not mark a failed entry hook as shown.
A non-abort onEnter rejection is only logged, then execution falls through to trackTour('step_shown'). The user can be shown a step whose setup failed. Surface an actionable error and stop/skip the tour without marking it seen, or propagate the failure to the caller.
As per coding guidelines, source code must provide user-friendly actionable error messages and proper error propagation.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/onboarding/onboardingTourStore.ts` around lines 130 - 137, The
next-step entry flow must not continue to tracking after a non-abort onEnter
failure. Update the onEnter catch handling in the onboarding tour progression
logic to surface a user-friendly actionable error and stop or skip the tour, or
propagate the rejection to the caller; ensure trackTour('step_shown') is reached
only after successful entry setup.
Source: Coding guidelines
| async function begin(entryPath: EntryPath): Promise<boolean> { | ||
| if (steps.value.length) return false | ||
| const definition = TOURS[entryPath] | ||
| const built = Array.isArray(definition) ? definition : await definition() | ||
| if (steps.value.length) return false | ||
| const resolved = resolveSteps(built, targetMounted) | ||
| if (!resolved.length) return false | ||
| steps.value = resolved | ||
| activeTour.value = entryPath | ||
| trackTour('started') | ||
| void showStep(0) |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Make async tour resolution stale-safe and failure-safe.
While a factory is pending, steps remains empty, so another begin() can start too. If one tour finishes before the slower factory resolves, the late result passes Line 211 and resurrects the dismissed tour. A rejected factory also becomes an unhandled rejection because auto-open calls void startTour(...).
Track a pending run/token, invalidate it from finish(), ignore stale completions, and catch factory failures before returning false with user-visible error handling.
As per coding guidelines, source code must provide user-friendly actionable error messages and proper error propagation.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/onboarding/onboardingTourStore.ts` around lines 207 - 217,
Update begin() to track a unique pending run/token before awaiting the tour
definition, then verify it remains current before resolving or assigning steps;
stale completions must return false without resurrecting a tour. In finish(),
invalidate the pending token so dismissed tours cannot be restored. Catch
factory failures in begin(), invoke the existing user-visible error handling
with an actionable message, and return false instead of allowing rejected
auto-open promises to become unhandled.
Source: Coding guidelines
| :class=" | ||
| cn( | ||
| 'pointer-events-none absolute rounded-xl shadow-[0_0_0_9999px_var(--color-coach-scrim)] outline-2 outline-coach-ring', | ||
| !targetMoves && | ||
| 'motion-safe:transition-[left,top,width,height,opacity] motion-safe:duration-300' | ||
| ) | ||
| " |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Disable card easing for followed targets too.
The spotlight stops transitioning, but the dialog at Line 35 still transitions left,top for 300ms. During node motion it continuously lags behind the target while Floating UI updates it every frame.
Proposed fix
- class="pointer-events-auto absolute max-h-[calc(100vh-var(--comfy-topbar-height)-2rem)] overflow-y-auto motion-safe:transition-[left,top] motion-safe:duration-300"
+ :class="
+ cn(
+ 'pointer-events-auto absolute max-h-[calc(100vh-var(--comfy-topbar-height)-2rem)] overflow-y-auto',
+ !targetMoves &&
+ 'motion-safe:transition-[left,top] motion-safe:duration-300'
+ )
+ "🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/onboarding/TourSpotlight.vue` around lines 14 - 20, Update the
dialog positioning transition near the card element in TourSpotlight so its
left/top easing is disabled when targetMoves is true, matching the spotlight
behavior. Preserve the existing 300ms transition for stationary targets and
leave unrelated transitions unchanged.
| it('reports motion only for a step that declares it', () => { | ||
| const el = laidOut() | ||
| registerCoachmark('outputs', el) | ||
| const scope = effectScope() | ||
| const api = scope.run(() => | ||
| useCoachmarkTarget( | ||
| () => | ||
| ({ | ||
| name: 's', | ||
| coachId: 'outputs', | ||
| placement: 'right', | ||
| follow: true | ||
| }) as CoachStep, | ||
| ref(null) | ||
| ) | ||
| )! | ||
| expect(api.targetMoves.value).toBe(true) | ||
| scope.stop() | ||
| }) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Cover the follow-absent branch.
This only proves targetMoves === true; add a step without follow and assert false. Otherwise a regression that enables animation-frame tracking and disables transitions for every step passes unnoticed.
As per path instructions, Vitest coverage must include the disabled-motion edge case when follow is absent.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/onboarding/useCoachmarkTarget.test.ts` around lines 62 - 80,
Extend the motion behavior test around useCoachmarkTarget to cover a CoachStep
without the follow property. Assert that targetMoves.value is false for this
step, while preserving the existing true assertion for follow: true, so the
disabled-motion branch is covered.
Source: Path instructions
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14293 +/- ##
==========================================
- Coverage 79.28% 77.83% -1.45%
==========================================
Files 1754 1761 +7
Lines 101615 103068 +1453
Branches 34155 35103 +948
==========================================
- Hits 80561 80219 -342
- Misses 20621 22374 +1753
- Partials 433 475 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 309 files with indirect coverage changes 🚀 New features to boost your workflow:
|
0c28138 to
fa5336c
Compare
fa5336c to
c757a88
Compare
|
Collapsed into #14298 — the stack merges as one PR. |
Summary
Canvas nodes need no target machinery in the engine: the tour registers the elements it targets through the existing
registerCoachmark, the canvas is locked while a tour runs, the camera flight duringonEnteris tracked by thedeferTargetsettle loop that has always been there, and tour definitions build synchronously — the engine's per-framewaitForTargetpolling absorbs any waiting.Changes
onEnter?(signal)onCoachStep(awaited beforestep_shown, abort-aware); lazyTourDefinition(CoachStep[] | () => CoachStep[], built at start, fully sync); thestartTour/beginsplit replacing theforceboolean;wheneveron the trigger watch.Review Focus
followflag + transition CSS, async definitions + their race guard, andcomplete()(next()on the last step already completes). Each removal reused something that already existed.