Repository navigation
refactor(onboarding): canvas nodes are ordinary coachmark targets #14293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
9897739
feat: add product coachmark onboarding tours
pythongosssss cc74e1d
add assets step to app mode tour
pythongosssss 75af043
- change dialog to use standard component
pythongosssss f80deb9
[automated] Apply ESLint and Oxfmt fixes
actions-user f642384
change dash stroke to solid
pythongosssss 5e23f76
fix: address coachmark tour review feedback
pythongosssss c51f963
trim comments
pythongosssss e9729ca
drop blankCanvas tour
pythongosssss f973626
improve test coverage
pythongosssss 5dbb560
refactor + tidy
pythongosssss 88cd848
fix test
pythongosssss fdfa988
feat: make app-mode tour explicit-only and refine assets step
pythongosssss 5118212
feat: auto-open app-mode tour for populated apps
pythongosssss 07356e3
tidy
pythongosssss b65da23
refactor: slim coachmark target tracking and spotlight chrome
pythongosssss 87d0a11
fix: close the coachmark landing on Escape explicitly
pythongosssss a818b7e
test: open the template browser in the coachmark drift guard
pythongosssss 9b8dd27
refactor: gate coachmark tour listeners behind an active-step component
pythongosssss 5383e23
Merge origin/main into pysssss/product-coachmarks
pythongosssss 3f84d4f
test: cover forced tour start, button labels, and spotlight escape
pythongosssss 64d10da
refactor: place coachmark cards with Floating UI
pythongosssss 831813a
fix: stop coachmark spotlight polling once its target settles
pythongosssss ce8b107
fix: correct coachmark tour skip telemetry and one-shot forcing
pythongosssss 2312b21
refactor: address coachmark tour review feedback
pythongosssss 96c2ae1
feat: add landing image to the app-mode tour
pythongosssss 549200a
fix: address coachmark tour stacking, telemetry, and fixture review n…
pythongosssss e97746f
refactor: address coachmark tour PR feedback
pythongosssss e7cdfc8
chore: ignore derived coachmark keys in the unused-i18n check
pythongosssss 9bcfda8
refactor: reconcile v-coachmark from the element's own data-coach-id
pythongosssss 76abe8e
Merge branch 'main' into pysssss/product-coachmarks
pythongosssss bb39a51
fix: narrow the coachmark i18n exemption to derived step keys
pythongosssss 7630cc9
fix: use the generic Skip label on the coachmark tour landing
pythongosssss 61756e9
fix missing modal backdrop
pythongosssss 9a71b54
refactor: move the coachmark tour state machine into a Pinia store
pythongosssss ccb3cd4
fix: restore the coachmark landing's md max-width
pythongosssss 9730850
fix: keep the coachmark tour alive when outputs clear
pythongosssss 25ce1eb
Merge remote-tracking branch 'origin/main' into pysssss/product-coach…
pythongosssss f1f7c53
feat: rework coachmark assets step and add step-back navigation
pythongosssss 7df585e
flush -> nextTick
pythongosssss 3f5b71a
refactor: use reka FocusScope for coachmark focus trapping
pythongosssss cb1be63
decrease padding
pythongosssss 66b9f32
update wording
pythongosssss dff76db
make button grow, match design
pythongosssss 62806d5
Merge branch 'main' into pysssss/product-coachmarks
pythongosssss 13fd072
Merge branch 'main' into pysssss/product-coachmarks
AustinMroz 62bb4d4
Merge remote-tracking branch 'origin/main' into pysssss/product-coach…
MaanilVerma e9caa31
test(onboarding): fix the coachmark drift-guard's assets-tab selector
MaanilVerma fcd151d
feat(onboarding): accept virtual coachmark targets
MaanilVerma b8c7035
feat(onboarding): add step onEnter hooks and async tour resolvers
MaanilVerma daef85f
feat(onboarding): mask-based scrim for interactive steps
MaanilVerma 44a383e
feat(first-run-tour): resolve canvas nodes as coachmark targets
MaanilVerma 1389a48
refactor(first-run-tour): drop the unused canvas union rect
MaanilVerma 76d612c
refactor(onboarding): spotlight one target, drop the unused extra mas…
MaanilVerma 0f93f63
refactor(first-run-tour): map canvas targets with litegraph's own camera
MaanilVerma 2b4516e
Merge main
AustinMroz 613ab51
Merge branch 'pysssss/product-coachmarks' into feat/tour-engine-canva…
MaanilVerma c671e33
Merge main (again)
AustinMroz 45b1e53
refactor(onboarding): follow the camera instead of polling the target
MaanilVerma 1cfccec
refactor(onboarding): position the card from the target itself
MaanilVerma 9a5d2be
refactor(onboarding): target canvas nodes by selector, not camera maths
MaanilVerma 08306cf
refactor(onboarding): the engine follows selector targets, nothing an…
deepme987 eb210bf
refactor(onboarding): nodes self-register through vCoachmark; a follo…
deepme987 49d5ccb
refactor(onboarding): strip the engine to what the graph tour consumes
deepme987 f1e371e
refactor(onboarding): drop the per-node directive; tours register the…
deepme987 eece6c8
Merge branch 'main' into deepme987/onboarding/selector-targets-lite
deepme987 c757a88
refactor(onboarding): the canvas is locked during a tour, nothing fol…
deepme987 c679194
refactor(onboarding): next on the last step already completes
deepme987 069aa16
refactor(onboarding): tour definitions build synchronously
deepme987 03082ec
refactor(onboarding): whenever reads the trigger intent directly
deepme987 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not mark a failed entry hook as shown.
A non-abort
onEnterrejection is only logged, then execution falls through totrackTour('step_shown'). The user can be shown a step whose setup failed. Surface an actionable error and stop/skip the tour without marking it seen, or propagate the failure to the caller.As per coding guidelines, source code must provide user-friendly actionable error messages and proper error propagation.
🤖 Prompt for AI Agents
Source: Coding guidelines