Skip to content

feat(onboarding): Getting Started takeover for first-run candidates - #14295

Closed
deepme987 wants to merge 10 commits into
deepme987/onboarding/selector-targets-litefrom
deepme987/onboarding/getting-started-lite
Closed

deepme987 wants to merge 10 commits into
deepme987/onboarding/selector-targets-litefrom
deepme987/onboarding/getting-started-lite

Conversation

@deepme987

@deepme987 deepme987 commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Lean rebuild of #14141 (2/6, on #14293). Startup stops burning Comfy.TutorialCompleted before the user chooses anything; fresh first-run candidates get a four-card curated takeover instead of the template browser.

Changes

  • What: loadDefaultWorkflow → resolveStartupOutcome returning restored | fresh | url-intent (Maanil's refactor kept verbatim — it fixes reload-before-choosing stranding you as a returning user); useFirstRunEntry routes fresh → takeover for candidates (cloud + ≥md + subscriptions on + isNewUser() === true + onboarding_tour_enabled flag) or Comfy.BrowseTemplates otherwise; dismiss is the single writer of TutorialCompleted, on a real user action; an 88-line screen reusing DefaultThumbnail/Loader/Button/FocusScope.
  • Bug found in QA and fixed here: hasV2DraftHistory counted the startup-created temporary draft as prior use, so a new user who bounced once was permanently disqualified on their next visit (invisible on main only because startup burned TutorialCompleted anyway). Temporary drafts no longer count; the old test fixture had the bug codified and is now split into kept-draft vs temp-only cases.

Review Focus

  • Cut vs feat(first-run-tour): add the Getting Started screen #14141 (964 → ~370): the Tutorials tab, both card components, skeleton/retry/failure states (failure = toast, clicking again is the retry; empty catalog dismisses), FALLBACK_TEMPLATE_IDS backfill, the wrapper component, the 185-line screen test.
  • A sub-100 variant exists (drop the screen; candidates get the template browser, candidacy recorded) at the cost of the curated-cards moment — product call, documented.
  • To test locally: clear site data, set localStorage['ff:onboarding_tour_enabled'] = 'true' before reloading, ensure Comfy.TutorialCompleted is false on the account, reload — the takeover shows on fresh startups and keeps showing on bounce (no pick, no dismissal) until a real choice is made. Locale keys are en-only by convention; the version-bump i18n workflow backfills the other 13, with fallbackLocale: 'en' in the meantime.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8b792978-e757-4f65-aa4a-d0a44683abc7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/30/2026, 01:10:56 AM UTC

Links

🎭 Playwright: ✅ 1755 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1734 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 142ms TBT · 96.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.4 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 218ms TBT · 156.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 517ms
canvas-idle: script duration 17ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.6 MB
canvas-idle: DOM nodes 19
canvas-idle: event listeners 5
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 845ms
canvas-mouse-sweep: script duration 123ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 56.4 MB
canvas-mouse-sweep: DOM nodes -109
canvas-mouse-sweep: event listeners -72
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 395ms
canvas-zoom-sweep: script duration 22ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 391ms
dom-widget-clipping: script duration 60ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 694ms
large-graph-idle: script duration 115ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.7 MB
large-graph-idle: DOM nodes -275
large-graph-idle: event listeners -144
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1326ms
large-graph-pan: script duration 464ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 58.4 MB
large-graph-pan: DOM nodes -279
large-graph-pan: event listeners -143
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1535ms
large-graph-zoom: script duration 535ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 55.8 MB
large-graph-zoom: DOM nodes -283
large-graph-zoom: event listeners -148
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 721ms
minimap-idle: script duration 121ms
minimap-idle: TBT 0ms
minimap-idle: heap used 63.8 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -144
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 417ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.5 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 498ms
subgraph-idle: script duration 16ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.0 MB
subgraph-idle: DOM nodes -127
subgraph-idle: event listeners -72
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 773ms
subgraph-mouse-sweep: script duration 92ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.6 MB
subgraph-mouse-sweep: DOM nodes 63
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1047ms
subgraph-transition-enter: script duration 40ms
subgraph-transition-enter: TBT 142ms
subgraph-transition-enter: heap used 96.1 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2371
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4892ms
viewport-pan-sweep: script duration 1608ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.9 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -127
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17198ms
vue-large-graph-idle: script duration 585ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 159.4 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16388
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 141
vue-large-graph-pan: task duration 20485ms
vue-large-graph-pan: script duration 906ms
vue-large-graph-pan: TBT 218ms
vue-large-graph-pan: heap used 156.7 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16384
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 117ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 48.6 MB
workflow-execution: DOM nodes 125
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-07-30T01:03:53.786Z",
  "gitSha": "dea0af7198a40b1662266af1fe452801e24de3b6",
  "branch": "deepme987/onboarding/getting-started-lite",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2118.088,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.088000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.1899999999999,
      "heapDeltaBytes": 3787892,
      "heapUsedBytes": 72002552,
      "domNodes": 16,
      "jsHeapTotalBytes": 20049920,
      "scriptDurationMs": 17.463,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2049.993000000029,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.850999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.974,
      "heapDeltaBytes": 3947084,
      "heapUsedBytes": 71892580,
      "domNodes": 22,
      "jsHeapTotalBytes": 20312064,
      "scriptDurationMs": 16.192999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1824.247999999983,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 37.942,
      "layouts": 12,
      "layoutDurationMs": 3.514,
      "taskDurationMs": 850.961,
      "heapDeltaBytes": -16695188,
      "heapUsedBytes": 51449672,
      "domNodes": -275,
      "jsHeapTotalBytes": 22274048,
      "scriptDurationMs": 121.824,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1855.5000000000064,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 39.675000000000004,
      "layouts": 12,
      "layoutDurationMs": 3.649,
      "taskDurationMs": 838.6270000000001,
      "heapDeltaBytes": -1243264,
      "heapUsedBytes": 66840860,
      "domNodes": 58,
      "jsHeapTotalBytes": 20836352,
      "scriptDurationMs": 124.22500000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.4639999999927,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 17.532,
      "layouts": 6,
      "layoutDurationMs": 0.5299999999999999,
      "taskDurationMs": 386.409,
      "heapDeltaBytes": 7239268,
      "heapUsedBytes": 75309472,
      "domNodes": 78,
      "jsHeapTotalBytes": 20574208,
      "scriptDurationMs": 21.239,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1772.4339999999756,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.655,
      "layouts": 6,
      "layoutDurationMs": 0.7279999999999999,
      "taskDurationMs": 403.215,
      "heapDeltaBytes": 7195784,
      "heapUsedBytes": 75213528,
      "domNodes": 78,
      "jsHeapTotalBytes": 20049920,
      "scriptDurationMs": 22.7,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 611.6309999999885,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.671999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.409,
      "heapDeltaBytes": -12071716,
      "heapUsedBytes": 55859404,
      "domNodes": 18,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 59.025999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 594.8070000000598,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.271,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 392.56699999999995,
      "heapDeltaBytes": -11985808,
      "heapUsedBytes": 55865172,
      "domNodes": 18,
      "jsHeapTotalBytes": 21360640,
      "scriptDurationMs": 60.963,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.6600000000262,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.200999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 703.486,
      "heapDeltaBytes": 7164756,
      "heapUsedBytes": 65763160,
      "domNodes": -273,
      "jsHeapTotalBytes": 4780032,
      "scriptDurationMs": 117.35199999999999,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2049.396999999999,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.476,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 685.2969999999998,
      "heapDeltaBytes": 6806996,
      "heapUsedBytes": 65635148,
      "domNodes": -277,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 112.21600000000001,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2172.1860000000106,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.865999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1364.2779999999998,
      "heapDeltaBytes": 6490856,
      "heapUsedBytes": 66610024,
      "domNodes": -278,
      "jsHeapTotalBytes": 5246976,
      "scriptDurationMs": 494.077,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2156.509000000028,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.892000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1288.06,
      "heapDeltaBytes": -4632956,
      "heapUsedBytes": 55836312,
      "domNodes": -279,
      "jsHeapTotalBytes": 5828608,
      "scriptDurationMs": 434.44200000000006,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3195.9130000000187,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.365999999999996,
      "layouts": 60,
      "layoutDurationMs": 7.464,
      "taskDurationMs": 1560.846,
      "heapDeltaBytes": -1641860,
      "heapUsedBytes": 59994372,
      "domNodes": -283,
      "jsHeapTotalBytes": 7139328,
      "scriptDurationMs": 532.6379999999999,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3176.819999999907,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.976000000000003,
      "layouts": 60,
      "layoutDurationMs": 7.455000000000001,
      "taskDurationMs": 1509.803,
      "heapDeltaBytes": -4526824,
      "heapUsedBytes": 56975740,
      "domNodes": -283,
      "jsHeapTotalBytes": 7663616,
      "scriptDurationMs": 538.3149999999999,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.7880000000346,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.749,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 724.491,
      "heapDeltaBytes": 5847688,
      "heapUsedBytes": 66613864,
      "domNodes": -276,
      "jsHeapTotalBytes": 5566464,
      "scriptDurationMs": 122.746,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.889999999933,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.835000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 718.4590000000002,
      "heapDeltaBytes": 6679852,
      "heapUsedBytes": 67209772,
      "domNodes": -278,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 119.023,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 610.6809999999996,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 14.346,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.263,
      "heapDeltaBytes": -12133384,
      "heapUsedBytes": 55929020,
      "domNodes": 20,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 122.185,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 572.5180000000591,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.899,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.729,
      "heapDeltaBytes": -11837236,
      "heapUsedBytes": 56188252,
      "domNodes": 18,
      "jsHeapTotalBytes": 21622784,
      "scriptDurationMs": 117.94999999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.474000000026,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.697000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.535,
      "heapDeltaBytes": -20270576,
      "heapUsedBytes": 47714532,
      "domNodes": -273,
      "jsHeapTotalBytes": 20963328,
      "scriptDurationMs": 17.462,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.8020000000406,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.987999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.81800000000004,
      "heapDeltaBytes": 3829816,
      "heapUsedBytes": 71777988,
      "domNodes": 20,
      "jsHeapTotalBytes": 20574208,
      "scriptDurationMs": 13.563999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.0759999999486,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 38.023,
      "layouts": 16,
      "layoutDurationMs": 4.26,
      "taskDurationMs": 780.523,
      "heapDeltaBytes": -5597548,
      "heapUsedBytes": 62358800,
      "domNodes": 63,
      "jsHeapTotalBytes": 20836352,
      "scriptDurationMs": 94.315,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1700.3879999999754,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.372,
      "layouts": 16,
      "layoutDurationMs": 4.373,
      "taskDurationMs": 764.504,
      "heapDeltaBytes": -5629072,
      "heapUsedBytes": 62637124,
      "domNodes": 62,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 89.527,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.8959999999847,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.45999999999999,
      "layouts": 14,
      "layoutDurationMs": 13.082,
      "taskDurationMs": 1047.0279999999998,
      "heapDeltaBytes": 9030476,
      "heapUsedBytes": 100733384,
      "domNodes": 13673,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 40.18000000000001,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8648.359999999968,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 37.839,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4991.86,
      "heapDeltaBytes": 16166172,
      "heapUsedBytes": 75518016,
      "domNodes": -274,
      "jsHeapTotalBytes": 12820480,
      "scriptDurationMs": 1683.846,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8607.724999999959,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.455,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4792.031,
      "heapDeltaBytes": 12293560,
      "heapUsedBytes": 71145384,
      "domNodes": -277,
      "jsHeapTotalBytes": 8101888,
      "scriptDurationMs": 1531.3020000000001,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17202.05900000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17165.512,
      "heapDeltaBytes": -50379712,
      "heapUsedBytes": 167575116,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14880768,
      "scriptDurationMs": 572.1109999999999,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17279.033000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17230.911,
      "heapDeltaBytes": -59856360,
      "heapUsedBytes": 166754864,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13828096,
      "scriptDurationMs": 597.923,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20773.932,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 17.61400000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20725.251,
      "heapDeltaBytes": -62025060,
      "heapUsedBytes": 164536244,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16449536,
      "scriptDurationMs": 906.2280000000001,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20289.96099999995,
      "styleRecalcs": 138,
      "styleRecalcDurationMs": 16.75500000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20244.354000000003,
      "heapDeltaBytes": -43942132,
      "heapUsedBytes": 164183388,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15405056,
      "scriptDurationMs": 904.8269999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 202,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 458.5119999999847,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 22.67,
      "layouts": 2,
      "layoutDurationMs": 0.38600000000000007,
      "taskDurationMs": 116.352,
      "heapDeltaBytes": -15871340,
      "heapUsedBytes": 51129416,
      "domNodes": 130,
      "jsHeapTotalBytes": 7991296,
      "scriptDurationMs": 9.848999999999998,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.83900000000267,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 20.322999999999997,
      "layouts": 3,
      "layoutDurationMs": 0.619,
      "taskDurationMs": 118.256,
      "heapDeltaBytes": -16176500,
      "heapUsedBytes": 50826312,
      "domNodes": 119,
      "jsHeapTotalBytes": 7729152,
      "scriptDurationMs": 10.627999999999998,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@codecov

codecov Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.45055% with 46 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rstRunTour/gettingStarted/GettingStartedScreen.vue 15.00% 34 Missing ⚠️
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 82.14% 5 Missing ⚠️
...ersistence/composables/useWorkflowPersistenceV2.ts 76.92% 3 Missing ⚠️
src/components/graph/GraphCanvas.vue 0.00% 2 Missing ⚠️
src/composables/useFeatureFlags.ts 33.33% 2 Missing ⚠️
@@                              Coverage Diff                               @@
##           deepme987/onboarding/selector-targets-lite   #14295      +/-   ##
==============================================================================
- Coverage                                       77.83%   77.68%   -0.15%     
==============================================================================
  Files                                            1761     1760       -1     
  Lines                                          103068   102265     -803     
  Branches                                        35103    34927     -176     
==============================================================================
- Hits                                            80219    79441     -778     
+ Misses                                          22374    22348      -26     
- Partials                                          475      476       +1     
Flag Coverage Δ
unit 69.45% <49.45%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/platform/workflow/persistence/base/draftTypes.ts 100.00% <ø> (ø)
...ns/firstRunTour/gettingStarted/curatedTemplates.ts 100.00% <100.00%> (ø)
src/services/useNewUserService.ts 100.00% <100.00%> (+1.63%) ⬆️
src/views/GraphView.vue 73.82% <100.00%> (+0.35%) ⬆️
src/components/graph/GraphCanvas.vue 64.86% <0.00%> (-0.64%) ⬇️
src/composables/useFeatureFlags.ts 77.58% <33.33%> (-1.18%) ⬇️
...ersistence/composables/useWorkflowPersistenceV2.ts 89.50% <76.92%> (+2.78%) ⬆️
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 82.14% <82.14%> (ø)
...rstRunTour/gettingStarted/GettingStartedScreen.vue 15.00% <15.00%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…rgets-lite' into deepme987/onboarding/getting-started-lite
@deepme987
deepme987 force-pushed the deepme987/onboarding/selector-targets-lite branch from fa5336c to c757a88 Compare July 29, 2026 23:09
@deepme987

Copy link
Copy Markdown
Contributor Author

Collapsed into #14298 — the stack merges as one PR.

@deepme987 deepme987 closed this Jul 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants