Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1755 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-07-30T01:03:53.786Z",
"gitSha": "dea0af7198a40b1662266af1fe452801e24de3b6",
"branch": "deepme987/onboarding/getting-started-lite",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2118.088,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.088000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.1899999999999,
"heapDeltaBytes": 3787892,
"heapUsedBytes": 72002552,
"domNodes": 16,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 17.463,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2049.993000000029,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.850999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.974,
"heapDeltaBytes": 3947084,
"heapUsedBytes": 71892580,
"domNodes": 22,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 16.192999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.247999999983,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.942,
"layouts": 12,
"layoutDurationMs": 3.514,
"taskDurationMs": 850.961,
"heapDeltaBytes": -16695188,
"heapUsedBytes": 51449672,
"domNodes": -275,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 121.824,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.5000000000064,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.675000000000004,
"layouts": 12,
"layoutDurationMs": 3.649,
"taskDurationMs": 838.6270000000001,
"heapDeltaBytes": -1243264,
"heapUsedBytes": 66840860,
"domNodes": 58,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 124.22500000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.4639999999927,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.532,
"layouts": 6,
"layoutDurationMs": 0.5299999999999999,
"taskDurationMs": 386.409,
"heapDeltaBytes": 7239268,
"heapUsedBytes": 75309472,
"domNodes": 78,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 21.239,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1772.4339999999756,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.655,
"layouts": 6,
"layoutDurationMs": 0.7279999999999999,
"taskDurationMs": 403.215,
"heapDeltaBytes": 7195784,
"heapUsedBytes": 75213528,
"domNodes": 78,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 22.7,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 611.6309999999885,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.671999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.409,
"heapDeltaBytes": -12071716,
"heapUsedBytes": 55859404,
"domNodes": 18,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 59.025999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.8070000000598,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.271,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.56699999999995,
"heapDeltaBytes": -11985808,
"heapUsedBytes": 55865172,
"domNodes": 18,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 60.963,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2039.6600000000262,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.200999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.486,
"heapDeltaBytes": 7164756,
"heapUsedBytes": 65763160,
"domNodes": -273,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 117.35199999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2049.396999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.476,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.2969999999998,
"heapDeltaBytes": 6806996,
"heapUsedBytes": 65635148,
"domNodes": -277,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 112.21600000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2172.1860000000106,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.865999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1364.2779999999998,
"heapDeltaBytes": 6490856,
"heapUsedBytes": 66610024,
"domNodes": -278,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 494.077,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2156.509000000028,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.892000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1288.06,
"heapDeltaBytes": -4632956,
"heapUsedBytes": 55836312,
"domNodes": -279,
"jsHeapTotalBytes": 5828608,
"scriptDurationMs": 434.44200000000006,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3195.9130000000187,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.365999999999996,
"layouts": 60,
"layoutDurationMs": 7.464,
"taskDurationMs": 1560.846,
"heapDeltaBytes": -1641860,
"heapUsedBytes": 59994372,
"domNodes": -283,
"jsHeapTotalBytes": 7139328,
"scriptDurationMs": 532.6379999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3176.819999999907,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.976000000000003,
"layouts": 60,
"layoutDurationMs": 7.455000000000001,
"taskDurationMs": 1509.803,
"heapDeltaBytes": -4526824,
"heapUsedBytes": 56975740,
"domNodes": -283,
"jsHeapTotalBytes": 7663616,
"scriptDurationMs": 538.3149999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.7880000000346,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.749,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.491,
"heapDeltaBytes": 5847688,
"heapUsedBytes": 66613864,
"domNodes": -276,
"jsHeapTotalBytes": 5566464,
"scriptDurationMs": 122.746,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2028.889999999933,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.835000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.4590000000002,
"heapDeltaBytes": 6679852,
"heapUsedBytes": 67209772,
"domNodes": -278,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 119.023,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.6809999999996,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.263,
"heapDeltaBytes": -12133384,
"heapUsedBytes": 55929020,
"domNodes": 20,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 122.185,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.5180000000591,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.729,
"heapDeltaBytes": -11837236,
"heapUsedBytes": 56188252,
"domNodes": 18,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 117.94999999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.474000000026,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.535,
"heapDeltaBytes": -20270576,
"heapUsedBytes": 47714532,
"domNodes": -273,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 17.462,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2004.8020000000406,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.987999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.81800000000004,
"heapDeltaBytes": 3829816,
"heapUsedBytes": 71777988,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 13.563999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.0759999999486,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.023,
"layouts": 16,
"layoutDurationMs": 4.26,
"taskDurationMs": 780.523,
"heapDeltaBytes": -5597548,
"heapUsedBytes": 62358800,
"domNodes": 63,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 94.315,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.3879999999754,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.372,
"layouts": 16,
"layoutDurationMs": 4.373,
"taskDurationMs": 764.504,
"heapDeltaBytes": -5629072,
"heapUsedBytes": 62637124,
"domNodes": 62,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 89.527,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.8959999999847,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.45999999999999,
"layouts": 14,
"layoutDurationMs": 13.082,
"taskDurationMs": 1047.0279999999998,
"heapDeltaBytes": 9030476,
"heapUsedBytes": 100733384,
"domNodes": 13673,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 40.18000000000001,
"eventListeners": 2371,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8648.359999999968,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4991.86,
"heapDeltaBytes": 16166172,
"heapUsedBytes": 75518016,
"domNodes": -274,
"jsHeapTotalBytes": 12820480,
"scriptDurationMs": 1683.846,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8607.724999999959,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4792.031,
"heapDeltaBytes": 12293560,
"heapUsedBytes": 71145384,
"domNodes": -277,
"jsHeapTotalBytes": 8101888,
"scriptDurationMs": 1531.3020000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17202.05900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17165.512,
"heapDeltaBytes": -50379712,
"heapUsedBytes": 167575116,
"domNodes": -8312,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 572.1109999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17279.033000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17230.911,
"heapDeltaBytes": -59856360,
"heapUsedBytes": 166754864,
"domNodes": -8312,
"jsHeapTotalBytes": -13828096,
"scriptDurationMs": 597.923,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20773.932,
"styleRecalcs": 143,
"styleRecalcDurationMs": 17.61400000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20725.251,
"heapDeltaBytes": -62025060,
"heapUsedBytes": 164536244,
"domNodes": -8312,
"jsHeapTotalBytes": -16449536,
"scriptDurationMs": 906.2280000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 233,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20289.96099999995,
"styleRecalcs": 138,
"styleRecalcDurationMs": 16.75500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20244.354000000003,
"heapDeltaBytes": -43942132,
"heapUsedBytes": 164183388,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 904.8269999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 202,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.5119999999847,
"styleRecalcs": 13,
"styleRecalcDurationMs": 22.67,
"layouts": 2,
"layoutDurationMs": 0.38600000000000007,
"taskDurationMs": 116.352,
"heapDeltaBytes": -15871340,
"heapUsedBytes": 51129416,
"domNodes": 130,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 9.848999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 468.83900000000267,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.322999999999997,
"layouts": 3,
"layoutDurationMs": 0.619,
"taskDurationMs": 118.256,
"heapDeltaBytes": -16176500,
"heapUsedBytes": 50826312,
"domNodes": 119,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 10.627999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## deepme987/onboarding/selector-targets-lite #14295 +/- ##
==============================================================================
- Coverage 77.83% 77.68% -0.15%
==============================================================================
Files 1761 1760 -1
Lines 103068 102265 -803
Branches 35103 34927 -176
==============================================================================
- Hits 80219 79441 -778
+ Misses 22374 22348 -26
- Partials 475 476 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…rgets-lite' into deepme987/onboarding/getting-started-lite
fa5336c to
c757a88
Compare
…987/onboarding/getting-started-lite
…rgets-lite' into deepme987/onboarding/getting-started-lite
…rgets-lite' into deepme987/onboarding/getting-started-lite
|
Collapsed into #14298 — the stack merges as one PR. |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Summary
Lean rebuild of #14141 (2/6, on #14293). Startup stops burning
Comfy.TutorialCompletedbefore the user chooses anything; fresh first-run candidates get a four-card curated takeover instead of the template browser.Changes
loadDefaultWorkflow→resolveStartupOutcomereturningrestored | fresh | url-intent(Maanil's refactor kept verbatim — it fixes reload-before-choosing stranding you as a returning user);useFirstRunEntryroutesfresh→ takeover for candidates (cloud + ≥md + subscriptions on +isNewUser() === true+onboarding_tour_enabledflag) orComfy.BrowseTemplatesotherwise;dismissis the single writer ofTutorialCompleted, on a real user action; an 88-line screen reusingDefaultThumbnail/Loader/Button/FocusScope.hasV2DraftHistorycounted the startup-created temporary draft as prior use, so a new user who bounced once was permanently disqualified on their next visit (invisible on main only because startup burnedTutorialCompletedanyway). Temporary drafts no longer count; the old test fixture had the bug codified and is now split into kept-draft vs temp-only cases.Review Focus
FALLBACK_TEMPLATE_IDSbackfill, the wrapper component, the 185-line screen test.localStorage['ff:onboarding_tour_enabled'] = 'true'before reloading, ensureComfy.TutorialCompletedis false on the account, reload — the takeover shows on fresh startups and keeps showing on bounce (no pick, no dismissal) until a real choice is made. Locale keys are en-only by convention; the version-bump i18n workflow backfills the other 13, withfallbackLocale: 'en'in the meantime.