Skip to content

refactor(assets): remove isCloud guards in widget composables (FE-731) - #12375

Closed
dante01yoon wants to merge 4 commits into
jaewon/fe-730-l13-l1-store-remove-iscloud-forks-in-assetsstore-no-fallbackfrom
jaewon/fe-731-l14-l1-widgets-remove-iscloud-guards-in-usecombowidget
Closed

dante01yoon wants to merge 4 commits into
jaewon/fe-730-l13-l1-store-remove-iscloud-forks-in-assetsstore-no-fallbackfrom
jaewon/fe-731-l14-l1-widgets-remove-iscloud-guards-in-usecombowidget

Conversation

@dante01yoon

@dante01yoon dante01yoon commented May 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

FE-731 (L1.4 — widget composables). With both Cloud and OSS serving /api/assets post-BE-786, useComboWidget and useAssetWidgetData collapse to a single asset-aware code path — no more isCloud short-circuits, no Cloud-only docstrings.

Draft — do not merge until BE-786 + FE-729 + FE-730 land.

Changes

src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.ts

  • Drop the isCloud import and the if (isCloud) { ... } wrapper in addComboWidget. The shouldUseAssetBrowser branch and the NODE_MEDIA_TYPE_MAP (LoadImage / LoadVideo / LoadAudio) branch now run unconditionally; eligibility is decided per-node by assetService.shouldUseAssetBrowser and the media-type map, not by distribution.
  • Rename resolveCloudDefault → resolveAssetDefault and update the docstring/comment to drop the "cloud" qualifier — the helper resolves against assetsStore.getAssets(nodeType) on either backend.

src/renderer/extensions/vueNodes/widgets/composables/useAssetWidgetData.ts

  • Remove the isCloud import and the outer if (isCloud) { ... } else { empty-data fallback } branch. The body (category lookup, asset list, loading/error refs, lazy updateModelsForNodeType watcher) now runs unconditionally.
  • Drop the "Cloud-only composable - returns empty data when not in cloud environment" line from the JSDoc.

src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts

  • Drop the hoisted mockDistributionState toggle, the @/platform/distribution/types mock, and 11 per-test mockDistributionState.isCloud = ... assignments.
  • Delete the should create normal combo widget for LoadImage in OSS test — it asserted the removed isCloud=false short-circuit (LoadImage falling through to the standard combo path); the new behavior routes LoadImage through createInputMappingWidget on both backends, which is covered by the existing input-mapping suite.
  • Rename setupCloudAssetWidget → setupAssetBrowserWidget and drop "cloud" / "in cloud" qualifiers from describe/it titles. Non-eligible-combo coverage (shouldUseAssetBrowser returns false → server inputSpec.options used) remains.

src/renderer/extensions/vueNodes/widgets/composables/useAssetWidgetData.test.ts

  • Drop the @/platform/distribution/types mock; the (cloud mode, isCloud=true) qualifier removed from the describe title.

src/renderer/extensions/vueNodes/widgets/composables/useAssetWidgetData.desktop.test.ts — deleted. The file's only test (returns empty/default values without calling stores under isCloud=false) verified a branch that no longer exists.

Review Focus

  • The asset-aware code paths now activate purely from per-node signals (shouldUseAssetBrowser, NODE_MEDIA_TYPE_MAP) — no distribution gate. This is the intended M1 shape; no temporary fallback / feature flag was added (per the no-flags decision).
  • resolveAssetDefault keeps the existing Cloud policy: prefer inputSpec.default if it's in the asset library, otherwise assets[0], otherwise placeholder. Server-provided inputSpec.options are intentionally ignored on asset-aware widgets to avoid missing-model errors on undo/reload — same behavior Cloud has been running with.
  • For non-asset-aware combos (shouldUseAssetBrowser=false, not in NODE_MEDIA_TYPE_MAP), the standard combo path is unchanged and still uses inputSpec.options. Covered by should create normal combo widget when asset browser is not eligible.

Dependencies

  • Blocks-merge: BE-786 — OSS asset routes unconditionally registered. Until this lands + the CI container bumps, OSS e2e shards will see empty asset lists on widgets that now route through the asset path.
  • Stacked on: FE-730 / PR #12335 — this PR's base is jaewon/fe-730-..., not main. Merge order: FE-729 → FE-730 → FE-731.
  • Coordinates with: BE-978 / PR #13994 on ComfyUI — OSS tag-shape alignment. Required for the diffusers / nested-path category lookup to behave correctly through the now-unconditional asset path. Not blocking-merge for this PR but required for OSS smoke-test parity at the FE-601 close.

Done when

  • isCloud guards removed from both files.
  • Asset combo widget renders without distribution gating.
  • "Cloud-only" docstring removed.
  • Composable / component tests updated (no isCloud mocks).
  • pnpm typecheck clean; pnpm test:unit on the two target specs — 25 tests pass.
  • OSS smoke verified locally (see below). Full CI e2e still gated on BE-786 merge + container bump.

OSS smoke test (ComfyUI master + --enable-assets, 2026-05-20)

Verified manually against a local ComfyUI master launched with python main.py --cpu --listen 127.0.0.1 --port 8189 --enable-assets --database-url sqlite:///:memory:. Vite dev server running this PR's worktree (jaewon/fe-731-..., commit 9b9b0f245) with DEV_SERVER_COMFYUI_URL=http://127.0.0.1:8189. /api/features confirms "assets": true.

# Scenario Touched by FE-731 Network / DOM evidence Result
1 Page load with saved workflow (Load Image node hydrated, example.png bound) createInputMappingWidget triggered during hydration GET /api/assets?include_tags=input&limit=100&exclude_tags=missing&include_public=false → 200 (reqid=1728) ✅
2 app.graph.clear() → assetsStore.$patch({ inputAssets: [], inputLoading: false }) → LiteGraph.createNode('LoadImage') + graph.add() on empty canvas direct trigger of createInputMappingWidget → updateInputs() lazy load GET /api/assets?include_tags=input&... → 200 (reqid=1768, new call after store reset). Widget breakdown: image (type=combo, values: []) + upload (type=button) — exactly createInputMappingWidget + useImageUploadWidget output ✅
3 CheckpointLoaderSimple rendered on canvas shouldUseAssetBrowser=true → createAssetBrowserWidget path (was isCloud-gated) Vue render tree: WidgetSelect modelValue="Select model" widget={type:"asset", spec.type:"COMBO"}. GET /api/assets?include_tags=models&limit=500&exclude_tags=missing → 200 (reqid=1757/1760) ✅
4 Click "Select image…" button on Load Image Asset Browser modal opens with All/Imported/Generated tabs — Cloud-style UX now active on OSS Modal DOM with tabs + example.png asset card (input asset); GET /api/jobs?status=completed,failed,cancelled&limit=200&offset=0 → 200 (reqid=1762, history fetch for the All/Generated tab — existing modal logic, not new from FE-731) ✅
5 Asset cache gating works (createInputMappingWidget skips updateInputs when inputAssets.length > 0) guard at useComboWidget.ts:170 After scenario 2's fetch populated the store, adding a second Load Image issued no extra /api/assets?include_tags=input call ✅
6 Non-asset combo regression check — KSampler sampler_name, scheduler not touched — shouldUseAssetBrowser=false, not in NODE_MEDIA_TYPE_MAP Falls through to standard node.addWidget('combo', …, { values: inputSpec.options }); no /api/assets request for these widgets ✅

What this proves

  • ✅ useComboWidget routes LoadImage through createInputMappingWidget on OSS — updateInputs() lazy load fires on first node add, and is correctly skipped on subsequent adds while the store is populated.
  • ✅ useAssetWidgetData and createAssetBrowserWidget activate for model widgets on OSS — WidgetSelect renders type: "asset" with category lookup via assetsStore.getAssets().
  • ✅ Standard combos (sampler_name, scheduler) remain on the non-asset path — no regression.
  • ⚠️ This is a manual smoke against a local ComfyUI master without BE-786. CI e2e shards still need the OSS container bump.

Refs

┆Issue is synchronized with this Notion page by Unito

- useComboWidget: drop the `if (isCloud)` wrap so shouldUseAssetBrowser
  and NODE_MEDIA_TYPE_MAP paths run unconditionally. Rename
  resolveCloudDefault -> resolveAssetDefault.
- useAssetWidgetData: drop the `if (isCloud)` branch and its empty-data
  fallback; remove the "Cloud-only" docstring.
- Tests: drop the isCloud mock + per-test toggles. Delete the
  isCloud=false desktop spec and the OSS LoadImage fall-through case
  that asserted the now-removed branch.
@coderabbitai

coderabbitai Bot commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a2cd3126-e5d1-4534-901d-7724b2fe6a02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaewon/fe-731-l14-l1-widgets-remove-iscloud-guards-in-usecombowidget

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 20, 2026
@codecov

codecov Bot commented May 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ons/vueNodes/widgets/composables/useComboWidget.ts 54.54% 5 Missing ⚠️
@@                                              Coverage Diff                                               @@
##           jaewon/fe-730-l13-l1-store-remove-iscloud-forks-in-assetsstore-no-fallback   #12375      +/-   ##
==============================================================================================================
- Coverage                                                                       62.17%   62.14%   -0.03%     
==============================================================================================================
  Files                                                                            1458     1458              
  Lines                                                                           75012    74992      -20     
  Branches                                                                        19494    21116    +1622     
==============================================================================================================
- Hits                                                                            46637    46604      -33     
- Misses                                                                          28031    28044      +13     
  Partials                                                                          344      344              
Flag Coverage Δ
unit 62.14% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vueNodes/widgets/composables/useAssetWidgetData.ts 100.00% <100.00%> (ø)
...ons/vueNodes/widgets/composables/useComboWidget.ts 54.54% <54.54%> (-15.62%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dante01yoon added a commit that referenced this pull request May 26, 2026
Align with the L1 stack pattern (FE-729 #12322 / FE-730 #12335 / FE-731 #12375
/ FE-732 #12417): the Generated tab now resolves to `useFlatOutputAssetsGrouped()`
unconditionally. OSS reaches the same asset-API path as cloud once BE-786 lands
and `_ASSETS_ENABLED` is no longer a gate; no transitional fallback is kept, in
line with FE-730's "no temporary isCloud fallback" stance.

FE-740
dante01yoon added a commit that referenced this pull request Jun 2, 2026
…ed feature-flag test infra

Per review (DrJKL): mockFeatureFlags and the exported FeatureFlags type have no live consumer in the open stack — FE-729~732 (#12322/#12335/#12375/#12417) don't use them, and FE-780/781 (#12485/#12486) still hand-roll inline vi.hoisted mocks. Shipping them here adds a public surface with no caller, so split them out; they'll be reintroduced bundled with the first PR that actually adopts the util.

This PR is now scoped to the getAssetStoredFilename extraction, which is consumed at its two call sites in useMediaAssetActions.

Retained-code review fixes:
- M3: spread importOriginal in the distribution/types mock so isDesktop and isNightly survive the wholesale replacement.
- L2: trim getAssetStoredFilename JSDoc; demote the BE-933/934 collapse to a one-line TODO.

Removed: src/test-utils/mockFeatureFlags.ts, the FeatureFlags type export, and its knip ignore entry. Pre-split state preserved on local branch jaewon/fe-733-presplit-snapshot.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dante01yoon added a commit that referenced this pull request Jun 2, 2026
…ed feature-flag test infra

Per review (DrJKL): mockFeatureFlags and the exported FeatureFlags type have no live consumer in the open stack — FE-729~732 (#12322/#12335/#12375/#12417) don't use them, and FE-780/781 (#12485/#12486) still hand-roll inline vi.hoisted mocks. Shipping them here adds a public surface with no caller, so split them out; they'll be reintroduced bundled with the first PR that actually adopts the util.

This PR is now scoped to the getAssetStoredFilename extraction, which is consumed at its two call sites in useMediaAssetActions.

Retained-code review fixes:
- M3: spread importOriginal in the distribution/types mock so isDesktop and isNightly survive the wholesale replacement.
- L2: trim getAssetStoredFilename JSDoc; demote the BE-933/934 collapse to a one-line TODO.

Removed: src/test-utils/mockFeatureFlags.ts, the FeatureFlags type export, and its knip ignore entry. Pre-split state preserved on local branch jaewon/fe-733-presplit-snapshot.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mathtone pushed a commit to sketchyplans/ComfyUI-frontend-fork1 that referenced this pull request Jun 17, 2026
…fy-Org#12287)

## Summary

L1 prerequisite cleanup, scoped to a single type-preserving refactor:
extract `getAssetStoredFilename(asset)` to collapse the duplicated
`isCloud && asset.asset_hash ? asset.asset_hash : asset.name` branch
from `useMediaAssetActions.ts` into one helper in
`assetMetadataUtils.ts`. No behavior change.

Once BE-933/934 emit `file_path` and the cloud spec sync brings the
field into generated types, only the helper internals change (collapse
to `asset.file_path ?? asset.name`).

## Scope change (per review)

The `mockFeatureFlags` test util and the exported `FeatureFlags` type
that this PR originally also added have been **split out**. They had no
live consumer in the open stack — FE-729~732 (Comfy-Org#12322 / Comfy-Org#12335 / Comfy-Org#12375 /
Comfy-Org#12417) don't use them, and FE-780 / FE-781 (Comfy-Org#12485 / Comfy-Org#12486) still
hand-roll inline `vi.hoisted` mocks — so shipping them here would add a
public surface with no caller. They will be reintroduced bundled with
the first PR that actually adopts the util, where `featureFlag`'s return
type and the "all flags off vs. production defaults" semantics can be
validated against a real consumer.

## Review fixes carried in this PR

- Mock `@/platform/distribution/types` via an `importOriginal` spread so
`isDesktop` / `isNightly` survive the wholesale replacement (only
`isCloud` was re-hoisted before).
- Trimmed the `getAssetStoredFilename` JSDoc; the BE-933/934
future-collapse is now a one-line `TODO` rather than a design-doc
paragraph.

## Review Focus

- The helper is intentionally named `getAssetStoredFilename` to
disambiguate from the existing `getAssetFilename` (which targets
`user_metadata.filename` / `metadata.filename` for serialized-identifier
contexts — missing-model matching, filename schema validation) and
`getAssetDisplayFilename` (UI labels). Folding the `isCloud &&
asset_hash` fallback into either of those would regress
display/identifier sites where the cloud hash is never meant to surface.

- Fixes FE-733
- Parent: FE-601 (L1 umbrella)
- RFC: [Asset Identity
Semantics](https://www.notion.so/comfy-org/RFC-Asset-Identity-Semantics-35a6d73d365080e59d59c98cebae779b)
- Survey: [Asset FE Divergence Survey M1
Scope](https://www.notion.so/comfy-org/Assets-FE-Divergence-Survey-M1-Scope-3616d73d365080d0a9cbf5f2394c12f8)
- Slack thread:
https://comfy-organization.slack.com/archives/C0AUUTS2RQV/p1778815571949519

## Screenshots (if applicable)

N/A — no UI change.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12287-refactor-assets-extract-getAssetStoredFilename-helper-add-mockFeatureFlags-test-util-3616d73d365081c9a1c6e1982728a38a)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Matt Miller <matt@miller-media.com>
…tsstore-no-fallback' into jaewon/fe-731-l14-l1-widgets-remove-iscloud-guards-in-usecombowidget
@github-actions

github-actions Bot commented Jun 18, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 146ms TBT · 94.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.5 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 350ms
canvas-idle: script duration 26ms
canvas-idle: TBT 0ms
canvas-idle: heap used 54.1 MB
canvas-idle: DOM nodes 21
canvas-idle: event listeners 5
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 757ms
canvas-mouse-sweep: script duration 123ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 55.7 MB
canvas-mouse-sweep: DOM nodes 57
canvas-mouse-sweep: event listeners 4
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 295ms
canvas-zoom-sweep: script duration 24ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 57.8 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 10ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 330ms
dom-widget-clipping: script duration 61ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 57.6 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 10ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 11
large-graph-idle: task duration 474ms
large-graph-idle: script duration 90ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 59.5 MB
large-graph-idle: DOM nodes 21
large-graph-idle: event listeners 5
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 17ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 975ms
large-graph-pan: script duration 376ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.6 MB
large-graph-pan: DOM nodes -129
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 18ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1206ms
large-graph-zoom: script duration 458ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.6 MB
large-graph-zoom: DOM nodes 15
large-graph-zoom: event listeners 8
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 456ms
minimap-idle: script duration 83ms
minimap-idle: TBT 0ms
minimap-idle: heap used 59.1 MB
minimap-idle: DOM nodes -129
minimap-idle: event listeners -92
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 351ms
subgraph-dom-widget-clipping: script duration 122ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 63.4 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 338ms
subgraph-idle: script duration 17ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 53.8 MB
subgraph-idle: DOM nodes 20
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 34ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 636ms
subgraph-mouse-sweep: script duration 90ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 47.9 MB
subgraph-mouse-sweep: DOM nodes 65
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 711ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 146ms
subgraph-transition-enter: heap used 94.1 MB
subgraph-transition-enter: DOM nodes 13833
subgraph-transition-enter: event listeners 2529
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 52ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 252
viewport-pan-sweep: task duration 3456ms
viewport-pan-sweep: script duration 1182ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 63.8 MB
viewport-pan-sweep: DOM nodes -122
viewport-pan-sweep: event listeners -78
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11324ms
vue-large-graph-idle: script duration 553ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.5 MB
vue-large-graph-idle: DOM nodes -27
vue-large-graph-idle: event listeners -6
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 65
vue-large-graph-pan: task duration 13652ms
vue-large-graph-pan: script duration 853ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 164.3 MB
vue-large-graph-pan: DOM nodes -27
vue-large-graph-pan: event listeners -3
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 23ms
workflow-execution: layout count 5
workflow-execution: style recalc count 20
workflow-execution: task duration 127ms
workflow-execution: script duration 22ms
workflow-execution: TBT 0ms
workflow-execution: heap used 56.2 MB
workflow-execution: DOM nodes 175
workflow-execution: event listeners 69
Raw data
{
  "timestamp": "2026-06-18T03:32:38.956Z",
  "gitSha": "59b1ea5ea527313f47280786f2f7a77fd9525b50",
  "branch": "jaewon/fe-731-l14-l1-widgets-remove-iscloud-guards-in-usecombowidget",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2022.1439999999689,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.969,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 343.818,
      "heapDeltaBytes": -2044424,
      "heapUsedBytes": 56715720,
      "domNodes": 22,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 22.115000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.3409999999458,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.234000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 356.299,
      "heapDeltaBytes": -1907336,
      "heapUsedBytes": 56674828,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 29.523,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1887.0200000000068,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 38.275,
      "layouts": 12,
      "layoutDurationMs": 3.702,
      "taskDurationMs": 812.207,
      "heapDeltaBytes": -8018500,
      "heapUsedBytes": 50859000,
      "domNodes": 58,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 126.29800000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1758.8779999999815,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 33.515,
      "layouts": 12,
      "layoutDurationMs": 3.1010000000000004,
      "taskDurationMs": 700.9139999999999,
      "heapDeltaBytes": 15194956,
      "heapUsedBytes": 65896164,
      "domNodes": 55,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 120.12299999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.0859999999902,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.873999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.568,
      "taskDurationMs": 295.209,
      "heapDeltaBytes": 1896640,
      "heapUsedBytes": 60491436,
      "domNodes": 79,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 24.255,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.7249999999922,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.754999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.5939999999999999,
      "taskDurationMs": 295.602,
      "heapDeltaBytes": 2020328,
      "heapUsedBytes": 60684360,
      "domNodes": 79,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 24.477,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 530.5940000000078,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.258,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 324.31,
      "heapDeltaBytes": 4453692,
      "heapUsedBytes": 54855468,
      "domNodes": 22,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 61.238,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 590.8620000000155,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 11.202000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.257,
      "heapDeltaBytes": 7532740,
      "heapUsedBytes": 66023768,
      "domNodes": 22,
      "jsHeapTotalBytes": 18874368,
      "scriptDurationMs": 61.476000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2019.549999999981,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.826,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.183,
      "heapDeltaBytes": -9993844,
      "heapUsedBytes": 63067748,
      "domNodes": 22,
      "jsHeapTotalBytes": 12988416,
      "scriptDurationMs": 88.856,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1994.3379999999706,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.297,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.543,
      "heapDeltaBytes": -8501860,
      "heapUsedBytes": 61802692,
      "domNodes": 20,
      "jsHeapTotalBytes": 11153408,
      "scriptDurationMs": 90.18599999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2117.322999999999,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 18.755000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1003.1479999999999,
      "heapDeltaBytes": 11253080,
      "heapUsedBytes": 82646688,
      "domNodes": 20,
      "jsHeapTotalBytes": 11853824,
      "scriptDurationMs": 391.351,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2064.3010000000004,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.653999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 947.168,
      "heapDeltaBytes": 27224620,
      "heapUsedBytes": 82182512,
      "domNodes": -277,
      "jsHeapTotalBytes": 1515520,
      "scriptDurationMs": 361.471,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3033.2239999999615,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 17.887999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.137999999999999,
      "taskDurationMs": 1205.8,
      "heapDeltaBytes": 14062756,
      "heapUsedBytes": 79708948,
      "domNodes": 14,
      "jsHeapTotalBytes": 17620992,
      "scriptDurationMs": 457.30699999999996,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3032.169000000067,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 18.944999999999997,
      "layouts": 60,
      "layoutDurationMs": 6.885,
      "taskDurationMs": 1205.3660000000002,
      "heapDeltaBytes": 12802504,
      "heapUsedBytes": 68359380,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 458.345,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.257999999998,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.597999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.61,
      "heapDeltaBytes": 6019136,
      "heapUsedBytes": 59158180,
      "domNodes": -278,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 84.089,
      "eventListeners": -189,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.1300000000274,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.488,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.51599999999996,
      "heapDeltaBytes": -9157744,
      "heapUsedBytes": 64687020,
      "domNodes": 20,
      "jsHeapTotalBytes": 7483392,
      "scriptDurationMs": 82.22600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 548.0000000000018,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.857,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.46299999999997,
      "heapDeltaBytes": 7508124,
      "heapUsedBytes": 66401308,
      "domNodes": 20,
      "jsHeapTotalBytes": 19660800,
      "scriptDurationMs": 124.395,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 583.4019999999782,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.732999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.665,
      "heapDeltaBytes": 7490176,
      "heapUsedBytes": 66574272,
      "domNodes": 22,
      "jsHeapTotalBytes": 19660800,
      "scriptDurationMs": 119.774,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.387000000008,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.634,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.62800000000004,
      "heapDeltaBytes": -2598720,
      "heapUsedBytes": 56276340,
      "domNodes": 20,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 16.357999999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.8170000000455,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.463999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.73199999999997,
      "heapDeltaBytes": -2400376,
      "heapUsedBytes": 56521196,
      "domNodes": 20,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 17.459,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.2090000000107,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 33.473000000000006,
      "layouts": 16,
      "layoutDurationMs": 3.5509999999999997,
      "taskDurationMs": 634.8000000000001,
      "heapDeltaBytes": -11593660,
      "heapUsedBytes": 52379432,
      "domNodes": 64,
      "jsHeapTotalBytes": 24178688,
      "scriptDurationMs": 91.254,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.9740000000593,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 33.799,
      "layouts": 16,
      "layoutDurationMs": 3.5620000000000003,
      "taskDurationMs": 636.636,
      "heapDeltaBytes": -10826888,
      "heapUsedBytes": 48047704,
      "domNodes": 66,
      "jsHeapTotalBytes": 26476544,
      "scriptDurationMs": 89.688,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 948.851999999988,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 27.265000000000004,
      "layouts": 5,
      "layoutDurationMs": 13.949000000000003,
      "taskDurationMs": 710.9960000000002,
      "heapDeltaBytes": 32222720,
      "heapUsedBytes": 98646324,
      "domNodes": 13833,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 26.372000000000007,
      "eventListeners": 2529,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8147.900999999991,
      "styleRecalcs": 252,
      "styleRecalcDurationMs": 52.418000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3445.4159999999997,
      "heapDeltaBytes": -16731028,
      "heapUsedBytes": 66417600,
      "domNodes": -266,
      "jsHeapTotalBytes": 9756672,
      "scriptDurationMs": 1189.594,
      "eventListeners": -175,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8148.45600000001,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 52.358000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3466.602,
      "heapDeltaBytes": -3881064,
      "heapUsedBytes": 67366980,
      "domNodes": 22,
      "jsHeapTotalBytes": 17620992,
      "scriptDurationMs": 1174.446,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11304.895000000044,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11292.151,
      "heapDeltaBytes": -8867168,
      "heapUsedBytes": 167183872,
      "domNodes": -27,
      "jsHeapTotalBytes": 15962112,
      "scriptDurationMs": 567.834,
      "eventListeners": -6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11384.348000000045,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11355.007000000001,
      "heapDeltaBytes": 102644,
      "heapUsedBytes": 165155648,
      "domNodes": -27,
      "jsHeapTotalBytes": 14651392,
      "scriptDurationMs": 537.3969999999999,
      "eventListeners": -6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13934.089000000085,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.810999999999991,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13912.064999999999,
      "heapDeltaBytes": -7353196,
      "heapUsedBytes": 168863044,
      "domNodes": -29,
      "jsHeapTotalBytes": 16486400,
      "scriptDurationMs": 823.504,
      "eventListeners": -2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13412.928999999964,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.519000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13391.473999999998,
      "heapDeltaBytes": 17818548,
      "heapUsedBytes": 175693804,
      "domNodes": -25,
      "jsHeapTotalBytes": 13254656,
      "scriptDurationMs": 881.5360000000001,
      "eventListeners": -4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.85200000008354,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 25.534000000000002,
      "layouts": 5,
      "layoutDurationMs": 1.4969999999999999,
      "taskDurationMs": 139.541,
      "heapDeltaBytes": -14903312,
      "heapUsedBytes": 52590972,
      "domNodes": 192,
      "jsHeapTotalBytes": 8187904,
      "scriptDurationMs": 22.433,
      "eventListeners": 69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.64600000002065,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 21.148,
      "layouts": 5,
      "layoutDurationMs": 1.2329999999999999,
      "taskDurationMs": 114.013,
      "heapDeltaBytes": 5239632,
      "heapUsedBytes": 65340420,
      "domNodes": 157,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 21.439,
      "eventListeners": 69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 06/18/2026, 03:23:42 AM UTC

Links

🎭 Playwright: ❌ 1408 passed, 129 failed · 2 flaky

❌ Failed Tests

📊 Browser Reports

…e-iscloud-forks-in-assetsstore-no-fallback' into HEAD

# Conflicts:
#	src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts
#	src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.ts

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel multi-agent review (8 reviewers: bug-hunter, regression-risk, test-quality, vue-patterns, api-contract, architecture, error-handling, dx-readability). Reviewed against the stacked base jaewon/fe-730-.... No public API breakage (the resolveCloudDefault->resolveAssetDefault rename is module-private; consumers are gated). One finding worth a close look (the input-mapping default, flagged by 4 of 8 reviewers and tracing to a named prior bugfix) plus a test-coverage note; the rest are minor/nit.

This is a Draft PR, so treating all of these as non-blocking pre-merge feedback.

additional (architecture, non-blocking, file not in diff): src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue:51 still forks on distribution: const outputMediaAssets = isCloud ? useFlatOutputAssets() : useAssetsApi('output'), sitting one line above the now-unconditional useAssetWidgetData(toRef(nodeType)). After FE-731 the model-asset path is per-node while the output-media path beside it is still per-distribution, so the residual isCloud reads like an oversight next to a deliberately de-clouded composable. If output-media unification is a later L1 ticket, a tracking ref would make the intent clear; otherwise it could move behind a service seam matching how shouldUseAssetBrowser hides the model-side decision.

)
}
if (NODE_MEDIA_TYPE_MAP[node.comfyClass ?? '']) {
return createInputMappingWidget(node, inputSpec, defaultValue)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: createInputMappingWidget is now seeded with the raw defaultValue (getDefaultValue(inputSpec) = inputSpec.default ?? options[0], a server filename) instead of the deleted resolveCloudInputDefault, which mapped the default onto an actual input-asset hash (else ''). The widget's dynamic values list (bindDynamicValuesOption) still exposes only asset.hash, so a freshly added LoadImage/LoadVideo/LoadAudio node gets seeded with a value that is not a member of its own option set: broken selection highlight, and on serialize/undo/reload it persists a filename the asset path cannot map back to a hash. That is the exact missing-model-on-reload case commit 4bfb0c3 "Fix Cloud media input defaults (#12562)" (2026-06-04) fixed. The surviving test masks it because it uses hash-shaped options[0].

Could the input-mapping path resolve the default against inputAssets (a resolveInputAssetDefault(node.comfyClass, inputSpec.default) mirroring the deleted helper), the way the adjacent asset-browser branch does via resolveAssetDefault? Or is the divergence intentional? If intentional, a one-line comment plus a regression test (a LoadImage default absent from the asset library should start empty, not as a server filename) would pin the contract.

expect.any(Function),
expect.objectContaining({
values: [],
values: [], // Empty initially, populated via dynamic getter

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: two coverage gaps survive the rewrite. (1) The options.values getter for input-mapping widgets (media-type filter + asset.hash extraction + null-hash drop) still runs unconditionally in production, but the suite only asserts values: [] at construction here and never reads the getter back with a populated inputAssets store. (2) The new raw-default passthrough into createInputMappingWidget is only covered for the options[0] case. Consider a behavioral test that populates inputAssets (mixed media types + one empty-hash asset) and asserts the getter exposes only the matching, non-empty hashes, plus input-mapping cases for an explicit default and the no-default/no-options ('') fallback.


const isLoading = assetsStore.isModelLoading(currentNodeType)
const hasBeenInitialized = assetsStore.hasAssetKey(currentNodeType)
watch(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note (non-blocking): removing the empty-data fallback means this watcher now runs updateModelsForNodeType on OSS too. That is not an unhandled rejection (the store catches the fetch error into state.error and the composable re-exposes it via error), but the consumer (useWidgetSelectItems) never reads error/isLoading - so pre-BE-786, a failed or empty OSS fetch renders an empty "Select model" dropdown with no error or retry affordance. Is the empty-dropdown UX acceptable for the pre-BE-786 window, or worth surfacing the error/loading state downstream?

}

const mockDistributionState = vi.hoisted(() => ({ isCloud: false }))
// Use vi.hoisted() to ensure mock state is initialized before mocks

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (non-blocking): this comment is vestigial - the mockDistributionState = vi.hoisted(...) toggle it described was deleted, and the remaining vi.hoisted() calls hoist for the ordinary mock-factory-reference reason. A few other added comments (lines 86, 105, 396, 419, 431) also paraphrase the next line. Per AGENTS.md (explain why, not what) these could be dropped.

@@ -234,7 +228,7 @@ describe('useComboWidget', () => {
createMockAssetItem({ name: 'cloud_model.safetensors' })

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (non-blocking): lone surviving cloud_model.safetensors literal after the systematic cloud_* -> asset_* rename in this file; asset_model.safetensors would keep the fixtures consistent.

DrJKL added a commit that referenced this pull request Jul 6, 2026
)

## Summary

L1 prerequisite cleanup, scoped to a single type-preserving refactor:
extract `getAssetStoredFilename(asset)` to collapse the duplicated
`isCloud && asset.asset_hash ? asset.asset_hash : asset.name` branch
from `useMediaAssetActions.ts` into one helper in
`assetMetadataUtils.ts`. No behavior change.

Once BE-933/934 emit `file_path` and the cloud spec sync brings the
field into generated types, only the helper internals change (collapse
to `asset.file_path ?? asset.name`).

## Scope change (per review)

The `mockFeatureFlags` test util and the exported `FeatureFlags` type
that this PR originally also added have been **split out**. They had no
live consumer in the open stack — FE-729~732 (#12322 / #12335 / #12375 /
#12417) don't use them, and FE-780 / FE-781 (#12485 / #12486) still
hand-roll inline `vi.hoisted` mocks — so shipping them here would add a
public surface with no caller. They will be reintroduced bundled with
the first PR that actually adopts the util, where `featureFlag`'s return
type and the "all flags off vs. production defaults" semantics can be
validated against a real consumer.

## Review fixes carried in this PR

- Mock `@/platform/distribution/types` via an `importOriginal` spread so
`isDesktop` / `isNightly` survive the wholesale replacement (only
`isCloud` was re-hoisted before).
- Trimmed the `getAssetStoredFilename` JSDoc; the BE-933/934
future-collapse is now a one-line `TODO` rather than a design-doc
paragraph.

## Review Focus

- The helper is intentionally named `getAssetStoredFilename` to
disambiguate from the existing `getAssetFilename` (which targets
`user_metadata.filename` / `metadata.filename` for serialized-identifier
contexts — missing-model matching, filename schema validation) and
`getAssetDisplayFilename` (UI labels). Folding the `isCloud &&
asset_hash` fallback into either of those would regress
display/identifier sites where the cloud hash is never meant to surface.

- Fixes FE-733
- Parent: FE-601 (L1 umbrella)
- RFC: [Asset Identity
Semantics](https://www.notion.so/comfy-org/RFC-Asset-Identity-Semantics-35a6d73d365080e59d59c98cebae779b)
- Survey: [Asset FE Divergence Survey M1
Scope](https://www.notion.so/comfy-org/Assets-FE-Divergence-Survey-M1-Scope-3616d73d365080d0a9cbf5f2394c12f8)
- Slack thread:
https://comfy-organization.slack.com/archives/C0AUUTS2RQV/p1778815571949519

## Screenshots (if applicable)

N/A — no UI change.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12287-refactor-assets-extract-getAssetStoredFilename-helper-add-mockFeatureFlags-test-util-3616d73d365081c9a1c6e1982728a38a)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Matt Miller <matt@miller-media.com>
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
@christian-byrne

christian-byrne commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Closed — retiring the FE-729→732 chain in favour of a fresh re-cut

Closing this chain (#12322, #12335, #12375, #12417 — Linear FE-729, FE-730, FE-731, FE-732) by agreement between @dante01yoon, @synap5e and @christian-byrne (Slack, 2026-07-23). This is not an abandonment of the work — the L1 isCloud / isAssetAPIEnabled teardown is still wanted. It is a decision to re-cut it fresh from main once the assets-sidebar stack lands, rather than rebase four branches whose premise has shifted underneath them.

Why re-cut rather than rebase. First, the premise was overtaken. The chain exists to delete Comfy.Assets.UseAssetAPI and the isCloud forks, but #13464 adds a sibling flag Comfy.ModelLibrary.UseAssetBrowser in the very block #12322 removes, plus new isCloud branches in modelStore.ts. A rebase would have to delete code that doesn't exist yet and re-open a design decision that just went the other way. Second, assetsStore.ts is a head-on collision: #12335 is +346/−395 in that file while #12948 is +416/−366 — two near-complete rewrites of the same file, with 13 files overlapping across the two stacks. Drift compounds it: #12322 is 246 commits behind main, #12417 is 320.

The blocker underneath all of it: BE-786 never landed. #12322 patches CI to start ComfyUI with --enable-assets because FE-729 routes modelStore through assetService, which 503s without it — and main's .github/actions/start-comfyui-server/action.yaml still does not pass that flag. So the chain was never merge-eligible regardless of conflicts, and the same dependency will block the re-cut. BE-786 (Core serving /api/assets by default, tracked in core as ComfyUI#14699) needs to land, or be explicitly scheduled, before the re-cut is scoped. Related context: the assets-panel rewire (FE-740 / #12464) faces the same gating fork, and the dialog-architecture work has its own track in #13558.

The full diff is preserved on each PR as the specification of intent — please read these branches rather than re-deriving the approach when the re-cut is scoped. @dante01yoon to be looped back in at that point.


Salvage note — this is the one to start from. Unlike the rest of the chain, this PR's five files (useAssetWidgetData.ts, useComboWidget.ts and their tests) have zero overlap with the incoming assets-sidebar stack, and it was already approved. It is the cleanest candidate to re-cut as a standalone patch from main, and it does not depend on BE-786 the way #12322 does. One known follow-up to carry across: useComboWidget.ts seeds createInputMappingWidget with a raw server filename (getDefaultValue(inputSpec)) instead of the asset-hash mapping the deleted resolveCloudInputDefault provided — that needs fixing in the re-cut, not just porting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants