Skip to content

refactor(assets): extract getAssetStoredFilename helper (FE-733) - #12287

Merged
christian-byrne merged 11 commits into
mainfrom
jaewon/fe-733-extract-stored-filename-helper
Jun 16, 2026
Merged

christian-byrne merged 11 commits into
mainfrom
jaewon/fe-733-extract-stored-filename-helper

Conversation

@dante01yoon

@dante01yoon dante01yoon commented May 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

L1 prerequisite cleanup, scoped to a single type-preserving refactor: extract getAssetStoredFilename(asset) to collapse the duplicated isCloud && asset.asset_hash ? asset.asset_hash : asset.name branch from useMediaAssetActions.ts into one helper in assetMetadataUtils.ts. No behavior change.

Once BE-933/934 emit file_path and the cloud spec sync brings the field into generated types, only the helper internals change (collapse to asset.file_path ?? asset.name).

Scope change (per review)

The mockFeatureFlags test util and the exported FeatureFlags type that this PR originally also added have been split out. They had no live consumer in the open stack — FE-729~732 (#12322 / #12335 / #12375 / #12417) don't use them, and FE-780 / FE-781 (#12485 / #12486) still hand-roll inline vi.hoisted mocks — so shipping them here would add a public surface with no caller. They will be reintroduced bundled with the first PR that actually adopts the util, where featureFlag's return type and the "all flags off vs. production defaults" semantics can be validated against a real consumer.

Review fixes carried in this PR

  • Mock @/platform/distribution/types via an importOriginal spread so isDesktop / isNightly survive the wholesale replacement (only isCloud was re-hoisted before).
  • Trimmed the getAssetStoredFilename JSDoc; the BE-933/934 future-collapse is now a one-line TODO rather than a design-doc paragraph.

Review Focus

Screenshots (if applicable)

N/A — no UI change.

┆Issue is synchronized with this Notion page by Unito

…ureFlags test util

L1 prerequisite cleanup. Two type-preserving refactors that make
subsequent L1 sub-issues mechanical.

1. Extract getAssetStoredFilename(asset) helper to collapse the
   duplicated `isCloud && asset.asset_hash ? asset.asset_hash :
   asset.name` branch from useMediaAssetActions (lines 302, 446)
   into a single helper. Once BE-933/934 emit file_path and the
   cloud spec sync brings it into generated types, only the helper
   changes.

2. Add mockFeatureFlags(overrides) test utility under src/test-utils/.
   L1 sub-issues will use this consistently instead of re-inventing
   the mock shape each time. Includes a FeatureFlags type export
   from useFeatureFlags.ts so the mock stays in sync.

Also auto-fixed unrelated tailwind class-order lint errors in four
files (VirtualGrid, RightSidePanel, Textarea, ModelInfoPanel) to
keep CI green.

No behavior change.
@dante01yoon
dante01yoon requested a review from a team May 15, 2026 09:05
@coderabbitai

coderabbitai Bot commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds a new exported helper getAssetStoredFilename (uses isCloud + asset_hash fallback), adds tests that mock cloud state, and updates media asset workflow code to call the helper for widget annotation filenames.

Changes

Asset Stored Filename Utility

Layer / File(s) Summary
Asset stored filename utility implementation
src/platform/assets/utils/assetMetadataUtils.ts
New exported getAssetStoredFilename(asset) returns asset.asset_hash when isCloud is true and hash exists, otherwise returns asset.name.
Testing infrastructure and test suite
src/platform/assets/utils/assetMetadataUtils.test.ts
Adds Vitest isCloud getter mock with mutable isCloudRef and tests verifying cloud vs OSS behavior; includes afterEach reset.
Refactor asset workflow operations
src/platform/assets/composables/useMediaAssetActions.ts
Import getAssetStoredFilename and replace inline cloud/OSS conditional logic in addWorkflow and addMultipleToWorkflow to compute widget annotation filename via the helper.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Comfy-Org/ComfyUI_frontend#11493: Related changes around which filename/asset_hash is written to Load Image widget annotations and how deletion/cache matching uses that mapping.

Suggested reviewers

  • DrJKL
  • christian-byrne
  • AustinMroz

Poem

🐰 I hopped through hashes, names, and cloud,
One helper now sings, quiet and proud,
Tests mock the sky and ground below,
Filenames chosen where they should go,
A little rabbit cheers—hip hop, bravo!

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main refactoring: extracting the getAssetStoredFilename helper function to reduce code duplication.
Docstring Coverage ✅ Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PR title uses "refactor" (not bug-fix language), so end-to-end regression test requirement does not apply. This is a type-preserving code organization refactor with no behavior change.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR modifies only asset metadata utilities in src/platform/assets/ — none of the ADR-applicable paths (src/lib/litegraph/, src/ecs/, graph entities) are modified.
Description check ✅ Passed The PR description comprehensively covers all required sections: a clear summary of the refactor, detailed scope changes, review fixes, and focused review guidance. It provides context, links to related issues/RFCs, and explains design decisions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaewon/fe-733-extract-stored-filename-helper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 06/16/2026, 02:19:04 AM UTC

Links

@github-actions

github-actions Bot commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1670 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1649 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 15, 2026
@github-actions

github-actions Bot commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.36 MB gzip 🔴 +242 B

Details

Summary

  • Raw size: 24.7 MB baseline 24.7 MB — 🔴 +746 B
  • Gzip: 5.36 MB baseline 5.36 MB — 🔴 +242 B
  • Brotli: 4.14 MB baseline 4.14 MB — 🔴 +494 B
  • Bundles: 268 current • 268 baseline • 120 added / 120 removed

Category Glance
Utilities & Hooks 🔴 +786 B (367 kB) · Data & Services 🟢 -40 B (3.16 MB) · Vendor & Third-Party ⚪ 0 B (9.94 MB) · Other ⚪ 0 B (9.16 MB) · Graph Workspace ⚪ 0 B (1.24 MB) · Panels & Settings ⚪ 0 B (527 kB) · + 5 more

App Entry Points — 26.1 kB (baseline 26.1 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CV5nSbsN.js (removed) 26.1 kB — 🟢 -26.1 kB 🟢 -8.76 kB 🟢 -7.56 kB
assets/index-wCBlKwn9.js (new) — 26.1 kB 🔴 +26.1 kB 🔴 +8.76 kB 🔴 +7.52 kB

Status: 1 added / 1 removed

Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BH_h0BxN.js (removed) 1.24 MB — 🟢 -1.24 MB 🟢 -264 kB 🟢 -199 kB
assets/GraphView-sd_JuyY0.js (new) — 1.24 MB 🔴 +1.24 MB 🔴 +264 kB 🔴 +199 kB

Status: 1 added / 1 removed

Views & Navigation — 82.9 kB (baseline 82.9 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-Brp3_Vza.js (new) — 19.6 kB 🔴 +19.6 kB 🔴 +5.14 kB 🔴 +4.58 kB
assets/CloudSurveyView-C1lLAkBd.js (removed) 19.6 kB — 🟢 -19.6 kB 🟢 -5.14 kB 🟢 -4.58 kB
assets/CloudLoginView-BEIK1s_G.js (removed) 12.5 kB — 🟢 -12.5 kB 🟢 -3.55 kB 🟢 -3.12 kB
assets/CloudLoginView-qApEWcN6.js (new) — 12.5 kB 🔴 +12.5 kB 🔴 +3.55 kB 🔴 +3.13 kB
assets/CloudSignupView-CLWnhA1T.js (removed) 10.4 kB — 🟢 -10.4 kB 🟢 -3.06 kB 🟢 -2.71 kB
assets/CloudSignupView-e4urU_ui.js (new) — 10.4 kB 🔴 +10.4 kB 🔴 +3.05 kB 🔴 +2.7 kB
assets/UserCheckView-C-ACsbjM.js (new) — 9.07 kB 🔴 +9.07 kB 🔴 +2.34 kB 🔴 +2.05 kB
assets/UserCheckView-o_0aipFs.js (removed) 9.07 kB — 🟢 -9.07 kB 🟢 -2.34 kB 🟢 -2.05 kB
assets/CloudLayoutView-BuUz_NcG.js (removed) 7.81 kB — 🟢 -7.81 kB 🟢 -2.48 kB 🟢 -2.17 kB
assets/CloudLayoutView-CHsZ84hf.js (new) — 7.81 kB 🔴 +7.81 kB 🔴 +2.48 kB 🔴 +2.17 kB
assets/CloudForgotPasswordView-ErBfGzV2.js (new) — 6.22 kB 🔴 +6.22 kB 🔴 +2.21 kB 🔴 +1.97 kB
assets/CloudForgotPasswordView-ZBnO4PXH.js (removed) 6.22 kB — 🟢 -6.22 kB 🟢 -2.21 kB 🟢 -1.95 kB
assets/CloudAuthTimeoutView--fwBBr5d.js (removed) 5.58 kB — 🟢 -5.58 kB 🟢 -2.05 kB 🟢 -1.8 kB
assets/CloudAuthTimeoutView-CVCeVFcr.js (new) — 5.58 kB 🔴 +5.58 kB 🔴 +2.05 kB 🔴 +1.79 kB
assets/CloudSubscriptionRedirectView-B4epFELK.js (removed) 5.36 kB — 🟢 -5.36 kB 🟢 -2.03 kB 🟢 -1.8 kB
assets/CloudSubscriptionRedirectView-BXhIy6gb.js (new) — 5.36 kB 🔴 +5.36 kB 🔴 +2.03 kB 🔴 +1.8 kB
assets/UserSelectView-B_OzaMCS.js (new) — 4.7 kB 🔴 +4.7 kB 🔴 +1.75 kB 🔴 +1.55 kB
assets/UserSelectView-YVyRNCfG.js (removed) 4.7 kB — 🟢 -4.7 kB 🟢 -1.75 kB 🟢 -1.55 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 527 kB (baseline 527 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-BK0dP2_B.js (removed) 47.5 kB — 🟢 -47.5 kB 🟢 -9.86 kB 🟢 -8.75 kB
assets/KeybindingPanel-DYl2NY2r.js (new) — 47.5 kB 🔴 +47.5 kB 🔴 +9.86 kB 🔴 +8.75 kB
assets/SecretsPanel-C76OIxOE.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.73 kB 🔴 +5.04 kB
assets/SecretsPanel-noDYLbaa.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.73 kB 🟢 -5.04 kB
assets/LegacyCreditsPanel-DDFpUSRp.js (new) — 21.8 kB 🔴 +21.8 kB 🔴 +5.94 kB 🔴 +5.26 kB
assets/LegacyCreditsPanel-DF-9CnNn.js (removed) 21.8 kB — 🟢 -21.8 kB 🟢 -5.94 kB 🟢 -5.25 kB
assets/SubscriptionPanel-BeSWJW71.js (removed) 20.2 kB — 🟢 -20.2 kB 🟢 -5.19 kB 🟢 -4.55 kB
assets/SubscriptionPanel-Dln2MxE4.js (new) — 20.2 kB 🔴 +20.2 kB 🔴 +5.18 kB 🔴 +4.58 kB
assets/AboutPanel-aTQK87xe.js (new) — 12 kB 🔴 +12 kB 🔴 +3.33 kB 🔴 +3 kB
assets/AboutPanel-h4DlAUyi.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.33 kB 🟢 -3 kB
assets/ExtensionPanel-4x9fozLG.js (new) — 10.1 kB 🔴 +10.1 kB 🔴 +2.94 kB 🔴 +2.62 kB
assets/ExtensionPanel-Bxy8ddcM.js (removed) 10.1 kB — 🟢 -10.1 kB 🟢 -2.94 kB 🟢 -2.61 kB
assets/ServerConfigPanel-CCa8U01H.js (new) — 7.13 kB 🔴 +7.13 kB 🔴 +2.39 kB 🔴 +2.13 kB
assets/ServerConfigPanel-upL2PWcM.js (removed) 7.13 kB — 🟢 -7.13 kB 🟢 -2.39 kB 🟢 -2.13 kB
assets/UserPanel-4cCR_PIf.js (new) — 6.84 kB 🔴 +6.84 kB 🔴 +2.27 kB 🔴 +2 kB
assets/UserPanel-COQH-sGk.js (removed) 6.84 kB — 🟢 -6.84 kB 🟢 -2.27 kB 🟢 -2.01 kB
assets/cloudRemoteConfig-BkCT-dqo.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +1.02 kB 🔴 +882 B
assets/cloudRemoteConfig-DnjrzSiq.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -1.02 kB 🟢 -884 B
assets/refreshRemoteConfig-0Pd0tfkP.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +648 B 🔴 +555 B
assets/refreshRemoteConfig-CzaVXHP3.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -650 B 🟢 -554 B

Status: 10 added / 10 removed / 14 unchanged

User & Accounts — 17.8 kB (baseline 17.8 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-CKBa_thz.js (new) — 3.65 kB 🔴 +3.65 kB 🔴 +1.29 kB 🔴 +1.1 kB
assets/auth-Cxu34cLN.js (removed) 3.65 kB — 🟢 -3.65 kB 🟢 -1.29 kB 🟢 -1.1 kB
assets/SignUpForm-BX0p6leL.js (new) — 3.19 kB 🔴 +3.19 kB 🔴 +1.29 kB 🔴 +1.15 kB
assets/SignUpForm-UtQysRdf.js (removed) 3.19 kB — 🟢 -3.19 kB 🟢 -1.29 kB 🟢 -1.15 kB
assets/UpdatePasswordContent-DDwhNdWJ.js (removed) 2.98 kB — 🟢 -2.98 kB 🟢 -1.33 kB 🟢 -1.18 kB
assets/UpdatePasswordContent-DGSo-pco.js (new) — 2.98 kB 🔴 +2.98 kB 🔴 +1.33 kB 🔴 +1.18 kB
assets/authStore-DfEKtg3i.js (new) — 1.27 kB 🔴 +1.27 kB 🔴 +598 B 🔴 +537 B
assets/authStore-dQOduR2q.js (removed) 1.27 kB — 🟢 -1.27 kB 🟢 -600 B 🟢 -539 B
assets/auth-DH-7W4gs.js (removed) 348 B — 🟢 -348 B 🟢 -218 B 🟢 -191 B
assets/auth-t6V-Rqri.js (new) — 348 B 🔴 +348 B 🔴 +218 B 🔴 +194 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-C2D_N4IN.js (new) — 85.8 kB 🔴 +85.8 kB 🔴 +18.6 kB 🔴 +15.9 kB
assets/ComfyHubPublishDialog-Ch-oYt2W.js (removed) 85.8 kB — 🟢 -85.8 kB 🟢 -18.6 kB 🟢 -15.9 kB
assets/useShareDialog-DXJiKCBV.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.81 kB 🟢 -5.15 kB
assets/useShareDialog-O7c6aBNd.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.81 kB 🔴 +5.15 kB
assets/ComfyHubPublishDialog-DsWUtTJy.js (new) — 1.43 kB 🔴 +1.43 kB 🔴 +657 B 🔴 +587 B
assets/ComfyHubPublishDialog-Eozo4_Ve.js (removed) 1.43 kB — 🟢 -1.43 kB 🟢 -656 B 🟢 -588 B
assets/useSubscriptionDialog-DbZStq42.js (new) — 1.25 kB 🔴 +1.25 kB 🔴 +589 B 🔴 +518 B
assets/useSubscriptionDialog-Dlxq4RfN.js (removed) 1.25 kB — 🟢 -1.25 kB 🟢 -589 B 🟢 -523 B

Status: 4 added / 4 removed

UI Components — 58 kB (baseline 58 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-B1yDAKQc.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.37 kB
assets/ComfyQueueButton-B5O2ULQC.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.38 kB
assets/useTerminalTabs-B_Kpl2C2.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +3.76 kB 🔴 +3.31 kB
assets/useTerminalTabs-VM2rb-Vm.js (removed) 11.1 kB — 🟢 -11.1 kB 🟢 -3.76 kB 🟢 -3.31 kB
assets/SubscribeButton-CXBtj-Yq.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.05 kB 🟢 -918 B
assets/SubscribeButton-KlvbnsR9.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +920 B
assets/cloudFeedbackTopbarButton-CukQv2JJ.js (new) — 1.94 kB 🔴 +1.94 kB 🔴 +963 B 🔴 +861 B
assets/cloudFeedbackTopbarButton-D8FCehMo.js (removed) 1.94 kB — 🟢 -1.94 kB 🟢 -964 B 🟢 -858 B
assets/ComfyQueueButton-BbcI7_Ij.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -623 B 🟢 -578 B
assets/ComfyQueueButton-DNAjCX8f.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +623 B 🔴 +573 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 3.16 MB (baseline 3.16 MB) • 🟢 -40 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-xxDFiCUH.js (removed) 2.09 MB — 🟢 -2.09 MB 🟢 -476 kB 🟢 -361 kB
assets/dialogService-DkRTEenA.js (new) — 2.09 MB 🔴 +2.09 MB 🔴 +476 kB 🔴 +361 kB
assets/api-BRRdMAXT.js (new) — 898 kB 🔴 +898 kB 🔴 +214 kB 🔴 +169 kB
assets/api-uQwhUmAH.js (removed) 898 kB — 🟢 -898 kB 🟢 -215 kB 🟢 -169 kB
assets/load3dService-BkiDZDHJ.js (new) — 116 kB 🔴 +116 kB 🔴 +25.4 kB 🔴 +21.6 kB
assets/load3dService-DdPuvc-R.js (removed) 116 kB — 🟢 -116 kB 🟢 -25.4 kB 🟢 -21.6 kB
assets/workflowShareService-B8UxRDx2.js (new) — 16.7 kB 🔴 +16.7 kB 🔴 +4.92 kB 🔴 +4.36 kB
assets/workflowShareService-y_1WDuNC.js (removed) 16.7 kB — 🟢 -16.7 kB 🟢 -4.92 kB 🟢 -4.36 kB
assets/keybindingService-B1UVf69_.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.21 kB
assets/keybindingService-DpQZ6p4c.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.21 kB
assets/releaseStore-1igkS75F.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/releaseStore-L2JWXbhq.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/userStore-BefR0LZ5.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +933 B 🔴 +819 B
assets/userStore-CzRsNFDP.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -932 B 🟢 -818 B
assets/audioService-BVNW84DV.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -880 B 🟢 -762 B
assets/audioService-DU3So8hW.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +879 B 🔴 +765 B
assets/releaseStore-BFSPgkFX.js (removed) 1.27 kB — 🟢 -1.27 kB 🟢 -593 B 🟢 -531 B
assets/releaseStore-BUfSu5Hk.js (new) — 1.27 kB 🔴 +1.27 kB 🔴 +592 B 🔴 +528 B
assets/workflowDraftStore-DSUuVoTm.js (new) — 1.25 kB 🔴 +1.25 kB 🔴 +587 B 🔴 +520 B
assets/workflowDraftStore-Dvp0_euM.js (removed) 1.25 kB — 🟢 -1.25 kB 🟢 -588 B 🟢 -525 B
assets/dialogService-CrnD4Yzu.js (new) — 1.24 kB 🔴 +1.24 kB 🔴 +580 B 🔴 +520 B
assets/dialogService-Oryoyk_y.js (removed) 1.24 kB — 🟢 -1.24 kB 🟢 -581 B 🟢 -525 B
assets/settingStore-BUu3rg1G.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -583 B 🟢 -521 B
assets/settingStore-DoRHDaWZ.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +582 B 🔴 +518 B
assets/assetsStore--YAF8p7r.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +583 B 🔴 +518 B
assets/assetsStore-DkBN-DMv.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -583 B 🟢 -519 B

Status: 13 added / 13 removed / 4 unchanged

Utilities & Hooks — 367 kB (baseline 366 kB) • 🔴 +786 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-B9bI8HvF.js (removed) 234 kB — 🟢 -234 kB 🟢 -52.1 kB 🟢 -42.4 kB
assets/useConflictDetection-CX06ssSJ.js (new) — 234 kB 🔴 +234 kB 🔴 +52.1 kB 🔴 +42.4 kB
assets/useLoad3d-B1rXj9U0.js (removed) 22.7 kB — 🟢 -22.7 kB 🟢 -5.22 kB 🟢 -4.61 kB
assets/useLoad3d-DEBHqAqa.js (new) — 22.7 kB 🔴 +22.7 kB 🔴 +5.22 kB 🔴 +4.62 kB
assets/useLoad3dViewer-Bv5jEi6q.js (removed) 21 kB — 🟢 -21 kB 🟢 -4.92 kB 🟢 -4.31 kB
assets/useLoad3dViewer-CmbFPdWa.js (new) — 21 kB 🔴 +21 kB 🔴 +4.93 kB 🔴 +4.31 kB
assets/assetMetadataUtils-qLtDoeyY.js (new) — 6.99 kB 🔴 +6.99 kB 🔴 +2.19 kB 🔴 +1.9 kB
assets/assetMetadataUtils-BrfVviz8.js (removed) 6.2 kB — 🟢 -6.2 kB 🟢 -1.9 kB 🟢 -1.65 kB
assets/useFeatureFlags-BXZAY0ze.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +1.79 kB 🔴 +1.53 kB
assets/useFeatureFlags-CDy92W1Y.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -1.8 kB 🟢 -1.52 kB
assets/useCopyToClipboard-BblZzlnB.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/useCopyToClipboard-BsYgedid.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/useWorkspaceUI-B0Gy_Ty-.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +980 B 🔴 +813 B
assets/useWorkspaceUI-BANyFoRx.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -982 B 🟢 -813 B
assets/subscriptionCheckoutUtil-BSobM_2f.js (removed) 3.31 kB — 🟢 -3.31 kB 🟢 -1.36 kB 🟢 -1.19 kB
assets/subscriptionCheckoutUtil-D1BrYkxy.js (new) — 3.31 kB 🔴 +3.31 kB 🔴 +1.36 kB 🔴 +1.19 kB
assets/assetPreviewUtil-D81ZJ8Dm.js (removed) 2.43 kB — 🟢 -2.43 kB 🟢 -1.01 kB 🟢 -880 B
assets/assetPreviewUtil-DPQX9F7r.js (new) — 2.43 kB 🔴 +2.43 kB 🔴 +1.01 kB 🔴 +878 B
assets/useUpstreamValue-BQVWX3cL.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +803 B 🔴 +719 B
assets/useUpstreamValue-z654WzV_.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -803 B 🟢 -708 B
assets/useLoad3d-DASuo9_R.js (removed) 1.41 kB — 🟢 -1.41 kB 🟢 -648 B 🟢 -586 B
assets/useLoad3d-lUOVFp-h.js (new) — 1.41 kB 🔴 +1.41 kB 🔴 +649 B 🔴 +582 B
assets/useLoad3dViewer-BOeFhjJb.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -617 B 🟢 -570 B
assets/useLoad3dViewer-JW3qOC3U.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +616 B 🔴 +569 B
assets/useCurrentUser-CCMpxo-k.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -584 B 🟢 -524 B
assets/useCurrentUser-KEqEgYNq.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +583 B 🔴 +520 B
assets/useWorkspaceSwitch-DFf_usn7.js (new) — 747 B 🔴 +747 B 🔴 +382 B 🔴 +335 B
assets/useWorkspaceSwitch-Diz7iEBf.js (removed) 747 B — 🟢 -747 B 🟢 -383 B 🟢 -331 B

Status: 14 added / 14 removed / 17 unchanged

Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 9.16 MB (baseline 9.16 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-BCW_oWNN.js (removed) 78 kB — 🟢 -78 kB 🟢 -20.2 kB 🟢 -17.2 kB
assets/core-BX5IljhA.js (new) — 78 kB 🔴 +78 kB 🔴 +20.2 kB 🔴 +17.2 kB
assets/groupNode-DDzoDFZQ.js (new) — 74.9 kB 🔴 +74.9 kB 🔴 +18.7 kB 🔴 +16.5 kB
assets/groupNode-v1fU_yZP.js (removed) 74.9 kB — 🟢 -74.9 kB 🟢 -18.7 kB 🟢 -16.5 kB
assets/WidgetSelect-B9yZDamP.js (new) — 67.9 kB 🔴 +67.9 kB 🔴 +14.8 kB 🔴 +12.8 kB
assets/WidgetSelect-It5t8iiY.js (removed) 67.9 kB — 🟢 -67.9 kB 🟢 -14.8 kB 🟢 -12.8 kB
assets/SubscriptionRequiredDialogContentWorkspace-COrYYiQx.js (new) — 48.9 kB 🔴 +48.9 kB 🔴 +9.56 kB 🔴 +8.25 kB
assets/SubscriptionRequiredDialogContentWorkspace-s4BRqD8q.js (removed) 48.9 kB — 🟢 -48.9 kB 🟢 -9.56 kB 🟢 -8.26 kB
assets/Load3DControls-BC6xKVyl.js (new) — 46.1 kB 🔴 +46.1 kB 🔴 +7.5 kB 🔴 +6.55 kB
assets/Load3DControls-BRzJzbq6.js (removed) 46.1 kB — 🟢 -46.1 kB 🟢 -7.5 kB 🟢 -6.55 kB
assets/WorkspacePanelContent-Bj_ackfw.js (new) — 34.3 kB 🔴 +34.3 kB 🔴 +7.44 kB 🔴 +6.58 kB
assets/WorkspacePanelContent-C2wJhPd-.js (removed) 34.3 kB — 🟢 -34.3 kB 🟢 -7.44 kB 🟢 -6.59 kB
assets/WidgetPainter-BIWrXbEV.js (removed) 33.5 kB — 🟢 -33.5 kB 🟢 -8.28 kB 🟢 -7.34 kB
assets/WidgetPainter-BODK_m8n.js (new) — 33.5 kB 🔴 +33.5 kB 🔴 +8.28 kB 🔴 +7.34 kB
assets/Load3dViewerContent-BA5_cAVI.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.19 kB 🟢 -5.36 kB
assets/Load3dViewerContent-D5rsqlcZ.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.19 kB 🔴 +5.36 kB
assets/SubscriptionRequiredDialogContent-BUuCSyTA.js (removed) 27.6 kB — 🟢 -27.6 kB 🟢 -7.02 kB 🟢 -6.19 kB
assets/SubscriptionRequiredDialogContent-CBnnPxh_.js (new) — 27.6 kB 🔴 +27.6 kB 🔴 +7.01 kB 🔴 +6.19 kB
assets/WidgetImageCrop-CK9jxpTa.js (new) — 24.4 kB 🔴 +24.4 kB 🔴 +6.23 kB 🔴 +5.48 kB
assets/WidgetImageCrop-CTO0_dkt.js (removed) 24.4 kB — 🟢 -24.4 kB 🟢 -6.23 kB 🟢 -5.48 kB
assets/SubscriptionPanelContentWorkspace-DE1pjQse.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.18 kB 🟢 -4.57 kB
assets/SubscriptionPanelContentWorkspace-Yc889Rse.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.17 kB 🔴 +4.56 kB
assets/SignInContent-D6eAEbIe.js (new) — 20.9 kB 🔴 +20.9 kB 🔴 +5.47 kB 🔴 +4.8 kB
assets/SignInContent-My5-xHGX.js (removed) 20.9 kB — 🟢 -20.9 kB 🟢 -5.47 kB 🟢 -4.78 kB
assets/CurrentUserPopoverWorkspace-C3_oQftA.js (new) — 20.9 kB 🔴 +20.9 kB 🔴 +4.99 kB 🔴 +4.46 kB
assets/CurrentUserPopoverWorkspace-DMp3aYLQ.js (removed) 20.9 kB — 🟢 -20.9 kB 🟢 -4.99 kB 🟢 -4.46 kB
assets/WidgetInputNumber-CvL87SEV.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.29 kB
assets/WidgetInputNumber-D-undYvG.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.29 kB
assets/Load3D-DuKtvXig.js (removed) 18.5 kB — 🟢 -18.5 kB 🟢 -4.39 kB 🟢 -3.83 kB
assets/Load3D-gyt3UDvx.js (new) — 18.5 kB 🔴 +18.5 kB 🔴 +4.39 kB 🔴 +3.83 kB
assets/WidgetRecordAudio-BNt4SWUx.js (removed) 17.6 kB — 🟢 -17.6 kB 🟢 -5.07 kB 🟢 -4.53 kB
assets/WidgetRecordAudio-DgMRhLKh.js (new) — 17.6 kB 🔴 +17.6 kB 🔴 +5.07 kB 🔴 +4.52 kB
assets/WidgetRange-CN93gPVd.js (removed) 17.1 kB — 🟢 -17.1 kB 🟢 -4.64 kB 🟢 -4.13 kB
assets/WidgetRange-DPUrPeCz.js (new) — 17.1 kB 🔴 +17.1 kB 🔴 +4.64 kB 🔴 +4.14 kB
assets/load3d-CrUZWdig.js (removed) 15.9 kB — 🟢 -15.9 kB 🟢 -4.62 kB 🟢 -4.01 kB
assets/load3d-DeLo2yRA.js (new) — 15.9 kB 🔴 +15.9 kB 🔴 +4.62 kB 🔴 +4.01 kB
assets/WaveAudioPlayer-B1PeVW9o.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.68 kB 🟢 -3.22 kB
assets/WaveAudioPlayer-BCR6s9S6.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.68 kB 🔴 +3.22 kB
assets/WidgetCurve-B3WTro1O.js (removed) 12.3 kB — 🟢 -12.3 kB 🟢 -3.96 kB 🟢 -3.59 kB
assets/WidgetCurve-zdufOQMQ.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +3.96 kB 🔴 +3.58 kB
assets/TeamWorkspacesDialogContent-C-kzVykP.js (new) — 11.4 kB 🔴 +11.4 kB 🔴 +3.45 kB 🔴 +3.07 kB
assets/TeamWorkspacesDialogContent-ChJW2rgt.js (removed) 11.4 kB — 🟢 -11.4 kB 🟢 -3.45 kB 🟢 -3.1 kB
assets/nodeTemplates--3RogAvx.js (removed) 9.92 kB — 🟢 -9.92 kB 🟢 -3.51 kB 🟢 -3.1 kB
assets/nodeTemplates-CwF9cmPt.js (new) — 9.92 kB 🔴 +9.92 kB 🔴 +3.51 kB 🔴 +3.11 kB
assets/NightlySurveyController-CEsfLJgF.js (removed) 9.05 kB — 🟢 -9.05 kB 🟢 -3.18 kB 🟢 -2.8 kB
assets/NightlySurveyController-DbfTlGaw.js (new) — 9.05 kB 🔴 +9.05 kB 🔴 +3.18 kB 🔴 +2.8 kB
assets/Load3DConfiguration-Bikod6Ul.js (new) — 8.77 kB 🔴 +8.77 kB 🔴 +2.61 kB 🔴 +2.3 kB
assets/Load3DConfiguration-C9GbfRR0.js (removed) 8.77 kB — 🟢 -8.77 kB 🟢 -2.61 kB 🟢 -2.29 kB
assets/InviteMemberDialogContent-avVfmJJ4.js (removed) 8.02 kB — 🟢 -8.02 kB 🟢 -2.56 kB 🟢 -2.25 kB
assets/InviteMemberDialogContent-US0smqJT.js (new) — 8.02 kB 🔴 +8.02 kB 🔴 +2.56 kB 🔴 +2.24 kB
assets/onboardingCloudRoutes-DRJ3Okz1.js (new) — 6.94 kB 🔴 +6.94 kB 🔴 +2.18 kB 🔴 +1.87 kB
assets/onboardingCloudRoutes-IGNCZ_61.js (removed) 6.94 kB — 🟢 -6.94 kB 🟢 -2.17 kB 🟢 -1.86 kB
assets/CreateWorkspaceDialogContent-BdANpMI3.js (removed) 6.23 kB — 🟢 -6.23 kB 🟢 -2.27 kB 🟢 -1.99 kB
assets/CreateWorkspaceDialogContent-C72Or1Sf.js (new) — 6.23 kB 🔴 +6.23 kB 🔴 +2.27 kB 🔴 +1.99 kB
assets/WidgetWithControl-D8l0CO-m.js (removed) 6.2 kB — 🟢 -6.2 kB 🟢 -2.5 kB 🟢 -2.22 kB
assets/WidgetWithControl-DXVArjCH.js (new) — 6.2 kB 🔴 +6.2 kB 🔴 +2.5 kB 🔴 +2.2 kB
assets/FreeTierDialogContent-BcO1KeHx.js (removed) 6.09 kB — 🟢 -6.09 kB 🟢 -2.17 kB 🟢 -1.93 kB
assets/FreeTierDialogContent-jvW8uI2t.js (new) — 6.09 kB 🔴 +6.09 kB 🔴 +2.17 kB 🔴 +1.92 kB
assets/EditWorkspaceDialogContent-BnQX8xlh.js (new) — 6.03 kB 🔴 +6.03 kB 🔴 +2.23 kB 🔴 +1.97 kB
assets/EditWorkspaceDialogContent-BPgFxO_Z.js (removed) 6.03 kB — 🟢 -6.03 kB 🟢 -2.23 kB 🟢 -1.95 kB
assets/WidgetTextarea-CNPIQ7Cd.js (removed) 5.84 kB — 🟢 -5.84 kB 🟢 -2.3 kB 🟢 -2.03 kB
assets/WidgetTextarea-D8N-rMdo.js (new) — 5.84 kB 🔴 +5.84 kB 🔴 +2.3 kB 🔴 +2.04 kB
assets/Preview3d-D_PmUrNq.js (new) — 5.81 kB 🔴 +5.81 kB 🔴 +1.96 kB 🔴 +1.7 kB
assets/Preview3d-X-e3BvRZ.js (removed) 5.81 kB — 🟢 -5.81 kB 🟢 -1.96 kB 🟢 -1.71 kB
assets/ValueControlPopover-BY_FwMnM.js (new) — 5.61 kB 🔴 +5.61 kB 🔴 +2.05 kB 🔴 +1.84 kB
assets/ValueControlPopover-Co7JJaeb.js (removed) 5.61 kB — 🟢 -5.61 kB 🟢 -2.04 kB 🟢 -1.83 kB
assets/CancelSubscriptionDialogContent-BjNS2Pj8.js (new) — 5.53 kB 🔴 +5.53 kB 🔴 +2.07 kB 🔴 +1.82 kB
assets/CancelSubscriptionDialogContent-BtWNAsZo.js (removed) 5.53 kB — 🟢 -5.53 kB 🟢 -2.07 kB 🟢 -1.82 kB
assets/DeleteWorkspaceDialogContent-CMap7o2E.js (removed) 4.93 kB — 🟢 -4.93 kB 🟢 -1.91 kB 🟢 -1.66 kB
assets/DeleteWorkspaceDialogContent-f8WZU98Y.js (new) — 4.93 kB 🔴 +4.93 kB 🔴 +1.91 kB 🔴 +1.66 kB
assets/saveMesh-BvZVNbnj.js (removed) 4.78 kB — 🟢 -4.78 kB 🟢 -1.9 kB 🟢 -1.69 kB
assets/saveMesh-Dppjt8kJ.js (new) — 4.78 kB 🔴 +4.78 kB 🔴 +1.9 kB 🔴 +1.69 kB
assets/LeaveWorkspaceDialogContent-C_7Mr5tc.js (new) — 4.76 kB 🔴 +4.76 kB 🔴 +1.85 kB 🔴 +1.61 kB
assets/LeaveWorkspaceDialogContent-euZI9c2d.js (removed) 4.76 kB — 🟢 -4.76 kB 🟢 -1.85 kB 🟢 -1.61 kB
assets/RemoveMemberDialogContent-6lvwSpTG.js (new) — 4.74 kB 🔴 +4.74 kB 🔴 +1.81 kB 🔴 +1.58 kB
assets/RemoveMemberDialogContent-BXsA_26k.js (removed) 4.74 kB — 🟢 -4.74 kB 🟢 -1.81 kB 🟢 -1.58 kB
assets/RevokeInviteDialogContent-BdUwoNSc.js (new) — 4.65 kB 🔴 +4.65 kB 🔴 +1.82 kB 🔴 +1.59 kB
assets/RevokeInviteDialogContent-BEGv1dLu.js (removed) 4.65 kB — 🟢 -4.65 kB 🟢 -1.82 kB 🟢 -1.59 kB
assets/InviteMemberUpsellDialogContent-CKjl9qyM.js (removed) 4.55 kB — 🟢 -4.55 kB 🟢 -1.68 kB 🟢 -1.48 kB
assets/InviteMemberUpsellDialogContent-CPr1_OZp.js (new) — 4.55 kB 🔴 +4.55 kB 🔴 +1.68 kB 🔴 +1.48 kB
assets/tierBenefits-9RmMqk8r.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.58 kB 🔴 +1.36 kB
assets/tierBenefits-Dl5SZJ3W.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.58 kB 🟢 -1.36 kB
assets/Media3DTop-Bkm_ZhCL.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.81 kB 🟢 -1.59 kB
assets/Media3DTop-DPVvxx1O.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.81 kB 🔴 +1.6 kB
assets/cloudSessionCookie-Cdb1dKUg.js (removed) 4.39 kB — 🟢 -4.39 kB 🟢 -1.61 kB 🟢 -1.41 kB
assets/cloudSessionCookie-CDH1Tp6p.js (new) — 4.39 kB 🔴 +4.39 kB 🔴 +1.6 kB 🔴 +1.4 kB
assets/GlobalToast-9OykgyXZ.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.11 kB
assets/GlobalToast-BCNb2kSz.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.12 kB
assets/CloudRunButtonWrapper-BqZKYLIM.js (new) — 2.31 kB 🔴 +2.31 kB 🔴 +1.05 kB 🔴 +941 B
assets/CloudRunButtonWrapper-OY08epsA.js (removed) 2.31 kB — 🟢 -2.31 kB 🟢 -1.05 kB 🟢 -939 B
assets/SubscribeToRun-CGoOFpq3.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +984 B 🔴 +876 B
assets/SubscribeToRun-DmeD86sb.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -981 B 🟢 -877 B
assets/MediaImageTop-C9lzr2VH.js (removed) 2.12 kB — 🟢 -2.12 kB 🟢 -1.03 kB 🟢 -908 B
assets/MediaImageTop-D3gim4ls.js (new) — 2.12 kB 🔴 +2.12 kB 🔴 +1.02 kB 🔴 +890 B
assets/MediaAudioTop-B4dnI1vg.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +1 kB 🔴 +890 B
assets/MediaAudioTop-m7PSx3Y5.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -1 kB 🟢 -894 B
assets/cloudBadges-B5HJoPQI.js (removed) 2.04 kB — 🟢 -2.04 kB 🟢 -1.01 kB 🟢 -879 B
assets/cloudBadges-Bo8hyMUb.js (new) — 2.04 kB 🔴 +2.04 kB 🔴 +1.01 kB 🔴 +876 B
assets/cloudSubscription-DomON1x4.js (new) — 1.96 kB 🔴 +1.96 kB 🔴 +929 B 🔴 +809 B
assets/cloudSubscription-DTMqf2E-.js (removed) 1.96 kB — 🟢 -1.96 kB 🟢 -929 B 🟢 -811 B
assets/graphHasMissingNodes-C3ydInTN.js (removed) 1.84 kB — 🟢 -1.84 kB 🟢 -860 B 🟢 -764 B
assets/graphHasMissingNodes-DwMmNj8d.js (new) — 1.84 kB 🔴 +1.84 kB 🔴 +860 B 🔴 +759 B
assets/Load3D-D6bqMDMM.js (new) — 1.66 kB 🔴 +1.66 kB 🔴 +738 B 🔴 +658 B
assets/Load3D-sf_fM6iE.js (removed) 1.66 kB — 🟢 -1.66 kB 🟢 -738 B 🟢 -661 B
assets/nightlyBadges-BjQli0zA.js (removed) 1.57 kB — 🟢 -1.57 kB 🟢 -778 B 🟢 -690 B
assets/nightlyBadges-BzZwJqRw.js (new) — 1.57 kB 🔴 +1.57 kB 🔴 +776 B 🔴 +691 B
assets/Load3dViewerContent-C0kJwh0N.js (new) — 1.54 kB 🔴 +1.54 kB 🔴 +691 B 🔴 +615 B
assets/Load3dViewerContent-C9eqjbdT.js (removed) 1.54 kB — 🟢 -1.54 kB 🟢 -692 B 🟢 -619 B
assets/previousFullPath-85kSMw5y.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -696 B 🟢 -601 B
assets/previousFullPath-CCoiizHI.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +692 B 🔴 +600 B
assets/SubscriptionPanelContentWorkspace-BaipTFNo.js (new) — 1.43 kB 🔴 +1.43 kB 🔴 +644 B 🔴 +581 B
assets/SubscriptionPanelContentWorkspace-ClDbdeS9.js (removed) 1.43 kB — 🟢 -1.43 kB 🟢 -646 B 🟢 -582 B
assets/WidgetLegacy-9HpHkglN.js (removed) 1.25 kB — 🟢 -1.25 kB 🟢 -595 B 🟢 -532 B
assets/WidgetLegacy-B_EedIlx.js (new) — 1.25 kB 🔴 +1.25 kB 🔴 +594 B 🔴 +530 B
assets/changeTracker-BS83DOYv.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -583 B 🟢 -522 B
assets/changeTracker-DsWSh3or.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +583 B 🔴 +518 B

Status: 58 added / 58 removed / 85 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 128ms TBT · 90.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 132.3 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 253.5 MB heap
vue-large-graph-pan: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 151.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.0 MB heap

⚠️ 3 regressions detected

Metric Baseline PR (median) Δ Sig
canvas-mouse-sweep: layout duration 4ms 4ms +16% ⚠️ z=4.0
large-graph-pan: style recalc duration 16ms 19ms +18% ⚠️ z=2.0
large-graph-pan: task duration 1085ms 1189ms +10% ⚠️ z=2.5
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 6ms 8ms +32% z=-3.2
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 8 9 +13% z=-3.8
canvas-idle: task duration 340ms 444ms +31% z=1.6
canvas-idle: script duration 18ms 19ms +2% z=-3.0
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 68.0 MB 67.4 MB -1% —
canvas-idle: DOM nodes 16 -122 -863% z=-113.4
canvas-idle: event listeners 6 -63 -1142% z=-15.7
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-1.5
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 4ms +16% ⚠️ z=4.0
canvas-mouse-sweep: style recalc duration 38ms 41ms +8% z=-0.6
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 75 77 +2% z=-0.9
canvas-mouse-sweep: task duration 777ms 836ms +8% z=-0.5
canvas-mouse-sweep: script duration 110ms 121ms +10% z=-2.2
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 56.5 MB 50.9 MB -10% —
canvas-mouse-sweep: DOM nodes -262 -100 -62% z=-62.8
canvas-mouse-sweep: event listeners -131 -131 +0% z=-33.5
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms +1% —
canvas-zoom-sweep: layout duration 1ms 1ms +10% z=1.6
canvas-zoom-sweep: style recalc duration 16ms 18ms +14% z=-0.6
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 32 -2% z=0.5
canvas-zoom-sweep: task duration 355ms 366ms +3% z=1.7
canvas-zoom-sweep: script duration 19ms 29ms +47% z=0.5
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 43.3 MB 69.9 MB +61% —
canvas-zoom-sweep: DOM nodes -211 80 -138% z=0.3
canvas-zoom-sweep: event listeners -116 21 -118% z=-0.5
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
dom-widget-clipping: p95 frame time 17ms 17ms +1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 7ms 7ms -8% z=-3.9
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 10 -9% z=-6.2
dom-widget-clipping: task duration 307ms 338ms +10% z=-1.6
dom-widget-clipping: script duration 51ms 56ms +11% z=-3.6
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 54.8 MB 61.1 MB +11% —
dom-widget-clipping: DOM nodes 18 16 -11% z=-4.3
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=0.2
large-graph-idle: p95 frame time 17ms 17ms -0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 7ms 8ms +24% z=-3.7
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 9 +0% z=-8.3
large-graph-idle: task duration 519ms 641ms +24% z=1.8
large-graph-idle: script duration 86ms 109ms +27% z=0.6
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 58.3 MB 78.2 MB +34% —
large-graph-idle: DOM nodes -261 -263 +1% z=-317.7
large-graph-idle: event listeners -129 -129 +0% z=-25.4
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 16ms 19ms +18% ⚠️ z=2.0
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 70 +2% z=-0.1
large-graph-pan: task duration 1085ms 1189ms +10% ⚠️ z=2.5
large-graph-pan: script duration 363ms 402ms +11% z=-0.3
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 103.4 MB 81.9 MB -21% —
large-graph-pan: DOM nodes -258 -262 +2% z=-170.3
large-graph-pan: event listeners -127 -128 +1% z=-160.5
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 8ms +7% —
large-graph-zoom: style recalc duration 18ms 19ms +10% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 65 65 +0% —
large-graph-zoom: task duration 1230ms 1333ms +8% —
large-graph-zoom: script duration 434ms 482ms +11% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 66.6 MB 66.6 MB -0% —
large-graph-zoom: DOM nodes -267 -268 +0% —
large-graph-zoom: event listeners -125 -125 +0% —
minimap-idle: avg frame time 17ms 17ms -0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms +1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 8ms -2% z=-2.3
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 10 9 -10% z=-0.8
minimap-idle: task duration 566ms 620ms +10% z=2.0
minimap-idle: script duration 83ms 97ms +17% z=-0.1
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 95.6 MB 96.3 MB +1% —
minimap-idle: DOM nodes -263 -263 -0% z=-205.9
minimap-idle: event listeners -129 -129 +0% z=-202.3
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 10ms -8% z=-2.9
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 46 -3% z=-4.2
subgraph-dom-widget-clipping: task duration 349ms 341ms -2% z=-2.0
subgraph-dom-widget-clipping: script duration 117ms 113ms -3% z=-2.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 55.2 MB 58.9 MB +7% —
subgraph-dom-widget-clipping: DOM nodes 20 17 -15% z=-4.6
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 7ms 8ms +9% z=-3.0
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 9 +0% z=-2.9
subgraph-idle: task duration 326ms 368ms +13% z=-0.0
subgraph-idle: script duration 15ms 17ms +10% z=-1.3
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 69.6 MB 68.8 MB -1% —
subgraph-idle: DOM nodes 18 18 +0% z=-2.5
subgraph-idle: event listeners 6 6 +0% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 4ms 5ms +14% z=0.5
subgraph-mouse-sweep: style recalc duration 34ms 39ms +12% z=-1.2
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 75 76 +1% z=-2.4
subgraph-mouse-sweep: task duration 726ms 726ms -0% z=-0.6
subgraph-mouse-sweep: script duration 81ms 90ms +11% z=-1.7
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 57.7 MB 69.0 MB +19% —
subgraph-mouse-sweep: DOM nodes -260 60 -123% z=-3.1
subgraph-mouse-sweep: event listeners -129 5 -104% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -1% —
subgraph-transition-enter: layout duration 11ms 11ms +1% —
subgraph-transition-enter: style recalc duration 24ms 24ms +3% —
subgraph-transition-enter: layout count 5 5 +0% —
subgraph-transition-enter: style recalc count 16 16 +0% —
subgraph-transition-enter: task duration 676ms 694ms +3% —
subgraph-transition-enter: script duration 28ms 27ms -3% —
subgraph-transition-enter: TBT 133ms 128ms -4% —
subgraph-transition-enter: heap used 90.7 MB 90.8 MB +0% —
subgraph-transition-enter: DOM nodes 13513 13513 +0% —
subgraph-transition-enter: event listeners 2527 2527 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 51ms 55ms +8% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 251 +1% —
viewport-pan-sweep: task duration 3560ms 4218ms +18% —
viewport-pan-sweep: script duration 1155ms 1290ms +12% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 70.4 MB 132.3 MB +88% —
viewport-pan-sweep: DOM nodes -261 -260 -0% —
viewport-pan-sweep: event listeners -113 -125 +11% —
vue-large-graph-idle: avg frame time 17ms 18ms +2% —
vue-large-graph-idle: p95 frame time 17ms 17ms +1% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 12986ms 13344ms +3% —
vue-large-graph-idle: script duration 591ms 682ms +15% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 254.0 MB 253.5 MB -0% —
vue-large-graph-idle: DOM nodes -8332 -8331 -0% —
vue-large-graph-idle: event listeners -16488 -16488 +0% —
vue-large-graph-pan: avg frame time 17ms 17ms +2% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 17ms +4% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 65 65 +0% —
vue-large-graph-pan: task duration 12532ms 12842ms +2% —
vue-large-graph-pan: script duration 826ms 887ms +7% —
vue-large-graph-pan: TBT 3ms 0ms -100% —
vue-large-graph-pan: heap used 169.3 MB 151.6 MB -10% —
vue-large-graph-pan: DOM nodes -8329 -8331 +0% —
vue-large-graph-pan: event listeners -16464 -16462 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 1ms -11% z=-2.2
workflow-execution: style recalc duration 22ms 24ms +5% z=-0.3
workflow-execution: layout count 5 5 -10% z=-0.8
workflow-execution: style recalc count 17 19 +9% z=0.3
workflow-execution: task duration 123ms 119ms -4% z=-0.4
workflow-execution: script duration 25ms 24ms -4% z=-1.6
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 52.8 MB 53.0 MB +0% —
workflow-execution: DOM nodes 157 163 +4% z=0.2
workflow-execution: event listeners 71 71 +0% z=4.4
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-05-15T09:25:53.321Z",
  "gitSha": "ac67370827fd8dbe18627e59a3d90c7ee2f1d78b",
  "branch": "jaewon/fe-733-extract-stored-filename-helper",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2107.0310000000063,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.198999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 522.462,
      "heapDeltaBytes": 19414912,
      "heapUsedBytes": 69439912,
      "domNodes": -262,
      "jsHeapTotalBytes": 16211968,
      "scriptDurationMs": 19.704,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2003.9280000000872,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.776000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.10200000000003,
      "heapDeltaBytes": 23195780,
      "heapUsedBytes": 71841100,
      "domNodes": 18,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 17.558000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1872.8680000000395,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 39.357,
      "layouts": 12,
      "layoutDurationMs": 4.085999999999999,
      "taskDurationMs": 820.721,
      "heapDeltaBytes": -5315980,
      "heapUsedBytes": 43686024,
      "domNodes": 58,
      "jsHeapTotalBytes": 16642048,
      "scriptDurationMs": 115.456,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1881.2860000000455,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 42.327000000000005,
      "layouts": 12,
      "layoutDurationMs": 4.687,
      "taskDurationMs": 850.6479999999999,
      "heapDeltaBytes": 13216604,
      "heapUsedBytes": 62988224,
      "domNodes": -258,
      "jsHeapTotalBytes": 21454848,
      "scriptDurationMs": 127.377,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1742.3939999999902,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.633000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.717,
      "taskDurationMs": 364.02,
      "heapDeltaBytes": 5028712,
      "heapUsedBytes": 73248184,
      "domNodes": 79,
      "jsHeapTotalBytes": 31195136,
      "scriptDurationMs": 27.008000000000003,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.7559999999285,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.863000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.715,
      "taskDurationMs": 368.75600000000003,
      "heapDeltaBytes": 23511212,
      "heapUsedBytes": 73337064,
      "domNodes": 80,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 30.096,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 549.7090000000071,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.560000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 332.581,
      "heapDeltaBytes": 15214908,
      "heapUsedBytes": 63870584,
      "domNodes": 16,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 57.419000000000004,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 550.8820000000014,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.956,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 344.338,
      "heapDeltaBytes": 15008512,
      "heapUsedBytes": 64213540,
      "domNodes": 16,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 54.82299999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2074.163999999996,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.963000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.617,
      "heapDeltaBytes": 9812708,
      "heapUsedBytes": 66892972,
      "domNodes": -262,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 107.49300000000001,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.4009999998507,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.827000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 675.173,
      "heapDeltaBytes": 39353156,
      "heapUsedBytes": 97160588,
      "domNodes": -263,
      "jsHeapTotalBytes": 33320960,
      "scriptDurationMs": 110.93299999999999,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2122.073999999998,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 18.55,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1197.807,
      "heapDeltaBytes": 58592656,
      "heapUsedBytes": 118575120,
      "domNodes": -263,
      "jsHeapTotalBytes": 35885056,
      "scriptDurationMs": 398.60200000000003,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2145.772999999963,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 19.292000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1180.77,
      "heapDeltaBytes": -5206224,
      "heapUsedBytes": 53093640,
      "domNodes": -261,
      "jsHeapTotalBytes": 6057984,
      "scriptDurationMs": 405,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3186.696999999981,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 19.314,
      "layouts": 60,
      "layoutDurationMs": 7.639,
      "taskDurationMs": 1326.707,
      "heapDeltaBytes": 9382716,
      "heapUsedBytes": 70437840,
      "domNodes": -266,
      "jsHeapTotalBytes": 28672,
      "scriptDurationMs": 479.646,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3185.609000000113,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 19.342000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.516,
      "taskDurationMs": 1338.517,
      "heapDeltaBytes": 7953556,
      "heapUsedBytes": 69150172,
      "domNodes": -270,
      "jsHeapTotalBytes": 6057984,
      "scriptDurationMs": 483.854,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2053.5670000000437,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.394999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.3059999999999,
      "heapDeltaBytes": 37081304,
      "heapUsedBytes": 99070700,
      "domNodes": -262,
      "jsHeapTotalBytes": 32567296,
      "scriptDurationMs": 95.803,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.5099999998602,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.897999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.933,
      "heapDeltaBytes": 40943580,
      "heapUsedBytes": 102974356,
      "domNodes": -263,
      "jsHeapTotalBytes": 32305152,
      "scriptDurationMs": 98.711,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 524.485000000027,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.280999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 338.569,
      "heapDeltaBytes": 14966812,
      "heapUsedBytes": 65322080,
      "domNodes": 18,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 110.02800000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 523.6509999999726,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.624999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 342.98299999999995,
      "heapDeltaBytes": 9214256,
      "heapUsedBytes": 58104848,
      "domNodes": 16,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 116.22900000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.1839999999484,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.125,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.437,
      "heapDeltaBytes": 22916388,
      "heapUsedBytes": 71974088,
      "domNodes": 18,
      "jsHeapTotalBytes": 14680064,
      "scriptDurationMs": 17.153000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.3350000001064,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.036999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.3310000000001,
      "heapDeltaBytes": 22990520,
      "heapUsedBytes": 72215004,
      "domNodes": 18,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 16.535,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1750.385999999935,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 40.524,
      "layouts": 16,
      "layoutDurationMs": 4.684000000000001,
      "taskDurationMs": 771.2320000000001,
      "heapDeltaBytes": 30647312,
      "heapUsedBytes": 81075816,
      "domNodes": 61,
      "jsHeapTotalBytes": 40894464,
      "scriptDurationMs": 91.18799999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1699.8670000000402,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.706999999999994,
      "layouts": 16,
      "layoutDurationMs": 5.046,
      "taskDurationMs": 681.664,
      "heapDeltaBytes": 14451224,
      "heapUsedBytes": 63553412,
      "domNodes": 59,
      "jsHeapTotalBytes": 14417920,
      "scriptDurationMs": 88.71500000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 898.194999999987,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 24.490000000000006,
      "layouts": 5,
      "layoutDurationMs": 10.875000000000002,
      "taskDurationMs": 694.0029999999999,
      "heapDeltaBytes": 30276956,
      "heapUsedBytes": 95192412,
      "domNodes": 13513,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 27.151000000000007,
      "eventListeners": 2527,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8395.579999999994,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 55.317,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4175.525000000001,
      "heapDeltaBytes": 76009372,
      "heapUsedBytes": 134623984,
      "domNodes": -262,
      "jsHeapTotalBytes": 69701632,
      "scriptDurationMs": 1290.342,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8424.514999999928,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 55.16399999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4259.982999999999,
      "heapDeltaBytes": 85378952,
      "heapUsedBytes": 142805888,
      "domNodes": -258,
      "jsHeapTotalBytes": 76255232,
      "scriptDurationMs": 1289.405,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13254.290999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13236.576,
      "heapDeltaBytes": 11679332,
      "heapUsedBytes": 266321420,
      "domNodes": -8331,
      "jsHeapTotalBytes": 16838656,
      "scriptDurationMs": 663.0039999999999,
      "eventListeners": -16488,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13478.250000000116,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13452.038000000002,
      "heapDeltaBytes": 20892728,
      "heapUsedBytes": 265262328,
      "domNodes": -8331,
      "jsHeapTotalBytes": 9170944,
      "scriptDurationMs": 700.1529999999999,
      "eventListeners": -16488,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12878.17300000006,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 17.176000000000023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12854.369999999999,
      "heapDeltaBytes": -44586604,
      "heapUsedBytes": 161329160,
      "domNodes": -8331,
      "jsHeapTotalBytes": 12906496,
      "scriptDurationMs": 829.912,
      "eventListeners": -16462,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12860.413999999992,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 17.360999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12829.301000000001,
      "heapDeltaBytes": -58803028,
      "heapUsedBytes": 156612048,
      "domNodes": -8331,
      "jsHeapTotalBytes": -3084288,
      "scriptDurationMs": 944.0110000000001,
      "eventListeners": -16462,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 451.50600000010854,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.628999999999998,
      "layouts": 5,
      "layoutDurationMs": 1.3870000000000002,
      "taskDurationMs": 127.787,
      "heapDeltaBytes": 5429396,
      "heapUsedBytes": 55948396,
      "domNodes": 168,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 27.932,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 445.34600000019964,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 23.421999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.0639999999999998,
      "taskDurationMs": 109.30300000000001,
      "heapDeltaBytes": 5067732,
      "heapUsedBytes": 55235904,
      "domNodes": 157,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 20.897,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/test-utils/mockFeatureFlags.ts (1)

42-43: 💤 Low value

Consider wrapping flags with readonly() to match production behavior.

The real useFeatureFlags() returns readonly(flags) (line 179), preventing direct mutation. The mock returns the plain object, which allows test code to mutate flags in ways that wouldn't work in production. Wrapping with readonly() would improve test fidelity.

🔒 Suggested change
+import { readonly } from 'vue'
+
 import { vi } from 'vitest'
 return {
-  flags,
+  flags: readonly(flags),
   featureFlag: vi.fn() as unknown as ReturnType<
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/test-utils/mockFeatureFlags.ts` around lines 42 - 43, The mock return
value currently exposes a mutable flags object; update the mock in
mockFeatureFlags (the function returning { flags, ... }) to wrap flags with
readonly()—matching the real useFeatureFlags() behavior—so tests cannot directly
mutate flags; locate the return in the mockFeatureFlags module and replace the
plain flags with readonly(flags) while preserving all other returned properties.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/test-utils/mockFeatureFlags.ts`:
- Around line 42-43: The mock return value currently exposes a mutable flags
object; update the mock in mockFeatureFlags (the function returning { flags, ...
}) to wrap flags with readonly()—matching the real useFeatureFlags() behavior—so
tests cannot directly mutate flags; locate the return in the mockFeatureFlags
module and replace the plain flags with readonly(flags) while preserving all
other returned properties.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 69282e6a-b09a-4268-be1d-7447779c02b0

📥 Commits

Reviewing files that changed from the base of the PR and between d05ec23 and c5dd38f.

📒 Files selected for processing (9)
  • src/components/common/VirtualGrid.vue
  • src/components/rightSidePanel/RightSidePanel.vue
  • src/components/ui/textarea/Textarea.vue
  • src/composables/useFeatureFlags.ts
  • src/platform/assets/components/modelInfo/ModelInfoPanel.vue
  • src/platform/assets/composables/useMediaAssetActions.ts
  • src/platform/assets/utils/assetMetadataUtils.test.ts
  • src/platform/assets/utils/assetMetadataUtils.ts
  • src/test-utils/mockFeatureFlags.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 15, 2026
@codecov

codecov Bot commented May 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff             @@
##             main   #12287       +/-   ##
===========================================
- Coverage   74.99%   61.92%   -13.08%     
===========================================
  Files        1568     1454      -114     
  Lines       93339    75208    -18131     
  Branches    26581    19599     -6982     
===========================================
- Hits        70002    46569    -23433     
- Misses      22634    28294     +5660     
+ Partials      703      345      -358     
Flag Coverage Δ
e2e ?
unit 61.92% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...latform/assets/composables/useMediaAssetActions.ts 76.56% <100.00%> (+14.71%) ⬆️
src/platform/assets/utils/assetMetadataUtils.ts 98.50% <100.00%> (+26.05%) ⬆️

... and 1144 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

knip flagged the newly added mockFeatureFlags test util and the
FeatureFlags type export as unused, failing lint-and-format. Both are
prerequisites consumed by upcoming stacked L1 sub-issue PRs, not by
code in this PR.

- Ignore src/test-utils/mockFeatureFlags.ts in knip.config.ts, matching
  the existing "pending integration in stacked PR" precedent.
- Tag the FeatureFlags type export with @knipIgnoreUsedByStackedPR,
  matching the existing tag usage in apps/website/src/utils/video.ts.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 1, 2026

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flying in from the vexillology desk — eight signals raised against the diff. Two heraldic field-faults need fixing before this banner unfurls; the rest are pennants for follow-up.

Verified before posting:

  • The Cloud-vs-OSS isCloud && asset.asset_hash ? asset.asset_hash : asset.name pattern has only one remaining occurrence (the new helper itself). Refactor charge is complete.
  • isCloud is still used on lines 99 and 123 of useMediaAssetActions.ts, so the import is not orphaned.
  • mockFeatureFlags is not yet flown anywhere outside its own JSDoc example — confirmed it awaits the stacked L1 fleet.
  • 14 test files already inline-mock useFeatureFlags via the flat vi.hoisted pattern (CurrentUserButton.test.ts, useWorkflowActionsMenu.test.ts, authTokenPriority.test.ts, …).

Comment thread src/test-utils/mockFeatureFlags.ts Resolved
Comment thread src/test-utils/mockFeatureFlags.ts Resolved
Comment thread src/test-utils/mockFeatureFlags.ts Resolved
Comment thread src/composables/useFeatureFlags.ts Resolved
Comment thread knip.config.ts Resolved
* For display use {@link getAssetDisplayFilename}; for serialized
* identifiers use {@link getAssetFilename}.
*/
export function getAssetStoredFilename(asset: AssetItem): string {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L3 — three banners, near-identical devices. getAssetFilename, getAssetStoredFilename, and getAssetDisplayFilename all march as (AssetItem) => string and all concern "filename." Without the docstrings, picking the right one is heraldic guesswork. Not blocking this PR, but if there's a rename-pass follow-up, more semantic suffixes (e.g. getAssetCanonicalFilename / getAssetStorageFilename / getAssetVisibleFilename) would help future readers pick the correct ensign on sight.

@DrJKL DrJKL assigned dante01yoon and unassigned DrJKL Jun 2, 2026
@dante01yoon dante01yoon changed the title refactor(assets): extract getAssetStoredFilename helper, add mockFeatureFlags test util refactor(assets): extract getAssetStoredFilename helper (FE-733) Jun 2, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 2, 2026
…ed feature-flag test infra

Per review (DrJKL): mockFeatureFlags and the exported FeatureFlags type have no live consumer in the open stack — FE-729~732 (#12322/#12335/#12375/#12417) don't use them, and FE-780/781 (#12485/#12486) still hand-roll inline vi.hoisted mocks. Shipping them here adds a public surface with no caller, so split them out; they'll be reintroduced bundled with the first PR that actually adopts the util.

This PR is now scoped to the getAssetStoredFilename extraction, which is consumed at its two call sites in useMediaAssetActions.

Retained-code review fixes:
- M3: spread importOriginal in the distribution/types mock so isDesktop and isNightly survive the wholesale replacement.
- L2: trim getAssetStoredFilename JSDoc; demote the BE-933/934 collapse to a one-line TODO.

Removed: src/test-utils/mockFeatureFlags.ts, the FeatureFlags type export, and its knip ignore entry. Pre-split state preserved on local branch jaewon/fe-733-presplit-snapshot.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dante01yoon
dante01yoon force-pushed the jaewon/fe-733-extract-stored-filename-helper branch from d04d2f4 to 499b2a2 Compare June 2, 2026 09:52
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 2, 2026
Resolve useMediaAssetActions.ts conflict: fold main's hash ?? asset_hash
precedence into getAssetStoredFilename so both call sites keep using the
extracted helper while honoring the new canonical hash field.
@github-actions

github-actions Bot commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-12287.vercel.app

This commit: https://website-frontend-gotiyl8e0-comfyui.vercel.app

Last updated: 2026-06-13T03:53:03Z for 239a4dc

@mattmillerai

Copy link
Copy Markdown
Member

High-level safety summary for anyone landing here:

Why this is safe to merge

  1. No behavior change — this is a pure extract-refactor. The helper's body is the exact expression the call sites already inlined (isCloud && (hash ?? asset_hash) ? … : name); it just gets one name and one home.
  2. Both runtimes already serve what it reads. Cloud serves hash in production today (the helper prefers it, keeping the legacy asset_hash alias as fallback); local/OSS takes the other branch and returns asset.name unconditionally — which is exactly what these code paths did before.
  3. Degrades gracefully — a cloud asset with no hash falls back to name, matching the previous inline behavior bit-for-bit.
  4. Tested on both branches — unit tests cover cloud vs OSS, the hash-over-alias preference, and the absent-field fallbacks.
  5. It shrinks future risk rather than adding it — once both backends emit file_path, the migration becomes a one-line change inside this helper instead of a hunt across call sites. That's the whole point of landing it first.

Net: same behavior today, one switch-point tomorrow.

@mattmillerai

Copy link
Copy Markdown
Member

Correction to my earlier note — main moved under this branch, so it's no longer a clean lift-and-merge. Two things to reconcile on rebase:

  1. main already did half this refactor a different way. useMediaAssetActions.ts (~lines 306 and 450) now reads const cloudHash = asset.hash — the ?? asset_hash fallback has been dropped on main. This branch's extracted getAssetStoredFilename still does asset.hash ?? asset.asset_hash, so a naive conflict-resolve would silently re-introduce the deprecated asset_hash alias main just removed. When you rebase, collapse the helper body to isCloud && asset.hash ? asset.hash : asset.name to match main's decision — that keeps it a true no-op against current main.
  2. Stale-branch churn: the branch is ~76 behind, so there are modify/delete conflicts on several affiliates/*.vue components that were deleted on main, plus some Tailwind class-reorder noise in website/legal files. Those should resolve as "take main" (accept the deletions) — none of it is part of this refactor.

Once rebased + reconciled, the substance is still sound (the BE-ready check holds, threads resolved, DrJKL re-approved). It just needs the rebase first now rather than going in ahead of the queue.

* TODO(BE-933/934): collapse to `asset.file_path ?? asset.name`.
*/
export function getAssetStoredFilename(asset: AssetItem): string {
const hash = asset.hash ?? asset.asset_hash

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads-up for the rebase: main has independently rewritten this same callsite (useMediaAssetActions.ts ~306/450) to read const cloudHash = asset.hash — it dropped the ?? asset_hash fallback already. So when you resolve the conflict here, collapse this to:

const hash = asset.hash

Keeping asset.hash ?? asset.asset_hash would silently re-introduce the deprecated alias main just removed, which makes the extracted helper a behavior change against current main rather than the no-op refactor it's meant to be. (The rest of the conflicts are the deleted affiliates/* files — just accept main's deletions there.)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the merge (e73e5b4af) — collapsed the helper to drop the asset_hash alias exactly as flagged:

export function getAssetStoredFilename(asset: AssetItem): string {
  return isCloud && asset.hash ? asset.hash : asset.name
}

Two notes:

  • It wasn't only a behavior concern: main removed asset_hash from the zAsset schema entirely, so asset.hash ?? asset.asset_hash was also a hard typecheck failure — same fix either way. I inlined the single-use hash local rather than keeping a const hash = asset.hash binding; identical behavior, one fewer name.
  • Updated the JSDoc to drop the alias mention and removed the now-meaningless "prefers hash over the deprecated alias" unit test. Remaining tests still cover cloud→hash, cloud→name fallback, and OSS→name.

Affiliate *.vue conflicts resolved as "take main" (accepted the deletions). typecheck / typecheck:browser / typecheck:website / lint / knip all green; PR is now MERGEABLE.

…-stored-filename-helper

# Conflicts:
#	apps/website/src/components/affiliates/AudienceSection.vue
#	apps/website/src/components/affiliates/BrandAssetsSection.vue
#	apps/website/src/components/affiliates/FooterCtaSection.vue
#	apps/website/src/components/affiliates/HeroSection.vue
#	apps/website/src/components/affiliates/HowItWorksSection.vue
#	apps/website/src/components/affiliates/ProgramDetailsSection.vue
#	apps/website/src/components/affiliates/TrustBandSection.vue
#	src/platform/assets/composables/useMediaAssetActions.ts
@dante01yoon
dante01yoon dismissed stale reviews from DrJKL and coderabbitai[bot] via e73e5b4 June 13, 2026 03:42
@mattmillerai

Copy link
Copy Markdown
Member

Rebase looks correct — the helper collapsed to asset.hash cleanly, the tests were updated to match, and it's mergeable + green.

One optional cleanup if you want a tidy diff: the rebase pulled in ~10 apps/website/* files (SiteFooter, CallToActionSection, GalleryCard, the pricing/legal sections, etc.) that are pure Tailwind class-reordering churn — same classes, different order, no functional change. They're stale-branch artifacts, not part of the helper extraction. You can drop them with:

git checkout origin/main -- apps/website/
git commit -m "chore: drop unrelated website class-order churn"

Totally non-blocking though — the functional change is good to go, so don't hold the stack on class ordering if you'd rather just ship. Just flagging since a helper-extraction PR touching 10 marketing-site files reads oddly in review.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 16, 2026
@DrJKL DrJKL assigned christian-byrne and unassigned DrJKL and imick-io Jun 16, 2026
@DrJKL
DrJKL requested review from christian-byrne and removed request for imick-io June 16, 2026 02:07
@christian-byrne
christian-byrne added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit 7a877d0 Jun 16, 2026
65 of 67 checks passed
@christian-byrne
christian-byrne deleted the jaewon/fe-733-extract-stored-filename-helper branch June 16, 2026 22:33
DrJKL added a commit that referenced this pull request Jul 6, 2026
)

## Summary

L1 prerequisite cleanup, scoped to a single type-preserving refactor:
extract `getAssetStoredFilename(asset)` to collapse the duplicated
`isCloud && asset.asset_hash ? asset.asset_hash : asset.name` branch
from `useMediaAssetActions.ts` into one helper in
`assetMetadataUtils.ts`. No behavior change.

Once BE-933/934 emit `file_path` and the cloud spec sync brings the
field into generated types, only the helper internals change (collapse
to `asset.file_path ?? asset.name`).

## Scope change (per review)

The `mockFeatureFlags` test util and the exported `FeatureFlags` type
that this PR originally also added have been **split out**. They had no
live consumer in the open stack — FE-729~732 (#12322 / #12335 / #12375 /
#12417) don't use them, and FE-780 / FE-781 (#12485 / #12486) still
hand-roll inline `vi.hoisted` mocks — so shipping them here would add a
public surface with no caller. They will be reintroduced bundled with
the first PR that actually adopts the util, where `featureFlag`'s return
type and the "all flags off vs. production defaults" semantics can be
validated against a real consumer.

## Review fixes carried in this PR

- Mock `@/platform/distribution/types` via an `importOriginal` spread so
`isDesktop` / `isNightly` survive the wholesale replacement (only
`isCloud` was re-hoisted before).
- Trimmed the `getAssetStoredFilename` JSDoc; the BE-933/934
future-collapse is now a one-line `TODO` rather than a design-doc
paragraph.

## Review Focus

- The helper is intentionally named `getAssetStoredFilename` to
disambiguate from the existing `getAssetFilename` (which targets
`user_metadata.filename` / `metadata.filename` for serialized-identifier
contexts — missing-model matching, filename schema validation) and
`getAssetDisplayFilename` (UI labels). Folding the `isCloud &&
asset_hash` fallback into either of those would regress
display/identifier sites where the cloud hash is never meant to surface.

- Fixes FE-733
- Parent: FE-601 (L1 umbrella)
- RFC: [Asset Identity
Semantics](https://www.notion.so/comfy-org/RFC-Asset-Identity-Semantics-35a6d73d365080e59d59c98cebae779b)
- Survey: [Asset FE Divergence Survey M1
Scope](https://www.notion.so/comfy-org/Assets-FE-Divergence-Survey-M1-Scope-3616d73d365080d0a9cbf5f2394c12f8)
- Slack thread:
https://comfy-organization.slack.com/archives/C0AUUTS2RQV/p1778815571949519

## Screenshots (if applicable)

N/A — no UI change.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12287-refactor-assets-extract-getAssetStoredFilename-helper-add-mockFeatureFlags-test-util-3616d73d365081c9a1c6e1982728a38a)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Matt Miller <matt@miller-media.com>
dante01yoon added a commit that referenced this pull request Jul 27, 2026
)

## Summary

L1 prerequisite cleanup, scoped to a single type-preserving refactor:
extract `getAssetStoredFilename(asset)` to collapse the duplicated
`isCloud && asset.asset_hash ? asset.asset_hash : asset.name` branch
from `useMediaAssetActions.ts` into one helper in
`assetMetadataUtils.ts`. No behavior change.

Once BE-933/934 emit `file_path` and the cloud spec sync brings the
field into generated types, only the helper internals change (collapse
to `asset.file_path ?? asset.name`).

## Scope change (per review)

The `mockFeatureFlags` test util and the exported `FeatureFlags` type
that this PR originally also added have been **split out**. They had no
live consumer in the open stack — FE-729~732 (#12322 / #12335 / #12375 /
#12417) don't use them, and FE-780 / FE-781 (#12485 / #12486) still
hand-roll inline `vi.hoisted` mocks — so shipping them here would add a
public surface with no caller. They will be reintroduced bundled with
the first PR that actually adopts the util, where `featureFlag`'s return
type and the "all flags off vs. production defaults" semantics can be
validated against a real consumer.

## Review fixes carried in this PR

- Mock `@/platform/distribution/types` via an `importOriginal` spread so
`isDesktop` / `isNightly` survive the wholesale replacement (only
`isCloud` was re-hoisted before).
- Trimmed the `getAssetStoredFilename` JSDoc; the BE-933/934
future-collapse is now a one-line `TODO` rather than a design-doc
paragraph.

## Review Focus

- The helper is intentionally named `getAssetStoredFilename` to
disambiguate from the existing `getAssetFilename` (which targets
`user_metadata.filename` / `metadata.filename` for serialized-identifier
contexts — missing-model matching, filename schema validation) and
`getAssetDisplayFilename` (UI labels). Folding the `isCloud &&
asset_hash` fallback into either of those would regress
display/identifier sites where the cloud hash is never meant to surface.

- Fixes FE-733
- Parent: FE-601 (L1 umbrella)
- RFC: [Asset Identity
Semantics](https://www.notion.so/comfy-org/RFC-Asset-Identity-Semantics-35a6d73d365080e59d59c98cebae779b)
- Survey: [Asset FE Divergence Survey M1
Scope](https://www.notion.so/comfy-org/Assets-FE-Divergence-Survey-M1-Scope-3616d73d365080d0a9cbf5f2394c12f8)
- Slack thread:
https://comfy-organization.slack.com/archives/C0AUUTS2RQV/p1778815571949519

## Screenshots (if applicable)

N/A — no UI change.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12287-refactor-assets-extract-getAssetStoredFilename-helper-add-mockFeatureFlags-test-util-3616d73d365081c9a1c6e1982728a38a)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Matt Miller <matt@miller-media.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants