Repository navigation
FE-746 refactor(missingMedia): match asset file_path and verify via asset listing - #12398
Conversation
…746) - Add `file_path` to AssetItem schema (nullable per BE-933/BE-934 wire shape) - Rewrite `getAssetDetectionNames`: use `file_path` alone when emitted, fall back to the legacy `asset_hash` / `name` / `subfolder + name` union when null (hash-only Core registrations, tagless Cloud rows, legacy data) - Drop `isCloud` parameter from `scanAllMediaCandidates`, `scanNodeMediaCandidates`, and `MediaVerificationOptions` — both backends consult the same asset listing oracle post-BE-933/934 - Remove the OSS synchronous-shortcut branch; all candidates now resolve asynchronously through `verifyMediaCandidates` against the unified listing - Rename `MediaVerificationOptions.isCloud` to `allowCompactSuffix` (N1-deferred annotation grammar flag, no longer a backend identity field) - Always call `assetService.getInputAssetsIncludingPublic`; retain internal `isCloud` only for the generated-assets oracle (Cloud /api/assets vs OSS history) — unifying that path is tracked separately - Update callers in app.ts, useErrorClearingHooks.ts, markDeletedAssetsAsMissingMedia.ts - Update tests with module-level `isCloud` mock for generated-asset oracle control; add `file_path`-primary matching test case Per RFC BE-808 v2 (Asset Identity Semantics). DO NOT MERGE until BE-933 (Comfy-Org/ComfyUI#14005) and BE-934 (Comfy-Org/cloud#3744) merge and ship — both backends must emit `file_path` for the new path to fire. Fixes FE-746
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughScans no longer pass cloud-mode and emit candidates with undefined isMissing. Verification now accepts allowCompactSuffix to control compact-suffix normalization. Asset schema adds optional file_path. Resolver imports isCloud at module level and selects cloud/history behavior internally instead of via options. All tests switch to a runtime isCloudHolder mock pattern. ChangesMissing Media Pipeline Refactor
Estimated code review effort🎯 4 (Complex) | ⏱️ ~70 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12398 +/- ##
==========================================
+ Coverage 84.82% 85.57% +0.75%
==========================================
Files 3437 2412 -1025
Lines 165255 137825 -27430
Branches 43140 37304 -5836
==========================================
- Hits 140171 117948 -22223
+ Misses 23127 19506 -3621
+ Partials 1957 371 -1586
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1029 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ts-to-unified-file_path-based
…ase B) `getAssetDetectionNames` previously short-circuited on `asset.file_path`, returning only that key when emitted. That premise — `file_path` as the primary match key — doesn't match RFC BE-808 v2: §3 names `id` as the identity field and §4 explicitly calls `file_path` "a standalone locator/display string" emitted on a BEST EFFORT basis. Workflow widget values predate the BE-933 / BE-934 `file_path` rollout and may still be bare filenames, hashes, or annotated paths. A pre-BE workflow paired with a post-BE asset would false-negative under the early-return: the asset emits `file_path: "input/sub/photo.png"` while the widget value is still `"photo.png"`, and the previous code would mark the reference missing even though the file is present. Union `file_path`, `asset_hash`, `name`, and `subfolder + name` variants so workflows authored against any historical asset shape keep matching. Both backends round-trip `name` through the BE-792 deprecation window, so the legacy keys stay valid for the duration of the rollout. Adversarial review (Codex) flagged the false-negative; RFC re-read confirmed `id` (not `file_path`) is the identity field. Plan and docblock terminology updated to drop the misleading "canonical match key" framing. Adds a regression test for the bare-filename × file_path-emitting asset case.
There was a problem hiding this comment.
🧹 Nitpick comments (3)
src/platform/missingMedia/missingMediaScan.test.ts (1)
512-515: ⚡ Quick winRemove redundant narrative comments from the test body.
The test title already communicates intent; these lines add maintenance overhead without changing behavior.
As per coding guidelines, "Write code that is expressive and self-documenting to minimize need for code comments" and "Avoid new usage of code comments; do not add or retain redundant comments."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/missingMedia/missingMediaScan.test.ts` around lines 512 - 515, Remove the redundant narrative comments in the test that start with "Pre-BE-933/934 workflow: widget value is the bare filename..." — open the test in missingMediaScan.test.ts and delete those explanatory comment lines inside the test body so the test title/description alone documents intent; leave assertions and setup (the existing test function and its assertions) unchanged.src/platform/assets/schemas/assetSchema.ts (1)
9-14: ⚡ Quick winKeep schema code self-documenting and move RFC prose out of inline comments.
This block is policy documentation rather than implementation detail and is likely to drift. Keep only minimal field intent in code and move rollout/RFC context to docs/tests.
As per coding guidelines, "Write code that is expressive and self-documenting to minimize need for code comments" and "Avoid new usage of code comments; do not add or retain redundant comments."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/assets/schemas/assetSchema.ts` around lines 9 - 14, The large RFC/prose comment in assetSchema.ts should be replaced with a concise, self-documenting comment for the schema field(s): remove the rollout/RFC paragraph and retain a short intent line such as "namespace-rooted locator/display string (optional) — consumers MUST NOT rely on this; use id for identity." Update references in the repo by moving the RFC details into a dedicated docs or tests file (e.g., RFC/BE-808 or tests that assert behavior) and ensure any code comments reference the resolver symbol missingMediaAssetResolver.getAssetDetectionNames and field names file_path and id so future readers can find the external RFC documentation.src/platform/missingMedia/missingMediaAssetResolver.ts (1)
80-89: ⚡ Quick winTrim inline rollout prose in implementation code.
This explanation is valuable, but it’s too policy-heavy for a hot-path function comment and will age quickly. Prefer a concise comment plus test/docs as source of truth.
As per coding guidelines, "Write code that is expressive and self-documenting to minimize need for code comments" and "Avoid new usage of code comments; do not add or retain redundant comments."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/missingMedia/missingMediaAssetResolver.ts` around lines 80 - 89, The long rollout/policy prose in the comment above the detection keys should be shortened: replace the paragraph with a concise one-line summary stating the intent (e.g., "Detection keys include file_path, asset_hash, name, and subfolder+name to preserve legacy matching semantics for asset identity per BE-808"), remove the historical/rollout details, and add or update relevant tests/docs (unit/integration tests that cover matching behavior and a docs note) to capture the removed explanation; update the comment located near the detection logic in missingMediaAssetResolver (the block referencing `file_path`, `asset_hash`, `name`, and `subfolder + name`) accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/platform/assets/schemas/assetSchema.ts`:
- Around line 9-14: The large RFC/prose comment in assetSchema.ts should be
replaced with a concise, self-documenting comment for the schema field(s):
remove the rollout/RFC paragraph and retain a short intent line such as
"namespace-rooted locator/display string (optional) — consumers MUST NOT rely on
this; use id for identity." Update references in the repo by moving the RFC
details into a dedicated docs or tests file (e.g., RFC/BE-808 or tests that
assert behavior) and ensure any code comments reference the resolver symbol
missingMediaAssetResolver.getAssetDetectionNames and field names file_path and
id so future readers can find the external RFC documentation.
In `@src/platform/missingMedia/missingMediaAssetResolver.ts`:
- Around line 80-89: The long rollout/policy prose in the comment above the
detection keys should be shortened: replace the paragraph with a concise
one-line summary stating the intent (e.g., "Detection keys include file_path,
asset_hash, name, and subfolder+name to preserve legacy matching semantics for
asset identity per BE-808"), remove the historical/rollout details, and add or
update relevant tests/docs (unit/integration tests that cover matching behavior
and a docs note) to capture the removed explanation; update the comment located
near the detection logic in missingMediaAssetResolver (the block referencing
`file_path`, `asset_hash`, `name`, and `subfolder + name`) accordingly.
In `@src/platform/missingMedia/missingMediaScan.test.ts`:
- Around line 512-515: Remove the redundant narrative comments in the test that
start with "Pre-BE-933/934 workflow: widget value is the bare filename..." —
open the test in missingMediaScan.test.ts and delete those explanatory comment
lines inside the test body so the test title/description alone documents intent;
leave assertions and setup (the existing test function and its assertions)
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 82b96acf-ffe2-41ed-a859-ad1da2b3fd7c
📒 Files selected for processing (4)
src/platform/assets/schemas/assetSchema.tssrc/platform/missingMedia/missingMediaAssetResolver.test.tssrc/platform/missingMedia/missingMediaAssetResolver.tssrc/platform/missingMedia/missingMediaScan.test.ts
…se.allSettled) `resolveMissingMediaAssetSources` previously ran the input-asset fetch (`/api/assets`) and the generated-asset fetch (Cloud `/api/assets` or OSS `/history`) under `Promise.all` with `abortSiblingsOnFailure`, so a single rejection took down both. With the FE-746 unification, the input fetch now always hits `assetService.getInputAssetsIncludingPublic` — including against backends that may legitimately fail (pre-BE-786 OSS without `/api/assets`, BE-934 partial deploys, transient network errors). Switch to `Promise.allSettled` and per-branch soft-degrade. Each oracle is independent; failure in one shouldn't cancel the other. On rejection, return an empty list from that branch; abort errors stay silent, real errors get a one-line console warning so we can spot them without swallowing the rest of the verification. Caller (`verifyMediaCandidates`) already treats an empty asset list as "nothing matches this candidate," which surfaces affected candidates as missing rather than silently dropping them via the previous toast-warn path. False-positive missing is recoverable (user sees the issue in the Errors tab); silent-fail was not. Adversarial review (Codex) flagged the cascade. RFC §4's BEST EFFORT framing for `file_path` already implies the contract has soft-fail expectations, so this aligns the resolver shape with the RFC's stated tolerance. Removes the now-unused `abortSiblingsOnFailure` helper. Replaces the abort-cascade regression test with two independence tests covering each oracle failing in isolation.
…ests (FE-746) Adds an e2e regression spec for the FE-746 behavior changes that unit tests can only assert with mocks: 1. Case B union — a workflow stored before BE-933/934 keeps its widget value as a bare filename. Once the backend starts emitting `file_path` on the same asset (a namespace-rooted locator that diverges from `name`), detection must still match via the `name` arm. The pre-correction Case A early-return would false-negative here. 2. BE-933 hash-only registration — assets registered via POST /assets/from-hash come back with `file_path: null` and `display_name: null`. The legacy `name` arm has to keep working through the BE-792 deprecation window. 3. Negative path — a listing that does not cover the widget value via any key still surfaces the missing-media overlay. Guards against an accidental "match everything" regression when the early-return was removed. 4. Soft-degrade — when `/api/assets` returns 500 (pre-BE-786 OSS without the endpoint, partial BE-934 deploys, transient errors), `Promise.allSettled` lets the verifier finish and mark the candidate missing instead of leaving `isMissing` stuck at undefined behind a silent toast. `Asset` from `@comfyorg/ingest-types` does not yet carry `file_path` / `display_name` (regen is BE-932). Spec extends the type locally so the mocked wire shape stays strongly typed. The companion workflow asset is the minimum LoadImage graph needed to fire the missing-media pipeline; widget value is a fixed sentinel filename used by every test.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/missingMediaAssetUnion.spec.ts (1)
16-19: ⚡ Quick winAvoid brittle overlap when extending
PostBEAsset
PostBEAssetis defined asAsset & { file_path?: string | null; display_name?: string | null }, but intersection types don’t “override” overlapping keys—they combine constraints, which can narrow unexpectedly ifAssetregenerates with different nullability/optionality. PreferOmit+ re-add for stable “override-like” behavior.♻️ Proposed fix
-type PostBEAsset = Asset & { +type PostBEAsset = Omit<Asset, 'file_path' | 'display_name'> & { file_path?: string | null display_name?: string | null }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@browser_tests/tests/missingMediaAssetUnion.spec.ts` around lines 16 - 19, PostBEAsset currently intersects Asset with a new shape which can produce brittle/contradictory constraints if Asset later defines file_path/display_name differently; change the type definition for PostBEAsset to first omit the overlapping keys from Asset (omit 'file_path' and 'display_name') and then intersect that omitted Asset with your desired optional nullable properties so the new optional/nullability for file_path and display_name reliably overrides Asset's definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@browser_tests/tests/missingMediaAssetUnion.spec.ts`:
- Around line 16-19: PostBEAsset currently intersects Asset with a new shape
which can produce brittle/contradictory constraints if Asset later defines
file_path/display_name differently; change the type definition for PostBEAsset
to first omit the overlapping keys from Asset (omit 'file_path' and
'display_name') and then intersect that omitted Asset with your desired optional
nullable properties so the new optional/nullability for file_path and
display_name reliably overrides Asset's definition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 488881c8-7b5d-44ab-a823-596c3be4bc42
📒 Files selected for processing (2)
browser_tests/assets/missing/fe746_load_image_bare_filename.jsonbrowser_tests/tests/missingMediaAssetUnion.spec.ts
✅ Files skipped from review due to trivial changes (1)
- browser_tests/assets/missing/fe746_load_image_bare_filename.json
# Conflicts: # src/platform/assets/schemas/assetSchema.ts # src/platform/missingMedia/missingMediaAssetResolver.ts # src/platform/missingMedia/missingMediaScan.ts
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10.1 MB gzip 🟢 -2.25 kBDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.89 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.47 MB) • 🟢 -116 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 648 kB (baseline 648 kB) • 🟢 -111 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 53.7 kB (baseline 53.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 185 kB (baseline 185 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 10 unchanged Data & Services — 4.16 MB (baseline 4.16 MB) • 🟢 -4.93 kBStores, services, APIs, and repositories
Status: 11 added / 11 removed / 3 unchanged Utilities & Hooks — 586 kB (baseline 586 kB) • 🟢 -513 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 18 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.3 MB (baseline 18.3 MB) • 🟢 -3.44 kBBundles that do not match a named category
Status: 79 added / 79 removed / 226 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T02:53:39.754Z",
"gitSha": "d5ca8f76242c182653c05d0dd24fc58e1cd2043c",
"branch": "jaewon/fe-746-l3-fe-migrate-missingmediascants-to-unified-file_path-based",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.3099999999808,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.743999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.722,
"heapDeltaBytes": 22357076,
"heapUsedBytes": 76251176,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.062000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.866999999962,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8400000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.644,
"heapDeltaBytes": 558708,
"heapUsedBytes": 68737040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.248,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.259999999997,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.006999999999998,
"layouts": 12,
"layoutDurationMs": 3.9389999999999996,
"taskDurationMs": 685.361,
"heapDeltaBytes": -2695524,
"heapUsedBytes": 65612428,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 126.631,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.983000000003,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.73,
"layouts": 12,
"layoutDurationMs": 4.111,
"taskDurationMs": 674.2009999999999,
"heapDeltaBytes": 19802252,
"heapUsedBytes": 79745800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.823,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.101000000022,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.304999999999998,
"layouts": 6,
"layoutDurationMs": 1.179,
"taskDurationMs": 304.616,
"heapDeltaBytes": 3410060,
"heapUsedBytes": 70647536,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.769,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.4309999999577,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.613,
"layouts": 6,
"layoutDurationMs": 1.1900000000000002,
"taskDurationMs": 331.167,
"heapDeltaBytes": -24986188,
"heapUsedBytes": 78761988,
"domNodes": -179,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 10.919000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 611.9080000000281,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.2970000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.595,
"heapDeltaBytes": 15249716,
"heapUsedBytes": 69207192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.205,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 631.0569999999416,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.999999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.65399999999994,
"heapDeltaBytes": -9399452,
"heapUsedBytes": 59107288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.815,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1091.2950000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 742.3870000000001,
"heapDeltaBytes": 14685360,
"heapUsedBytes": 93082716,
"domNodes": 0,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 48.52000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 478,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.6199999999862,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.1540000000001,
"heapDeltaBytes": 18818452,
"heapUsedBytes": 89427208,
"domNodes": 0,
"jsHeapTotalBytes": 10387456,
"scriptDurationMs": 55.885000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 565,
"frameDurationMs": 35.857575757575766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 761.9109999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.6869999999999,
"heapDeltaBytes": 16725176,
"heapUsedBytes": 95495152,
"domNodes": 0,
"jsHeapTotalBytes": 1839104,
"scriptDurationMs": 131.39000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 148,
"frameDurationMs": 22.547058823529397,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 780.4879999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.5510000000001,
"heapDeltaBytes": 17073012,
"heapUsedBytes": 117554792,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 134.112,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.035294117647027,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8166.871000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7257.120000000001,
"heapDeltaBytes": -13041148,
"heapUsedBytes": 67743200,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 5751.576,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 28.95851063829787,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7464.619000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6820.612,
"heapDeltaBytes": 12609640,
"heapUsedBytes": 92873660,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 5372.77,
"eventListeners": 0,
"totalBlockingTimeMs": 51,
"frameDurationMs": 29.279999999999998,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7045.820999999989,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.029999999999998778,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6479.688,
"heapDeltaBytes": -12506100,
"heapUsedBytes": 67566384,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 4998.495,
"eventListeners": 0,
"totalBlockingTimeMs": 126,
"frameDurationMs": 28.589837398373984,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7199.386000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6671.165999999999,
"heapDeltaBytes": 3159312,
"heapUsedBytes": 83608260,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 5214.561,
"eventListeners": 0,
"totalBlockingTimeMs": 59,
"frameDurationMs": 28.457312252964428,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2012.7459999999928,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.634000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.77,
"heapDeltaBytes": 10333180,
"heapUsedBytes": 73264516,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.063000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.387999999968,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.882000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.671,
"heapDeltaBytes": -12258296,
"heapUsedBytes": 66001568,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.233999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2117.849999999976,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.268,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1335.791,
"heapDeltaBytes": 375268,
"heapUsedBytes": 63681312,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 664.6750000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2866.9869999999946,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1602.736,
"heapDeltaBytes": -18517416,
"heapUsedBytes": 69739148,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 807.279,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3413.0949999999984,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.929000000000002,
"layouts": 60,
"layoutDurationMs": 14.768999999999998,
"taskDurationMs": 1426.5339999999997,
"heapDeltaBytes": 672740,
"heapUsedBytes": 64621284,
"domNodes": -304,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 640.476,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3447.5119999999606,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.054,
"layouts": 60,
"layoutDurationMs": 15.399000000000001,
"taskDurationMs": 1460.384,
"heapDeltaBytes": 705672,
"heapUsedBytes": 65096164,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 664.8230000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2698.6779999999726,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.566000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1605.237,
"heapDeltaBytes": 5452804,
"heapUsedBytes": 70258984,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.38,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.770625000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3051.894999999945,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1711.568,
"heapDeltaBytes": 5120568,
"heapUsedBytes": 71835088,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 863.8240000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75714285714286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.491999999991,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3680000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.4410000000001,
"heapDeltaBytes": -28014800,
"heapUsedBytes": 72466272,
"domNodes": -328,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 28.765999999999995,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2008.5490000000163,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.207999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.69499999999994,
"heapDeltaBytes": -10026396,
"heapUsedBytes": 79568740,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.544000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.8040000000133,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.532999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.89799999999997,
"heapDeltaBytes": 9657136,
"heapUsedBytes": 64184396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.169,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.0589999999011,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.898999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.786,
"heapDeltaBytes": 9526052,
"heapUsedBytes": 63540608,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.467,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2013.5530000000017,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.927999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.01700000000005,
"heapDeltaBytes": 21957420,
"heapUsedBytes": 76137988,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.096000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.2900000000782,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.842999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.26800000000003,
"heapDeltaBytes": 583416,
"heapUsedBytes": 71230364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.147,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.4369999999835,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.005,
"layouts": 16,
"layoutDurationMs": 5.523,
"taskDurationMs": 648.072,
"heapDeltaBytes": -6262380,
"heapUsedBytes": 63050128,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 88.65200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1815.4910000000655,
"styleRecalcs": 80,
"styleRecalcDurationMs": 24.576,
"layouts": 16,
"layoutDurationMs": 7.6419999999999995,
"taskDurationMs": 926.4630000000001,
"heapDeltaBytes": -6342740,
"heapUsedBytes": 63358712,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 124.308,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 966.904999999997,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.83,
"layouts": 5,
"layoutDurationMs": 9.849,
"taskDurationMs": 783.4340000000002,
"heapDeltaBytes": 22039224,
"heapUsedBytes": 108109504,
"domNodes": 13747,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 26.37500000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 122,
"frameDurationMs": 20.568085106382973,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8183.05799999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4650.2,
"heapDeltaBytes": -7805692,
"heapUsedBytes": 90824192,
"domNodes": -328,
"jsHeapTotalBytes": -2826240,
"scriptDurationMs": 2178.444,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666191446028513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8242.839000000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.814,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5021.861999999999,
"heapDeltaBytes": 8153996,
"heapUsedBytes": 86012868,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2459.435,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14443.95800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13421.561,
"heapDeltaBytes": -35298940,
"heapUsedBytes": 169966708,
"domNodes": -3045,
"jsHeapTotalBytes": 1417216,
"scriptDurationMs": 220.578,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.366610455311974,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 14564.296000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14038.410999999998,
"heapDeltaBytes": -28942876,
"heapUsedBytes": 177773520,
"domNodes": -3045,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 230.303,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.563237774030355,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 17577.636000000042,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.209000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17141.521999999997,
"heapDeltaBytes": -55195496,
"heapUsedBytes": 169989068,
"domNodes": -3045,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 863.1179999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 17,
"frameDurationMs": 32.11316270566728,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17343.052000000058,
"styleRecalcs": 149,
"styleRecalcDurationMs": 19.464999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16908.251999999997,
"heapDeltaBytes": -29163356,
"heapUsedBytes": 179989432,
"domNodes": -3045,
"jsHeapTotalBytes": 8056832,
"scriptDurationMs": 838.742,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 31.17374100719425,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5273.150999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.85700000000003,
"layouts": 20,
"layoutDurationMs": 25.24399999999999,
"taskDurationMs": 5142.080999999999,
"heapDeltaBytes": 941768,
"heapUsedBytes": 212156556,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 92.94299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.077647058823533,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5227.237000000059,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.51299999999999,
"layouts": 20,
"layoutDurationMs": 25.22999999999999,
"taskDurationMs": 5080.861000000001,
"heapDeltaBytes": -6067448,
"heapUsedBytes": 204407384,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 92.71999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.3061797752809,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7465.008000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7038.172000000001,
"heapDeltaBytes": -42170360,
"heapUsedBytes": 183380848,
"domNodes": -3045,
"jsHeapTotalBytes": 4624384,
"scriptDurationMs": 121.44300000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.167905405405406,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7447.6889999999685,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7104.493999999999,
"heapDeltaBytes": -21169732,
"heapUsedBytes": 177781216,
"domNodes": -3045,
"jsHeapTotalBytes": 4362240,
"scriptDurationMs": 119.66699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.339115646258495,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 485.23099999999886,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.595999999999997,
"layouts": 5,
"layoutDurationMs": 2.3440000000000003,
"taskDurationMs": 139.883,
"heapDeltaBytes": 5972880,
"heapUsedBytes": 70851808,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.291999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 102.42900000002919,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.569999999999999,
"layouts": 2,
"layoutDurationMs": 1.6389999999999998,
"taskDurationMs": 77.404,
"heapDeltaBytes": 3611236,
"heapUsedBytes": 69596092,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.820000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 636.1949999999297,
"styleRecalcs": 78,
"styleRecalcDurationMs": 89.782,
"layouts": 76,
"layoutDurationMs": 19.744,
"taskDurationMs": 595.9649999999999,
"heapDeltaBytes": 15335816,
"heapUsedBytes": 82326904,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 223.167,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 674.3879999999081,
"styleRecalcs": 78,
"styleRecalcDurationMs": 90.78,
"layouts": 76,
"layoutDurationMs": 20.641,
"taskDurationMs": 646.2880000000001,
"heapDeltaBytes": -16275256,
"heapUsedBytes": 67844556,
"domNodes": 76,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 244.837,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1067.1979999999621,
"styleRecalcs": 78,
"styleRecalcDurationMs": 222.751,
"layouts": 76,
"layoutDurationMs": 20.951999999999998,
"taskDurationMs": 1022.4980000000002,
"heapDeltaBytes": -21565792,
"heapUsedBytes": 106865132,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 310.395,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1268.5740000000578,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.978,
"layouts": 76,
"layoutDurationMs": 24.7,
"taskDurationMs": 1241.4969999999998,
"heapDeltaBytes": 7837568,
"heapUsedBytes": 114063544,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 396.579,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.352054794520544,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2187 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9578eb328c6015d90f77e15da29d71d15a05bec3
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
🎭 Playwright: ⏳ Running... |
…ot abort graph load (FE-746)
…ts-to-unified-file_path-based
christian-byrne
left a comment
There was a problem hiding this comment.
Looks good but will need rebase and test against latest
christian-byrne
left a comment
There was a problem hiding this comment.
Current-main lint preflight flags comfy/no-redundant-vitest-cleanup in this file. The project test setup runs vi.clearAllMocks() automatically in a global afterEach, so the per-describe beforeEach calls are redundant. The new beforeEach block this PR adds at line 212 carries the same redundant call. Remove vi.clearAllMocks() from the new beforeEach (keep assetService.invalidateInputAssetsIncludingPublic()), and the existing blocks can be cleaned up in the same pass or left for a separate sweep. The PR also needs a rebase onto current main (5882b01388) — the merge tree is conflicting, which blocks the lint rerun until resolved.
…ts-to-unified-file_path-based Resolve conflicts by keeping main's reviewed missing-media pipeline and re-applying this branch's intent on top: - Match asset file_path alongside hash, name, and subfolder/name keys. - Defer media scan results to asset verification whenever the asset API is enabled, not only on Cloud; scanners no longer take isCloud. - Resolve input and generated asset sources with allSettled so one failing endpoint no longer discards the other. Dropped as superseded by main: the hand-written file_path schema field (the asset schema now spreads the generated ingest Asset, which carries file_path/display_name), the app.ts call sites (moved to missingMediaPipeline), and the model-folder soft-load (the model pipeline no longer loads folders). verifyMediaCandidates keeps isCloud because it now also drives Cloud hash-named output matching.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
…e fails A failed asset listing previously degraded to an empty list, flagging every dependent candidate as missing. Mark the failed source unavailable instead so only its own candidates stay unresolved while the other source still verifies.
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 1f5b2ffff4b2b6954e9e318fe5dd5e9558d4da41.
Full context for agent readers
Asset verification is gated by the asset feature, failed listings leave dependent candidates unresolved, and the legacy widget-option path remains available when assets are disabled. The eight prior review threads are answered and resolved, hosted CI is settled green, and no review threads remain open.
`scanAllMediaCandidates` lost its `isCloud` parameter on main (#12398). The merge was textually clean, so nothing conflicted and only CI saw it - it typechecks the branch merged with main, which is what my local app typecheck does not do.
Summary
Missing-media detection now matches the asset
file_pathand consults the asset listing on every backend that has the asset API enabled, not only Cloud.Backend dependencies have shipped: Comfy-Org/ComfyUI#14005 (BE-933, merged 2026-06-26) and Comfy-Org/cloud#3744 (BE-934, merged 2026-06-09).
file_pathcomes from the generated@comfyorg/ingest-typesAssetschema, whichassetSchema.tsalready spreads.Changes
getAssetDetectionNames): unionfile_pathwith the existinghash,name, andsubfolder/namekeys. RFC BE-808 v2 makesidthe identity andfile_patha best-effort locator. Workflows saved before the rollout still store bare filenames, sofile_pathadds a key and the existing keys stay.scanAllMediaCandidates/scanNodeMediaCandidates): theisCloudparameter is gone. Whenflags.assetsEnabledis on, candidates stayisMissing: undefinedandverifyMediaCandidatesresolves them against the asset listing. The resolver uses the same flag to decide whether to fetch input assets. When the flag is off, the scanner still resolves synchronously from widget options, so OSS without the asset API keeps working.resolveMissingMediaAssetSources):Promise.all+abortSiblingsOnFailureis replaced byPromise.allSettled. If the input-asset or generated-asset fetch fails, that source becomesnullandverifyMediaCandidatesleaves the candidates that depend on it unresolved, so a failed listing does not flag everything as missing. The other source still verifies. Caller aborts still reject.Kept from main:
verifyMediaCandidatesstill takesisCloud, because main now also uses it for Cloud hash-named output matching. The earlier rename toallowCompactSuffixno longer fit and was dropped. The schema field, theapp.tscall sites and the model-folder soft-load were superseded by main and dropped in the merge.Tests
file_pathmatch with and withoutfile_path; scanner defers to verification when the asset API is on; a failed source leaves only its own candidates unresolved; abort still rejects.@cloud(missingMediaFilePath.spec.ts): an asset whosefile_pathdiffers from a bare-filename widget value still matches; a nullfile_pathfalls back toname; an unrelated asset is reported missing; a failing listing does not report media missing.Fixes FE-746