Skip to content

fix: promoted widget indicator missing on nested subgraphs - #10851

Closed
dante01yoon wants to merge 25 commits into
mainfrom
fix/promoted-indicator-nested-subgraph
Closed

dante01yoon wants to merge 25 commits into
mainfrom
fix/promoted-indicator-nested-subgraph

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Apr 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The promoted widget indicator ring (CSS class ring-component-node-widget-promoted) was missing on nested subgraph widgets because of a key mismatch in isPromotedByAny lookups.

Root cause: When a widget is promoted from a non-SubgraphNode inner node, the promotion is stored WITHOUT disambiguatingSourceNodeId (key: "3:text"). However, NodeWidgets.vue always computes a disambiguatingSourceNodeId from widget.storeNodeId, producing a different lookup key ("3:text:1"). The keys never match, so the ring never renders.

Fix: Check both key shapes — with and without disambiguatingSourceNodeId — so nested promotions stored in either format are detected.

Red-Green Verification

Commit CI Status Purpose
`test: add failing test for promoted indicator on nested subgraphs` 🔴 Red Proves the test catches the bug
`fix: also check base key in promoted widget indicator lookup` 🟢 Green Proves the fix resolves the bug

E2E Test Coverage

This fix is a rendering logic change (CSS class application in processedWidgets computed) that is fully testable via Vitest component mount test. The existing E2E test in subgraphNested.spec.ts (lines 219-251) already covers promoted border styling for 2-level nested subgraphs. A 3-level E2E test would require a new fixture workflow and is better suited as a follow-up.

Test Plan

  • CI red on test-only commit
  • CI green on fix commit
  • Vitest component mount test validates promoted ring appears for nested promotion without disambiguatingSourceNodeId
  • All existing subgraph tests pass (166 tests)

@github-actions

github-actions Bot commented Apr 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 04/15/2026, 09:47:25 AM UTC

Links

@coderabbitai

coderabbitai Bot commented Apr 4, 2026 •

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated promotion detection in NodeWidgets.vue to treat a widget as promoted if promotionStore reports a match either with or without a disambiguatingSourceNodeId; added a unit test and a Playwright E2E test that reproduce nested subgraph promotion scenarios and assert the promoted-widget indicator appears inside nested subgraphs.

Changes

Cohort / File(s) Summary
Unit test — promoted widget indicator
src/core/graph/subgraph/promotedWidgetIndicator.test.ts
New Vitest that mounts NodeWidgets.vue with nested SubgraphNode data, initializes Pinia, mocks useCanvasStore root id, records a promotion via usePromotionStore().promote(...) (omitting disambiguatingSourceNodeId), and asserts a promoted border style appears.
Component — promotion detection
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
Changed promotion-ring computation to compute isPromoted by checking promotionStore.isPromotedByAny both with disambiguatingSourceNodeId (when available) and without it (using sourceNodeId + sourceWidgetName), then derive borderStyle from that result.
E2E test — nested subgraph promotion
browser_tests/tests/subgraph/subgraphNested.spec.ts
Added Playwright regression test that loads subgraphs/subgraph-nested-promotion, navigates into nested subgraphs, and asserts presence of ring-component-node-widget-promoted inside the inner subgraph while absent in the outermost one.

Sequence Diagram(s)

sequenceDiagram
  participant UI as "NodeWidgets.vue\n(Component)"
  participant Promotion as "promotionStore"
  participant Canvas as "canvasStore"
  participant VM as "Vue runtime"

  Note over UI,Canvas: on mount / render
  UI->>Canvas: read rootGraph.id
  UI->>Promotion: isPromotedByAny({sourceNodeId, sourceWidgetName, disambiguatingSourceNodeId})
  alt disambiguatingSourceNodeId available
    Promotion-->>UI: result (with disambiguatingSourceNodeId)
  end
  UI->>Promotion: isPromotedByAny({sourceNodeId, sourceWidgetName})
  Promotion-->>UI: result (without disambiguatingSourceNodeId)
  UI->>VM: compute isPromoted = either result
  VM-->>UI: compute borderStyle and render promoted ring if true
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I peeked into nested nodes today,

A tiny ring returned to play,
I nudged the store and ran a test,
Now promoted rings nest in their rest,
A happy hop — success, hooray!

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing the missing promoted widget indicator on nested subgraphs, which aligns with the core issue being addressed.
Description check ✅ Passed The description includes a clear summary of the problem and fix, explains the root cause, references the linked issue (#10612), and documents test verification with red/green CI status.
Linked Issues check ✅ Passed The PR fully addresses issue #10612 by implementing logic to check both key shapes (with and without disambiguatingSourceNodeId) so promotions stored in either format are detected, resolving the missing visual indicator.
Out of Scope Changes check ✅ Passed All changes (test file, component logic update, and E2E test suite) directly support fixing the promoted widget indicator on nested subgraphs, with no unrelated or out-of-scope modifications.
End-To-End Regression Coverage For Fixes ✅ Passed PR includes bug-fix language and adds Playwright E2E tests to browser_tests/tests/subgraph/subgraphNested.spec.ts for regression coverage.
Adr Compliance For Entity/Litegraph Changes ✅ Passed Modified files are not under restricted paths (src/lib/litegraph/, src/ecs/) and do not involve core entity definitions or architecture concerns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/promoted-indicator-nested-subgraph

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1125 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1111 / ❌ 0 / ⚠️ 2 / ⏭️ 1)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 11 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

github-actions Bot commented Apr 4, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.16 MB gzip 🔴 +393 B

Details

Summary

  • Raw size: 23.8 MB baseline 23.8 MB — 🔴 +1.56 kB
  • Gzip: 5.16 MB baseline 5.16 MB — 🔴 +393 B
  • Brotli: 3.99 MB baseline 3.99 MB — 🔴 +466 B
  • Bundles: 251 current • 251 baseline • 115 added / 115 removed

Category Glance
Data & Services 🔴 +1.56 kB (3 MB) · Graph Workspace 🔴 +1 B (1.22 MB) · Vendor & Third-Party ⚪ 0 B (9.86 MB) · Other ⚪ 0 B (8.57 MB) · Panels & Settings ⚪ 0 B (482 kB) · Utilities & Hooks ⚪ 0 B (344 kB) · + 5 more

App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BfJfLq9s.js (new) — 22.3 kB 🔴 +22.3 kB 🔴 +7.93 kB 🔴 +6.79 kB
assets/index-KyHMEaNq.js (removed) 22.3 kB — 🟢 -22.3 kB 🟢 -7.93 kB 🟢 -6.79 kB

Status: 1 added / 1 removed

Graph Workspace — 1.22 MB (baseline 1.22 MB) • 🔴 +1 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-D9GUOly0.js (new) — 1.22 MB 🔴 +1.22 MB 🔴 +260 kB 🔴 +196 kB
assets/GraphView-BbsQJAbE.js (removed) 1.22 MB — 🟢 -1.22 MB 🟢 -260 kB 🟢 -196 kB

Status: 1 added / 1 removed

Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-BPH3EZE3.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +3.4 kB 🔴 +2.89 kB
assets/CloudSurveyView-DTNvKWZ8.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -3.4 kB 🟢 -2.89 kB
assets/CloudLoginView-25lBo2Wm.js (new) — 12 kB 🔴 +12 kB 🔴 +3.36 kB 🔴 +2.96 kB
assets/CloudLoginView-BQSz6ndG.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.35 kB 🟢 -2.96 kB
assets/CloudSignupView-Al9-xI1-.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.86 kB 🔴 +2.52 kB
assets/CloudSignupView-ChFWymKq.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.85 kB 🟢 -2.51 kB
assets/UserCheckView-CpRu-RqE.js (new) — 9.04 kB 🔴 +9.04 kB 🔴 +2.32 kB 🔴 +2.03 kB
assets/UserCheckView-Hyo47kvZ.js (removed) 9.04 kB — 🟢 -9.04 kB 🟢 -2.32 kB 🟢 -2.03 kB
assets/CloudLayoutView-CnR5x7nf.js (new) — 7.54 kB 🔴 +7.54 kB 🔴 +2.36 kB 🔴 +2.05 kB
assets/CloudLayoutView-iytT7EU9.js (removed) 7.54 kB — 🟢 -7.54 kB 🟢 -2.36 kB 🟢 -2.05 kB
assets/CloudForgotPasswordView-CEklUloD.js (new) — 5.94 kB 🔴 +5.94 kB 🔴 +2.1 kB 🔴 +1.84 kB
assets/CloudForgotPasswordView-sw7-zvYd.js (removed) 5.94 kB — 🟢 -5.94 kB 🟢 -2.09 kB 🟢 -1.84 kB
assets/CloudAuthTimeoutView-BM4t05tE.js (removed) 5.31 kB — 🟢 -5.31 kB 🟢 -1.93 kB 🟢 -1.68 kB
assets/CloudAuthTimeoutView-DH-Ptfu8.js (new) — 5.31 kB 🔴 +5.31 kB 🔴 +1.93 kB 🔴 +1.68 kB
assets/CloudSubscriptionRedirectView-DDMxwMZj.js (removed) 5.08 kB — 🟢 -5.08 kB 🟢 -1.91 kB 🟢 -1.69 kB
assets/CloudSubscriptionRedirectView-hxMBo4HG.js (new) — 5.08 kB 🔴 +5.08 kB 🔴 +1.91 kB 🔴 +1.7 kB
assets/UserSelectView-C7b_P0np.js (removed) 4.71 kB — 🟢 -4.71 kB 🟢 -1.74 kB 🟢 -1.54 kB
assets/UserSelectView-vtpqy84x.js (new) — 4.71 kB 🔴 +4.71 kB 🔴 +1.75 kB 🔴 +1.54 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-C9-CH85-.js (removed) 46.6 kB — 🟢 -46.6 kB 🟢 -9.53 kB 🟢 -8.48 kB
assets/KeybindingPanel-CxgfjAHc.js (new) — 46.6 kB 🔴 +46.6 kB 🔴 +9.53 kB 🔴 +8.48 kB
assets/SecretsPanel-CJVFrpVJ.js (removed) 22.4 kB — 🟢 -22.4 kB 🟢 -5.42 kB 🟢 -4.76 kB
assets/SecretsPanel-DuXVeCo8.js (new) — 22.4 kB 🔴 +22.4 kB 🔴 +5.42 kB 🔴 +4.77 kB
assets/LegacyCreditsPanel-BlQotzWj.js (removed) 21.5 kB — 🟢 -21.5 kB 🟢 -5.81 kB 🟢 -5.13 kB
assets/LegacyCreditsPanel-D4M5sI1P.js (new) — 21.5 kB 🔴 +21.5 kB 🔴 +5.82 kB 🔴 +5.13 kB
assets/SubscriptionPanel-BBLYq49S.js (removed) 19.7 kB — 🟢 -19.7 kB 🟢 -5 kB 🟢 -4.4 kB
assets/SubscriptionPanel-Kw4qgXJ5.js (new) — 19.7 kB 🔴 +19.7 kB 🔴 +5.01 kB 🔴 +4.41 kB
assets/AboutPanel-D7EgvCMx.js (new) — 12 kB 🔴 +12 kB 🔴 +3.33 kB 🔴 +2.98 kB
assets/AboutPanel-DmBekAja.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.33 kB 🟢 -2.98 kB
assets/ExtensionPanel-BMkB7YZ_.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.83 kB 🔴 +2.51 kB
assets/ExtensionPanel-Bx0owXq_.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.82 kB 🟢 -2.52 kB
assets/ServerConfigPanel-BuFYuTa5.js (removed) 6.85 kB — 🟢 -6.85 kB 🟢 -2.27 kB 🟢 -2.03 kB
assets/ServerConfigPanel-CjisGpDV.js (new) — 6.85 kB 🔴 +6.85 kB 🔴 +2.27 kB 🔴 +2.03 kB
assets/UserPanel-D4UkhMsm.js (new) — 6.56 kB 🔴 +6.56 kB 🔴 +2.15 kB 🔴 +1.89 kB
assets/UserPanel-DnalXfhS.js (removed) 6.56 kB — 🟢 -6.56 kB 🟢 -2.15 kB 🟢 -1.9 kB
assets/cloudRemoteConfig-Cnsyaauf.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +905 B 🔴 +805 B
assets/cloudRemoteConfig-RpvFhtGX.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -903 B 🟢 -806 B
assets/refreshRemoteConfig-BV1hWtKA.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -648 B 🟢 -554 B
assets/refreshRemoteConfig-CSqB7UDQ.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +650 B 🔴 +553 B

Status: 10 added / 10 removed / 11 unchanged

User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-B0dxnIww.js (new) — 3.57 kB 🔴 +3.57 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/auth-BXZ6QV2h.js (removed) 3.57 kB — 🟢 -3.57 kB 🟢 -1.26 kB 🟢 -1.07 kB
assets/SignUpForm-BTHZ6cxw.js (removed) 3.16 kB — 🟢 -3.16 kB 🟢 -1.28 kB 🟢 -1.14 kB
assets/SignUpForm-h4DD4qab.js (new) — 3.16 kB 🔴 +3.16 kB 🔴 +1.29 kB 🔴 +1.15 kB
assets/UpdatePasswordContent-naoWRsrV.js (removed) 2.7 kB — 🟢 -2.7 kB 🟢 -1.21 kB 🟢 -1.06 kB
assets/UpdatePasswordContent-UWIxcDgD.js (new) — 2.7 kB 🔴 +2.7 kB 🔴 +1.21 kB 🔴 +1.07 kB
assets/authStore-CJMA3RNQ.js (removed) 989 B — 🟢 -989 B 🟢 -482 B 🟢 -426 B
assets/authStore-CPVzd4av.js (new) — 989 B 🔴 +989 B 🔴 +482 B 🔴 +430 B
assets/auth-BL6gI5vx.js (new) — 348 B 🔴 +348 B 🔴 +218 B 🔴 +212 B
assets/auth-BQKfkwZ-.js (removed) 348 B — 🟢 -348 B 🟢 -219 B 🟢 -185 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useShareDialog-BckyjoH_.js (removed) 108 kB — 🟢 -108 kB 🟢 -22.4 kB 🟢 -18.9 kB
assets/useShareDialog-DRKWrhna.js (new) — 108 kB 🔴 +108 kB 🔴 +22.4 kB 🔴 +18.9 kB
assets/useSubscriptionDialog-Cidy2gb5.js (new) — 969 B 🔴 +969 B 🔴 +476 B 🔴 +420 B
assets/useSubscriptionDialog-PxRJOsfi.js (removed) 969 B — 🟢 -969 B 🟢 -476 B 🟢 -417 B

Status: 2 added / 2 removed

UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-BFvqtWy4.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.38 kB
assets/ComfyQueueButton-CROyeuHt.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.39 kB
assets/useTerminalTabs-B2hIry3R.js (new) — 10.7 kB 🔴 +10.7 kB 🔴 +3.6 kB 🔴 +3.16 kB
assets/useTerminalTabs-BXnbHiWu.js (removed) 10.7 kB — 🟢 -10.7 kB 🟢 -3.6 kB 🟢 -3.16 kB
assets/SubscribeButton-D8oEBpkL.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +921 B
assets/SubscribeButton-rbglLM_N.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.05 kB 🟢 -920 B
assets/cloudFeedbackTopbarButton-B_IrTJb2.js (removed) 1.64 kB — 🟢 -1.64 kB 🟢 -860 B 🟢 -752 B
assets/cloudFeedbackTopbarButton-CIhWr23-.js (new) — 1.64 kB 🔴 +1.64 kB 🔴 +861 B 🔴 +746 B
assets/ComfyQueueButton-Dm_GRAKz.js (new) — 1.03 kB 🔴 +1.03 kB 🔴 +488 B 🔴 +441 B
assets/ComfyQueueButton-G3tKkHzo.js (removed) 1.03 kB — 🟢 -1.03 kB 🟢 -489 B 🟢 -437 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 3 MB (baseline 3 MB) • 🔴 +1.56 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-Bu8KB5uM.js (removed) 1.96 MB — 🟢 -1.96 MB 🟢 -449 kB 🟢 -340 kB
assets/dialogService-B5V8pdAX.js (new) — 1.95 MB 🔴 +1.95 MB 🔴 +449 kB 🔴 +340 kB
assets/api-CPDY3fBD.js (new) — 893 kB 🔴 +893 kB 🔴 +213 kB 🔴 +168 kB
assets/api-DCG0gLTi.js (removed) 891 kB — 🟢 -891 kB 🟢 -213 kB 🟢 -168 kB
assets/load3dService-BhXq-FiH.js (new) — 96.5 kB 🔴 +96.5 kB 🔴 +20.5 kB 🔴 +17.7 kB
assets/load3dService-DnQIWiT3.js (removed) 96.5 kB — 🟢 -96.5 kB 🟢 -20.5 kB 🟢 -17.7 kB
assets/workflowShareService-Bor8TpZO.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.89 kB 🔴 +4.34 kB
assets/workflowShareService-DFvz3NQS.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.88 kB 🟢 -4.33 kB
assets/keybindingService-BH6y9Hb-.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.22 kB
assets/keybindingService-CvrXq2CO.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.22 kB
assets/releaseStore-CcCncglR.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/releaseStore-DJBNX4cd.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/userStore-CgjWTEQU.js (removed) 2.24 kB — 🟢 -2.24 kB 🟢 -870 B 🟢 -761 B
assets/userStore-DBpCXBLB.js (new) — 2.24 kB 🔴 +2.24 kB 🔴 +870 B 🔴 +761 B
assets/audioService-BKkBmqMU.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -879 B 🟢 -760 B
assets/audioService-CYIzkkWG.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +880 B 🔴 +759 B
assets/releaseStore-B_oIMraH.js (new) — 993 B 🔴 +993 B 🔴 +480 B 🔴 +429 B
assets/releaseStore-CP70_f_H.js (removed) 993 B — 🟢 -993 B 🟢 -481 B 🟢 -428 B
assets/workflowDraftStore-CFTEoSRf.js (new) — 969 B 🔴 +969 B 🔴 +475 B 🔴 +424 B
assets/workflowDraftStore-DkOtdd0G.js (removed) 969 B — 🟢 -969 B 🟢 -475 B 🟢 -419 B
assets/dialogService-BZJodtlc.js (new) — 958 B 🔴 +958 B 🔴 +468 B 🔴 +419 B
assets/dialogService-J8DUKYkJ.js (removed) 958 B — 🟢 -958 B 🟢 -468 B 🟢 -414 B
assets/settingStore-Bk0YpDxm.js (removed) 956 B — 🟢 -956 B 🟢 -471 B 🟢 -416 B
assets/settingStore-DADTuON-.js (new) — 956 B 🔴 +956 B 🔴 +471 B 🔴 +417 B
assets/assetsStore-CBmZsz4_.js (new) — 955 B 🔴 +955 B 🔴 +470 B 🔴 +419 B
assets/assetsStore-LDVR5wgO.js (removed) 955 B — 🟢 -955 B 🟢 -470 B 🟢 -416 B

Status: 13 added / 13 removed / 4 unchanged

Utilities & Hooks — 344 kB (baseline 344 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-DZK6BySB.js (removed) 232 kB — 🟢 -232 kB 🟢 -51.3 kB 🟢 -41.8 kB
assets/useConflictDetection-UC1ppugD.js (new) — 232 kB 🔴 +232 kB 🔴 +51.3 kB 🔴 +41.8 kB
assets/useLoad3d-B39jp7VY.js (new) — 20.2 kB 🔴 +20.2 kB 🔴 +4.7 kB 🔴 +4.17 kB
assets/useLoad3d-T7IDq4BN.js (removed) 20.2 kB — 🟢 -20.2 kB 🟢 -4.7 kB 🟢 -4.17 kB
assets/useLoad3dViewer-BUdGDP0B.js (removed) 18.7 kB — 🟢 -18.7 kB 🟢 -4.43 kB 🟢 -3.89 kB
assets/useLoad3dViewer-nl3ZSHel.js (new) — 18.7 kB 🔴 +18.7 kB 🔴 +4.44 kB 🔴 +3.87 kB
assets/useFeatureFlags-DKJ4naVu.js (new) — 5.78 kB 🔴 +5.78 kB 🔴 +1.75 kB 🔴 +1.48 kB
assets/useFeatureFlags-fPpddxoI.js (removed) 5.78 kB — 🟢 -5.78 kB 🟢 -1.75 kB 🟢 -1.48 kB
assets/useCopyToClipboard-Czvp2P5J.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/useCopyToClipboard-uz4_gXBa.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/useWorkspaceUI-CEo6J8Z7.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -983 B 🟢 -811 B
assets/useWorkspaceUI-gqgBlg3Z.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +982 B 🔴 +809 B
assets/subscriptionCheckoutUtil-brnKI9BG.js (new) — 2.97 kB 🔴 +2.97 kB 🔴 +1.31 kB 🔴 +1.14 kB
assets/subscriptionCheckoutUtil-w-5AD3xS.js (removed) 2.97 kB — 🟢 -2.97 kB 🟢 -1.31 kB 🟢 -1.14 kB
assets/assetPreviewUtil-DFw7DXlL.js (removed) 2.27 kB — 🟢 -2.27 kB 🟢 -959 B 🟢 -840 B
assets/assetPreviewUtil-DhKcHIeG.js (new) — 2.27 kB 🔴 +2.27 kB 🔴 +960 B 🔴 +839 B
assets/useUpstreamValue-CtE3wpFz.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -806 B 🟢 -708 B
assets/useUpstreamValue-D8uOZriZ.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +806 B 🔴 +718 B
assets/useLoad3d-_Gj94cXt.js (removed) 1.13 kB — 🟢 -1.13 kB 🟢 -539 B 🟢 -483 B
assets/useLoad3d-CZ2eREJT.js (new) — 1.13 kB 🔴 +1.13 kB 🔴 +540 B 🔴 +481 B
assets/useLoad3dViewer-4mq4muOu.js (removed) 1.07 kB — 🟢 -1.07 kB 🟢 -506 B 🟢 -452 B
assets/useLoad3dViewer-CKCfiJGV.js (new) — 1.07 kB 🔴 +1.07 kB 🔴 +504 B 🔴 +455 B
assets/useCurrentUser-CcZbbyvc.js (new) — 955 B 🔴 +955 B 🔴 +471 B 🔴 +418 B
assets/useCurrentUser-D1M8dbin.js (removed) 955 B — 🟢 -955 B 🟢 -471 B 🟢 -415 B
assets/useWorkspaceSwitch-C8IeTBKA.js (removed) 747 B — 🟢 -747 B 🟢 -383 B 🟢 -333 B
assets/useWorkspaceSwitch-jKfyv5j1.js (new) — 747 B 🔴 +747 B 🔴 +383 B 🔴 +332 B

Status: 13 added / 13 removed / 14 unchanged

Vendor & Third-Party — 9.86 MB (baseline 9.86 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 8.57 MB (baseline 8.57 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-CjZC_vub.js (removed) 77 kB — 🟢 -77 kB 🟢 -19.9 kB 🟢 -17 kB
assets/core-DShMh0nm.js (new) — 77 kB 🔴 +77 kB 🔴 +19.9 kB 🔴 +17 kB
assets/groupNode-Ca7Fmmmr.js (removed) 74 kB — 🟢 -74 kB 🟢 -18.5 kB 🟢 -16.3 kB
assets/groupNode-tbjspVHZ.js (new) — 74 kB 🔴 +74 kB 🔴 +18.5 kB 🔴 +16.3 kB
assets/WidgetSelect-3Ees9Kem.js (removed) 64.4 kB — 🟢 -64.4 kB 🟢 -13.9 kB 🟢 -12.1 kB
assets/WidgetSelect-Coqyt9-L.js (new) — 64.4 kB 🔴 +64.4 kB 🔴 +13.9 kB 🔴 +12.1 kB
assets/SubscriptionRequiredDialogContentWorkspace-C8nrFtPd.js (new) — 49.1 kB 🔴 +49.1 kB 🔴 +9.35 kB 🔴 +7.99 kB
assets/SubscriptionRequiredDialogContentWorkspace-jLu_T79P.js (removed) 49.1 kB — 🟢 -49.1 kB 🟢 -9.35 kB 🟢 -7.99 kB
assets/Load3DControls-CbjtSalI.js (new) — 40.2 kB 🔴 +40.2 kB 🔴 +6.88 kB 🔴 +6.01 kB
assets/Load3DControls-DlEFhHy4.js (removed) 40.2 kB — 🟢 -40.2 kB 🟢 -6.88 kB 🟢 -6.01 kB
assets/WidgetPainter-DjflrbrD.js (new) — 33.6 kB 🔴 +33.6 kB 🔴 +8.19 kB 🔴 +7.29 kB
assets/WidgetPainter-Dmyk5xI5.js (removed) 33.6 kB — 🟢 -33.6 kB 🟢 -8.19 kB 🟢 -7.28 kB
assets/WorkspacePanelContent-B3RsKvC8.js (new) — 32.6 kB 🔴 +32.6 kB 🔴 +6.93 kB 🔴 +6.13 kB
assets/WorkspacePanelContent-CC2mpVLR.js (removed) 32.6 kB — 🟢 -32.6 kB 🟢 -6.93 kB 🟢 -6.12 kB
assets/SubscriptionRequiredDialogContent-BPeQyfFw.js (new) — 28.2 kB 🔴 +28.2 kB 🔴 +7.17 kB 🔴 +6.31 kB
assets/SubscriptionRequiredDialogContent-vcP5LVTG.js (removed) 28.2 kB — 🟢 -28.2 kB 🟢 -7.17 kB 🟢 -6.3 kB
assets/Load3dViewerContent-CqY4SjKP.js (removed) 24.5 kB — 🟢 -24.5 kB 🟢 -5.36 kB 🟢 -4.65 kB
assets/Load3dViewerContent-WhLTQn_V.js (new) — 24.5 kB 🔴 +24.5 kB 🔴 +5.36 kB 🔴 +4.66 kB
assets/WidgetImageCrop-DyEiRl71.js (new) — 23.4 kB 🔴 +23.4 kB 🔴 +5.87 kB 🔴 +5.18 kB
assets/WidgetImageCrop-v1eFuvth.js (removed) 23.4 kB — 🟢 -23.4 kB 🟢 -5.87 kB 🟢 -5.19 kB
assets/SubscriptionPanelContentWorkspace-BTaB-BJf.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.18 kB 🟢 -4.56 kB
assets/SubscriptionPanelContentWorkspace-CPBjXkp4.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.18 kB 🔴 +4.56 kB
assets/SignInContent-5ds31wic.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.29 kB 🟢 -4.62 kB
assets/SignInContent-Vm5J1Oxc.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.29 kB 🔴 +4.62 kB
assets/CurrentUserPopoverWorkspace-CwgzKUTp.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +4.84 kB 🔴 +4.33 kB
assets/CurrentUserPopoverWorkspace-zh4frd0a.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -4.83 kB 🟢 -4.33 kB
assets/WidgetInputNumber-CxquoKll.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.3 kB
assets/WidgetInputNumber-Dljh2x8r.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.31 kB
assets/WidgetRecordAudio-C1aGOvvj.js (new) — 17.2 kB 🔴 +17.2 kB 🔴 +4.93 kB 🔴 +4.41 kB
assets/WidgetRecordAudio-DSBTGTFu.js (removed) 17.2 kB — 🟢 -17.2 kB 🟢 -4.92 kB 🟢 -4.42 kB
assets/Load3D-Chw0Dgtn.js (removed) 17 kB — 🟢 -17 kB 🟢 -4.14 kB 🟢 -3.62 kB
assets/Load3D-qlLFgj8j.js (new) — 17 kB 🔴 +17 kB 🔴 +4.14 kB 🔴 +3.63 kB
assets/WidgetRange-B7uJcISh.js (removed) 16.9 kB — 🟢 -16.9 kB 🟢 -4.53 kB 🟢 -4.05 kB
assets/WidgetRange-CnZayZsi.js (new) — 16.9 kB 🔴 +16.9 kB 🔴 +4.53 kB 🔴 +4.06 kB
assets/load3d-D3jPabZp.js (removed) 15 kB — 🟢 -15 kB 🟢 -4.32 kB 🟢 -3.74 kB
assets/load3d-Q_sZp0E4.js (new) — 15 kB 🔴 +15 kB 🔴 +4.33 kB 🔴 +3.74 kB
assets/WaveAudioPlayer-BVAvQzP0.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.69 kB 🔴 +3.23 kB
assets/WaveAudioPlayer-DRbcUH_a.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.69 kB 🟢 -3.23 kB
assets/WidgetCurve-1XGsCAd0.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.87 kB 🟢 -3.5 kB
assets/WidgetCurve-C4zXSc9t.js (new) — 12 kB 🔴 +12 kB 🔴 +3.87 kB 🔴 +3.51 kB
assets/TeamWorkspacesDialogContent-BITilwHx.js (removed) 11.1 kB — 🟢 -11.1 kB 🟢 -3.34 kB 🟢 -2.97 kB
assets/TeamWorkspacesDialogContent-DLq0pS_w.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +3.34 kB 🔴 +2.96 kB
assets/nodeTemplates-BCh68j-d.js (new) — 9.58 kB 🔴 +9.58 kB 🔴 +3.37 kB 🔴 +2.97 kB
assets/nodeTemplates-DjRhiT5o.js (removed) 9.58 kB — 🟢 -9.58 kB 🟢 -3.37 kB 🟢 -2.96 kB
assets/InviteMemberDialogContent-C6Ks_7QU.js (removed) 7.77 kB — 🟢 -7.77 kB 🟢 -2.45 kB 🟢 -2.14 kB
assets/InviteMemberDialogContent-CHrB2v-i.js (new) — 7.77 kB 🔴 +7.77 kB 🔴 +2.45 kB 🔴 +2.15 kB
assets/Load3DConfiguration-CV5nylGF.js (removed) 7.22 kB — 🟢 -7.22 kB 🟢 -2.2 kB 🟢 -1.93 kB
assets/Load3DConfiguration-DSX1CH5c.js (new) — 7.22 kB 🔴 +7.22 kB 🔴 +2.2 kB 🔴 +1.93 kB
assets/onboardingCloudRoutes-BAK2Dg3p.js (new) — 6.53 kB 🔴 +6.53 kB 🔴 +2.03 kB 🔴 +1.76 kB
assets/onboardingCloudRoutes-Cj0uafyh.js (removed) 6.53 kB — 🟢 -6.53 kB 🟢 -2.04 kB 🟢 -1.75 kB
assets/WidgetWithControl-C6NrrSS6.js (new) — 5.99 kB 🔴 +5.99 kB 🔴 +2.38 kB 🔴 +2.13 kB
assets/WidgetWithControl-CgpGujVu.js (removed) 5.99 kB — 🟢 -5.99 kB 🟢 -2.38 kB 🟢 -2.13 kB
assets/CreateWorkspaceDialogContent-B07idZaq.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -2.15 kB 🟢 -1.87 kB
assets/CreateWorkspaceDialogContent-BzZ7ts4b.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +2.15 kB 🔴 +1.87 kB
assets/FreeTierDialogContent-C0tbzp0T.js (new) — 5.82 kB 🔴 +5.82 kB 🔴 +2.05 kB 🔴 +1.82 kB
assets/FreeTierDialogContent-rVWuV0L3.js (removed) 5.82 kB — 🟢 -5.82 kB 🟢 -2.04 kB 🟢 -1.81 kB
assets/EditWorkspaceDialogContent-BzehMR0C.js (new) — 5.75 kB 🔴 +5.75 kB 🔴 +2.11 kB 🔴 +1.85 kB
assets/EditWorkspaceDialogContent-xLMW6vQG.js (removed) 5.75 kB — 🟢 -5.75 kB 🟢 -2.11 kB 🟢 -1.84 kB
assets/WidgetTextarea-B1nAsUBg.js (new) — 5.53 kB 🔴 +5.53 kB 🔴 +2.17 kB 🔴 +1.92 kB
assets/WidgetTextarea-CvYTyn7q.js (removed) 5.53 kB — 🟢 -5.53 kB 🟢 -2.17 kB 🟢 -1.92 kB
assets/Preview3d-CtmWGCuw.js (new) — 5.39 kB 🔴 +5.39 kB 🔴 +1.8 kB 🔴 +1.57 kB
assets/Preview3d-UqYgqPwt.js (removed) 5.39 kB — 🟢 -5.39 kB 🟢 -1.81 kB 🟢 -1.57 kB
assets/ValueControlPopover-asa2fCe8.js (removed) 5.33 kB — 🟢 -5.33 kB 🟢 -1.93 kB 🟢 -1.73 kB
assets/ValueControlPopover-DAt4s91l.js (new) — 5.33 kB 🔴 +5.33 kB 🔴 +1.93 kB 🔴 +1.73 kB
assets/CancelSubscriptionDialogContent-CqRt77Cq.js (new) — 5.22 kB 🔴 +5.22 kB 🔴 +1.95 kB 🔴 +1.7 kB
assets/CancelSubscriptionDialogContent-CSu49zVl.js (removed) 5.22 kB — 🟢 -5.22 kB 🟢 -1.95 kB 🟢 -1.7 kB
assets/DeleteWorkspaceDialogContent-CdxyyYam.js (new) — 4.65 kB 🔴 +4.65 kB 🔴 +1.79 kB 🔴 +1.56 kB
assets/DeleteWorkspaceDialogContent-DOKHd57H.js (removed) 4.65 kB — 🟢 -4.65 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/LeaveWorkspaceDialogContent-D0mgLkPv.js (removed) 4.48 kB — 🟢 -4.48 kB 🟢 -1.73 kB 🟢 -1.5 kB
assets/LeaveWorkspaceDialogContent-D97HwI1J.js (new) — 4.48 kB 🔴 +4.48 kB 🔴 +1.73 kB 🔴 +1.51 kB
assets/RemoveMemberDialogContent-BuClsqqI.js (removed) 4.46 kB — 🟢 -4.46 kB 🟢 -1.69 kB 🟢 -1.47 kB
assets/RemoveMemberDialogContent-D64rdT7z.js (new) — 4.46 kB 🔴 +4.46 kB 🔴 +1.69 kB 🔴 +1.47 kB
assets/tierBenefits-CgMrSvWN.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.58 kB 🔴 +1.36 kB
assets/tierBenefits-DFizglmn.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.57 kB 🟢 -1.36 kB
assets/RevokeInviteDialogContent-CwA-3a5M.js (removed) 4.37 kB — 🟢 -4.37 kB 🟢 -1.7 kB 🟢 -1.49 kB
assets/RevokeInviteDialogContent-zRaI-9pc.js (new) — 4.37 kB 🔴 +4.37 kB 🔴 +1.7 kB 🔴 +1.49 kB
assets/InviteMemberUpsellDialogContent-Bg71ARAf.js (removed) 4.27 kB — 🟢 -4.27 kB 🟢 -1.56 kB 🟢 -1.37 kB
assets/InviteMemberUpsellDialogContent-DfDO6M9T.js (new) — 4.27 kB 🔴 +4.27 kB 🔴 +1.56 kB 🔴 +1.37 kB
assets/cloudSessionCookie-a4CS99KR.js (new) — 4.12 kB 🔴 +4.12 kB 🔴 +1.49 kB 🔴 +1.29 kB
assets/cloudSessionCookie-BVWxu6_A.js (removed) 4.12 kB — 🟢 -4.12 kB 🟢 -1.49 kB 🟢 -1.29 kB
assets/saveMesh-CLCtXlPo.js (new) — 3.92 kB 🔴 +3.92 kB 🔴 +1.69 kB 🔴 +1.48 kB
assets/saveMesh-yAEMb9Dj.js (removed) 3.92 kB — 🟢 -3.92 kB 🟢 -1.69 kB 🟢 -1.48 kB
assets/Media3DTop-_uYUhtkq.js (removed) 3.85 kB — 🟢 -3.85 kB 🟢 -1.63 kB 🟢 -1.43 kB
assets/Media3DTop-G9qzyKjp.js (new) — 3.85 kB 🔴 +3.85 kB 🔴 +1.63 kB 🔴 +1.43 kB
assets/GlobalToast-DJpb5kBc.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.07 kB
assets/GlobalToast-DOfoenYd.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.11 kB
assets/SubscribeToRun-Cw1UcqvE.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -981 B 🟢 -888 B
assets/SubscribeToRun-DMjhkBF-.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +981 B 🔴 +865 B
assets/MediaAudioTop-C444WzvY.js (new) — 2.02 kB 🔴 +2.02 kB 🔴 +982 B 🔴 +881 B
assets/MediaAudioTop-DREId6wi.js (removed) 2.02 kB — 🟢 -2.02 kB 🟢 -980 B 🟢 -867 B
assets/CloudRunButtonWrapper-CLLYj7jT.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -912 B 🟢 -812 B
assets/CloudRunButtonWrapper-DJ9v_b80.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +910 B 🔴 +814 B
assets/graphHasMissingNodes-C8qB20No.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +862 B 🔴 +764 B
assets/graphHasMissingNodes-CV5LMGBv.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -862 B 🟢 -758 B
assets/cloudBadges-CxEu9GCs.js (removed) 1.77 kB — 🟢 -1.77 kB 🟢 -891 B 🟢 -788 B
assets/cloudBadges-CyC_cpPA.js (new) — 1.77 kB 🔴 +1.77 kB 🔴 +892 B 🔴 +790 B
assets/cloudSubscription-CRSQlPsf.js (new) — 1.68 kB 🔴 +1.68 kB 🔴 +816 B 🔴 +708 B
assets/cloudSubscription-D3I1aI0N.js (removed) 1.68 kB — 🟢 -1.68 kB 🟢 -815 B 🟢 -706 B
assets/previousFullPath-DkDWhl71.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -694 B 🟢 -596 B
assets/previousFullPath-DmYU9cfO.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +694 B 🔴 +591 B
assets/Load3D-CjM-z8sc.js (new) — 1.34 kB 🔴 +1.34 kB 🔴 +613 B 🔴 +547 B
assets/Load3D-DlOIk392.js (removed) 1.34 kB — 🟢 -1.34 kB 🟢 -615 B 🟢 -545 B
assets/nightlyBadges-2vLJd4P9.js (new) — 1.29 kB 🔴 +1.29 kB 🔴 +660 B 🔴 +583 B
assets/nightlyBadges-81R-l4-d.js (removed) 1.29 kB — 🟢 -1.29 kB 🟢 -659 B 🟢 -578 B
assets/Load3dViewerContent-B7Cf0u9d.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +565 B 🔴 +504 B
assets/Load3dViewerContent-RLY_qupV.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -568 B 🟢 -499 B
assets/SubscriptionPanelContentWorkspace-Cj5Vtggu.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +534 B 🔴 +467 B
assets/SubscriptionPanelContentWorkspace-Cv7ID0RY.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -535 B 🟢 -467 B
assets/WidgetLegacy-Do1mLSBR.js (removed) 978 B — 🟢 -978 B 🟢 -482 B 🟢 -425 B
assets/WidgetLegacy-DQFC2SI9.js (new) — 978 B 🔴 +978 B 🔴 +481 B 🔴 +427 B
assets/changeTracker-Ccvpmj8U.js (removed) 953 B — 🟢 -953 B 🟢 -472 B 🟢 -413 B
assets/changeTracker-ytJy7R7c.js (new) — 953 B 🔴 +953 B 🔴 +471 B 🔴 +409 B

Status: 56 added / 56 removed / 79 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 262ms TBT · 152.5 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 143.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.7 MB heap

⚠️ 7 regressions detected

Metric Baseline PR (median) Δ Sig
canvas-idle: script duration 20ms 30ms +50% ⚠️ z=2.1
canvas-mouse-sweep: layout duration 3ms 4ms +22% ⚠️ z=2.5
canvas-mouse-sweep: style recalc duration 46ms 50ms +8% ⚠️ z=2.3
large-graph-pan: task duration 1077ms 1202ms +12% ⚠️ z=2.8
minimap-idle: task duration 545ms 624ms +14% ⚠️ z=2.0
subgraph-idle: style recalc duration 10ms 13ms +35% ⚠️ z=3.2
subgraph-mouse-sweep: task duration 933ms 964ms +3% ⚠️ z=2.9
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 10ms +15% z=-1.4
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 +0% z=-2.1
canvas-idle: task duration 362ms 424ms +17% z=1.0
canvas-idle: script duration 20ms 30ms +50% ⚠️ z=2.1
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 60.9 MB 60.3 MB -1% —
canvas-idle: DOM nodes 19 20 +5% z=-2.0
canvas-idle: event listeners 6 6 +0% z=-1.2
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms -1% —
canvas-mouse-sweep: layout duration 3ms 4ms +22% ⚠️ z=2.5
canvas-mouse-sweep: style recalc duration 46ms 50ms +8% ⚠️ z=2.3
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 84 79 -6% z=0.1
canvas-mouse-sweep: task duration 941ms 893ms -5% z=0.5
canvas-mouse-sweep: script duration 139ms 133ms -4% z=-0.3
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 56.5 MB 57.1 MB +1% —
canvas-mouse-sweep: DOM nodes 65 64 -2% z=0.7
canvas-mouse-sweep: event listeners 6 6 +0% z=-0.6
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +2% z=1.4
canvas-zoom-sweep: style recalc duration 18ms 19ms +7% z=0.1
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 30 31 +3% z=-0.6
canvas-zoom-sweep: task duration 299ms 365ms +22% z=1.6
canvas-zoom-sweep: script duration 25ms 31ms +22% z=1.2
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 64.2 MB 64.1 MB -0% —
canvas-zoom-sweep: DOM nodes 79 79 +0% z=-0.3
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.6
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 11ms +32% z=1.5
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 13 +8% z=-0.2
dom-widget-clipping: task duration 347ms 368ms +6% z=0.2
dom-widget-clipping: script duration 68ms 64ms -6% z=-1.3
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 47.1 MB 46.9 MB -1% —
dom-widget-clipping: DOM nodes 20 21 +5% z=-0.8
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 12ms 10ms -20% z=-2.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 11 10 -9% z=-5.1
large-graph-idle: task duration 550ms 625ms +14% z=1.5
large-graph-idle: script duration 99ms 104ms +5% z=0.1
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 53.0 MB 53.4 MB +1% —
large-graph-idle: DOM nodes -255 -256 +0% z=-310.6
large-graph-idle: event listeners -127 -127 +0% z=-25.1
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 15ms 18ms +20% z=0.5
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 70 +3% z=0.7
large-graph-pan: task duration 1077ms 1202ms +12% ⚠️ z=2.8
large-graph-pan: script duration 395ms 417ms +6% z=0.5
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 69.0 MB 65.2 MB -5% —
large-graph-pan: DOM nodes -261 -261 +0% z=-169.7
large-graph-pan: event listeners -127 -125 -2% z=-156.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 8ms +17% —
large-graph-zoom: style recalc duration 17ms 17ms -0% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 66 65 -2% —
large-graph-zoom: task duration 1318ms 1408ms +7% —
large-graph-zoom: script duration 499ms 494ms -1% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 59.6 MB 59.5 MB -0% —
large-graph-zoom: DOM nodes -265 -264 -0% —
large-graph-zoom: event listeners -123 -123 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 9ms 10ms +8% z=-0.0
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 10 10 +0% z=0.6
minimap-idle: task duration 545ms 624ms +14% ⚠️ z=2.0
minimap-idle: script duration 98ms 98ms +0% z=-0.1
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 54.3 MB 54.0 MB -1% —
minimap-idle: DOM nodes -258 -259 +0% z=-203.4
minimap-idle: event listeners -127 -125 -2% z=-196.2
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 12ms 13ms +2% z=-0.1
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 47 -2% z=-1.6
subgraph-dom-widget-clipping: task duration 358ms 382ms +7% z=0.2
subgraph-dom-widget-clipping: script duration 125ms 125ms -0% z=-0.5
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 47.3 MB 47.5 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 22 20 -9% z=-1.9
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.7
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 10ms 13ms +35% ⚠️ z=3.2
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 11 +0% z=0.2
subgraph-idle: task duration 367ms 414ms +13% z=1.4
subgraph-idle: script duration 22ms 25ms +15% z=1.7
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 60.3 MB 60.5 MB +0% —
subgraph-idle: DOM nodes 21 22 +5% z=0.1
subgraph-idle: event listeners 6 6 +0% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 4ms 5ms +10% z=0.7
subgraph-mouse-sweep: style recalc duration 48ms 49ms +3% z=2.0
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 84 84 +0% z=2.0
subgraph-mouse-sweep: task duration 933ms 964ms +3% ⚠️ z=2.9
subgraph-mouse-sweep: script duration 104ms 111ms +6% z=1.5
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 52.2 MB 52.6 MB +1% —
subgraph-mouse-sweep: DOM nodes 73 73 +0% z=2.7
subgraph-mouse-sweep: event listeners 6 6 +0% variance too high
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 43ms 47ms +9% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 251 251 +0% —
viewport-pan-sweep: task duration 3647ms 4101ms +12% —
viewport-pan-sweep: script duration 1232ms 1326ms +8% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 73.0 MB 74.0 MB +1% —
viewport-pan-sweep: DOM nodes -256 -259 +1% —
viewport-pan-sweep: event listeners -111 -109 -2% —
vue-large-graph-idle: avg frame time 17ms 17ms -0% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 5ms 0ms -100% —
vue-large-graph-idle: style recalc duration 18ms 0ms -100% —
vue-large-graph-idle: layout count 1 0 -100% —
vue-large-graph-idle: style recalc count 1 0 -100% —
vue-large-graph-idle: task duration 13016ms 10744ms -17% —
vue-large-graph-idle: script duration 623ms 593ms -5% —
vue-large-graph-idle: TBT 1226ms 262ms -79% —
vue-large-graph-idle: heap used 160.6 MB 152.5 MB -5% —
vue-large-graph-idle: DOM nodes -8329 -9850 +18% —
vue-large-graph-idle: event listeners -14696 -23962 +63% —
vue-large-graph-pan: avg frame time 17ms 17ms +0% —
vue-large-graph-pan: p95 frame time 17ms 17ms +1% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 14ms 16ms +10% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 67 66 -1% —
vue-large-graph-pan: task duration 14515ms 13065ms -10% —
vue-large-graph-pan: script duration 882ms 891ms +1% —
vue-large-graph-pan: TBT 26ms 0ms -100% —
vue-large-graph-pan: heap used 144.2 MB 143.5 MB -1% —
vue-large-graph-pan: DOM nodes -9850 -9850 +0% —
vue-large-graph-pan: event listeners -23983 -23961 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 2ms +27% z=1.1
workflow-execution: style recalc duration 22ms 26ms +19% z=0.8
workflow-execution: layout count 5 4 -20% z=-1.7
workflow-execution: style recalc count 16 19 +19% z=0.6
workflow-execution: task duration 114ms 132ms +16% z=0.8
workflow-execution: script duration 24ms 28ms +15% z=-0.5
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 46.8 MB 46.7 MB -0% —
workflow-execution: DOM nodes 158 156 -1% z=-0.7
workflow-execution: event listeners 71 71 +0% z=4.4
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-04-15T09:58:46.761Z",
  "gitSha": "3ed76d8448cb4791595a68e6c62863d4f0e75441",
  "branch": "fix/promoted-indicator-nested-subgraph",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2064.1669999999976,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.310000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.79400000000004,
      "heapDeltaBytes": 20906840,
      "heapUsedBytes": 63866388,
      "domNodes": 20,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 30.197999999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2031.9320000000403,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.536,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.34800000000007,
      "heapDeltaBytes": 20359900,
      "heapUsedBytes": 62927188,
      "domNodes": 20,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 29.999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.0030000000033,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.363000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 377.04400000000004,
      "heapDeltaBytes": 20058440,
      "heapUsedBytes": 63222236,
      "domNodes": 20,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 20.423,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2256.7190000000037,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 59.255,
      "layouts": 12,
      "layoutDurationMs": 4.388000000000001,
      "taskDurationMs": 1222.177,
      "heapDeltaBytes": 16798136,
      "heapUsedBytes": 59856420,
      "domNodes": 67,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 157.88,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1881.8049999999857,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 45.287,
      "layouts": 12,
      "layoutDurationMs": 3.8810000000000002,
      "taskDurationMs": 831.335,
      "heapDeltaBytes": 16291672,
      "heapUsedBytes": 60159000,
      "domNodes": 63,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 133.467,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1968.4140000000525,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 49.864999999999995,
      "layouts": 12,
      "layoutDurationMs": 4.11,
      "taskDurationMs": 892.898,
      "heapDeltaBytes": 16345180,
      "heapUsedBytes": 58941164,
      "domNodes": 64,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 130.44400000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.675999999994,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.616,
      "layouts": 6,
      "layoutDurationMs": 0.7070000000000002,
      "taskDurationMs": 372.479,
      "heapDeltaBytes": 15380576,
      "heapUsedBytes": 67194164,
      "domNodes": 79,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 30.229,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.246999999963,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.744000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.8049999999999999,
      "taskDurationMs": 351.58199999999994,
      "heapDeltaBytes": -107552,
      "heapUsedBytes": 48891768,
      "domNodes": 78,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 31.958000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.5579999998981,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.254,
      "layouts": 6,
      "layoutDurationMs": 0.6099999999999999,
      "taskDurationMs": 364.87800000000004,
      "heapDeltaBytes": 15683272,
      "heapUsedBytes": 67504860,
      "domNodes": 81,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 30.845,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 647.5230000000067,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 11.158000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.1790000000001,
      "heapDeltaBytes": 6794836,
      "heapUsedBytes": 49424084,
      "domNodes": 21,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 68.452,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 602.23000000002,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 11.091,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.608,
      "heapDeltaBytes": 6541292,
      "heapUsedBytes": 49135176,
      "domNodes": 25,
      "jsHeapTotalBytes": 13893632,
      "scriptDurationMs": 63.725,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 552.6709999999184,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.458,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.954,
      "heapDeltaBytes": 6022684,
      "heapUsedBytes": 49089816,
      "domNodes": 19,
      "jsHeapTotalBytes": 13893632,
      "scriptDurationMs": 55.77,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.6180000000045,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.326,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 624.983,
      "heapDeltaBytes": 4626924,
      "heapUsedBytes": 55995056,
      "domNodes": -260,
      "jsHeapTotalBytes": 15917056,
      "scriptDurationMs": 103.711,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2062.7719999999954,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 11.029000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 665.9770000000001,
      "heapDeltaBytes": 4682232,
      "heapUsedBytes": 55753776,
      "domNodes": -255,
      "jsHeapTotalBytes": 15917056,
      "scriptDurationMs": 107.157,
      "eventListeners": -121,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.4489999999241,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.554,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.612,
      "heapDeltaBytes": 20030928,
      "heapUsedBytes": 72005252,
      "domNodes": -256,
      "jsHeapTotalBytes": 14663680,
      "scriptDurationMs": 103.72200000000001,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2197.6510000000076,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.72,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1228.1449999999998,
      "heapDeltaBytes": 15721148,
      "heapUsedBytes": 67822260,
      "domNodes": -261,
      "jsHeapTotalBytes": 17170432,
      "scriptDurationMs": 411.571,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2175.576000000035,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 18.142,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1200.6889999999999,
      "heapDeltaBytes": 16418352,
      "heapUsedBytes": 68410176,
      "domNodes": -256,
      "jsHeapTotalBytes": 17432576,
      "scriptDurationMs": 421.956,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2178.472000000056,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 16.892000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1202.449,
      "heapDeltaBytes": 18616080,
      "heapUsedBytes": 71981328,
      "domNodes": -261,
      "jsHeapTotalBytes": 17956864,
      "scriptDurationMs": 417.05499999999995,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3230.5599999999968,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 19.658,
      "layouts": 60,
      "layoutDurationMs": 8.28,
      "taskDurationMs": 1450.2189999999998,
      "heapDeltaBytes": 2706780,
      "heapUsedBytes": 57736384,
      "domNodes": -263,
      "jsHeapTotalBytes": 16703488,
      "scriptDurationMs": 493.647,
      "eventListeners": -121,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3166.22000000001,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 16.602,
      "layouts": 60,
      "layoutDurationMs": 8.228000000000002,
      "taskDurationMs": 1383.0580000000002,
      "heapDeltaBytes": 7202500,
      "heapUsedBytes": 62343536,
      "domNodes": -267,
      "jsHeapTotalBytes": 17752064,
      "scriptDurationMs": 484.39099999999996,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3231.843000000026,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.165,
      "layouts": 60,
      "layoutDurationMs": 8.275,
      "taskDurationMs": 1407.7630000000001,
      "heapDeltaBytes": 8973976,
      "heapUsedBytes": 65100384,
      "domNodes": -264,
      "jsHeapTotalBytes": 17285120,
      "scriptDurationMs": 509.66100000000006,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.9409999999552,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.536000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 624.121,
      "heapDeltaBytes": 2650160,
      "heapUsedBytes": 56586552,
      "domNodes": -264,
      "jsHeapTotalBytes": 15392768,
      "scriptDurationMs": 97.53699999999999,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.9499999999857,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.844,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 625.9129999999999,
      "heapDeltaBytes": 4106436,
      "heapUsedBytes": 55971088,
      "domNodes": -259,
      "jsHeapTotalBytes": 16703488,
      "scriptDurationMs": 102.77999999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.4659999999758,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.133,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 558.5949999999999,
      "heapDeltaBytes": 4501880,
      "heapUsedBytes": 57800480,
      "domNodes": -258,
      "jsHeapTotalBytes": 15425536,
      "scriptDurationMs": 94.251,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 631.465999999989,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.657,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.7339999999999,
      "heapDeltaBytes": 6730384,
      "heapUsedBytes": 49853068,
      "domNodes": 20,
      "jsHeapTotalBytes": 13369344,
      "scriptDurationMs": 137.33599999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 571.0339999999974,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.998999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 382.22999999999996,
      "heapDeltaBytes": 6150680,
      "heapUsedBytes": 50722036,
      "domNodes": 22,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 121.195,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.3310000000292,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.866999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.556,
      "heapDeltaBytes": 6485120,
      "heapUsedBytes": 49673520,
      "domNodes": 20,
      "jsHeapTotalBytes": 13369344,
      "scriptDurationMs": 125.037,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2001.5000000000214,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 12.923999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.245,
      "heapDeltaBytes": 19954628,
      "heapUsedBytes": 64111872,
      "domNodes": 23,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 24.857000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2027.2820000000138,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.595000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.597,
      "heapDeltaBytes": 10549836,
      "heapUsedBytes": 62773536,
      "domNodes": 22,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 26.182000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.9730000000454,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 15.698999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 380.17100000000005,
      "heapDeltaBytes": 20124388,
      "heapUsedBytes": 63402504,
      "domNodes": 20,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 22.712,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1811.7560000000026,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 45.663,
      "layouts": 16,
      "layoutDurationMs": 5.787999999999999,
      "taskDurationMs": 805.023,
      "heapDeltaBytes": 12302220,
      "heapUsedBytes": 55190448,
      "domNodes": 66,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 114.04099999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 2007.3739999999702,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 49.092,
      "layouts": 16,
      "layoutDurationMs": 4.649,
      "taskDurationMs": 963.505,
      "heapDeltaBytes": 11542288,
      "heapUsedBytes": 54842768,
      "domNodes": 73,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 100.08600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1988.5459999999284,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 52.661,
      "layouts": 16,
      "layoutDurationMs": 4.928999999999999,
      "taskDurationMs": 1007.2080000000001,
      "heapDeltaBytes": 12235528,
      "heapUsedBytes": 55358336,
      "domNodes": 73,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 110.732,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8170.3469999999925,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 49.749,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4210.761,
      "heapDeltaBytes": 17575656,
      "heapUsedBytes": 77983056,
      "domNodes": -259,
      "jsHeapTotalBytes": 18595840,
      "scriptDurationMs": 1329.55,
      "eventListeners": -109,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8228.291999999954,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 46.800999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4101.039,
      "heapDeltaBytes": 25102216,
      "heapUsedBytes": 77584084,
      "domNodes": -259,
      "jsHeapTotalBytes": 19529728,
      "scriptDurationMs": 1296.385,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8320.093000000043,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 47.144000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4095.0999999999995,
      "heapDeltaBytes": -20423124,
      "heapUsedBytes": 51666576,
      "domNodes": -251,
      "jsHeapTotalBytes": 21889024,
      "scriptDurationMs": 1325.71,
      "eventListeners": -109,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11425.005999999996,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 17.154000000000003,
      "layouts": 1,
      "layoutDurationMs": 4.380000000000009,
      "taskDurationMs": 11399.902,
      "heapDeltaBytes": -35487864,
      "heapUsedBytes": 159435192,
      "domNodes": -8329,
      "jsHeapTotalBytes": 26828800,
      "scriptDurationMs": 603.829,
      "eventListeners": -14702,
      "totalBlockingTimeMs": 1117,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10699.180000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10679.867999999999,
      "heapDeltaBytes": -29226016,
      "heapUsedBytes": 168614160,
      "domNodes": -9850,
      "jsHeapTotalBytes": 26566656,
      "scriptDurationMs": 589.4699999999999,
      "eventListeners": -23962,
      "totalBlockingTimeMs": 251,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10760.765999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10744.006,
      "heapDeltaBytes": -54308092,
      "heapUsedBytes": 159861980,
      "domNodes": -9850,
      "jsHeapTotalBytes": 17391616,
      "scriptDurationMs": 593.4939999999999,
      "eventListeners": -23963,
      "totalBlockingTimeMs": 262,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13203.18599999996,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.616999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13181.419000000002,
      "heapDeltaBytes": -67312656,
      "heapUsedBytes": 149758356,
      "domNodes": -9850,
      "jsHeapTotalBytes": -10395648,
      "scriptDurationMs": 874.7280000000001,
      "eventListeners": -23961,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13094.673,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.637999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13064.881,
      "heapDeltaBytes": -63825108,
      "heapUsedBytes": 150421268,
      "domNodes": -9850,
      "jsHeapTotalBytes": -10395648,
      "scriptDurationMs": 890.5110000000001,
      "eventListeners": -23961,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13022.695999999996,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.23399999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12998.598,
      "heapDeltaBytes": -40776848,
      "heapUsedBytes": 173961800,
      "domNodes": -9850,
      "jsHeapTotalBytes": -8122368,
      "scriptDurationMs": 925.3549999999999,
      "eventListeners": -23958,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 446.0109999999986,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 26.025,
      "layouts": 4,
      "layoutDurationMs": 1.3109999999999997,
      "taskDurationMs": 131.77300000000002,
      "heapDeltaBytes": 4620764,
      "heapUsedBytes": 49019828,
      "domNodes": 169,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 24.974999999999998,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.4870000000019,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 20.221,
      "layouts": 4,
      "layoutDurationMs": 1.706,
      "taskDurationMs": 97.68199999999999,
      "heapDeltaBytes": 2763096,
      "heapUsedBytes": 47124156,
      "domNodes": 140,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.606000000000005,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 458.2029999999122,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.682,
      "layouts": 6,
      "layoutDurationMs": 1.731,
      "taskDurationMs": 138.79,
      "heapDeltaBytes": 4567240,
      "heapUsedBytes": 48989096,
      "domNodes": 156,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.045,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/core/graph/subgraph/promotedWidgetIndicator.test.ts (1)

41-41: Consider using createTestRootGraph() directly.

The current code creates a subgraph just to access its rootGraph, discarding the subgraph itself. The createTestRootGraph() helper from the same fixtures module would be cleaner.

♻️ Suggested refactor
-    const rootGraph = createTestSubgraph().rootGraph
+    const rootGraph = createTestRootGraph()

You would need to add createTestRootGraph to the imports:

import {
  createTestRootGraph,
  createTestSubgraph,
  createTestSubgraphNode,
  resetSubgraphFixtureState
} from '@/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers'

Based on learnings: "createTestSubgraph() is only appropriate when the test does not need to control or reference the parent LGraph."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/core/graph/subgraph/promotedWidgetIndicator.test.ts` at line 41, The test
creates a subgraph only to access its rootGraph; replace the call to
createTestSubgraph().rootGraph with createTestRootGraph() and update the imports
to include createTestRootGraph (and remove createTestSubgraph if it becomes
unused). Locate the rootGraph assignment in promotedWidgetIndicator.test.ts and
change the expression to use createTestRootGraph(), adjusting imports
accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/core/graph/subgraph/promotedWidgetIndicator.test.ts`:
- Around line 99-121: The test shows a key mismatch between
makePromotionEntryKey stored keys and the lookup performed by
promotionStore.isPromotedByAny: fix this by making lookup keys consistent with
stored keys — either stop appending disambiguatingSourceNodeId when the stored
promotion key has no disambiguator or ensure promotions are stored with the
disambiguator too; additionally ensure the sourceNodeId passed into
isPromotedByAny (from NodeWidgets.vue) is the original promotion source id
(e.g., subBNodeId) rather than the host node id (subANodeId) so
makePromotionEntryKey({ sourceNodeId, sourceWidgetName,
disambiguatingSourceNodeId }) produces the same key format as when the promotion
was saved (check callers that construct sourceNodeId and change NodeWidgets.vue
or normalize inside isPromotedByAny/makePromotionEntryKey accordingly).

---

Nitpick comments:
In `@src/core/graph/subgraph/promotedWidgetIndicator.test.ts`:
- Line 41: The test creates a subgraph only to access its rootGraph; replace the
call to createTestSubgraph().rootGraph with createTestRootGraph() and update the
imports to include createTestRootGraph (and remove createTestSubgraph if it
becomes unused). Locate the rootGraph assignment in
promotedWidgetIndicator.test.ts and change the expression to use
createTestRootGraph(), adjusting imports accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0cf063ce-67b7-4a4b-89af-cbcfa76e29e3

📥 Commits

Reviewing files that changed from the base of the PR and between f4fb7a4 and 12992c3.

📒 Files selected for processing (1)
  • src/core/graph/subgraph/promotedWidgetIndicator.test.ts

Reproduces #10612 where the promoted widget ring indicator is missing
on nested subgraphs due to a key mismatch in isPromotedByAny lookup.
The isPromotedByAny check was only looking up the key with
disambiguatingSourceNodeId, missing promotions stored without one.
Now tries both with and without the disambiguating segment so
nested subgraph promotions are detected regardless of storage shape.

Fixes #10612
@dante01yoon
dante01yoon force-pushed the fix/promoted-indicator-nested-subgraph branch from 12992c3 to fd9e732 Compare April 4, 2026 15:14

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/core/graph/subgraph/promotedWidgetIndicator.test.ts (1)

76-83: Consider using type narrowing instead of double-cast through fromAny.

The fromAny helper from @total-typescript/shoehorn is typically for test scenarios where you need to bypass strict typing. Here, you're accessing wrapper.vm.processedWidgets which is a known property. A simpler approach using type assertion might be clearer.

♻️ Suggested refactor
 function getBorderStyles(wrapper: ReturnType<typeof mount>) {
-  return fromAny<{ processedWidgets: unknown[] }, unknown>(
-    wrapper.vm
-  ).processedWidgets.map(
-    (entry) =>
-      (entry as { simplified: { borderStyle?: string } }).simplified.borderStyle
-  )
+  const vm = wrapper.vm as unknown as {
+    processedWidgets: Array<{ simplified: { borderStyle?: string } }>
+  }
+  return vm.processedWidgets.map((entry) => entry.simplified.borderStyle)
 }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/core/graph/subgraph/promotedWidgetIndicator.test.ts` around lines 76 -
83, The test helper getBorderStyles currently double-casts wrapper.vm through
fromAny; instead directly narrow the type of wrapper.vm to access
processedWidgets (e.g. assert wrapper.vm as { processedWidgets: { simplified: {
borderStyle?: string } }[] }) and then map over processedWidgets to return
simplified.borderStyle; update references to getBorderStyles, wrapper.vm,
processedWidgets and simplified.borderStyle to use this direct type assertion or
an explicit local interface rather than fromAny.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/core/graph/subgraph/promotedWidgetIndicator.test.ts`:
- Around line 76-83: The test helper getBorderStyles currently double-casts
wrapper.vm through fromAny; instead directly narrow the type of wrapper.vm to
access processedWidgets (e.g. assert wrapper.vm as { processedWidgets: {
simplified: { borderStyle?: string } }[] }) and then map over processedWidgets
to return simplified.borderStyle; update references to getBorderStyles,
wrapper.vm, processedWidgets and simplified.borderStyle to use this direct type
assertion or an explicit local interface rather than fromAny.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3039742a-57f0-4d57-a465-1725137a8854

📥 Commits

Reviewing files that changed from the base of the PR and between 12992c3 and fd9e732.

📒 Files selected for processing (2)
  • src/core/graph/subgraph/promotedWidgetIndicator.test.ts
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphNested.spec.ts (1)

512-518: Prefer expect.poll for this single-call retry assertion.

Line 512 uses toPass for one async read (count()) and one assertion; expect.poll is the clearer and recommended pattern here.

♻️ Proposed refactor
-        await comfyExpect(async () => {
-          const count = await intermediateRings.count()
-          expect(
-            count,
-            'Node 6 (Sub 1) should have at least one promoted ring'
-          ).toBeGreaterThan(0)
-        }).toPass({ timeout: 5000 })
+        await expect
+          .poll(() => intermediateRings.count(), {
+            timeout: 5000,
+            message: 'Node 6 (Sub 1) should have at least one promoted ring'
+          })
+          .toBeGreaterThan(0)

As per coding guidelines: "Prefer expect.poll() over expect(async () => { ... }).toPass() when the block contains a single async call with a single assertion".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphNested.spec.ts` around lines 512 - 518,
Replace the comfyExpect(...).toPass retry pattern with expect.poll for the
single async call; specifically, swap the comfyExpect wrapper and its inner
async block that calls intermediateRings.count() with expect.poll(() =>
intermediateRings.count()).toBeGreaterThan(0, { timeout: 5000 }) so the test
retries the count until it's > 0 using the built-in expect.poll API (keep the
same timeout and assertion target).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphNested.spec.ts`:
- Around line 512-518: Replace the comfyExpect(...).toPass retry pattern with
expect.poll for the single async call; specifically, swap the comfyExpect
wrapper and its inner async block that calls intermediateRings.count() with
expect.poll(() => intermediateRings.count()).toBeGreaterThan(0, { timeout: 5000
}) so the test retries the count until it's > 0 using the built-in expect.poll
API (keep the same timeout and assertion target).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 52fed46a-f144-4b39-bf79-fb47ea6c39fe

📥 Commits

Reviewing files that changed from the base of the PR and between c601aab and 71a4098.

📒 Files selected for processing (1)
  • browser_tests/tests/subgraph/subgraphNested.spec.ts

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphNested.spec.ts (1)

519-525: Use expect.poll() instead of single-call toPass()

This block has one async read (intermediateRings.count()) and one assertion, so expect.poll() is the clearer retry primitive here.

♻️ Suggested refactor
-        await comfyExpect(async () => {
-          const count = await intermediateRings.count()
-          expect(
-            count,
-            'Node 6 (Sub 1) should have at least one promoted ring'
-          ).toBeGreaterThan(0)
-        }).toPass({ timeout: 5000 })
+        await expect
+          .poll(async () => intermediateRings.count(), {
+            timeout: 5000,
+            message: 'Node 6 (Sub 1) should have at least one promoted ring'
+          })
+          .toBeGreaterThan(0)

As per coding guidelines: "Prefer expect.poll() over expect(async () => { ... }).toPass() when the block contains a single async call with a single assertion."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphNested.spec.ts` around lines 519 - 525,
The test uses comfyExpect(...).toPass() around a single async read and
assertion; replace that with expect.poll() to align with the guideline: call
expect.poll(() => intermediateRings.count()) and assert the polled value with
.toBeGreaterThan(0) (or use expect.poll(async () => await
intermediateRings.count()).toBeGreaterThan(0) if needed), removing the
comfyExpect wrapper and keeping the same timeout of 5000ms so the retry
behaviour and message ("Node 6 (Sub 1) should have at least one promoted ring")
are preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphNested.spec.ts`:
- Around line 519-525: The test uses comfyExpect(...).toPass() around a single
async read and assertion; replace that with expect.poll() to align with the
guideline: call expect.poll(() => intermediateRings.count()) and assert the
polled value with .toBeGreaterThan(0) (or use expect.poll(async () => await
intermediateRings.count()).toBeGreaterThan(0) if needed), removing the
comfyExpect wrapper and keeping the same timeout of 5000ms so the retry
behaviour and message ("Node 6 (Sub 1) should have at least one promoted ring")
are preserved.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2f11177d-3d39-470d-ba07-6da4154ad6e6

📥 Commits

Reviewing files that changed from the base of the PR and between 71a4098 and 735d639.

📒 Files selected for processing (1)
  • browser_tests/tests/subgraph/subgraphNested.spec.ts

@dante01yoon
dante01yoon marked this pull request as ready for review April 5, 2026 12:13
@dante01yoon
dante01yoon requested a review from a team April 5, 2026 12:13
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 5, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

@coderabbitai approve

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 5, 2026
@coderabbitai

coderabbitai Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Comments resolved and changes approved.

Comment on lines +393 to +408
const sourceWidgetName = widget.storeName ?? widget.name
// Promotions stored for non-SubgraphNode inner nodes omit the
// disambiguatingSourceNodeId, but the widget's storeNodeId causes
// one to be computed here. Check both key shapes to handle nested
// subgraph promotions correctly (#10612).
const isPromoted =
graphId &&
promotionStore.isPromotedByAny(graphId, {
(promotionStore.isPromotedByAny(graphId, {
sourceNodeId: hostNodeId,
sourceWidgetName: widget.storeName ?? widget.name,
sourceWidgetName,
disambiguatingSourceNodeId: promotionSourceNodeId
})
? 'ring ring-component-node-widget-promoted'
: mergedOptions.advanced
? 'ring ring-component-node-widget-advanced'
: undefined
}) ||
promotionStore.isPromotedByAny(graphId, {
sourceNodeId: hostNodeId,
sourceWidgetName
}))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is complex enough to graduate into promotionUtils so the logic can be shared with BaseWidget and domWidget.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — the promoted indicator check is duplicated across NodeWidgets.vue, domWidget.ts, and BaseWidget.ts. Will extract it into promotionUtils.ts as a shared isWidgetPromoted(graphId, hostNodeId, sourceWidgetName, disambiguatingSourceNodeId?) function.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled in 91a754f. I did extract the shared lookup, but kept it in a lightweight promotionLookup.ts helper rather than the existing promotionUtils.ts so BaseWidget/domWidget/useProcessedWidgets can share the hot-path logic without pulling in the heavier promotion utils dependency graph.

const outerRings = outerNode.locator(`.${PROMOTED_BORDER_CLASS}`)
await comfyExpect(outerRings).toHaveCount(0)

// Navigate into Sub 0 programmatically to avoid click interception

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a bug with entering subgraphs via our utilities we should fix that.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bug — enterSubgraph works correctly here. I used the manual double-click approach initially during development when debugging the subgraph navigation flow, but comfyPage.vueNodes.enterSubgraph('5') is the right call. Will switch to it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 91a754f — the test now uses comfyPage.vueNodes.enterSubgraph('5') instead of mutating canvas state from page.evaluate.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to request

@DrJKL DrJKL assigned dante01yoon and unassigned DrJKL Apr 7, 2026
Move promotion entry resolution logic (linked/fallback merging, alias
pruning, persistence decisions) into a standalone module to reduce
SubgraphNode method count and improve readability.

- Extract resolvePromotionEntries, buildLinkedReconcileEntries,
  buildDisplayNameByViewKey, makePromotionViewKey into
  PromotionEntryResolver.ts
- Remove 12 private methods (~280 lines) from SubgraphNode
- Eliminate _makePromotionEntryKey wrapper (use store export directly)
- Add 10 characterization tests pinning promotion entry resolution
  behavior before refactoring
Address Codex adversarial review findings:

1. [high] Fix at data layer instead of read-time fallback: during
   SubgraphNode._internalConfigureAfterSlots, resolve the concrete
   node for entries targeting SubgraphNodes and store the correct
   disambiguatingSourceNodeId. This ensures ALL promotion consumers
   (ring, side panel, demote) see consistent keys.

2. [medium] Prevent over-matching of duplicate-named widgets: replace
   the unconditional base-key fallback with dual-indexed ref counts.
   Disambiguated entries now increment both exact and base keys, so
   exact lookups (Vue renderer) match precisely while base lookups
   (legacy BaseWidget) still work without a disambiguator.

3. Simplify isWidgetPromoted to a pass-through — no special fallback
   logic needed since the data is correct at the source.
@dante01yoon dante01yoon assigned DrJKL and unassigned dante01yoon Apr 13, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

@coderabbitai approve

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 13, 2026
@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Comments resolved and changes approved.

"properties": {
"proxyWidgets": [
["5", "string_a"],
["9", "string_a"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping — still curious about this. Was the original ["5", "string_a"] entry pointing at the wrong node (node 5 is the outermost SubgraphNode, while node 9 is an inner concrete node)?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes — the original ['5', 'string_a'] was pointing at the wrong node for that nested promotion. proxyWidgets on node 6 are scoped to Sub 1's local graph, so the nested string_a entry needs to target inner node 9, not the outer SubgraphNode 5. I also added an inline comment in the spec to make that scope explicit.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix — root cause analysis is solid and the dual-indexing approach is well thought out. Tests pass, typecheck clean, knip clean. A few inline suggestions below, none blocking.

: mergedOptions

const borderStyle =
const sourceWidgetName = widget.slotName ?? widget.name

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storeName → slotName — semantic change worth verifying

The old code used widget.storeName ?? widget.name (the resolved interior widget name, e.g. text). The new code uses widget.slotName ?? widget.name (the subgraph input slot name, e.g. value_1).

For the nested case this is correct — sourceWidgetName in the store is set to targetInput.name (SubgraphNode.ts L157) which is the slot name. But this changes lookup semantics for all promoted widgets, not only nested ones.

Can you confirm there is no scenario where slotName is undefined but storeName would have been set and was the correct lookup key? The dual-indexing in the store provides a safety net, but it would be good to verify this explicitly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add to this: the promotion entries in SubgraphNode.ts set sourceWidgetName from either targetInput.name (L157, the slot name) or targetWidget.name (L163, the widget name). For non-subgraph sources these are typically the same, but for the nested subgraph case they can diverge — slotName matches the slot-based path (L157) while storeName matches the widget-based path (L163).

The dual-indexed base key masks potential mismatches, but ideally a comment here would explain why slotName is the correct lookup key for the nested case, so future readers don't have to re-derive the reasoning.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and documented in 91a754f. For the nested case the store key is slot-based, so slotName is the correct lookup key; storeName still tracks the concrete leaf widget and is now only used as the disambiguator. I added a code comment in useProcessedWidgets.ts to spell that out.

sourceWidgetName,
...(disambiguatingSourceNodeId && { disambiguatingSourceNodeId })
})
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing isPromotedByAny rather than adding isWidgetPromoted alongside it

isWidgetPromoted is a thin wrapper that destructures positional args into a PromotedWidgetSource object, then delegates to isPromotedByAny. Both are now exported. Since all three call sites (BaseWidget, domWidget, useProcessedWidgets) have been migrated to isWidgetPromoted, consider making isPromotedByAny private (remove from the return object) to reduce the store's public API surface.

If external callers (extensions, tests) need isPromotedByAny, keeping both is fine — but worth a conscious decision.

Suggested change
}
function isWidgetPromoted(
graphId: UUID,
sourceNodeId: string,
sourceWidgetName: string,
disambiguatingSourceNodeId?: string
): boolean {
return isPromotedByAny(graphId, {
sourceNodeId,
sourceWidgetName,
...(disambiguatingSourceNodeId && { disambiguatingSourceNodeId })
})
}
return {
getPromotionsRef,
getPromotions,
isPromoted,
isPromotedByAny,
isWidgetPromoted,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 — after the planned extraction to promotionUtils, it would be a good time to also make isPromotedByAny private (remove from the store's return object). All external callers now use isWidgetPromoted, and tests can access internal methods via the store instance directly if needed.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left isPromotedByAny exported for now. There are still direct internal call sites/tests built around the object-form API, so I wanted to keep this follow-up scoped to the behavior/perf fixes; making it private would be a reasonable follow-up cleanup.

@@ -0,0 +1,152 @@
import { createTestingPinia } from '@pinia/testing'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider colocating this test with the renderer composable

This test renders NodeWidgets.vue and asserts on the promoted ring CSS class — it's really testing the useProcessedWidgets → promotionStore integration from the renderer's perspective. src/renderer/extensions/vueNodes/composables/ (alongside useProcessedWidgets.test.ts) might be a more natural home.

Not blocking — just a suggestion for discoverability.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the test in its current file for now to keep this PR focused on the promotion regression and follow-up review fixes. Agreed that colocating it with the renderer composable could improve discoverability in a later cleanup.

… tag, retrying assertion

- Replace manual page.evaluate subgraph navigation with enterSubgraph('5')
- Use @vue-nodes tag (from #11184) instead of manual beforeEach setting
- Replace expect.poll with comfyExpect retrying assertion per Playwright best practices
enterSubgraph helper clicks the button, but the canvas z-999 overlay
intercepts pointer events at root level. Use page.evaluate to navigate
programmatically instead.
Comment on lines +228 to +236
// Navigate programmatically — the enter-subgraph button on
// node 5 is obscured by the canvas z-999 overlay at root level.
await comfyPage.page.evaluate(() => {
const node = window.app!.graph!.getNodeById('5')
if (node?.isSubgraphNode()) {
window.app!.canvas.setGraph(node.subgraph)
}
})
await comfyPage.nextFrame()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've hit this before, I think it's a misdiagnosis of the issue. The LLMs seem to fixate on the overlay, but that's almost never the real source of the failure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the interaction here. Users aren't expected to run console commands so the test shouldn't either.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 91a754f — the regression test now exercises the real enter-subgraph control instead of using a console-side graph switch.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 14, 2026
@DrJKL DrJKL assigned dante01yoon and unassigned DrJKL Apr 14, 2026

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix — the root cause analysis is solid, dual-indexing is a reasonable approach, and the regression E2E test is a great addition. A few items below, some new and some following up on existing threads.

const count = (refCounts.get(key) ?? 1) - 1
if (count <= 0) {
refCounts.delete(key)
} else {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: (refCounts.get(key) ?? 1) - 1 silently treats "decrement a non-existent key" as a no-op (result is 0 → delete). This could mask ref-count imbalance bugs. Consider:

Suggested change
} else {
function _decrementKey(refCounts: Map<string, number>, key: string): void {
const current = refCounts.get(key)
if (current === undefined) return
if (current <= 1) {
refCounts.delete(key)
} else {
refCounts.set(key, current - 1)
}
}

Not blocking — just a defensive coding note.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 91a754f. _decrementKey now no-ops on a missing key and only decrements/deletes from an existing count.

Comment on lines +1106 to +1122
// Infer disambiguatingSourceNodeId for entries whose source node is a
// SubgraphNode. The renderer computes a promotionSourceNodeId from the
// concrete (leaf) node deep in the promotion chain; the store key must
// carry the same value so that exact-match lookups succeed (#10612).
for (const entry of entries) {
if (entry.disambiguatingSourceNodeId) continue

const sourceNode = this.subgraph.getNodeById(entry.sourceNodeId)
if (!sourceNode?.isSubgraphNode()) continue

const result = resolveConcretePromotedWidget(
this,
entry.sourceNodeId,
entry.sourceWidgetName
)
if (result.status === 'resolved') {
entry.disambiguatingSourceNodeId = String(result.resolved.node.id)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entries were just built by the .map() above via normalizeLegacyProxyWidgetEntry, which already does widget resolution. This loop calls resolveConcretePromotedWidget again for SubgraphNode sources — a second resolution pass.

Could the disambiguator be inferred during the initial .map() pass instead? That would avoid O(entries × graph depth) duplicate work during hydration.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 91a754f. I moved the disambiguator inference into normalizeLegacyProxyWidgetEntry() and removed the second resolveConcretePromotedWidget() pass from SubgraphNode.configure(), so hydration no longer walks the promotion chain twice.

Comment thread src/scripts/domWidget.ts Outdated
Comment on lines +191 to +195
usePromotionStore().isWidgetPromoted(
graphId,
String(this.node.id),
this.name
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the old code cached this.promotionStore = usePromotionStore() as an instance property. Now usePromotionStore() is called inline on every draw() (per-widget per-frame). Pinia returns a singleton so it's functionally correct, but it's a function call + map lookup on a hot path.

Was the removal intentional? If the planned extraction to promotionUtils (per the other thread) caches the store reference internally, this becomes moot.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 91a754f. I factored the shared lookup into a lightweight promotionLookup.ts helper that caches the store per active Pinia, so the widget hot paths no longer call usePromotionStore() inline each draw.

})

it('isPromotedByAny with disambiguatingSourceNodeId only matches keyed entries', () => {
it('isPromotedByAny with disambiguatingSourceNodeId matches exact key and base key', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new public method isWidgetPromoted() has no direct unit tests in this file. The store tests have 10+ assertions covering isPromotedByAny — worth adding parallel coverage for isWidgetPromoted, especially the key behavioral difference: when disambiguatingSourceNodeId is omitted, it should fall back to the base-key lookup.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 91a754f. promotionStore.test.ts now has direct isWidgetPromoted() coverage for both the exact disambiguated lookup and the base-key fallback when the disambiguator is omitted.

@dante01yoon
dante01yoon requested a review from DrJKL April 15, 2026 06:59
@dante01yoon dante01yoon assigned DrJKL and unassigned dante01yoon Apr 15, 2026
@dante01yoon dante01yoon closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promoted indicator inside parent subgraph is missing on nested subgraphs.

2 participants