Repository navigation
test: remove redundant setup/settings now handled by @vue-nodes fixture - #11195
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (9)
📝 WalkthroughWalkthroughThis PR removes test-level setup initialization and configuration overrides from nine browser test files, consolidating setup logic to a higher level (suite or global scope). Changes include eliminating Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1099 passed, 0 failed · 2 flaky📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11195 +/- ##
=======================================
Coverage 43.68% 43.68%
=======================================
Files 1349 1349
Lines 69149 69149
Branches 18289 18289
=======================================
Hits 30211 30211
Misses 38340 38340
Partials 598 598 🚀 New features to boost your workflow:
|
📦 Bundle: 5.15 MB gzip 🔴 +427 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.22 MB (baseline 1.22 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3 MB (baseline 3 MB) • 🟢 -3 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 344 kB (baseline 344 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 14 unchanged Vendor & Third-Party — 9.86 MB (baseline 9.86 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.56 MB (baseline 8.56 MB) • 🟢 -203 BBundles that do not match a named category
Status: 56 added / 56 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-13T21:45:00.852Z",
"gitSha": "b03babfafe0470f12a6316fb8115db3e2599f47f",
"branch": "drjkl/simplify-test-settings-cleanup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.0080000000376,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.988000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.44699999999995,
"heapDeltaBytes": 19948076,
"heapUsedBytes": 63321232,
"domNodes": 16,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 22.911,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.3390000000918,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.54100000000005,
"heapDeltaBytes": 20018336,
"heapUsedBytes": 63236436,
"domNodes": 19,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 21.352999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.395999999958,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.63700000000006,
"heapDeltaBytes": 20016288,
"heapUsedBytes": 63268920,
"domNodes": 18,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 22.177000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2022.8099999999927,
"styleRecalcs": 79,
"styleRecalcDurationMs": 55.522,
"layouts": 12,
"layoutDurationMs": 4.458,
"taskDurationMs": 933.233,
"heapDeltaBytes": 16290500,
"heapUsedBytes": 59129708,
"domNodes": 65,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 147.354,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.193000000023,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.075,
"layouts": 12,
"layoutDurationMs": 3.5100000000000002,
"taskDurationMs": 835.1569999999999,
"heapDeltaBytes": 15981592,
"heapUsedBytes": 58934864,
"domNodes": 61,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 133.691,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2096.9629999999597,
"styleRecalcs": 82,
"styleRecalcDurationMs": 50.179,
"layouts": 12,
"layoutDurationMs": 3.5930000000000004,
"taskDurationMs": 1069.015,
"heapDeltaBytes": 16131344,
"heapUsedBytes": 59137052,
"domNodes": 68,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 132.06699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1729.0009999999825,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.747999999999998,
"layouts": 6,
"layoutDurationMs": 0.853,
"taskDurationMs": 339.58500000000004,
"heapDeltaBytes": 24606104,
"heapUsedBytes": 67554944,
"domNodes": 76,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 31.75,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.8030000000135,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.328999999999997,
"layouts": 6,
"layoutDurationMs": 0.7540000000000001,
"taskDurationMs": 353.831,
"heapDeltaBytes": 24625884,
"heapUsedBytes": 67512944,
"domNodes": 77,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 32.161,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1791.7720000000372,
"styleRecalcs": 34,
"styleRecalcDurationMs": 19.740999999999996,
"layouts": 6,
"layoutDurationMs": 0.655,
"taskDurationMs": 403.826,
"heapDeltaBytes": 19422932,
"heapUsedBytes": 66033816,
"domNodes": 81,
"jsHeapTotalBytes": 22020096,
"scriptDurationMs": 57.135000000000005,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 612.7529999999979,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.098999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.144,
"heapDeltaBytes": 7074524,
"heapUsedBytes": 49546012,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 67.273,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 599.0339999999605,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.190999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.428,
"heapDeltaBytes": -3090700,
"heapUsedBytes": 47967068,
"domNodes": 22,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 64.141,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 605.5250000000569,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.245999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.448,
"heapDeltaBytes": 6116132,
"heapUsedBytes": 49194816,
"domNodes": 20,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 64.304,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2035.5859999999666,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.737,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.487,
"heapDeltaBytes": 17438028,
"heapUsedBytes": 69172648,
"domNodes": -253,
"jsHeapTotalBytes": 14925824,
"scriptDurationMs": 104.39200000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2049.237000000062,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.764000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.1210000000001,
"heapDeltaBytes": 17862248,
"heapUsedBytes": 69876476,
"domNodes": -254,
"jsHeapTotalBytes": 15187968,
"scriptDurationMs": 100.664,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.8720000000121,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.250000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.538,
"heapDeltaBytes": 5113900,
"heapUsedBytes": 56036952,
"domNodes": -257,
"jsHeapTotalBytes": 15654912,
"scriptDurationMs": 100.036,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2165.7180000000267,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.746,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1227.084,
"heapDeltaBytes": 15821212,
"heapUsedBytes": 68087796,
"domNodes": -260,
"jsHeapTotalBytes": 16646144,
"scriptDurationMs": 425.667,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2144.7090000000344,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.439000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1251.005,
"heapDeltaBytes": 18308700,
"heapUsedBytes": 72386012,
"domNodes": -262,
"jsHeapTotalBytes": 17694720,
"scriptDurationMs": 441.52200000000005,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2175.337000000013,
"styleRecalcs": 70,
"styleRecalcDurationMs": 21.063000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1197.3039999999999,
"heapDeltaBytes": 15454400,
"heapUsedBytes": 69214164,
"domNodes": -262,
"jsHeapTotalBytes": 18481152,
"scriptDurationMs": 404.081,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3213.762000000031,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.918,
"layouts": 60,
"layoutDurationMs": 8.254000000000001,
"taskDurationMs": 1414.065,
"heapDeltaBytes": 7396940,
"heapUsedBytes": 62097616,
"domNodes": -263,
"jsHeapTotalBytes": 17752064,
"scriptDurationMs": 491.46599999999995,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3199.0359999999782,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.106,
"layouts": 60,
"layoutDurationMs": 8.040000000000001,
"taskDurationMs": 1403.7549999999999,
"heapDeltaBytes": 7441312,
"heapUsedBytes": 62194560,
"domNodes": -265,
"jsHeapTotalBytes": 16703488,
"scriptDurationMs": 493.892,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3246.1809999999787,
"styleRecalcs": 67,
"styleRecalcDurationMs": 20.210999999999995,
"layouts": 60,
"layoutDurationMs": 8.078,
"taskDurationMs": 1440.097,
"heapDeltaBytes": 10520204,
"heapUsedBytes": 66465312,
"domNodes": -262,
"jsHeapTotalBytes": 14925824,
"scriptDurationMs": 502.37999999999994,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.7589999999886,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.441,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.121,
"heapDeltaBytes": 3315584,
"heapUsedBytes": 56387480,
"domNodes": -261,
"jsHeapTotalBytes": 16441344,
"scriptDurationMs": 103.44700000000002,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.0419999999476,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.8000000000001,
"heapDeltaBytes": 4461060,
"heapUsedBytes": 57217852,
"domNodes": -260,
"jsHeapTotalBytes": 16179200,
"scriptDurationMs": 101.66900000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.8559999999106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.357000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.536,
"heapDeltaBytes": 3272148,
"heapUsedBytes": 57336672,
"domNodes": -260,
"jsHeapTotalBytes": 16023552,
"scriptDurationMs": 102.98000000000002,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 619.9119999999994,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.715000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.00100000000003,
"heapDeltaBytes": 6853520,
"heapUsedBytes": 49659200,
"domNodes": 24,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 131.18099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.7600000000548,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.73,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.50699999999995,
"heapDeltaBytes": 6240036,
"heapUsedBytes": 49427388,
"domNodes": 21,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 127.654,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 603.8590000000568,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.20500000000004,
"heapDeltaBytes": 6675216,
"heapUsedBytes": 49937156,
"domNodes": 21,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 128.372,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2032.3209999999676,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.598999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.64699999999993,
"heapDeltaBytes": 19960260,
"heapUsedBytes": 62803796,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 27.289,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2031.4570000000458,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.567000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.6789999999999,
"heapDeltaBytes": 19868660,
"heapUsedBytes": 62909968,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 36.352999999999994,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.0180000000219,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.716,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.57800000000003,
"heapDeltaBytes": 20121660,
"heapUsedBytes": 63631632,
"domNodes": 21,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 23.968999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.308999999986,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.282000000000004,
"layouts": 16,
"layoutDurationMs": 4.162,
"taskDurationMs": 759.5939999999998,
"heapDeltaBytes": 11842480,
"heapUsedBytes": 54701096,
"domNodes": 65,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 100.56700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2040.614000000005,
"styleRecalcs": 87,
"styleRecalcDurationMs": 46.71600000000001,
"layouts": 16,
"layoutDurationMs": 4.144,
"taskDurationMs": 1001.2970000000001,
"heapDeltaBytes": 2647572,
"heapUsedBytes": 54219800,
"domNodes": 75,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 103.021,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1996.3710000000674,
"styleRecalcs": 87,
"styleRecalcDurationMs": 56.63,
"layouts": 16,
"layoutDurationMs": 5.317,
"taskDurationMs": 1022.327,
"heapDeltaBytes": 11809764,
"heapUsedBytes": 55041704,
"domNodes": 73,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 102.07900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.275999999987,
"styleRecalcs": 251,
"styleRecalcDurationMs": 50.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4200.748,
"heapDeltaBytes": 25742156,
"heapUsedBytes": 76346332,
"domNodes": -254,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 1315.489,
"eventListeners": -105,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8239.277000000016,
"styleRecalcs": 252,
"styleRecalcDurationMs": 49.47199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4560.875999999999,
"heapDeltaBytes": 38023300,
"heapUsedBytes": 88329436,
"domNodes": -254,
"jsHeapTotalBytes": 31326208,
"scriptDurationMs": 1602.94,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.868999999972,
"styleRecalcs": 252,
"styleRecalcDurationMs": 49.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4093.396,
"heapDeltaBytes": 25590668,
"heapUsedBytes": 76462336,
"domNodes": -255,
"jsHeapTotalBytes": 18481152,
"scriptDurationMs": 1278.8849999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10967.412000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10953.922999999999,
"heapDeltaBytes": -34493492,
"heapUsedBytes": 186673952,
"domNodes": -9848,
"jsHeapTotalBytes": 26042368,
"scriptDurationMs": 558.722,
"eventListeners": -23963,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12266.28900000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 46.04999999999998,
"layouts": 2,
"layoutDurationMs": 9.192000000000005,
"taskDurationMs": 12240.376999999999,
"heapDeltaBytes": 15363352,
"heapUsedBytes": 168335724,
"domNodes": -4992,
"jsHeapTotalBytes": 56713216,
"scriptDurationMs": 564.804,
"eventListeners": 5290,
"totalBlockingTimeMs": 1092,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 11398.738999999978,
"styleRecalcs": 1,
"styleRecalcDurationMs": 26.77200000000002,
"layouts": 1,
"layoutDurationMs": 6.804000000000005,
"taskDurationMs": 11372.432,
"heapDeltaBytes": -25927752,
"heapUsedBytes": 167981692,
"domNodes": -8329,
"jsHeapTotalBytes": 36790272,
"scriptDurationMs": 584.725,
"eventListeners": -14700,
"totalBlockingTimeMs": 1097,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12919.31599999998,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.780000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12891.283000000001,
"heapDeltaBytes": -44485548,
"heapUsedBytes": 179097316,
"domNodes": -9852,
"jsHeapTotalBytes": 15994880,
"scriptDurationMs": 837.892,
"eventListeners": -23963,
"totalBlockingTimeMs": 31,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13159.30800000001,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.22700000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13130.711,
"heapDeltaBytes": -42854432,
"heapUsedBytes": 174037804,
"domNodes": -9848,
"jsHeapTotalBytes": -14413824,
"scriptDurationMs": 881.6590000000001,
"eventListeners": -23963,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13115.380999999958,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.40400000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13095.471,
"heapDeltaBytes": -65526536,
"heapUsedBytes": 150647736,
"domNodes": -9850,
"jsHeapTotalBytes": -10395648,
"scriptDurationMs": 872.341,
"eventListeners": -23983,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 136.3730000000487,
"styleRecalcs": 11,
"styleRecalcDurationMs": 19.604,
"layouts": 4,
"layoutDurationMs": 1.484,
"taskDurationMs": 104.74999999999999,
"heapDeltaBytes": 2892260,
"heapUsedBytes": 48494224,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 25.621000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 458.91999999992095,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.94,
"layouts": 5,
"layoutDurationMs": 1.5590000000000002,
"taskDurationMs": 137.33200000000002,
"heapDeltaBytes": 4459656,
"heapUsedBytes": 48802456,
"domNodes": 158,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.877999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 468.93899999997757,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.496,
"layouts": 5,
"layoutDurationMs": 1.605,
"taskDurationMs": 142.64600000000002,
"heapDeltaBytes": 4512624,
"heapUsedBytes": 48627936,
"domNodes": 158,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.455,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
a6f44a1 to
579ec6b
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (3)
browser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.ts (1)
7-12: Drop the extracomfyPage.setup()now that the suite is@vue-nodestagged.After this tag change, the fixture already performs setup; keeping an extra setup call is redundant.
Based on learnings, `comfyPageFixture` intentionally calls `comfyPage.setup()` before yielding.♻️ Suggested cleanup
test.describe('Vue Upload Widgets', { tag: '@vue-nodes' }, () => { test('should hide canvas-only upload buttons', async ({ comfyPage }) => { - await comfyPage.setup() await comfyPage.workflow.loadWorkflow('widgets/all_load_widgets') await comfyPage.vueNodes.waitForNodes()🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.ts` around lines 7 - 12, Remove the redundant call to comfyPage.setup() in the test body since the comfyPage fixture (comfyPageFixture) already invokes setup when the suite is tagged `@vue-nodes`; locate the test 'should hide canvas-only upload buttons' and delete the extra comfyPage.setup() invocation so the test relies on the fixture-provided setup instead.browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts (1)
50-53: Scope the drag-start lookup to the Vue node instead of page-wide text.
page.getByText('KSampler')/page.getByText('VAE Decode')can start matching unrelated copies of the label as the page grows. UsingcomfyPage.vueNodes.getNodeByTitle(...)or a title locator scoped beneath that node would make the bounding-box source deterministic.Also applies to: 108-111
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts` around lines 50 - 53, The test currently uses page.getByText('KSampler') / page.getByText('VAE Decode') which can match unrelated labels; instead scope the lookup to the specific Vue node by using comfyPage.vueNodes.getNodeByTitle('KSampler') (or getNodeByTitle('VAE Decode')) and then call a title-locator or boundingBox on that node's scoped locator so the drag-start source is deterministic; update the instances around the boundingBox usages (e.g., where ksamplerHeader is obtained and the similar block at lines 108-111) to use the node-scoped locator rather than page.getByText.browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts (1)
446-469: Extract the duplicated reroute-insertion block.Both reroute tests carry the same graph lookup and
createReroute(...)logic. Pulling that into a small helper would reduce copy/paste drift and make later link-behavior tweaks safer.Also applies to: 541-564
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts` around lines 446 - 469, Extract the duplicated reroute-insertion logic into a reusable test helper: create a function (e.g., insertRerouteAtClientPoint or insertRerouteInGraph) that performs the graph lookup (using graph.getNodeById, node.inputs[index], graph.getLink), converts client coordinates with app.canvas.ds.convertCanvasToOffset, and calls graph.createReroute(pos, link); replace the inline evaluate blocks in linkInteraction.spec.ts (the block using targetNodeId/targetSlot/clientPoint and the similar block at lines ~541-564) to call this helper via page.evaluate with the same inputs so the test behavior is identical but the logic is centralized for reuse and easier maintenance.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts`:
- Around line 446-469: Extract the duplicated reroute-insertion logic into a
reusable test helper: create a function (e.g., insertRerouteAtClientPoint or
insertRerouteInGraph) that performs the graph lookup (using graph.getNodeById,
node.inputs[index], graph.getLink), converts client coordinates with
app.canvas.ds.convertCanvasToOffset, and calls graph.createReroute(pos, link);
replace the inline evaluate blocks in linkInteraction.spec.ts (the block using
targetNodeId/targetSlot/clientPoint and the similar block at lines ~541-564) to
call this helper via page.evaluate with the same inputs so the test behavior is
identical but the logic is centralized for reuse and easier maintenance.
In `@browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts`:
- Around line 50-53: The test currently uses page.getByText('KSampler') /
page.getByText('VAE Decode') which can match unrelated labels; instead scope the
lookup to the specific Vue node by using
comfyPage.vueNodes.getNodeByTitle('KSampler') (or getNodeByTitle('VAE Decode'))
and then call a title-locator or boundingBox on that node's scoped locator so
the drag-start source is deterministic; update the instances around the
boundingBox usages (e.g., where ksamplerHeader is obtained and the similar block
at lines 108-111) to use the node-scoped locator rather than page.getByText.
In `@browser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.ts`:
- Around line 7-12: Remove the redundant call to comfyPage.setup() in the test
body since the comfyPage fixture (comfyPageFixture) already invokes setup when
the suite is tagged `@vue-nodes`; locate the test 'should hide canvas-only upload
buttons' and delete the extra comfyPage.setup() invocation so the test relies on
the fixture-provided setup instead.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4115d53b-6d1f-42b5-90b9-635703eb596b
📒 Files selected for processing (80)
browser_tests/fixtures/ComfyPage.tsbrowser_tests/tests/actionbar.spec.tsbrowser_tests/tests/bottomPanelLogs.spec.tsbrowser_tests/tests/bottomPanelShortcuts.spec.tsbrowser_tests/tests/collapsedNodeLinks.spec.tsbrowser_tests/tests/customIcons.spec.tsbrowser_tests/tests/defaultKeybindings.spec.tsbrowser_tests/tests/dialog.spec.tsbrowser_tests/tests/dialogs/signInDialog.spec.tsbrowser_tests/tests/errorOverlay.spec.tsbrowser_tests/tests/extensionAPI.spec.tsbrowser_tests/tests/focusMode.spec.tsbrowser_tests/tests/imageCompare.spec.tsbrowser_tests/tests/interaction.spec.tsbrowser_tests/tests/jobHistoryActions.spec.tsbrowser_tests/tests/linearMode.spec.tsbrowser_tests/tests/maskEditor.spec.tsbrowser_tests/tests/menu.spec.tsbrowser_tests/tests/minimap.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/nodeLibraryEssentials.spec.tsbrowser_tests/tests/outputHistory.spec.tsbrowser_tests/tests/painter.spec.tsbrowser_tests/tests/pasteImageContextMenu.spec.tsbrowser_tests/tests/propertiesPanel/errorsTab.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabExecution.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingMedia.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingNodes.spec.tsbrowser_tests/tests/propertiesPanel/nodeSettings.spec.tsbrowser_tests/tests/releaseNotifications.spec.tsbrowser_tests/tests/remoteWidgets.spec.tsbrowser_tests/tests/resultGallery.spec.tsbrowser_tests/tests/rightSidePanelTabs.spec.tsbrowser_tests/tests/saveImageAndWebp.spec.tsbrowser_tests/tests/selectionRectangle.spec.tsbrowser_tests/tests/selectionToolboxActions.spec.tsbrowser_tests/tests/sidebar/nodeLibrary.spec.tsbrowser_tests/tests/sidebar/nodeLibraryV2.spec.tsbrowser_tests/tests/sidebar/sidebarSplitterWidth.spec.tsbrowser_tests/tests/sidebar/workflows.spec.tsbrowser_tests/tests/subgraph/subgraphDuplicateIndependentValues.spec.tsbrowser_tests/tests/subgraph/subgraphLifecycle.spec.tsbrowser_tests/tests/subgraph/subgraphNavigation.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/subgraph/subgraphSearch.spec.tsbrowser_tests/tests/subgraph/subgraphZeroUuid.spec.tsbrowser_tests/tests/subgraphPromotedWidgetPanel.spec.tsbrowser_tests/tests/templates.spec.tsbrowser_tests/tests/toastNotifications.spec.tsbrowser_tests/tests/topbar/workflowTabs.spec.tsbrowser_tests/tests/versionMismatchWarnings.spec.tsbrowser_tests/tests/vueNodes/groups/groups.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/pan.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/zoom.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/vueNodes/interactions/node/imagePreview.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/vueNodes/interactions/node/remove.spec.tsbrowser_tests/tests/vueNodes/interactions/node/rename.spec.tsbrowser_tests/tests/vueNodes/interactions/node/resize.spec.tsbrowser_tests/tests/vueNodes/interactions/node/select.spec.tsbrowser_tests/tests/vueNodes/nodeStates/bypass.spec.tsbrowser_tests/tests/vueNodes/nodeStates/collapse.spec.tsbrowser_tests/tests/vueNodes/nodeStates/colors.spec.tsbrowser_tests/tests/vueNodes/nodeStates/error.spec.tsbrowser_tests/tests/vueNodes/nodeStates/mute.spec.tsbrowser_tests/tests/vueNodes/nodeStates/pin.spec.tsbrowser_tests/tests/vueNodes/rerouteNodeSize.spec.tsbrowser_tests/tests/vueNodes/widgets/advancedWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/imageCrop.spec.tsbrowser_tests/tests/vueNodes/widgets/int/integerWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/text/multilineStringWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/widgetReactivity.spec.tsbrowser_tests/tests/widgetCopyButton.spec.tsbrowser_tests/tests/workflowTabThumbnail.spec.ts
💤 Files with no reviewable changes (41)
- browser_tests/tests/bottomPanelLogs.spec.ts
- browser_tests/tests/outputHistory.spec.ts
- browser_tests/tests/customIcons.spec.ts
- browser_tests/tests/jobHistoryActions.spec.ts
- browser_tests/tests/bottomPanelShortcuts.spec.ts
- browser_tests/tests/minimap.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabExecution.spec.ts
- browser_tests/tests/dialog.spec.ts
- browser_tests/tests/actionbar.spec.ts
- browser_tests/tests/focusMode.spec.ts
- browser_tests/tests/workflowTabThumbnail.spec.ts
- browser_tests/tests/sidebar/nodeLibrary.spec.ts
- browser_tests/tests/menu.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingNodes.spec.ts
- browser_tests/tests/sidebar/nodeLibraryV2.spec.ts
- browser_tests/tests/rightSidePanelTabs.spec.ts
- browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts
- browser_tests/tests/propertiesPanel/errorsTab.spec.ts
- browser_tests/tests/dialogs/signInDialog.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingMedia.spec.ts
- browser_tests/tests/versionMismatchWarnings.spec.ts
- browser_tests/tests/linearMode.spec.ts
- browser_tests/tests/releaseNotifications.spec.ts
- browser_tests/tests/remoteWidgets.spec.ts
- browser_tests/tests/nodeLibraryEssentials.spec.ts
- browser_tests/tests/extensionAPI.spec.ts
- browser_tests/tests/errorOverlay.spec.ts
- browser_tests/tests/toastNotifications.spec.ts
- browser_tests/tests/templates.spec.ts
- browser_tests/tests/sidebar/sidebarSplitterWidth.spec.ts
- browser_tests/tests/nodeHelp.spec.ts
- browser_tests/tests/defaultKeybindings.spec.ts
- browser_tests/tests/subgraph/subgraphSearch.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts
- browser_tests/tests/subgraphPromotedWidgetPanel.spec.ts
- browser_tests/tests/sidebar/workflows.spec.ts
- browser_tests/tests/selectionToolboxActions.spec.ts
- browser_tests/tests/subgraph/subgraphNavigation.spec.ts
- browser_tests/tests/subgraph/subgraphLifecycle.spec.ts
- browser_tests/tests/subgraph/subgraphPromotion.spec.ts
- browser_tests/tests/topbar/workflowTabs.spec.ts
@vue-nodes tag makes fixture call setup() + waitForNodes(), so per-test repeats are unnecessary page reloads. UseNewMenu:'Top' is the fixture default — leftover calls are no-ops. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d88a3-ae16-74cb-8120-b7ab11d6a678
The merge-base changed after approval.
579ec6b to
2b88a0f
Compare
…re (#11195) ## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
…re (#11195) ## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
…re (#11195) ## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
Summary
Follow-up cleanup for #11184 — removes redundant test setup calls that the
@vue-nodesfixture now handles.Changes
setSetting,setup(), andwaitForNodes()calls across 11 test filesUseNewMenu: 'Top'calls (already fixture default)setup()+waitForNodes()on default workflow (fixture already does this for@vue-nodes)subgraphZeroUuid(fixture applies VueNodes.Enabled server-side before navigation)Review Focus
Each removal was verified against the fixture's
setupSettings()defaults (ComfyPage.ts:420-442) and the@vue-nodesauto-setup (lines 454-456). Tests that callsetup()/waitForNodes()afterloadWorkflow()orpage.evaluate()were intentionally kept.┆Issue is synchronized with this Notion page by Unito