Repository navigation
[backport cloud/1.43] fix: exclude muted/bypassed nodes from missing asset detection (#10856) - #11218
Conversation
…asset detection (#10856) Cherry-pick of 521019d onto cloud/1.43. Manual conflict resolution on two files (same root cause as the core/1.43 backport), both limited to the `cleanupFakeModel` helper extraction: - browser_tests/tests/errorOverlay.spec.ts - browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts cloud/1.43 base still had the inline `expect(cleanupOk).toBeTruthy()` implementation; #10856 replaced both sites with `await cleanupFakeModel(comfyPage)` calling the new helper in ErrorsTabHelper.ts. Conflict resolved by accepting the PR version (helper call); the helper itself is added in this same commit.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1016 passed, 0 failed · 1 flaky📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
📦 Bundle Size
⚡ Performance Report
No baseline found — showing absolute values.
Raw data{
"timestamp": "2026-04-20T01:49:43.517Z",
"gitSha": "cbb22ac9723a4b9da909d4c6716c91db3dbd1d98",
"branch": "backport/cloud-1.43/10856",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.1460000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.1519999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.32399999999996,
"heapDeltaBytes": 20073628,
"heapUsedBytes": 63023680,
"domNodes": 14,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 14.720000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2016.0079999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.966000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.043,
"heapDeltaBytes": 11737932,
"heapUsedBytes": 64816052,
"domNodes": 21,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 21.967999999999993,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2034.1429999999718,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.626,
"heapDeltaBytes": 21001816,
"heapUsedBytes": 63829072,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 22.073999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2047.5640000000226,
"styleRecalcs": 81,
"styleRecalcDurationMs": 49.596000000000004,
"layouts": 12,
"layoutDurationMs": 3.343,
"taskDurationMs": 992.9890000000001,
"heapDeltaBytes": 16701920,
"heapUsedBytes": 59249684,
"domNodes": 66,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 140.51500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.8599999999983,
"styleRecalcs": 72,
"styleRecalcDurationMs": 30.923000000000002,
"layouts": 12,
"layoutDurationMs": 3.215,
"taskDurationMs": 689.276,
"heapDeltaBytes": 15959752,
"heapUsedBytes": 58837196,
"domNodes": 54,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 125.32399999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.1589999999915,
"styleRecalcs": 73,
"styleRecalcDurationMs": 32.395,
"layouts": 12,
"layoutDurationMs": 3.244,
"taskDurationMs": 700.211,
"heapDeltaBytes": 15793560,
"heapUsedBytes": 58394944,
"domNodes": 56,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 126.25500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.1760000000427,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.459999999999997,
"layouts": 6,
"layoutDurationMs": 0.5890000000000001,
"taskDurationMs": 291.35,
"heapDeltaBytes": 24720248,
"heapUsedBytes": 67552836,
"domNodes": 77,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 22.560000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.9470000000001,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.64,
"layouts": 6,
"layoutDurationMs": 0.6139999999999999,
"taskDurationMs": 283.00199999999995,
"heapDeltaBytes": 24969128,
"heapUsedBytes": 67549936,
"domNodes": 80,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 21.735999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.407000000032,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.085,
"layouts": 6,
"layoutDurationMs": 0.6169999999999999,
"taskDurationMs": 268.629,
"heapDeltaBytes": 24332096,
"heapUsedBytes": 67496188,
"domNodes": 76,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 16.212999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 565.6160000000057,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.918000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.33599999999996,
"heapDeltaBytes": 6211128,
"heapUsedBytes": 49049964,
"domNodes": 19,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 63.266000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 513.8170000000173,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.23,
"heapDeltaBytes": 6497472,
"heapUsedBytes": 50617508,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 60.729,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 550.3380000000107,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.763,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.11699999999996,
"heapDeltaBytes": 6563960,
"heapUsedBytes": 49111480,
"domNodes": 24,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 61.623999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.848000000001,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.091999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.651,
"heapDeltaBytes": 4441060,
"heapUsedBytes": 55600380,
"domNodes": -256,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 100.14600000000002,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.5149999999653,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.304000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.9790000000001,
"heapDeltaBytes": 4980104,
"heapUsedBytes": 55917796,
"domNodes": -257,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 92.879,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2077.280000000087,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.732,
"heapDeltaBytes": 4745060,
"heapUsedBytes": 55901544,
"domNodes": -257,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 100.747,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2122.998999999993,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.471999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1023.22,
"heapDeltaBytes": 14690880,
"heapUsedBytes": 68107296,
"domNodes": -257,
"jsHeapTotalBytes": 17436672,
"scriptDurationMs": 372.28,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2135.173000000009,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1028.6090000000002,
"heapDeltaBytes": 21165072,
"heapUsedBytes": 73365196,
"domNodes": -258,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 381.847,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2108.924000000002,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.622000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1010.7790000000001,
"heapDeltaBytes": 19151872,
"heapUsedBytes": 71495460,
"domNodes": -258,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 379.75100000000003,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3131.2389999999937,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.459,
"layouts": 60,
"layoutDurationMs": 6.760000000000001,
"taskDurationMs": 1246.485,
"heapDeltaBytes": 7318232,
"heapUsedBytes": 62270780,
"domNodes": -263,
"jsHeapTotalBytes": 17494016,
"scriptDurationMs": 474.094,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3129.068000000018,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.219,
"layouts": 60,
"layoutDurationMs": 6.806999999999999,
"taskDurationMs": 1245.929,
"heapDeltaBytes": 9109364,
"heapUsedBytes": 63632260,
"domNodes": -261,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 466.73999999999995,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3132.59800000003,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.228999999999996,
"layouts": 60,
"layoutDurationMs": 7.089999999999999,
"taskDurationMs": 1241.614,
"heapDeltaBytes": -3118164,
"heapUsedBytes": 60923928,
"domNodes": -261,
"jsHeapTotalBytes": 16822272,
"scriptDurationMs": 467.098,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.4790000000135,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.647000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.20699999999994,
"heapDeltaBytes": 3760636,
"heapUsedBytes": 56531604,
"domNodes": -260,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 89.718,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2055.031999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.150000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.736,
"heapDeltaBytes": 4802312,
"heapUsedBytes": 57247260,
"domNodes": -258,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 99.081,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.1410000000233,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.48,
"heapDeltaBytes": 9360264,
"heapUsedBytes": 71161456,
"domNodes": -256,
"jsHeapTotalBytes": 15249408,
"scriptDurationMs": 88.68,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.3209999999776,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.279000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.775,
"heapDeltaBytes": 6457288,
"heapUsedBytes": 49623780,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 121.196,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.8530000000128,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.704,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.787,
"heapDeltaBytes": 6475884,
"heapUsedBytes": 49450864,
"domNodes": 22,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 126.14399999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.0949999999802,
"styleRecalcs": 50,
"styleRecalcDurationMs": 12.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.16499999999996,
"heapDeltaBytes": 6519684,
"heapUsedBytes": 49436484,
"domNodes": 25,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 122.86,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2015.118000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.669,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.76400000000007,
"heapDeltaBytes": 19978316,
"heapUsedBytes": 63052976,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 15.896,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.7190000000223,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.72499999999997,
"heapDeltaBytes": 19916688,
"heapUsedBytes": 63061812,
"domNodes": 22,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 15.813,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.614000000075,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.451,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.11199999999997,
"heapDeltaBytes": 19949644,
"heapUsedBytes": 63061836,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 18.297999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1961.0179999999957,
"styleRecalcs": 83,
"styleRecalcDurationMs": 41.167,
"layouts": 16,
"layoutDurationMs": 4.385,
"taskDurationMs": 864.502,
"heapDeltaBytes": 12300732,
"heapUsedBytes": 55296020,
"domNodes": 71,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 94.70400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.0219999999908,
"styleRecalcs": 84,
"styleRecalcDurationMs": 43.348,
"layouts": 16,
"layoutDurationMs": 4.601,
"taskDurationMs": 872.07,
"heapDeltaBytes": 11860208,
"heapUsedBytes": 54739744,
"domNodes": 73,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 97.24100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.3950000000295,
"styleRecalcs": 84,
"styleRecalcDurationMs": 39.835,
"layouts": 16,
"layoutDurationMs": 4.168000000000001,
"taskDurationMs": 846.516,
"heapDeltaBytes": 11911584,
"heapUsedBytes": 54949112,
"domNodes": 73,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 92.60199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8176.479,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.626,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3443.7070000000003,
"heapDeltaBytes": 25231396,
"heapUsedBytes": 76123548,
"domNodes": -257,
"jsHeapTotalBytes": 19533824,
"scriptDurationMs": 1200.3259999999998,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8150.943999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.09400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3454.049,
"heapDeltaBytes": 20260004,
"heapUsedBytes": 71216092,
"domNodes": -255,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 1213.2230000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8136.785000000032,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.584999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3441.435,
"heapDeltaBytes": 27095724,
"heapUsedBytes": 78296052,
"domNodes": -258,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 1195.282,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11726.967000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11714.969,
"heapDeltaBytes": -55572960,
"heapUsedBytes": 159860440,
"domNodes": -9848,
"jsHeapTotalBytes": 17391616,
"scriptDurationMs": 591.222,
"eventListeners": -23959,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11388.369000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11376.032,
"heapDeltaBytes": -54833932,
"heapUsedBytes": 160511616,
"domNodes": -9848,
"jsHeapTotalBytes": 17653760,
"scriptDurationMs": 559.963,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 11247.734000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11236.263,
"heapDeltaBytes": -46593464,
"heapUsedBytes": 168340288,
"domNodes": -9848,
"jsHeapTotalBytes": 28401664,
"scriptDurationMs": 538.3100000000001,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13715.295000000026,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.692999999999955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13689.479000000003,
"heapDeltaBytes": -51414048,
"heapUsedBytes": 149434108,
"domNodes": -9850,
"jsHeapTotalBytes": -14852096,
"scriptDurationMs": 799.1120000000001,
"eventListeners": -23987,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13843.651000000023,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.409999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13817.345,
"heapDeltaBytes": -42508160,
"heapUsedBytes": 172771372,
"domNodes": -9850,
"jsHeapTotalBytes": -9433088,
"scriptDurationMs": 824.407,
"eventListeners": -23959,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13693.4379999999,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.319000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13671.493000000002,
"heapDeltaBytes": -34509372,
"heapUsedBytes": 167545464,
"domNodes": -9848,
"jsHeapTotalBytes": -15724544,
"scriptDurationMs": 865.9689999999999,
"eventListeners": -23955,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 456.27700000000004,
"styleRecalcs": 23,
"styleRecalcDurationMs": 26.215999999999998,
"layouts": 5,
"layoutDurationMs": 1.3769999999999998,
"taskDurationMs": 123.67299999999997,
"heapDeltaBytes": 4800948,
"heapUsedBytes": 49136656,
"domNodes": 192,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.964000000000002,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 436.06099999999515,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.773000000000003,
"layouts": 4,
"layoutDurationMs": 0.9960000000000001,
"taskDurationMs": 103.05399999999999,
"heapDeltaBytes": 4377396,
"heapUsedBytes": 48723832,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.688,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 445.9320000000844,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.959000000000003,
"layouts": 5,
"layoutDurationMs": 1.258,
"taskDurationMs": 119.05399999999999,
"heapDeltaBytes": 4489460,
"heapUsedBytes": 48777364,
"domNodes": 158,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.795,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Manual backport of #10856 to
cloud/1.43.Paired with core/1.43 backport #11217.
Conflicts resolved
Same two files, same root cause as the core/1.43 backport — #10856 extracted the inline
cleanup_fake_modelblock into a sharedcleanupFakeModelhelper inbrowser_tests/tests/propertiesPanel/ErrorsTabHelper.ts:browser_tests/tests/errorOverlay.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.tscloud/1.43still carries the original inlineexpect(cleanupOk).toBeTruthy()form. #10856 replaces both withawait cleanupFakeModel(comfyPage)calling the helper added by this same PR.Resolution: accepted the PR version (helper call) on both conflict sites. The helper itself is added as part of this backport, so no runtime behavior is lost.
Verification
Original PR summary
See #10856 for full behavioral description, test plan, and screenshots.
Fixes Comfy-Org/ComfyUI#13256 on cloud/1.43
┆Issue is synchronized with this Notion page by Unito