Repository navigation
[fix] preserve unequal values with colliding hashes (LET-45) - #198
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 120 |
| Duplication | 9 |
🟢 Coverage 100.00% diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (b690efc) 8441 8028 95.11% Head commit (9372640) 8456 (+15) 8043 (+15) 95.12% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#198) 26 26 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
47c70c6 to
b928dbb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 93.98% 94.00% +0.01%
==========================================
Files 53 53
Lines 6755 6769 +14
==========================================
+ Hits 6349 6363 +14
Misses 258 258
Partials 148 148 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Compare colliding values with Starlark equality while retaining the first value, type and input order. Keep hash callbacks single-pass and release iterators on every return. Restore the existing defensive regressions and document the necessary CPU and memory cost. Refs LET-45.
b928dbb to
9372640
Compare
distinct([1, 4294967297])silently discarded an unequal value with the same hash. Compare values using Starlark equality within each hash bucket, preserving first-value identity, numeric type and order. Retain the small local index/collision chain, error propagation and iterator cleanup; no type fast path, new dependency, cache or Go-floor change.Fresh host/floor build, race tests twice, vet and coverage pass on the final source: 32/32 distinct statements covered, all 46 specified regression names pass twice on both compilers, no old coverage lost. Full 80-configuration consumer and real CLI verification passed on identical runtime/module bytes. After the separate HTTP test-only fix #202, all 175 other files and frozen consumer/CLI inputs remain identical; the source bridge and fresh own4 are independently reviewed. Original source labels and the original macOS failure remain preserved. The final head passes all 23 required / 24 reported checks, both Codecov gates, review inspection and checks-watch.
Correct equality/index storage costs CPU and memory. Original representative List128 results were +61.83% host / +92.50% floor and about +432 / +402–404 B per call, with allocation counts unchanged; smaller fixtures varied. These disclosed costs are accepted to prevent data loss under the safety-first, simple-implementation criterion. No new timing samples or equivalence claim. Tracks LET-45. No tags, releases or auto-merge.