Repository navigation
[doc] Explain distinct hash collisions and integer workaround - #200
Conversation
Refs LET-45 / LOCAL-046. Document the current hash-only limitation without claiming the pending equality fix is merged.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.00% coverage variation (-1.00%) |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (1d05057) 8433 8018 95.08% Head commit (ea7e4cf) 8433 (+0) 8018 (+0) 95.08% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#200) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 53 53
Lines 6750 6750
=======================================
Hits 6342 6342
Misses 259 259
Partials 149 149 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
distinctcurrently treats matching hashes as duplicates and can discard unequal integers:distinct([1, 4294967297])returns[1]. Document this current limitation and a native-integer workaround using an ordered Starlark dict. The equality fix in #198 remains unmerged; this PR changes documentation only.Validation: ran the exact Starlark example and current
distinctbehavior once on Go 1.27.3/darwin-arm64 and once on Go 1.19.13/linux-amd64, both with the pinned interpreter. The dict example returns[1, 4294967297]; currentdistinctreturns[1]. The normal commit hook (gofmt, vet and tests) passed. Every other tracked file, including Go source, tests and module files, is byte-identical to master1d050572.The workaround is scoped to native integers; it makes no claim about arbitrary host values or performance costs.
Refs LET-45 / LOCAL-046.