You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[fix] release distinct iterators on every return (LET-42) - #194
distinct(list) left its iterator active after returning, preventing later list mutation. Defer iterator cleanup on every return, including an element-hashing error, while preserving result shapes and input values.
Regressions cover empty/success/error paths for native lists and tracked iterators, exact cleanup, input preservation and mutation after return. This PR retains the existing hash-only deduplication; #198 separately addresses hash collisions and equality.
Validation:
Host Go 1.27.3 and library-floor Go 1.19.13: build, race tests (-count=2), vet and coverage comparisons pass. The added statement is covered on each compiler, with no previously covered statements lost.
The independent-candidate consumer matrix passes all 200 fresh configurations (190 active and 10 archived MQ diagnostics); all 160 consumer profile comparisons are exact. Packages without unit tests are checked by build/vet.
Public hello/qrcard scripts pass all 20 executions across 10 real CLI binaries, on host Go 1.27.3 and the CLI floor Go 1.25.8.
Allocation medians match across eight representative list/tuple/custom/control workloads. The fixed timing comparisons are machine-specific and do not establish equivalence.
Tracks LET-42. No API, dependency, interpreter or Go-floor change.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distinct(list)left its iterator active after returning, preventing later list mutation. Defer iterator cleanup on every return, including an element-hashing error, while preserving result shapes and input values.Regressions cover empty/success/error paths for native lists and tracked iterators, exact cleanup, input preservation and mutation after return. This PR retains the existing hash-only deduplication; #198 separately addresses hash collisions and equality.
Validation:
-count=2), vet and coverage comparisons pass. The added statement is covered on each compiler, with no previously covered statements lost.Allocation medians match across eight representative list/tuple/custom/control workloads. The fixed timing comparisons are machine-specific and do not establish equivalence.
Tracks LET-42. No API, dependency, interpreter or Go-floor change.