You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[test] verify eval builtins across module policies (BOX-15) - #41
Starlet's go_idiomatic collection now provides eval and try_eval. Add integration tests for their availability in Safe/Network/Full and explicit Empty-set opt-in, data ownership and frozen results, excluded host capabilities, shared step limits and fatal cancellation. This changes only ctor_test.go; production code, module allowlists and dependency files match current master. Addresses BOX-15.
The currently published Starlet pin exposes neither helper, so the new feature test explicitly skips there; partial registration fails. A dependency upgrade runs every new case without changing the existing exact module-set golden. This PR does not adopt a new dependency version.
Validation:
Fresh four-leg build/race-count2/atomic-coverage/vet comparison on Go 1.27.3 and Go 1.19.13: identical PR source with original Starlet v0.2.4/Starlight v0.2.2 pins versus temporary replacements to Starlet 91918836 and Starlight cd5f885d. All four legs pass. Each original-pin leg records the two expected feature-test skips; each upgraded leg executes every feature case. Both compiler profile pairs retain identical statement/hit blocks and 749/754 covered statements. The interpreter, Go floor and all non-core selected dependency versions stay unchanged.
An initial refresh exposed an overstrict cancellation assertion: the outer VM can stop before the evaluator runs and return its typed cancellation error instead of the context sentinel. Its original failure is retained. The corrected test accepts only the context cause or the pinned VM's exact typed cancellation message, and proves no following host callback runs. Separate direct-builtin and pre-cancelled-run tests require the context cause and zero script side effects. The revised source has its own four fresh passing legs; the old failed execution was not rerun.
The original normal pre-commit hook passes. Earlier b12f37e9/3c5e2ab8 evidence includes the full 84-leg ecosystem comparison and sixteen real CLI scenarios; those records retain their original scope and were not relabelled as a rerun of this refreshed head.
The producer Starlet #187 has been accepted and merged. Its disclosed performance costs remain documented; this test-only companion adds no production implementation change. Other held runtime fixes remain separate. No tag, release or auto-merge.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starlet's
go_idiomaticcollection now providesevalandtry_eval. Add integration tests for their availability in Safe/Network/Full and explicit Empty-set opt-in, data ownership and frozen results, excluded host capabilities, shared step limits and fatal cancellation. This changes onlyctor_test.go; production code, module allowlists and dependency files match current master. Addresses BOX-15.The currently published Starlet pin exposes neither helper, so the new feature test explicitly skips there; partial registration fails. A dependency upgrade runs every new case without changing the existing exact module-set golden. This PR does not adopt a new dependency version.
Validation:
91918836and Starlightcd5f885d. All four legs pass. Each original-pin leg records the two expected feature-test skips; each upgraded leg executes every feature case. Both compiler profile pairs retain identical statement/hit blocks and 749/754 covered statements. The interpreter, Go floor and all non-core selected dependency versions stay unchanged.b12f37e9/3c5e2ab8evidence includes the full 84-leg ecosystem comparison and sixteen real CLI scenarios; those records retain their original scope and were not relabelled as a rerun of this refreshed head.The producer Starlet #187 has been accepted and merged. Its disclosed performance costs remain documented; this test-only companion adds no production implementation change. Other held runtime fixes remain separate. No tag, release or auto-merge.