You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Superseded by #41, which implements the approved go_idiomatic builtin design. This earlier separate-module candidate is closed without merging; its original description and validation history remain below.
When Starlet registers its data-only starlark evaluator, Starbox's fail-closed module-classification test rejects the new builtin even though Safe and Network correctly keep it unavailable.
Classify this one reviewed optional module as Full-only when it is present. Preserve the exact existing Safe/Network lists and continue rejecting every other unclassified future module. Add integration tests proving that Safe/Network return ModuleWithheldError, while Full and an explicit AddNamedModules("starlark") opt-in can evaluate native data, report a friendly try-error on attempted mutation, and leave the caller's list writable and independent.
This test-only change addresses BOX-14. Current published Starlet pins remain supported: the module-set golden still runs, while only the new evaluator-specific test skips when the module is absent. Production files, dependencies, and policy configuration are unchanged.
Validation:
Reproduced the classification failure on the unmodified consumer against the new-module source; the two-file test change passes against that same source snapshot. Original red evidence is retained.
Fresh paired validation of this final consumer commit passes with Starlet actual master bf94a756 and the new-module candidate 179266c2, on host Go 1.27.3 and Docker Go 1.19.13. Full build, race tests repeated twice, and vet pass in all four legs.
Consumer coverage remains 749/754 covered statements, with identical hit blocks inside each compiler. Baseline absent-module skips are explicit; the new-module legs execute all policy cases.
The original pre-commit hook ran vet and the full current-pin suite successfully.
The producer is Starlet #186. Its directed framework cohort totals 16 fresh legs with exact coverage, and 16 real CLI invocations; independent terminal review passes. The two original CLI budget-exit assertion failures are retained: the existing source contract requires exit 5, and a separate audit corrected the expectation without rerunning.
Exact-head 12 required / 12 reported checks, both Codecov contexts, and checks-watch pass; post-watch head/base remain unchanged. Keep this PR in draft alongside the producer pending full-ecosystem and final performance acceptance. This PR does not change production policy, and no tag, release, or auto-merge is requested.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #41, which implements the approved go_idiomatic builtin design. This earlier separate-module candidate is closed without merging; its original description and validation history remain below.
When Starlet registers its data-only
starlarkevaluator, Starbox's fail-closed module-classification test rejects the new builtin even though Safe and Network correctly keep it unavailable.Classify this one reviewed optional module as Full-only when it is present. Preserve the exact existing Safe/Network lists and continue rejecting every other unclassified future module. Add integration tests proving that Safe/Network return
ModuleWithheldError, while Full and an explicitAddNamedModules("starlark")opt-in can evaluate native data, report a friendly try-error on attempted mutation, and leave the caller's list writable and independent.This test-only change addresses BOX-14. Current published Starlet pins remain supported: the module-set golden still runs, while only the new evaluator-specific test skips when the module is absent. Production files, dependencies, and policy configuration are unchanged.
Validation:
The producer is Starlet #186. Its directed framework cohort totals 16 fresh legs with exact coverage, and 16 real CLI invocations; independent terminal review passes. The two original CLI budget-exit assertion failures are retained: the existing source contract requires exit 5, and a separate audit corrected the expectation without rerunning.
Exact-head 12 required / 12 reported checks, both Codecov contexts, and checks-watch pass; post-watch head/base remain unchanged. Keep this PR in draft alongside the producer pending full-ecosystem and final performance acceptance. This PR does not change production policy, and no tag, release, or auto-merge is requested.