You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add eval(source, vars={}) and Go-style (value, error_info) handling through try_eval(...) to the existing go_idiomatic helpers (LET-36).
Expressions receive explicit native-data snapshots: private inputs and returned data are copied, validated and frozen. Functions, host objects and cycles are rejected. Ordinary failures have bounded structured diagnostics; cancellation and cumulative caller step exhaustion remain errors. Evaluation uses the caller's Thread and does not capture locals or fork the complete runtime. Source/data quotas are admission limits, not hard process CPU/memory isolation.
Preserve the Go floor, interpreter pin, dependencies, module registry/capabilities and Machine execution methods. Preloads follow existing name precedence. Starbox Safe/Network already include this module, so the helpers become available there; inner expressions still exclude outer host callbacks and module capabilities. Companion test-only PR 1set/starbox#41 verifies the existing allowlists and execution boundaries.
The README now prioritizes signatures, parameters/defaults, loading, runnable examples, return/error handling and the complete six-field error_info schema. Its performance section explains the qualitative findings and usage tradeoffs; detailed local measurements and commands are retained in linked BENCHMARKS.md. Benchmarks compare direct compiled Starlark with the same expressions through public eval/try_eval. Fixed-source, small-I/O scaling supports amortization of preparation cost as shared computation grows; the absolute time difference is not a universal constant, and large-workload noise does not establish speedup or equivalence. Source/data sizes, hardware, OS, architecture, compiler/Go, GC and load affect results.
Validation:
Defensive tests cover native types, snapshots/aliases/cycles/depth, hostile/custom values, output capabilities, bounded diagnostics, cancellation/steps, owner callbacks, concurrency and independent call state. Fresh full baseline/candidate host Go1.27.3 and Docker Go1.19.13 build/race×2/vet pass at runtime commit b12f37e. New production statements cover329/330; the only missing statement is the unreachable trusted-literal compile panic. Old53host/50floor file hit blocks remain unchanged; total coverage increases.
Complete differential downstream cohort:84legs (80active/four archived diagnostic),42pairs;40exact consumer profiles/16012blocks;107packagepairs with105exact and two own gains,34unchanged functions with no lost blocks. Sixteen actual CLI cases pass. All108skip events/eight no-unit-test pairs are classified; no native Windows/WASM or live/private-service runtime claim is made.
Supplemental module-combination validation covers Box tiers/Reset, Base configuration/secret boundaries, YAML/TOML round trips, QRCode and CLI kit/loader/budget isolation on host and declared floors:24effective race-enabled top-level completions and four actual unchanged hello/qrcard demos. Seven source snapshots/module selections and binary/compiler/dependency metadata are verified. Two harness errors are retained and corrected with only failed tests rerun; no product regression was found.
New same-expression and scaling cohorts complete once under predeclared protocols, with independent numerical reviews and source/binary/declaration locks. Original failures, unfavorable observations and prior commit labels remain intact; no additional old-cohort sampling was used to seek green. Final qualitative-doc follow-up changes no Go/test/module bytes from53bce964, so original runtime/coverage/downstream evidence retains its correct source provenance. Normal pre-commit hooks pass.
Measured assembly/cache costs remain disclosed: configured-cache paths add64B/op on both compilers; floor Fresh adds about115B/one allocation; some loading/cache timings increase around1–5%. These are not described as zero overhead or full causal attribution. Other foundation performance candidates remain outside this change.
Final head f8a2c34 passes all23 required/24 reported checks and both Codecov contexts from app254. Review/bot inspection, checks-watch exit0 and unchanged head/base guards pass. Fourteen minor Markdown findings were individually reviewed against repository settings:13line-length findings conflict with MD013=false; one required-heading finding expects [None] without a configured template. No Go finding or service-rule change. Proceed through a final ready-state guard and normal squash merge; no auto-merge, tag, release or credential changes.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
❌ Patch coverage is 99.45799% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.89%. Comparing base (bf94a75) to head (f8a2c34).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
eval(source, vars={})and Go-style(value, error_info)handling throughtry_eval(...)to the existinggo_idiomatichelpers (LET-36).Expressions receive explicit native-data snapshots: private inputs and returned data are copied, validated and frozen. Functions, host objects and cycles are rejected. Ordinary failures have bounded structured diagnostics; cancellation and cumulative caller step exhaustion remain errors. Evaluation uses the caller's Thread and does not capture locals or fork the complete runtime. Source/data quotas are admission limits, not hard process CPU/memory isolation.
Preserve the Go floor, interpreter pin, dependencies, module registry/capabilities and Machine execution methods. Preloads follow existing name precedence. Starbox Safe/Network already include this module, so the helpers become available there; inner expressions still exclude outer host callbacks and module capabilities. Companion test-only PR 1set/starbox#41 verifies the existing allowlists and execution boundaries.
The README now prioritizes signatures, parameters/defaults, loading, runnable examples, return/error handling and the complete six-field error_info schema. Its performance section explains the qualitative findings and usage tradeoffs; detailed local measurements and commands are retained in linked BENCHMARKS.md. Benchmarks compare direct compiled Starlark with the same expressions through public eval/try_eval. Fixed-source, small-I/O scaling supports amortization of preparation cost as shared computation grows; the absolute time difference is not a universal constant, and large-workload noise does not establish speedup or equivalence. Source/data sizes, hardware, OS, architecture, compiler/Go, GC and load affect results.
Validation:
Measured assembly/cache costs remain disclosed: configured-cache paths add64B/op on both compilers; floor Fresh adds about115B/one allocation; some loading/cache timings increase around1–5%. These are not described as zero overhead or full causal attribution. Other foundation performance candidates remain outside this change.
Final head f8a2c34 passes all23 required/24 reported checks and both Codecov contexts from app254. Review/bot inspection, checks-watch exit0 and unchanged head/base guards pass. Fourteen minor Markdown findings were individually reviewed against repository settings:13line-length findings conflict with MD013=false; one required-heading finding expects [None] without a configured template. No Go finding or service-rule change. Proceed through a final ready-state guard and normal squash merge; no auto-merge, tag, release or credential changes.