Skip to content

fix: update footer links to be translatableString #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanhu95 merged 2 commits into from
Sep 2, 2026
Merged

fix: update footer links to be translatableString #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4505625
update footer links to be translatableString
nanhu95 Sep 1, 2026
0dc53a4
use translatableString format for link default value
nanhu95 Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/footer/ExpandedFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const PLACEHOLDER_LOGO_IMAGE: string =
export const defaultLink = {
linkType: "URL" as const,
label: { defaultValue: "Footer Link" },
link: "#",
link: { defaultValue: "#" },
normalizeLink: true,
openInNewTab: false,
};
Expand Down
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/footer/FooterExpandedLinkSectionSlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const footerExpandedLinkSectionSlotFields: YextFields<FooterExpandedLinkSectionS
},
link: {
label: msg("fields.link", "Link"),
type: "text",
type: "translatableString",
},
normalizeLink: {
label: msg("fields.normalizeLink", "Normalize Link"),
Expand Down
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/footer/FooterExpandedLinksWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const footerExpandedLinksWrapperFields: YextFields<FooterExpandedLinksWrapperPro
},
link: {
label: msg("fields.link", "Link"),
type: "text",
type: "translatableString",
},
normalizeLink: {
label: msg("fields.normalizeLink", "Normalize Link"),
Expand Down
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/footer/FooterLinksSlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ const footerLinksSlotFields: YextFields<FooterLinksSlotProps> = {
},
link: {
label: msg("fields.link", "Link"),
type: "text",
type: "translatableString",
Comment thread
nanhu95 marked this conversation as resolved.
},
normalizeLink: {
label: msg("fields.normalizeLink", "Normalize Link"),
Expand Down
2 changes: 1 addition & 1 deletion packages/visual-editor/src/components/header/HeaderLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export type HeaderLinksProps = {
const defaultLink: TranslatableCTA = {
linkType: "URL",
label: { defaultValue: "Header Link" },
link: "#",
link: { defaultValue: "#" },
normalizeLink: true,
openInNewTab: false,
};
Expand Down
Loading