Skip to content

fix: update footer links to be translatableString - #1309

Merged
nanhu95 merged 2 commits into
mainfrom
footer-link-translatableString
Sep 2, 2026
Merged

fix: update footer links to be translatableString#1309
nanhu95 merged 2 commits into
mainfrom
footer-link-translatableString

Conversation

@nanhu95

@nanhu95 nanhu95 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

The footer links need to be updated to the translatableString type so they have different values per locale. This is how they are currently defined for header links, which is how users can set different values for link labels and values across different locales.

Screen.Recording.2026-09-01.at.18.17.14.mov

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 3b86011f-7d4b-47f1-8f9f-ed8bbc2c33f8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@asanehisa asanehisa added the create-dev-release Triggers dev release workflow label Sep 2, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown

commit: 0dc53a4

asanehisa
asanehisa previously approved these changes Sep 2, 2026

@asanehisa asanehisa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a btw the link target for the Utility Image isn't localized yet nor are the social media links

Comment thread packages/visual-editor/src/components/footer/FooterLinksSlot.tsx
@nanhu95
nanhu95 merged commit bed2ade into main Sep 2, 2026
18 checks passed
@nanhu95
nanhu95 deleted the footer-link-translatableString branch September 2, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-dev-release Triggers dev release workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants