Skip to content

fix(security): bump next to 16.4.3 and pin node 22.23.4 #135 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashiels merged 1 commit into from
Oct 23, 2026
Merged

fix(security): bump next to 16.4.3 and pin node 22.23.4 #135 #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-node/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ runs:
steps:
- uses: actions/setup-node@v6
with:
node-version: "22"
node-version: "22.23.4"

- uses: pnpm/action-setup@v6
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
set -euo pipefail
cd ~/apps/skystream/src/skystream
git fetch -q origin main && git reset -q --hard origin/main
DOCKER_BUILDKIT=1 docker build --build-arg NEXT_PUBLIC_TMDB_API_KEY="$TMDB_KEY" -t skystream:local .
DOCKER_BUILDKIT=1 docker build --pull --build-arg NEXT_PUBLIC_TMDB_API_KEY="$TMDB_KEY" -t skystream:local .

@sentinel-skyner sentinel-skyner Bot Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Low This PR modifies .github/workflows/deploy-prod.yml by adding --pull to the remote docker build, but the diff does not update deploy/README.md or the AGENTS.md deploy section as required by REVIEW.md for deploy workflow changes.

cd ~/apps/skystream
docker compose -p skystream --env-file .env -f compose.yml up -d
docker image prune -f >/dev/null 2>&1 || true
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22
22.23.4
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# a build argument, not a runtime variable. It is public by design — the browser
# calls TMDB directly with it. See .env.example for the full contract.

ARG NODE_VERSION=22-alpine
ARG NODE_VERSION=22.23.4-alpine@sha256:fe4f6d74e20370acb04ad889077d14d0f64a9c8ea6a42bc60cddf1e844699914
ARG PNPM_VERSION=10.26.0

# --- Stage 1: install dependencies ------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const nextConfig = {
// the traced runtime deps, so the image doesn't carry dev dependencies.
// See Dockerfile.
output: 'standalone',
poweredByHeader: false,
// Inline public env vars at build time with sensible defaults.
env: {
NEXT_PUBLIC_TMDB_API_KEY: process.env.NEXT_PUBLIC_TMDB_API_KEY || '',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"hls.js": "^1.6.16",
"lucide-react": "^1.17.0",
"luxon": "^3.7.2",
"next": "^16.2.7",
"next": "^16.4.3",
"react": "^19.2.7",
"react-dom": "^19.2.7",
"video.js": "^8.23.4"
Expand Down
Loading
Loading