Repository navigation
fix(security): bump next to 16.4.3 and pin node 22.23.4 #135 - #136
Merged
Merged
Conversation
![sentinel-skyner[bot]](https://avatars.githubusercontent.com/u/208464438?s=60&v=4){kind=small}
| cd ~/apps/skystream/src/skystream | ||
| git fetch -q origin main && git reset -q --hard origin/main | ||
| DOCKER_BUILDKIT=1 docker build --build-arg NEXT_PUBLIC_TMDB_API_KEY="$TMDB_KEY" -t skystream:local . | ||
| DOCKER_BUILDKIT=1 docker build --pull --build-arg NEXT_PUBLIC_TMDB_API_KEY="$TMDB_KEY" -t skystream:local . |
There was a problem hiding this comment.
🛡️ Low This PR modifies .github/workflows/deploy-prod.yml by adding --pull to the remote docker build, but the diff does not update deploy/README.md or the AGENTS.md deploy section as required by REVIEW.md for deploy workflow changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135
Local: frozen install, lint, format:check, 366 tests, build all pass. Dry run on launchpad: real image built with fake TMDB key, node v22.23.4, next 16.4.3, sharp 0.35.5, / and /offline 200, /_next/image TMDB jpeg 200, no x-powered-by.