Skip to content

fix(venv): honor configured sources in post-install hooks - #5386

Open
m199369309 wants to merge 1 commit into
xorbitsai:mainfrom
m199369309:fix/venv-post-install-sources
Open

fix(venv): honor configured sources in post-install hooks#5386
m199369309 wants to merge 1 commit into
xorbitsai:mainfrom
m199369309:fix/venv-post-install-sources

Conversation

@m199369309

Copy link
Copy Markdown
Collaborator

Summary

  • reuse the virtualenv index_url, extra_index_url, find_links, trusted_host, and index_strategy settings in FlashInfer post-install commands
  • keep hook-specific public indexes as online fallbacks without overriding configured package sources
  • allow explicit offline installs to use configured private indexes or local find-links while continuing to block public fallback indexes
  • pass the resolved virtualenv install configuration to both FlashInfer post-install hooks

Motivation

The main virtualenv installation already honors configured package sources, but the FlashInfer AOT and cubin synchronization hooks invoke uv directly. Those commands previously ignored part or all of the resolved source configuration, which could break private-mirror and offline installations after the main package install had succeeded.

Tests

  • pytest -q xinference/core/tests/test_virtual_env_manager.py
  • pytest -q xinference/core/tests/test_utils.py
  • pre-commit run --files xinference/core/virtual_env_manager.py xinference/core/worker.py xinference/core/tests/test_virtual_env_manager.py

@XprobeBot XprobeBot added the bug Something isn't working label Aug 19, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@m199369309
m199369309 force-pushed the fix/venv-post-install-sources branch from f20d25f to 2555abf Compare August 19, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants