feat(venv): install Jina flash-attn wheel from find-links - #5392
Open
m199369309 wants to merge 4 commits into
Open
feat(venv): install Jina flash-attn wheel from find-links#5392m199369309 wants to merge 4 commits into
m199369309 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for worker-local wheel directories (find_links) during virtual environment package installation at model launch time. It adds validation to ensure local paths are absolute, readable, and reside within administrator-configured allowed roots. Additionally, it implements a dedicated post-install hook for installing flash-attn from local wheels for jina-embeddings-v3 models. Feedback on the changes suggests addressing a Python 3.9 compatibility issue with importlib.metadata.Distribution.locate_file and improving error reporting by logging or raising subprocess stdout and stderr when validation or installation fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flash-attn==2.8.3.post1+cvte1forjina-embeddings-v3Dependencies
Depends on #5387.
Transitively depends on #5386.
This branch temporarily contains the dependency commits. It will be rebased onto official
mainafter the prerequisite PRs merge.Safety and compatibility
jina-embeddings-v3--no-indexis addedValidation
pytest -q xinference/core/tests/test_virtual_env_manager.py xinference/core/tests/test_worker.py— 150 passedpre-commit run --files ...— passedpython -m json.tool xinference/model/embedding/model_spec.json— passedgit diff --check— passed