-
Notifications
You must be signed in to change notification settings - Fork 61
Clarify that Enable Desktop Support switch is CPP only #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cswilson252
wants to merge
32
commits into
wpilibsuite:2027
Choose a base branch
from
cswilson252:enableDesktopJavaRomi
base: 2027
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 19 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
8ddad19
Update copyright year to 2025 (#820)
sciencewhiz 538df0c
Check for WPILib project before running most commands (#819)
sciencewhiz ffd2bda
Move source backup in jar to backup directory (#826)
sciencewhiz f63028f
Update copyright to 2026 (#830)
sciencewhiz 3243b41
Remove duplicate source included in jar (#831)
sciencewhiz c47a582
Update frcYear to 2026 (#829)
sciencewhiz 39780e3
Fix error message about building code not in project (#825)
sciencewhiz 264d6c7
Revert "Revert "Clarify that Enable Desktop Support switch is CPP only""
cswilson252 0a04965
vscommands output is redundant
cswilson252 2e44ff9
(empty commit)
cswilson252 20f8a06
actually revert string change
cswilson252 a1f0d19
Revert "Fix error message about building code not in project (#825)"
cswilson252 ce5bbad
Revert "Update frcYear to 2026 (#829)"
cswilson252 3279cc9
Revert "Remove duplicate source included in jar (#831)"
cswilson252 e070638
Revert "Update copyright to 2026 (#830)"
cswilson252 5054e6d
Revert "Move source backup in jar to backup directory (#826)"
cswilson252 dc8e4ed
Revert "Check for WPILib project before running most commands (#819)"
cswilson252 f6cc8d0
Revert "Update copyright year to 2025 (#820)"
cswilson252 348a773
Update copyright year to 2026 on 2027 branch
cswilson252 2a41016
Add Project creator warning to TS instead
cswilson252 c910873
lint by hand
cswilson252 4115f31
actually lint by hand
cswilson252 cbb5149
lint more
cswilson252 8470c91
me when i have a hair on my clothes (get it because linting)
cswilson252 e383c45
update everything except tooltip
cswilson252 70222a7
rm / package-lock
cswilson252 f2d7e66
disable checkbox on non-cpp selection
cswilson252 11fdc89
lint
cswilson252 4a456f0
Make desktop support checkbox a const
cswilson252 3390af8
Update vscode-wpilib/src/webviews/pages/projectcreatorpage.ts
cswilson252 591089d
Add checkbox event listener
cswilson252 535bbd6
lint
cswilson252 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
|
|
||
| <head> | ||
| <title>WPILib Project Create</title> | ||
| <script> | ||
| const exports = require('./out/projectcreator.js'); | ||
| const validators = require('./out/validators.js'); | ||
| </script> | ||
|
|
||
| <style> | ||
| .error { | ||
| color: red; | ||
| border-color: red; | ||
| border-width: 2px; | ||
| } | ||
| body { | ||
| color: white; | ||
| background-color: #2e2c29; | ||
| } | ||
| </style> | ||
| </head> | ||
|
|
||
| <body> | ||
| <img src="./wpilib-generic.svg" height="75" /> | ||
|
|
||
| <h1>Welcome to WPILib New Project Creator</h1> | ||
|
|
||
| <select id="projectTypeSelect" style="display: initial" onchange="exports.selectProjectType();"> | ||
| <option value="base">Select a project type</option> | ||
| <option value="template">Templates</option> | ||
| <option value="example">Examples</option> | ||
| </select> | ||
|
|
||
| <select id="languageSelect" style="display: initial" disabled onchange="exports.selectLanguage();"> | ||
| <option value="base">Select a project language</option> | ||
| <option value="cpp">C++</option> | ||
| <option value='java'>Java</option> | ||
| </select> | ||
|
|
||
| <select id="projectBaseSelect" style="display: initial" disabled onchange="exports.selectRobotBase();"> | ||
| <option value="base">Select a project base</option> | ||
| </select> | ||
|
|
||
| <br/> | ||
| <br/> <span STYLE="font-weight:bold">Base Folder.</span> <span>Select a base folder to place the new project into.</span> | ||
| <br/> | ||
| <input id="projectFolder" type="text" style="width: 100%; margin-top: 10px; margin-bottom: 10px" /> | ||
| <br/> | ||
| <button onclick="exports.projectSelectButtonClick();">Select a new project folder</button> | ||
| <br/> <span data-i18n-trans STYLE="font-weight:bold">Create a new folder?</span> | ||
| <input id="newFolderCB" type="checkbox" checked/> | ||
| <br/> | ||
| <span>This creates a new folder at <i>Base Folder\Project Name</i>. Highly recommended to be checked. Otherwise the folder will be placed at <i>Base Folder</i> and not utilize the Project Name</span> | ||
| <br/> | ||
| <div id="projectnamediv" class="error" STYLE="font-weight:bold">Project Name</div> | ||
| <input id="projectName" class="error" oninput="validators.validateProject(document.getElementById('projectName'), document.getElementById('projectnamediv'));" type="text" style="width: 100%; margin-top: 10px; margin-bottom: 10px" | ||
| /> | ||
| <br/> | ||
| <div id="teamnumberdiv" class="error" STYLE="font-weight:bold">Team Number</div> | ||
| <input id="teamNumber" class="error" oninput="validators.validateTeamNumber(document.getElementById('teamNumber'), document.getElementById('teamnumberdiv'));" type="text" style="width: 100%; margin-top: 10px; margin-bottom: 10px" | ||
| /> | ||
| <br/> | ||
| <div id="desktopdiv"> | ||
| <span STYLE="font-weight:bold">(C++) Enable Desktop Support</span> | ||
| <input id="desktopCB" type="checkbox" /> | ||
| <br/> | ||
| <span data-i18n-trans data-i18n-key="hintDesktopSupport"> | ||
| This is needed for simulation and unit testing support, however there are some cases where this will do | ||
| some unexpected things during build. In addition, not all vendor libraries support desktop. | ||
| This option can be set with the command "WPILib: Set Desktop Support" for C++ projects at any time. | ||
| </span> | ||
| </div> | ||
| <br/> | ||
|
|
||
| <button id="generateProject" onclick="exports.generateProjectButtonClick()">Generate Project</button> | ||
| </body> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.