-
Notifications
You must be signed in to change notification settings - Fork 61
Clarify that Enable Desktop Support switch is CPP only #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2027
Are you sure you want to change the base?
Changes from all commits
8ddad19
538df0c
ffd2bda
f63028f
3243b41
c47a582
39780e3
264d6c7
0a04965
2e44ff9
20f8a06
a1f0d19
ce5bbad
3279cc9
e070638
5054e6d
dc8e4ed
f6cc8d0
348a773
2a41016
c910873
4115f31
cbb5149
8470c91
e383c45
70222a7
f2d7e66
11fdc89
4a456f0
3390af8
591089d
535bbd6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -311,8 +311,16 @@ | |
| }, | ||
| type: 'base', | ||
| }); | ||
| }); | ||
|
|
||
| validateStep2(); | ||
| const desktopCb = document.getElementById('desktopCB') as HTMLInputElement; | ||
| desktopCb.addEventListener('change', () => { | ||
| if (languageSelect.value !== 'cpp') { | ||
| desktopCb.disabled = true; | ||
| desktopCb.title = 'Desktop Support can only be enabled for C++ projects!'; | ||
| } else if (languageSelect.value == 'cpp') { | ||
|
Check warning on line 321 in vscode-wpilib/src/webviews/pages/projectcreatorpage.ts
|
||
| validateStep2(); | ||
| } | ||
|
cswilson252 marked this conversation as resolved.
Comment on lines
+314
to
+323
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checkbox event listener is the wrong way to do this, go back to the language event listener. And the branch still isn't updated. You need to reenable the checkbox when it's C++. |
||
| }); | ||
|
|
||
| const baseSelect = document.getElementById('base-select') as HTMLSelectElement; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.