Repository navigation
Add missing HAVE_PBKDF2 guards - #11958
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the PBKDF2 feature-guard changes.
No open issues 🎉
What changed in this PR
This PR aligns PBKDF2-dependent code with wolfCrypt’s feature availability, supporting builds that enable password-based cryptography but disable PBKDF2.
Changes:
- Add
HAVE_PBKDF2guards to encryption code, OpenSSL compatibility wrappers, and benchmarks. - Guard PBKDF2-dependent PKCS#5, PKCS#8, and PKCS#12 tests.
- Add a Linux CI configuration with password-based cryptography enabled and PBKDF2 disabled.
| File | Description |
|---|---|
wolfcrypt/src/wc_encrypt.c |
Guard PKCS#5 v2 key derivation with PBKDF2 availability. |
wolfcrypt/src/evp.c |
Align PBKDF2 wrapper guards with feature availability. |
wolfcrypt/benchmark/benchmark.c |
Guard PBKDF2 benchmark registration, invocation, and implementation. |
tests/api/test_pkcs12.c |
Guard PBKDF2-dependent PKCS#12 test cases. |
tests/api.c |
Guard PBKDF2-dependent PKCS#5 and PKCS#8 tests. |
.github/configs/os-check-linux.json |
Add CI coverage for password-based cryptography without PBKDF2. |
Review effort: Balanced
|
Contributor
Author
|
jenkins retest this please |
padelsbach
force-pushed
the
pbkdf2-guard
branch
from
November 3, 2026 05:15
402ecaf to
0e80e9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wc_PBKDF2()is only present withHAVE_PBKDF2 && !NO_HMAC, but several callers only checkNO_PWDBASEDorNO_HMAC.Testing
Added CI coverage.
Checklist