Repository navigation
Fix Ed448 key/sig size, build without HAVE_ECC - #41
Open
padelsbach wants to merge 3 commits into
Open
padelsbach wants to merge 3 commits into
padelsbach wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the Ed448 buffer-sizing and no-ECC build changes.
No open issues 🎉
What changed in this PR
This PR corrects Ed448 buffer-size calculations in wolfPSA and fixes builds where HAVE_ECC is disabled.
Changes:
- Adjust ECC export and signature size macros to accommodate Ed448.
- Add regression tests for signing and key export using the advertised buffer sizes.
- Guard ECC-specific declarations and calls, and add a no-ECC shared-library CI build that rejects undefined symbols.
| File | Description |
|---|---|
wolfpsa/psa/crypto_sizes.h |
Correct Ed448 key-export and signature buffer sizes. |
test/psa_server/psa_pure_eddsa_context_test.c |
Test Ed25519 and Ed448 signing with macro-sized output buffers. |
test/psa_server/psa_eddsa_mont_export_test.c |
Test key-pair export with the advertised output size. |
src/psa_asymmetric_api.c |
Guard ECC declarations and dispatch branches with HAVE_ECC. |
.github/workflows/build-config-matrix.yml |
Add a no-ECC shared-library build and undefined-symbol link checks. |
Review effort: Balanced
Frauschi
reviewed
Nov 2, 2026
…checks in test, CI build fix
Frauschi
approved these changes
Nov 3, 2026
| modifiers: "-WOLFSSL_HAVE_PRF" | ||
| # This config stays as a static library (not shared) because of a | ||
| # missing symbol in this build of wolfSSL. 'target' field and the | ||
| # LDFLAGS environment variable below can be removed after |
Member
There was a problem hiding this comment.
Dropping LDFLAGS would also drop -z defs from every lane, so only the pbkdf2 target can go. That also has to wait for a wolfSSL stable release with wolfSSL/wolfssl#11958, since the matrix still builds v5.9.4-stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
PSA_EXPORT_KEY_OUTPUT_SIZEandPSA_SIGN_OUTPUT_SIZEwere one byte too smallBuilds without
HAVE_ECCwould fail due to missing guardsTests added.