20261029-misc-fixes by douzzer · Pull Request #11934 · wolfSSL/wolfssl

douzzer · 2026-10-30T04:42:47Z

linuxkm/Kbuild: fix+improve handling for CONFIG_MITIGATION_RETPOLINE, CONFIG_MITIGATION_RETHUNK, and CONFIG_OBJTOOL. Also tabify some whitespace.

wolfssl/wolfcrypt/wc_compat.h: in wc_AesGcmEncrypt_compat_shim(), wipe tag and output to match wc_AesGcmEncrypt().

wolfcrypt/test/test.c: don't define SLHDSA_TEST_CERT if WOLFSSL_NO_MALLOC (not compatible).

wolfcrypt/benchmark/benchmark.c: refactor key init/free in bench_frodokem_keygen(), bench_frodokem_encap(), and bench_frodokem(), to fix uninited-key free ops.

github-actions · 2026-10-30T04:46:36Z

MemBrowse Memory Report · Explore what changed →

zephyr-frdm_rw612

FLASH: log_const_area -8 B, rodata -8 B, text +1,568 B (+0.5%, 284,016 B / 67,108,864 B, total: 0% used)

No memory changes detected for:

_{Catch memory regressions in CI with MemBrowse. Free for open source.}

Copilot

🟡 Changes recommended

Unresolved issues include out-of-bounds authentication-tag zeroization, broken kernel return-thunk mitigation handling, and compilation failures in supported configurations.

4 open issues

What changed in this PR

This PR addresses compatibility and cleanup issues in wolfSSL’s Linux kernel integration, AES-GCM shim, and cryptographic tests and benchmarks.

Changes:

Correct kernel mitigation flag handling and adjust objtool controls.
Add ciphertext and tag wiping on AES-GCM shim failures.
Refactor FrodoKEM benchmark key lifetimes and exclude SLH-DSA certificate tests from no-malloc builds.

File	Description
`wolfssl/wolfcrypt/wc_compat.h`	Wipe output and authentication tags after streaming-shim failures.
`wolfcrypt/test/test.c`	Disable SLH-DSA certificate tests with `WOLFSSL_NO_MALLOC`.
`wolfcrypt/benchmark/benchmark.c`	Adjust FrodoKEM key initialization, generation, and cleanup.
`linuxkm/Kbuild`	Update mitigation flags, legacy configuration aliases, and objtool handling.

_{Review effort: Balanced}

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11934

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): linuxkm/Kbuild, wolfcrypt/benchmark/benchmark.c
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

Copilot

🔵 Needs a closer look

The new inline shims call ForceZero without a prior declaration when FIPS AES-GCM and WOLFSSL_NO_FORCE_ZERO are enabled, causing compilation failures even when applications provide the zeroizer in another translation unit.

1 open issue

Guard FrodoKEM benchmark setup when key generation is disabled

3 resolved since last review

_{Review effort: Balanced}

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11934

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): linuxkm/Kbuild, wolfcrypt/benchmark/benchmark.c
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: wolfssl/wolfcrypt/memory.h

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

douzzer · 2026-10-31T04:04:38Z

retest this please

FAIL: scripts/google

douzzer · 2026-10-31T05:30:37Z

retest this please

ERROR: Checkout failed

(PRB-fips-repo-and-harness-test-v3-part1)

philljj · 2026-11-02T23:00:45Z

note: merge with

https://github.com/wolfSSL/testing/pull/1088

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11934

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras, linuxkm/Kbuild, wolfcrypt/benchmark/benchmark.c
Coverage: 5 of 15 in-scope changed file(s) opened by the reviewer; not opened: src/pk.c, tests/api/test_aes.c, tests/api/test_kdf.c, tests/api/test_ossl_x509_str.c, tests/api/test_sha512.c, wolfcrypt/src/evp.c, wolfcrypt/src/hpke.c, wolfcrypt/src/pkcs7.c, wolfssl/internal.h, wolfssl/wolfcrypt/types.h

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

Copilot

🟡 Changes recommended

With WOLFSSL_NO_FORCE_ZERO enabled in non-FIPS builds, memory.h aliases wc_ForceZero to an undeclared ForceZero, preventing callers that include only this header from compiling in C++ or strict C.

1 open issue

Declare custom zeroizer alongside WOLFSSL_NO_FORCE_ZERO alias · New

1 resolved since last review

Guard FrodoKEM benchmark setup when key generation is disabled

_{Review effort: Balanced}

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11934

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras, linuxkm/Kbuild, wolfcrypt/benchmark/benchmark.c
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

…Level for the mismatched _PublicKeyDecode() refusal test.

PRIVATE_KEY_UNLOCK()/LOCK() pairs for FIPS-gated KDF/KEM calls whose output is consumed internally: in wc_PKCS7_GenerateKEK_PWRI() around the wc_PBKDF2() KEK derivation (reached from both wc_PKCS7_AddRecipient_PWRI() and PWRI decode), and in wc_HpkeInitSealContext() and wc_HpkeInitOpenContext() around wc_HpkeSetupBaseSender()/-Receiver(), matching the existing arrangement in wc_HpkeSealBase()/wc_HpkeOpenBase(). Both paths returned FIPS_PRIVATE_KEY_LOCKED_E in FIPS builds; untested previously because configure omits PKCS7 and HPKE from FIPS builds unless explicitly enabled.

…) wraps: * in dh_agree_ct_test(), add point-of-use PRIVATE_KEY_UNLOCK()/PRIVATE_KEY_LOCK() around the wc_DhAgree_ct() calls, and in dh_key_import_export_test(), around the wc_DhExportKeyPair() call. No current FIPS flavor gates these, but the wraps are harmless and future-proof the tests against a flavor that restores DH to inside-boundary status, or activates these subtests on FIPS <v7. * in mlkem512_kat(), mlkem768_kat(), and mlkem1024_kat(), add point-of-use PRIVATE_KEY_UNLOCK()/PRIVATE_KEY_LOCK() around the wc_MlKemKey_EncodePrivateKey() and wc_MlKemKey_Decapsulate() calls.

* in wc_rng_bank_init_nonce(), use wc_RNG_lock_put_unconditional() to unlock the root_rng if it was locked, and don't unlock it otherwise; * in wc_rng_bank_root_rng_init(), if RNG init fails and the caller didn't request _PRESERVE_LOCK, wipe the root_rng, restoring it to its condition after the whole-context wipe at the start of wc_rng_bank_init_nonce() -- with this fix, wc_rng_bank_root_rng_init() always leaves bank->root_rng in a known and sensible state that the caller can rely on, regardless of retval.

…orceZero(), matching the one in wc_compat.h, to assure warning-free availability regardless of include order.

…cess, call wolfSSL_RAND_Cleanup() before _exit() to avoid valgrind-detected leaks of globalRNG allocations.

…cc_export_x963_ex(); fix unused-store warning in ed448_kat_test(); add missing PRIVATE_KEY_UNLOCK()s in mlkem_asn1_test().

…l PRIVATE_KEY_UNLOCK() for wc_ecc_export_x963_ex().

…'t wipe buffers when WC_PENDING_E, and don't wipe output buffer when it's equal to the input buffer.

Copilot

🟡 Changes recommended

RNG initialization failures can leak an allocated Nitrox context because resetting the RNG discards the device handle before cleanup, requiring partial-resource cleanup before zeroing.

1 open issue

Clean up Nitrox context on RNG initialization failure · New

1 resolved since last review

Avoid wiping buffers while async AES-GCM encryption is pending

_{Review effort: Balanced}

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11934

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras, linuxkm/Kbuild, wolfcrypt/benchmark/benchmark.c
Coverage: 6 of 16 in-scope changed file(s) opened by the reviewer; not opened: src/pk.c, tests/api/test_aes.c, tests/api/test_sha512.c, wolfcrypt/src/evp.c, wolfcrypt/src/hpke.c, wolfcrypt/src/pkcs7.c, wolfssl/internal.h, wolfssl/wolfcrypt/error-crypt.h, wolfssl/wolfcrypt/memory.h, wolfssl/wolfcrypt/types.h

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

Fenrir's latest completed scan found no issues; clearing the prior automated change request.

douzzer · 2026-11-04T04:23:37Z

retest this please

java.nio.file.FileSystemException: /tmp/workspace/wolfSSL/PRB-FIPS-windows-test-ACVP@tmp/durable-489ae734: No space left on device

philljj · 2026-11-04T16:35:14Z

tests good with multi-test with all-gcc-c89, c89-clang-tidy, wolfssl-all, sanitizer, no-malloc, tls13, dtls13, quic, etc scenarios

douzzer requested review from wolfSSL-Bot and wolfSSL-Fenrir-bot October 30, 2026 04:42

douzzer assigned wolfSSL-Bot Oct 30, 2026

Copilot AI balanced review requested due to automatic review settings October 30, 2026 04:42

Copilot started reviewing on behalf of douzzer October 30, 2026 04:43

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread linuxkm/Kbuild Resolved

Comment thread wolfssl/wolfcrypt/wc_compat.h Resolved

Comment thread wolfcrypt/benchmark/benchmark.c Resolved

Comment thread wolfssl/wolfcrypt/wc_compat.h Resolved

wolfSSL-Fenrir-bot reviewed Oct 30, 2026

View reviewed changes

philljj assigned philljj and douzzer and unassigned wolfSSL-Bot Oct 30, 2026

douzzer force-pushed the 20261029-misc-fixes branch from b5c5eb4 to 36f4ff4 Compare October 30, 2026 22:09

douzzer requested review from wolfSSL-Fenrir-bot and a balanced review from Copilot October 30, 2026 22:09

Copilot started reviewing on behalf of douzzer October 30, 2026 22:09

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

wolfSSL-Fenrir-bot previously requested changes Oct 30, 2026

View reviewed changes

Comment thread wolfssl/wolfcrypt/wc_compat.h Resolved

philljj mentioned this pull request Nov 2, 2026

misc fixes #11957

Open

douzzer force-pushed the 20261029-misc-fixes branch from 36f4ff4 to 724c8d3 Compare November 2, 2026 22:44

philljj requested a review from wolfSSL-Fenrir-bot November 3, 2026 06:11

wolfSSL-Fenrir-bot previously requested changes Nov 3, 2026

View reviewed changes

Comment thread wolfcrypt/src/rng_bank.c Resolved

douzzer force-pushed the 20261029-misc-fixes branch from 5f103d5 to d76e0d1 Compare November 3, 2026 20:47

douzzer requested review from wolfSSL-Fenrir-bot and a balanced review from Copilot November 3, 2026 20:49

Copilot started reviewing on behalf of douzzer November 3, 2026 20:49

View session

Copilot AI reviewed Nov 3, 2026

View reviewed changes

Comment thread wolfssl/wolfcrypt/memory.h Resolved

wolfSSL-Fenrir-bot previously requested changes Nov 3, 2026

View reviewed changes

douzzer added 10 commits November 3, 2026 18:27

wolfcrypt/test/test.c: in mlkem_asn1_test(), fix calculation of wrong…

95e484a

…Level for the mismatched _PublicKeyDecode() refusal test.

.wolfssl_known_macro_extras: garbage collect and fix lexical order.

b5296c4

wolfssl/wolfcrypt/memory.h: add prototype for WOLFSSL_NO_FORCE_ZERO F…

88e9b9b

…orceZero(), matching the one in wc_compat.h, to assure warning-free availability regardless of include order.

tests/api/test_ossl_rand.c: in test_wolfSSL_RAND_bytes() in child pro…

ddd69f2

…cess, call wolfSSL_RAND_Cleanup() before _exit() to avoid valgrind-detected leaks of globalRNG allocations.

wolfcrypt/test/test.c: in FIPS v6, call PRIVATE_KEY_UNLOCK() for wc_e…

588d881

…cc_export_x963_ex(); fix unused-store warning in ed448_kat_test(); add missing PRIVATE_KEY_UNLOCK()s in mlkem_asn1_test().

wolfcrypt/src/hpke.c: in wc_HpkeSerializePublicKey(), on FIPS v6, cal…

3ad471c

…l PRIVATE_KEY_UNLOCK() for wc_ecc_export_x963_ex().

wolfssl/wolfcrypt/wc_compat.h: in wc_AesGcmEncrypt_compat_shim(), don…

1b6fa87

…'t wipe buffers when WC_PENDING_E, and don't wipe output buffer when it's equal to the input buffer.

douzzer force-pushed the 20261029-misc-fixes branch from 3c359b4 to 1b6fa87 Compare November 4, 2026 00:28

douzzer requested review from wolfSSL-Fenrir-bot and a balanced review from Copilot November 4, 2026 00:31

Copilot started reviewing on behalf of douzzer November 4, 2026 00:31

View session

Copilot AI reviewed Nov 4, 2026

View reviewed changes

Comment thread wolfcrypt/src/rng_bank.c Resolved

wolfSSL-Fenrir-bot reviewed Nov 4, 2026

View reviewed changes

douzzer requested a review from philljj November 4, 2026 01:41

philljj removed their assignment Nov 4, 2026

douzzer assigned wolfSSL-Bot and unassigned douzzer Nov 4, 2026

philljj self-assigned this Nov 4, 2026

philljj approved these changes Nov 4, 2026

View reviewed changes

philljj merged commit 869a64f into wolfSSL:master Nov 4, 2026
442 checks passed

stenslae mentioned this pull request Nov 4, 2026

fix forcezero linking on every build #10935

Open

2 of 4 tasks

Conversation

douzzer commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report · Explore what changed →

zephyr-frdm_rw612

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11934

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11934

Uh oh!

Uh oh!

douzzer commented Oct 31, 2026

Uh oh!

douzzer commented Oct 31, 2026

Uh oh!

philljj commented Nov 2, 2026

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11934

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11934

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11934

Uh oh!

douzzer commented Nov 4, 2026

Uh oh!

philljj commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Oct 30, 2026 •

edited

Loading

philljj commented Nov 4, 2026 •

edited

Loading