Repository navigation
misc fixes - #11957
Open
philljj wants to merge 3 commits into
Open
misc fixes#11957philljj wants to merge 3 commits into
philljj wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change addressing the clang-tidy unused-return-value warning.
No open issues 🎉
What changed in this PR
Addresses a clang-tidy unused-return-value warning in QUIC early-data validation without changing runtime behavior.
Changes:
- Explicitly casts
wolfSSL_quic_send_alert’s return value tovoid, preserving the existingINVALID_PARAMETERerror path.
| File | Description |
|---|---|
src/tls.c |
Explicitly discards the QUIC alert return value for an invalid ticket early-data size. |
Review effort: Balanced
|
Contributor
Author
|
Retest this please. (script google test disrupted) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
multi-test misc fixes:
src/tls.c:wolfSSL_quic_send_alertclang-tidy unused ret value.wolfcrypt/test/test.c:slhdsa_cert_testhad a hard dependency on malloc through theslhdsa_cert_self_signed_test()static helper. Guard with no malloc define.testing
all-c89-clang-tidyallcryptonly-no-malloc-no-wolf-memory