Skip to content

misc fixes - #11957

Open
philljj wants to merge 3 commits into
wolfSSL:masterfrom
philljj:misc-fixes
Open

philljj wants to merge 3 commits into
wolfSSL:masterfrom
philljj:misc-fixes

Conversation

@philljj

@philljj philljj commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

multi-test misc fixes:

  • src/tls.c: wolfSSL_quic_send_alert clang-tidy unused ret value.
  • wolfcrypt/test/test.c: slhdsa_cert_test had a hard dependency on malloc through the slhdsa_cert_self_signed_test() static helper. Guard with no malloc define.

testing

  • all-c89-clang-tidy
  • allcryptonly-no-malloc-no-wolf-memory

@philljj philljj self-assigned this Nov 2, 2026
Copilot AI balanced review requested due to automatic review settings November 2, 2026 17:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change addressing the clang-tidy unused-return-value warning.

No open issues 🎉

What changed in this PR

Addresses a clang-tidy unused-return-value warning in QUIC early-data validation without changing runtime behavior.

Changes:

  • Explicitly casts wolfSSL_quic_send_alert’s return value to void, preserving the existing INVALID_PARAMETER error path.
File Description
src/​tls.c Explicitly discards the QUIC alert return value for an invalid ticket early-data size.

Review effort: Balanced

@philljj

philljj commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Retest this please.

(script google test disrupted)

@philljj

philljj commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

note: wolfcrypt test fix redundant with #11934.

Will probably merge #11934 first and rebase this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants