Skip to content

Build sp_mont_red_ex for ECCSI/SAKKE in RSA verify-only builds #11848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stenslae wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

Build sp_mont_red_ex for ECCSI/SAKKE in RSA verify-only builds #11848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/configs/os-check-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,11 @@
"configure": ["--enable-cryptonly", "--enable-cryptocb", "--enable-curve25519",
"--enable-keygen", "--disable-examples",
"CPPFLAGS=-DNO_CURVE25519_KEY_EXPORT"]},
{"name": "cryptonly-rsavfy-sp-math-eccsi-sakke", "minutes": 0.3,
"comment": "RSA verify-only with sp-math (not sp-math-all) and ECCSI/SAKKE. This is the shape where the ECCSI/SAKKE calls to mp_montgomery_reduce are the only users of sp_mont_red_ex, so a guard on it that leaves them out fails to link (with DH) or leaves _sp_mont_red unreferenced (with --disable-dh).",
"configure": ["--enable-cryptonly", "--disable-dh", "--enable-eccsi",
"--enable-sakke", "--enable-rsavfy", "--enable-sp-math", "--enable-sp",
"--disable-examples"]},
{"name": "cryptonly-no-asn-rsa", "minutes": 0.2, "check": false,
"comment": "RSA with ASN.1 disabled. Build only, since wolfcrypt test and benchmark do not support this combination.",
"configure": ["--enable-cryptonly", "--disable-asn", "--enable-lowresource",
Expand Down
3 changes: 2 additions & 1 deletion wolfcrypt/src/sp_int.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18115,7 +18115,8 @@ static int _sp_mont_red(sp_int* a, const sp_int* m, sp_int_digit mp, int ct)
}

#if !defined(WOLFSSL_RSA_VERIFY_ONLY) || \
(defined(WOLFSSL_SP_MATH_ALL) && defined(HAVE_ECC))
(defined(WOLFSSL_SP_MATH_ALL) && defined(HAVE_ECC)) || \
defined(WOLFCRYPT_HAVE_ECCSI) || defined(WOLFCRYPT_HAVE_SAKKE)
/* Reduce a number in Montgomery form.
*
* @param [in, out] a SP integer to Montgomery reduce.
Expand Down
Loading