Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused guard change matches its callers and adds targeted regression coverage, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes ECCSI/SAKKE builds using RSA verify-only and SP math without WOLFSSL_SP_MATH_ALL.
Changes:
- Compiles
sp_mont_red_exwhen ECCSI or SAKKE is enabled. - Adds a targeted Linux regression configuration with warnings treated as errors.
| File | Description |
|---|---|
wolfcrypt/src/sp_int.c |
Extends the compilation guard for ECCSI/SAKKE. |
.github/configs/os-check-linux.json |
Adds coverage for the affected build configuration. |
Review effort: Balanced
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11848
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs
Not reviewed (no scan target covers them): .github/configs/os-check-linux.json
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
|
26f7429 to
bd77843
Compare
Description
When configuring with RSA verify-only (--enable-rsavfy) and SP math (without WOLFSSL_SP_MATH_ALL), enabling ECCSI or SAKKE caused build failures.
Testing
Added cryptonly-rsavfy-sp-math-eccsi-sakke test config to os-check-linux.json.
Checklist