Repository navigation
Improved configuration and error handling - #9
Merged
Merged
Conversation
- Add baseUrl property and with() method to ConfigInterface/Config - Replace old ErrorHandler middleware/NotFoundController with ErrorHandlerInterface contract - Refactor Http kernel to use ErrorHandlerInterface, Environment, and Logger for error handling - Remove bootstrap() from BaseServiceProvider (middleware registration moved to kernel) - Clean up dead code: NotFoundController, ErrorHandler middleware, RouteServiceProvider - Update tests for all changes; remove stale CoversMethod for removed bootstrap() - Update copyright year to 2023 - Present across all files Signed-off-by: Mohammed Shifreen <mshifreen@gmail.com>
…flow setup. Signed-off-by: Mohammed Shifreen <mshifreen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved configuration and error handling:
baseUrlproperty andwith()method to ConfigInterface/ConfigErrorHandlermiddleware/NotFoundController withErrorHandlerInterfacecontractErrorHandlerInterface,Environment, andLoggerfor error handlingbootstrap()fromBaseServiceProvider(middleware registration moved to kernel)NotFoundController,ErrorHandlermiddleware,RouteServiceProvider