Repository navigation
chore(deps): bump vt100 from 0.16.2 to 0.18.1 - #608
Conversation
Bumps [vt100](https://github.com/doy/vt100-rust) from 0.16.2 to 0.18.1. - [Changelog](https://github.com/doy/vt100-rust/blob/main/CHANGELOG.md) - [Commits](doy/vt100-rust@v0.16.2...v0.18.1) --- updated-dependencies: - dependency-name: vt100 dependency-version: 0.18.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
vt100 0.18 takes and returns sizes as NonZeroU16; termlens never asks for a zero dimension, so the adapter converts at the edges. Upstream also implements REP, HPA, HVP, DECSCUSR and ED 3, fixes the wide-character resize panic, and resizes as xterm does: a shorter screen pushes rows into history and a taller one pulls them back. The history capture assumed history only grows below its cap, so: - the attribute shadow keeps the primary's history whether styled history is on or not; a taller screen pulls rows back onto both grids, and with none the shadow's came back blank and the lockstep assertion fired; - a shorter history is rows that came back onto the grid, and they leave the copy, newest first; - RIS and ED 3 are announced by the tracker and fed alone, so the copy restarts its mark explicitly. Inferred from the length, an ED 3 followed by more rows than the mark held lost the first of them; - nothing is captured while the alternate screen is up: its grid's zero length read as an emptied history, and every return copied the whole history again (#576). Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
BACKENDS.md measures 0.18.1, DESIGN.md says how height changes, RIS and ED 3 move history, and LIMITATIONS.md that history outlives ED 3. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
|
The bump needed more than the API port, so three commits sit on top of Dependabot's, plus a merge of main (the branch predated #606, and a plain squash would have reverted its lockfile bumps). API port. Sizes are What the whole suite missed and a behaviour probe found. 0.18 resizes as xterm does: a shorter screen pushes rows into history, a taller one pulls them back. With that:
Upstream fixes this brings: #577 (the wide-character resize panic: reproduced on 0.16.2 — Verification. Eight new unit tests; five mutations of the fix (no alternate-screen guard, shadow without history, shorter history read as a reset, tracker not announcing ED 3, ED 3 on the alternate screen restarting the mark) each fail the tests they should. Full workspace suite, clippy, rustdoc |
vyncint
left a comment
There was a problem hiding this comment.
Reviewed with the port on top: 16/16 checks green; behaviour verified with a probe against 0.16.2, and every fix in the history capture pinned by a test that a mutation of the fix fails.
Bumps vt100 from 0.16.2 to 0.18.1.
Changelog
Sourced from vt100's changelog.
... (truncated)
Commits
fb0f54echangelog and version bumpb88a5a1a few tweaks to github actionsc20819dfeat: addcapture::basic_formatted_to_plain_indexed(#38)17965e8perf: trim trailing blank cells from scrollback rows (#36)a87517bfeat: make vertical resizes more closely match real terminal emulators even w...33abc97feat: change behavior ofset_size(#31)46d1dfbfeat: addParser::screen_and_callbacks_mut(#29)04d933ffeat: add basic formatted capture utilities, fix: fix handling of triple-widt...1102dfffeat: makeScreen::sizereturnNonZeroU16s (#26)32e8a3efix: respect alternate screen inScreen::contents_formatted_basic(#24)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)