ci: drop the PR builds that have never worked in this fork - #3
Merged
Conversation
build.yml has failed on every run since 2026-05-01 -- nine consecutive failures before any of today's work existed. A check that is permanently red gates nothing and teaches people to ignore CI, which is how the next real failure gets missed. build-steamlink has never linked here, and build-win-mac fails on Windows while passing on macOS. Neither is load-bearing: the builds that actually ship are build-moonlightvibe-windows.yml and -mac.yml, which run on push to master and are green. So build.yml keeps the two jobs that pass -- setup and build-appimage, a real Qt 6 build -- and build-steamlink.yml and build-win-mac.yml are deleted, since build.yml was their only caller.⚠️ PR coverage is now Linux-only. A Windows-specific break will pass the PR and fail on the master push instead. That is a real reduction, accepted deliberately over leaving a red check nobody reads; repairing the Windows PR build is the better fix if it is ever worth the time. ⛔ build.yml is NOT deleted outright, which was the first instinct. Its `build-appimage / build` and `setup` are master's required status checks, so removing it would leave protection waiting forever on checks that no longer exist -- exactly the deadlock fixed an hour ago, where the required context "build" was never produced by any PR workflow. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQvL62WkT8xDWXqyjFCGDw
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.ymlhas failed on every run since 2026-05-01 — nine consecutive failures before any of today's work existed. A permanently red check gates nothing and teaches people to ignore CI, which is how the next real failure gets missed.What was actually broken
setupbuild-appimagebuild-steamlinkbuild-win-macNeither failing job is load-bearing. The builds that actually ship are
build-moonlightvibe-windows.ymland-mac.yml, which run on push to master and are green.So
build.ymlkeeps the two jobs that pass, andbuild-steamlink.yml/build-win-mac.ymlare deleted —build.ymlwas their only caller.Not deleted outright, deliberately
The first instinct was to delete
build.ymlentirely. That would have been a mistake: itsbuild-appimage / buildandsetuparemaster's required status checks, so removing it would leave branch protection waiting forever on checks that no longer exist.That is precisely the deadlock fixed an hour ago, where the required context
buildwas never produced by any PR workflow and no pull request could merge at all.Cost, stated plainly
PR coverage is now Linux-only. A Windows-specific break will pass the PR and fail on the master push instead. Trimming
build-win-macalso gives up a working macOS PR build.That is a real reduction, accepted deliberately over leaving a red check nobody reads. Repairing the Windows PR build is the better fix if it is ever worth the time.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SQvL62WkT8xDWXqyjFCGDw