release: 6.3.4 - #4
Merged
Merged
Conversation
app/version.txt 6.3.3 -> 6.3.4, plus notes. The tag must equal v<version.txt> or the release build fails on purpose, so the bump comes first. Ships two merged commits: 00e256a (seats are found by probing the seat port block instead of asking the MultiSeat service at 127.0.0.1, which could only ever work with Moonlight running on the host) and 1c5f539 (the PR build pipeline trimmed to the jobs that pass). ⛔ The notes lead with the fact that the discovery change has NEVER BEEN RUN. It compiles under Qt 5.14.1 and Qt 6, and the host side is confirmed -- a seat answers /serverinfo with the name discovery looks for -- but no client has executed this code. The machine it was written on has no Qt toolchain. The plausible failure is client-side: discovery reads the host list every 15s while other paths write to it under a write lock on a thread pool. A pull model was chosen specifically to avoid deadlocking against that, but designed-around is not tested. The notes say so, name the symptom to watch for, and point at 6.3.3 as the way back. Understating that would be the wrong trade for a client binary people install. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQvL62WkT8xDWXqyjFCGDw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts 6.3.4.
app/version.txt6.3.3 → 6.3.4 plus notes. The tag must equalv<version.txt>or the release build fails on purpose, so the bump comes first.No code changes — ships two already-merged commits:
00e256a4(fix: find seats by probing the seat port block, not by asking the service #2) — seats are found by probing the seat port block instead of asking the MultiSeat service at127.0.0.1, which could only ever work with Moonlight running on the host itself1c5f5395(ci: drop the PR builds that have never worked in this fork #3) — the PR build pipeline trimmed to the jobs that pass⛔ The discovery change has never been run
It compiles under Qt 5.14.1 and Qt 6, and the host side is confirmed — a seat really does answer
/serverinfowith the name discovery looks for. But no client has executed this code. The machine it was written on has no Qt toolchain, so a build could not be tested there.The plausible failure is client-side: discovery reads the host list every 15 seconds while other paths write to it under a write lock on a thread pool. A pull model (
aboutToPoll) was chosen specifically to avoid deadlocking against that — but designed-around is not tested.The release notes lead with this rather than bury it, name the symptom to watch for (a hang on startup or when adding a host), and point at 6.3.3 as the way back. Understating it would be the wrong trade for a client binary people install.
What users get if it works
Seats appear on their own from any machine, within about fifteen seconds of being provisioned, with no API key and no need to expose MultiSeat's dashboard to the network. Before this they only ever appeared if Moonlight was running on the streaming host.
The manual fallback is documented in the notes: host address plus the seat's port, starting at 48100 and rising by 30 per seat. That is also the answer for a host with non-default port settings, since discovery checks the defaults and nothing advertises a custom range.
Once merged, pushing
v6.3.4publishes both the Windows and macOS assets.🤖 Generated with Claude Code
https://claude.ai/code/session_01SQvL62WkT8xDWXqyjFCGDw