fix(e2e): keep hosted-search checks aligned with Pi - #1375
Merged
Merged
Conversation
PR #1357 bumped the workspace to Pi 1.0.1 but left the hosted-search e2e asserting manifest.version === '1.0.0', so the run fails on the installed 1.0.1 packages. Track the locked version.
The hosted-search regression should track the exact Pi version declared by agent-runtime so future dependency upgrades do not stale the harness. Keep all Pi packages aligned to that pin and make the offline fixture persist runtime messages through the host RPC it exposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up carries shabhui's original #1364 fix and removes the version-drift cause instead of replacing one hard-coded version with another.
The hosted-search E2E now derives its expected version from agent-runtime's exact
@earendil-works/pi-aipin and asserts all three installed Pi packages match it. Running the harness also exposed a fixture gap: the Pi 1.0.1 runtime persists transcript messages withsession.appendMessage, which the offline host had not implemented. The fixture now stores those messages idempotently by message id.Validation:
node scripts/e2e-hosted-search.mjspassed all 7 offline scenarios on a freshly built task-candidate bundle.node --checkpassed for both changed scripts.git diff --checkpassed.origin/mainis an ancestor of this head; latest base is included.Supersedes #1364.