Skip to content

fix(e2e): align hosted-search version assertion with Pi 1.0.1 - #1364

Closed
shabhui wants to merge 1 commit into
vastsa:mainfrom
shabhui:fix/e2e-hosted-search-pi-101
Closed

shabhui wants to merge 1 commit into
vastsa:mainfrom
shabhui:fix/e2e-hosted-search-pi-101

Conversation

@shabhui

@shabhui shabhui commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

What happened

PR #1357 upgraded the Pi kernel packages to 1.0.1 (workspace pins, patches, lockfile, check scripts) but missed one file: scripts/e2e-hosted-search.mjs still asserts manifest.version === "1.0.0" for pi-ai / pi-agent-core / pi-coding-agent.

Steps to reproduce

  1. On current main, install dependencies (Pi 1.0.1 is locked).
  2. Run the hosted-search e2e (node scripts/e2e-hosted-search.mjs).
  3. The dependency version check fails before any scenario runs:
pi-ai must match the locked pi version

Expected

The e2e tracks the locked Pi version (now 1.0.1) and proceeds past the dependency check.

Actual

Assertion manifest.version === "1.0.0" fails against installed 1.0.1 packages (scripts/e2e-hosted-search.mjs:163).

Fix

Single-line change: bump the assertion to "1.0.1".

Verified: on a Pi-1.0.1-locked workspace (identical pins/patches as main via #1357) the version check passes and the run proceeds past dependency verification.

App version: main @ c79b6ca (post #1357)
OS: Windows 11 26220.9587

PR vastsa#1357 bumped the workspace to Pi 1.0.1 but left the hosted-search e2e asserting manifest.version === '1.0.0', so the run fails on the installed 1.0.1 packages. Track the locked version.
@vastsa

vastsa commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Thanks for catching the stale Pi version assertion after #1357. The follow-up in #1375 now derives the expected version from the exact agent-runtime pin and fixes the offline host fixture for session.appendMessage; its 7 hosted-search scenarios and CI passed. Closing this original as superseded.

@vastsa vastsa closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants