Conversation
PR vastsa#1357 bumped the workspace to Pi 1.0.1 but left the hosted-search e2e asserting manifest.version === '1.0.0', so the run fails on the installed 1.0.1 packages. Track the locked version.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
PR #1357 upgraded the Pi kernel packages to 1.0.1 (workspace pins, patches, lockfile, check scripts) but missed one file:
scripts/e2e-hosted-search.mjsstill assertsmanifest.version === "1.0.0"for pi-ai / pi-agent-core / pi-coding-agent.Steps to reproduce
main, install dependencies (Pi 1.0.1 is locked).node scripts/e2e-hosted-search.mjs).Expected
The e2e tracks the locked Pi version (now 1.0.1) and proceeds past the dependency check.
Actual
Assertion
manifest.version === "1.0.0"fails against installed 1.0.1 packages (scripts/e2e-hosted-search.mjs:163).Fix
Single-line change: bump the assertion to
"1.0.1".Verified: on a Pi-1.0.1-locked workspace (identical pins/patches as main via #1357) the version check passes and the run proceeds past dependency verification.
App version: main @ c79b6ca (post #1357)
OS: Windows 11 26220.9587