Repository navigation
Fix unlink_template_from_host --no-clear clearing templates - #348
Merged
Merged
Conversation
Contributor
Author
|
Friendly bump on this one. CI never got approved so the runs timed out after 30 days, not an actual failure. Happy to rebase if that's easier for you. We hit this when trying to swap templates on a host without wiping its items, --no-clear just gets ignored right now. |
pederhan
self-requested a review
October 22, 2026 13:26
pederhan
approved these changes
Oct 22, 2026
pederhan
left a comment
pederhan
left a comment
Member
There was a problem hiding this comment.
Hi, thank you for your contribution! Sorry for the delay, I need to get better at monitoring incoming PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unlink_template_from_host --no-clearwas still clearing items and triggers on the hosts. The command never passescleardown tounlink_templates_from_hosts, so it always ran with the default (clear=True).Added a test that checks what actually gets sent to
host.massremovefor each flag combo, plus a changelog line.