Repository navigation
Preserve context case in macro names - #349
Merged
Merged
Conversation
Contributor
Author
|
Bump. Same deal as #348, CI runs expired waiting on approval rather than failing. Small fix, macros with an uppercase context like {$FOO:"Bar"} get lowercased on create/update so they stop matching what's on the host. |
pederhan
approved these changes
Oct 22, 2026
pederhan
left a comment
pederhan
left a comment
Member
There was a problem hiding this comment.
Thank you for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context macros were getting uppercased as a whole, so something like
{$VFS.FS.PUSED.MAX.CRIT:"/var/log"}turned into{$VFS.FS.PUSED.MAX.CRIT:"/VAR/LOG"}and the macro commands went looking for a macro that doesn't exist. Zabbix treats the context as case sensitive, so now only the part before the first:gets uppercased.Added a few context cases to the existing
fmt_macro_nametest.