Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #501
Summary
checkHoleTraceClearancepreviously considered non-plated holes but omitted via drill holes, so a trace could pass the check despite being closer than the specified trace-to-hole clearance.hole_diameter, independently of the via's outer copper diameter, while preserving the existing default behavior for other hole-geometry callers.Validation
bun test tests/lib/check-via-drill-trace-clearance.test.ts— 7 passed, 41 assertions.bun test— 760 passed, 0 failed across 248 files, 16 snapshots and 8,477 assertions../node_modules/.bin/tsc --noEmitandbun run build— passed.bun run format:check— passed; Biome reported that three pre-existing JSON files over 1 MiB were skipped by its size limit.git diff --check— passed for the tracked changes.Tests used Bun 1.4.2 on macOS arm64 with isolated HOME, temporary and cache directories and network denied during the full suite. Dependencies were installed with lifecycle scripts disabled except for the reviewed
sharpnative install, which ran in the isolated environment. The original issue's board and KiCad DRC results were not independently reproduced on physical hardware or in KiCad; the regression cases use synthetic circuit JSON and existing project fixtures.AI assistance
This change and its tests were developed with AI assistance and reviewed and validated using the checks described above.
Payment / 收款方式
I can receive cryptocurrency via Ethereum, X Layer, Robinhood Chain, Arc, Solana, TRON, or Bitcoin where the agreed currency and network match an available address. Please confirm the payment currency, network, and amount before I provide a matching address.