Skip to content

Fix false power-pin warnings for passive components - #504

Merged
imrishabh18 merged 1 commit into
tscircuit:mainfrom
GokulPandi-M:fix-passive-encoder-power-warning
Oct 31, 2026
Merged

imrishabh18 merged 1 commit into
tscircuit:mainfrom
GokulPandi-M:fix-passive-encoder-power-warning

Conversation

@GokulPandi-M

@GokulPandi-M GokulPandi-M commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

The Macro Six USB-C board board uses an EC11E18244AU mechanical encoder for volume control. Its imported component uses , but it has no power-supply pin: it works through passive contacts. All seven pins are explicitly marked passive and connected to the board’s signal or ground nets.

The power-pin checker currently treats this component like a powered chip and reports ENC1 has no pin with requires_power=true, despite those passive attributes. This creates a misleading warning for a component that cannot truthfully declare a power pin.

This fixes the behaviour reproduced in #500 by skipping the power-pin warning when every connectable pin is explicitly passive. Components with non-passive or unspecified pins remain checked.

Before and after

Before After
ENC1 reports has no pin with requires_power=true. ENC1 produces no power-pin warning.
Passive pin markings do not prevent this warning. Fully passive components are exempt; components with non-passive or unspecified pins are still checked.

@GokulPandi-M
GokulPandi-M marked this pull request as ready for review October 31, 2026 16:21
@imrishabh18
imrishabh18 merged commit af8705a into tscircuit:main Oct 31, 2026
10 checks passed
@GokulPandi-M
GokulPandi-M deleted the fix-passive-encoder-power-warning branch October 31, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants